From: "Pali Rohár" <pali@kernel.org>
To: u-boot@lists.denx.de
Subject: [PATCH] Revert "mmc: disable UHS modes if Vcc cannot be switched on and off"
Date: Sun, 9 Aug 2020 18:03:03 +0200 [thread overview]
Message-ID: <20200809160303.8773-1-pali@kernel.org> (raw)
This reverts commit 04a2ea248f58b3b6216d0cd0a6b8698df8b14355.
That commit is causing reboot loops on Nokia N900 and basically make U-Boot
on Nokia N900 unusable. Revert it for now until problem is solved.
After reverting that commit U-Boot on Nokia N900 is working again.
Signed-off-by: Pali Roh?r <pali@kernel.org>
---
drivers/mmc/mmc.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index d79cdef62e..48c1629a19 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -2800,18 +2800,7 @@ int mmc_get_op_cond(struct mmc *mmc)
MMC_QUIRK_RETRY_APP_CMD;
#endif
- err = mmc_power_cycle(mmc);
- if (err) {
- /*
- * if power cycling is not supported, we should not try
- * to use the UHS modes, because we wouldn't be able to
- * recover from an error during the UHS initialization.
- */
- pr_debug("Unable to do a full power cycle. Disabling the UHS modes for safety\n");
- uhs_en = false;
- mmc->host_caps &= ~UHS_CAPS;
- err = mmc_power_on(mmc);
- }
+ err = mmc_power_on(mmc);
if (err)
return err;
--
2.20.1
next reply other threads:[~2020-08-09 16:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 16:03 Pali Rohár [this message]
2020-08-10 0:55 ` [PATCH] Revert "mmc: disable UHS modes if Vcc cannot be switched on and off" Peng Fan
2020-08-11 3:09 ` Faiz Abbas
2020-08-11 7:49 ` Pali Rohár
2020-08-11 16:03 ` Faiz Abbas
2020-08-11 16:27 ` Pali Rohár
2020-08-14 20:16 ` Pali Rohár
2020-09-24 22:03 ` Pali Rohár
2020-10-31 16:26 ` Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200809160303.8773-1-pali@kernel.org \
--to=pali@kernel.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.