All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yasushi Asano <yazzep@gmail.com>
To: stern@rowland.harvard.edu, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, erosca@de.adit-jv.com,
	andrew_gabbasov@mentor.com, jim_baxter@mentor.com,
	wnatsume@jp.adit-jv.com, nnishiguchi@jp.adit-jv.com,
	yasano@jp.adit-jv.com
Subject: [PATCH v2] [RFC] USB: hub.c: decrease the number of attempts of enumeration
Date: Mon, 10 Aug 2020 09:19:34 +0900	[thread overview]
Message-ID: <20200810001935.4489-1-yazzep@gmail.com> (raw)
In-Reply-To: <20200808151648.GC256751@rowland.harvard.edu>

From: Yasushi Asano <yasano@jp.adit-jv.com>

Hello Alan,
Thank you for the feedback. I added the information in the commit.
I reconsidered the reduction place in the number of attempts.
Since I don't want to miss 2nd reset[1] or do not change the timing of power cycling the port[2],
I changed to reduce attempts from the nearest enclosing loop.
I'm sorry to trouble you, please confirm it again.

[1]
 /*
  * Some devices time out if they are powered on
  * when already connected. They need a second
  * reset. But only on the first attempt,
  * lest we get into a time out/reset loop
  */
 if (r == 0 || (r == -ETIMEDOUT &&
                 retries == 0 &&
                 udev->speed > USB_SPEED_FULL))
         break;

[2]
 /* When halfway through our retry count, power-cycle the port */
 if (i == (SET_CONFIG_TRIES / 2) - 1) {

Yasushi Asano (1):
  [RFC] USB: hub.c: decrease the number of attempts of enumeration
    scheme

 drivers/usb/core/hub.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

-- 
2.7.4


  reply	other threads:[~2020-08-10  0:21 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAEt1RjrQsb6=reKUKV9uJTG4JoJXErhJFj=2TdVx=N1_Ad1GVg@mail.gmail.com>
2020-08-08  6:40 ` [PATCH] [RFC] USB: hub.c: decrease the number of attempts of enumeration scheme Yasushi Asano
2020-08-08 15:16   ` Alan Stern
2020-08-10  0:19     ` Yasushi Asano [this message]
2020-08-10  0:19       ` [PATCH v2] " Yasushi Asano
2020-08-10  7:46         ` Greg KH
2020-08-11 15:20           ` yasushi asano
2020-09-07 15:50             ` [PATCH v3] " Yasushi Asano
2020-09-07 15:50               ` Yasushi Asano
2020-09-08 19:04                 ` Alan Stern
2020-09-10  4:49                   ` yasushi asano
2020-09-11  8:33                     ` yasushi asano
2020-09-11 15:12                       ` Alan Stern
2020-09-15  9:45                         ` Eugeniu Rosca
2020-09-15 11:01                           ` Greg KH
2020-09-15 14:52                             ` Alan Stern
2020-09-16 10:16                               ` yasushi asano
2020-09-18 15:00                                 ` yasushi asano
2020-09-20 19:21                                   ` Alan Stern
2020-09-21 14:03                                     ` [PATCH] " Yasushi Asano
2020-09-21 14:48                                       ` Alan Stern
     [not found]                                         ` <CAEt1Rjq-DOwN0+_7F0m-kqUHTzm5YPUaXqUOpTszCsqrfLRt5w@mail.gmail.com>
2020-09-21 15:06                                           ` Alan Stern
2020-09-25  1:05                                             ` yasushi asano
2020-09-25 17:21                                               ` yasushi asano
2020-09-25 18:41                                                 ` Alan Stern
2020-09-27 15:43                                                   ` yasushi asano
2020-09-28 15:20                                                     ` [Patch 1/2]: USB: hub: Clean up use of port initialization schemes and retries Alan Stern
2020-09-28 15:22                                                       ` [Patch 2/2]: USB: hub: Add Kconfig option to reduce number of port initialization retries Alan Stern
2020-09-15 14:48                           ` [PATCH v3] USB: hub.c: decrease the number of attempts of enumeration scheme Alan Stern
2020-08-12 17:09           ` [PATCH v2] " Yasushi Asano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200810001935.4489-1-yazzep@gmail.com \
    --to=yazzep@gmail.com \
    --cc=andrew_gabbasov@mentor.com \
    --cc=erosca@de.adit-jv.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jim_baxter@mentor.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=nnishiguchi@jp.adit-jv.com \
    --cc=stern@rowland.harvard.edu \
    --cc=wnatsume@jp.adit-jv.com \
    --cc=yasano@jp.adit-jv.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.