diff for duplicates of <20200810093948.GB6615@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 8fdf2af..043b682 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -85,7 +85,7 @@ gxfb_probe() invokes pci_set_drvdata(pdev, info) which in turn calls dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant. > > -> > - if (state.event = PM_EVENT_SUSPEND) { +> > - if (state.event == PM_EVENT_SUSPEND) { > > - console_lock(); > > - gx_powerdown(info); > > - fb_set_suspend(info, 1); @@ -141,7 +141,7 @@ Earlier, gxfb_suspend() performed each operation just for suspend event. And as it was legacy code, it was invoked by pci_legacy_suspend() for pci_pm_suspend(), pci_pm_freeze() and pci_pm_poweroff(). Thus, the code was wrapped inside "if" container: - if (state.event = PM_EVENT_SUSPEND) { } + if (state.event == PM_EVENT_SUSPEND) { } After binding it with dev_pm_ops variable, pm->suspend() is invoked by just pci_pm_suspend() which is required. @@ -195,3 +195,7 @@ Vaibhav Gupta > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel +_______________________________________________ +Linux-kernel-mentees mailing list +Linux-kernel-mentees@lists.linuxfoundation.org +https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees diff --git a/a/content_digest b/N1/content_digest index 5136105..5791ddc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,23 +2,22 @@ "ref\020200805180722.244008-2-vaibhavgupta40@gmail.com\0" "ref\020200808111746.GA24172@ravnborg.org\0" "From\0Vaibhav Gupta <vaibhavgupta40@gmail.com>\0" - "Subject\0Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management\0" - "Date\0Mon, 10 Aug 2020 09:51:48 +0000\0" + "Subject\0Re: [Linux-kernel-mentees] [PATCH v1 01/12] fbdev: gxfb: use generic power management\0" + "Date\0Mon, 10 Aug 2020 15:09:48 +0530\0" "To\0Sam Ravnborg <sam@ravnborg.org>\0" "Cc\0linux-fbdev@vger.kernel.org" + Antonino Daplas <adaplas@gmail.com> Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Vaibhav Gupta <vaibhav.varodek@gmail.com> Florian Tobias Schandinat <FlorianSchandinat@gmx.de> Russell King <linux@armlinux.org.uk> dri-devel@lists.freedesktop.org linux-kernel@vger.kernel.org - Bjorn Helgaas <bjorn@helgaas.com> Bjorn Helgaas <helgaas@kernel.org> linux-arm-kernel@lists.infradead.org Andres Salomon <dilinger@queued.net> Bjorn Helgaas <bhelgaas@google.com> Paul Mackerras <paulus@samba.org> - Shuah Khan <skhan@linuxfoundation.org> linux-kernel-mentees@lists.linuxfoundation.org " linux-geode@lists.infradead.org\0" "\00:1\0" @@ -110,7 +109,7 @@ "dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant.\n" "\n" "> > \n" - "> > -\tif (state.event = PM_EVENT_SUSPEND) {\n" + "> > -\tif (state.event == PM_EVENT_SUSPEND) {\n" "> > -\t\tconsole_lock();\n" "> > -\t\tgx_powerdown(info);\n" "> > -\t\tfb_set_suspend(info, 1);\n" @@ -166,7 +165,7 @@ "And as it was legacy code, it was invoked by pci_legacy_suspend() for\n" "pci_pm_suspend(), pci_pm_freeze() and pci_pm_poweroff().\n" "Thus, the code was wrapped inside \"if\" container:\n" - "\tif (state.event = PM_EVENT_SUSPEND) { }\n" + "\tif (state.event == PM_EVENT_SUSPEND) { }\n" "\n" "After binding it with dev_pm_ops variable, pm->suspend() is invoked by just\n" "pci_pm_suspend() which is required.\n" @@ -219,6 +218,10 @@ "> > _______________________________________________\n" "> > dri-devel mailing list\n" "> > dri-devel@lists.freedesktop.org\n" - > > https://lists.freedesktop.org/mailman/listinfo/dri-devel + "> > https://lists.freedesktop.org/mailman/listinfo/dri-devel\n" + "_______________________________________________\n" + "Linux-kernel-mentees mailing list\n" + "Linux-kernel-mentees@lists.linuxfoundation.org\n" + https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees -69797645aa437af0e72c79cc14f924f2b29ca1abc2d03cd0fe616174a451f008 +4fba008b71d1bc00d6d41dd83322b9db55eb11766a03c2941d6bc08d0f159de9
diff --git a/a/1.txt b/N2/1.txt index 8fdf2af..44a6240 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -85,7 +85,7 @@ gxfb_probe() invokes pci_set_drvdata(pdev, info) which in turn calls dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant. > > -> > - if (state.event = PM_EVENT_SUSPEND) { +> > - if (state.event == PM_EVENT_SUSPEND) { > > - console_lock(); > > - gx_powerdown(info); > > - fb_set_suspend(info, 1); @@ -141,7 +141,7 @@ Earlier, gxfb_suspend() performed each operation just for suspend event. And as it was legacy code, it was invoked by pci_legacy_suspend() for pci_pm_suspend(), pci_pm_freeze() and pci_pm_poweroff(). Thus, the code was wrapped inside "if" container: - if (state.event = PM_EVENT_SUSPEND) { } + if (state.event == PM_EVENT_SUSPEND) { } After binding it with dev_pm_ops variable, pm->suspend() is invoked by just pci_pm_suspend() which is required. @@ -195,3 +195,8 @@ Vaibhav Gupta > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N2/content_digest index 5136105..963d18a 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,9 +3,10 @@ "ref\020200808111746.GA24172@ravnborg.org\0" "From\0Vaibhav Gupta <vaibhavgupta40@gmail.com>\0" "Subject\0Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management\0" - "Date\0Mon, 10 Aug 2020 09:51:48 +0000\0" + "Date\0Mon, 10 Aug 2020 15:09:48 +0530\0" "To\0Sam Ravnborg <sam@ravnborg.org>\0" "Cc\0linux-fbdev@vger.kernel.org" + Antonino Daplas <adaplas@gmail.com> Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Vaibhav Gupta <vaibhav.varodek@gmail.com> Florian Tobias Schandinat <FlorianSchandinat@gmx.de> @@ -110,7 +111,7 @@ "dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant.\n" "\n" "> > \n" - "> > -\tif (state.event = PM_EVENT_SUSPEND) {\n" + "> > -\tif (state.event == PM_EVENT_SUSPEND) {\n" "> > -\t\tconsole_lock();\n" "> > -\t\tgx_powerdown(info);\n" "> > -\t\tfb_set_suspend(info, 1);\n" @@ -166,7 +167,7 @@ "And as it was legacy code, it was invoked by pci_legacy_suspend() for\n" "pci_pm_suspend(), pci_pm_freeze() and pci_pm_poweroff().\n" "Thus, the code was wrapped inside \"if\" container:\n" - "\tif (state.event = PM_EVENT_SUSPEND) { }\n" + "\tif (state.event == PM_EVENT_SUSPEND) { }\n" "\n" "After binding it with dev_pm_ops variable, pm->suspend() is invoked by just\n" "pci_pm_suspend() which is required.\n" @@ -219,6 +220,11 @@ "> > _______________________________________________\n" "> > dri-devel mailing list\n" "> > dri-devel@lists.freedesktop.org\n" - > > https://lists.freedesktop.org/mailman/listinfo/dri-devel + "> > https://lists.freedesktop.org/mailman/listinfo/dri-devel\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -69797645aa437af0e72c79cc14f924f2b29ca1abc2d03cd0fe616174a451f008 +008b87269d7b193312cd23d437f679cfc45959bc5b95c4138a9777cce3db5cf6
diff --git a/a/1.txt b/N3/1.txt index 8fdf2af..1d28072 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -85,7 +85,7 @@ gxfb_probe() invokes pci_set_drvdata(pdev, info) which in turn calls dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant. > > -> > - if (state.event = PM_EVENT_SUSPEND) { +> > - if (state.event == PM_EVENT_SUSPEND) { > > - console_lock(); > > - gx_powerdown(info); > > - fb_set_suspend(info, 1); @@ -141,7 +141,7 @@ Earlier, gxfb_suspend() performed each operation just for suspend event. And as it was legacy code, it was invoked by pci_legacy_suspend() for pci_pm_suspend(), pci_pm_freeze() and pci_pm_poweroff(). Thus, the code was wrapped inside "if" container: - if (state.event = PM_EVENT_SUSPEND) { } + if (state.event == PM_EVENT_SUSPEND) { } After binding it with dev_pm_ops variable, pm->suspend() is invoked by just pci_pm_suspend() which is required. @@ -195,3 +195,7 @@ Vaibhav Gupta > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/dri-devel +_______________________________________________ +dri-devel mailing list +dri-devel@lists.freedesktop.org +https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/a/content_digest b/N3/content_digest index 5136105..5bcf021 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -3,7 +3,7 @@ "ref\020200808111746.GA24172@ravnborg.org\0" "From\0Vaibhav Gupta <vaibhavgupta40@gmail.com>\0" "Subject\0Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management\0" - "Date\0Mon, 10 Aug 2020 09:51:48 +0000\0" + "Date\0Mon, 10 Aug 2020 15:09:48 +0530\0" "To\0Sam Ravnborg <sam@ravnborg.org>\0" "Cc\0linux-fbdev@vger.kernel.org" Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> @@ -110,7 +110,7 @@ "dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant.\n" "\n" "> > \n" - "> > -\tif (state.event = PM_EVENT_SUSPEND) {\n" + "> > -\tif (state.event == PM_EVENT_SUSPEND) {\n" "> > -\t\tconsole_lock();\n" "> > -\t\tgx_powerdown(info);\n" "> > -\t\tfb_set_suspend(info, 1);\n" @@ -166,7 +166,7 @@ "And as it was legacy code, it was invoked by pci_legacy_suspend() for\n" "pci_pm_suspend(), pci_pm_freeze() and pci_pm_poweroff().\n" "Thus, the code was wrapped inside \"if\" container:\n" - "\tif (state.event = PM_EVENT_SUSPEND) { }\n" + "\tif (state.event == PM_EVENT_SUSPEND) { }\n" "\n" "After binding it with dev_pm_ops variable, pm->suspend() is invoked by just\n" "pci_pm_suspend() which is required.\n" @@ -219,6 +219,10 @@ "> > _______________________________________________\n" "> > dri-devel mailing list\n" "> > dri-devel@lists.freedesktop.org\n" - > > https://lists.freedesktop.org/mailman/listinfo/dri-devel + "> > https://lists.freedesktop.org/mailman/listinfo/dri-devel\n" + "_______________________________________________\n" + "dri-devel mailing list\n" + "dri-devel@lists.freedesktop.org\n" + https://lists.freedesktop.org/mailman/listinfo/dri-devel -69797645aa437af0e72c79cc14f924f2b29ca1abc2d03cd0fe616174a451f008 +bd8d7397e4fbad450d40a3aa6a43ff46e890f7ada0bc53051448aa896222a41b
diff --git a/a/1.txt b/N4/1.txt index 8fdf2af..0a3c9a6 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -85,7 +85,7 @@ gxfb_probe() invokes pci_set_drvdata(pdev, info) which in turn calls dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant. > > -> > - if (state.event = PM_EVENT_SUSPEND) { +> > - if (state.event == PM_EVENT_SUSPEND) { > > - console_lock(); > > - gx_powerdown(info); > > - fb_set_suspend(info, 1); @@ -141,7 +141,7 @@ Earlier, gxfb_suspend() performed each operation just for suspend event. And as it was legacy code, it was invoked by pci_legacy_suspend() for pci_pm_suspend(), pci_pm_freeze() and pci_pm_poweroff(). Thus, the code was wrapped inside "if" container: - if (state.event = PM_EVENT_SUSPEND) { } + if (state.event == PM_EVENT_SUSPEND) { } After binding it with dev_pm_ops variable, pm->suspend() is invoked by just pci_pm_suspend() which is required. diff --git a/a/content_digest b/N4/content_digest index 5136105..75f97be 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -3,24 +3,25 @@ "ref\020200808111746.GA24172@ravnborg.org\0" "From\0Vaibhav Gupta <vaibhavgupta40@gmail.com>\0" "Subject\0Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management\0" - "Date\0Mon, 10 Aug 2020 09:51:48 +0000\0" + "Date\0Mon, 10 Aug 2020 15:09:48 +0530\0" "To\0Sam Ravnborg <sam@ravnborg.org>\0" - "Cc\0linux-fbdev@vger.kernel.org" - Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> + "Cc\0Bjorn Helgaas <helgaas@kernel.org>" + Bjorn Helgaas <bhelgaas@google.com> + Bjorn Helgaas <bjorn@helgaas.com> Vaibhav Gupta <vaibhav.varodek@gmail.com> - Florian Tobias Schandinat <FlorianSchandinat@gmx.de> + Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> + Paul Mackerras <paulus@samba.org> Russell King <linux@armlinux.org.uk> - dri-devel@lists.freedesktop.org - linux-kernel@vger.kernel.org - Bjorn Helgaas <bjorn@helgaas.com> - Bjorn Helgaas <helgaas@kernel.org> - linux-arm-kernel@lists.infradead.org Andres Salomon <dilinger@queued.net> - Bjorn Helgaas <bhelgaas@google.com> - Paul Mackerras <paulus@samba.org> + Antonino Daplas <adaplas@gmail.com> + Florian Tobias Schandinat <FlorianSchandinat@gmx.de> + linux-fbdev@vger.kernel.org + linux-kernel@vger.kernel.org + dri-devel@lists.freedesktop.org + linux-geode@lists.infradead.org Shuah Khan <skhan@linuxfoundation.org> linux-kernel-mentees@lists.linuxfoundation.org - " linux-geode@lists.infradead.org\0" + " linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Sat, Aug 08, 2020 at 01:17:46PM +0200, Sam Ravnborg wrote:\n" @@ -110,7 +111,7 @@ "dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant.\n" "\n" "> > \n" - "> > -\tif (state.event = PM_EVENT_SUSPEND) {\n" + "> > -\tif (state.event == PM_EVENT_SUSPEND) {\n" "> > -\t\tconsole_lock();\n" "> > -\t\tgx_powerdown(info);\n" "> > -\t\tfb_set_suspend(info, 1);\n" @@ -166,7 +167,7 @@ "And as it was legacy code, it was invoked by pci_legacy_suspend() for\n" "pci_pm_suspend(), pci_pm_freeze() and pci_pm_poweroff().\n" "Thus, the code was wrapped inside \"if\" container:\n" - "\tif (state.event = PM_EVENT_SUSPEND) { }\n" + "\tif (state.event == PM_EVENT_SUSPEND) { }\n" "\n" "After binding it with dev_pm_ops variable, pm->suspend() is invoked by just\n" "pci_pm_suspend() which is required.\n" @@ -221,4 +222,4 @@ "> > dri-devel@lists.freedesktop.org\n" > > https://lists.freedesktop.org/mailman/listinfo/dri-devel -69797645aa437af0e72c79cc14f924f2b29ca1abc2d03cd0fe616174a451f008 +50bab5817f84d3901695c689efda7fe845a0083bfcc628d0ac85b2d08fb707b0
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.