From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vaibhav Gupta Date: Mon, 10 Aug 2020 09:56:13 +0000 Subject: Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management Message-Id: <20200810094413.GA7579@gmail.com> List-Id: References: <20200805180722.244008-1-vaibhavgupta40@gmail.com> <20200805180722.244008-2-vaibhavgupta40@gmail.com> <20200808111746.GA24172@ravnborg.org> <20200810093948.GB6615@gmail.com> In-Reply-To: <20200810093948.GB6615@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sam Ravnborg Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Vaibhav Gupta , Shuah Khan , Russell King , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Andres Salomon , Bjorn Helgaas , Paul Mackerras , linux-kernel-mentees@lists.linuxfoundation.org, linux-geode@lists.infradead.org > > > -static int gxfb_suspend(struct pci_dev *pdev, pm_message_t state) > > > +static int __maybe_unused gxfb_suspend(struct device *dev) > > > { > > > - struct fb_info *info = pci_get_drvdata(pdev); > > > + struct fb_info *info = dev_get_drvdata(dev); > > I do not see any dev_set_drvdata() so I guess we get a NULL pointer > > here which is not intended. > > Adding a dev_set_data() to gxfb_probe() would do the trick. > > > gxfb_probe() invokes pci_set_drvdata(pdev, info) which in turn calls > dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant. > s/dev_get_drvdata/dev_set_drvdata Thanks Vaibhav Gupta From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15DE3C433E0 for ; Mon, 10 Aug 2020 09:46:08 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFA3B206B5 for ; Mon, 10 Aug 2020 09:46:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tJvq3feY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFA3B206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 7D0E52634D; Mon, 10 Aug 2020 09:46:07 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7UJrmFXYyPpB; Mon, 10 Aug 2020 09:46:06 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by silver.osuosl.org (Postfix) with ESMTP id 5DFBC204BF; Mon, 10 Aug 2020 09:46:06 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 54813C0864; Mon, 10 Aug 2020 09:46:06 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 99511C004D for ; Mon, 10 Aug 2020 09:46:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 8F98487009 for ; Mon, 10 Aug 2020 09:46:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id X5mc176b374A for ; Mon, 10 Aug 2020 09:46:05 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 2E3A486F55 for ; Mon, 10 Aug 2020 09:46:05 +0000 (UTC) Received: by mail-pl1-f196.google.com with SMTP id t10so4494629plz.10 for ; Mon, 10 Aug 2020 02:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3fQqRDOEEK3chzUCl0lL9Ogs6I8yGgHjcMYgs480q6A=; b=tJvq3feYTqDjpFSHsGa2nJp192C6I/gC+CaEBcq+Rjc10MIMDQEU3hwx8IX6Kd9idz AruD5txahoyc/RfHJNXbJrjPl6nc7UFpzVUaQeNGh5Pn6Jt3C6tfMbmw3RcNqymAsb6f IByBxrDQLihGva6ZJJSzfOCbQOMpoQ89ePpCdAc06+LDjHNe49iOuezNAf5j5IfaBJ/G Kaf58/2KRp1dnSVJNv3TXUz7ETLosn6Q61C9Akr0W6sQHuPPrT7nj2IqhwwwPfHNaL3G mArAkvtKlrcZT8j3HfLZqz4krYEZdlGTf2oFVGjHDUPYFOU3TK4n0dw6NweWPnPV3oP4 dIaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3fQqRDOEEK3chzUCl0lL9Ogs6I8yGgHjcMYgs480q6A=; b=LOkOQtnxyNsEcGZDFGOiMrFWbgD/ET58ZD9d1ZB2y6zu+LRoF7NrEh14LDRT9Vgoet GMu546KHTI692I6MnCLIgP1d80yHeXNo6UdaOIgOV7HhOPydEA9Ki2i88i0LUviIcl7q xx0I/pEHCd7wPW5eE/sV5gf+teFcfRlGXA4rkzF/DR3plethOxnjPFS17KbTM0Om+bwP tOpr4o1tVRPk+wStNa7Cz16pMDsNxUQPU0V4oOVNshuEQg6j65cVu//9RRfMegEj8/PO PVXpFjbEBBW/qStGKCylvTeppzP9i2xASOinzI/FLFA17K4spKFkZgN480IHXTz8fulp fO4Q== X-Gm-Message-State: AOAM5336L3g8GY1OW2EPoYDcI1x7XyeXfUk7OIB/mTKYDjeBTzcdNWTK TVUXeeiXSGX9Jtl0QLJq7sE= X-Google-Smtp-Source: ABdhPJwvz+1J3dgGouXI08GF3iGqfuD+/RYt1n1Cm2Iz11htOXNeqE5EI6zW35FtLcFUJzc2qTBLsw== X-Received: by 2002:a17:902:d3c6:: with SMTP id w6mr21348487plb.209.1597052764753; Mon, 10 Aug 2020 02:46:04 -0700 (PDT) Received: from gmail.com ([103.105.152.86]) by smtp.gmail.com with ESMTPSA id l4sm9385502pgk.74.2020.08.10.02.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2020 02:46:04 -0700 (PDT) Date: Mon, 10 Aug 2020 15:14:13 +0530 From: Vaibhav Gupta To: Sam Ravnborg Message-ID: <20200810094413.GA7579@gmail.com> References: <20200805180722.244008-1-vaibhavgupta40@gmail.com> <20200805180722.244008-2-vaibhavgupta40@gmail.com> <20200808111746.GA24172@ravnborg.org> <20200810093948.GB6615@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200810093948.GB6615@gmail.com> Cc: linux-fbdev@vger.kernel.org, Antonino Daplas , Bartlomiej Zolnierkiewicz , Vaibhav Gupta , Russell King , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Andres Salomon , Bjorn Helgaas , Paul Mackerras , linux-kernel-mentees@lists.linuxfoundation.org, linux-geode@lists.infradead.org Subject: Re: [Linux-kernel-mentees] [PATCH v1 01/12] fbdev: gxfb: use generic power management X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" > > > -static int gxfb_suspend(struct pci_dev *pdev, pm_message_t state) > > > +static int __maybe_unused gxfb_suspend(struct device *dev) > > > { > > > - struct fb_info *info = pci_get_drvdata(pdev); > > > + struct fb_info *info = dev_get_drvdata(dev); > > I do not see any dev_set_drvdata() so I guess we get a NULL pointer > > here which is not intended. > > Adding a dev_set_data() to gxfb_probe() would do the trick. > > > gxfb_probe() invokes pci_set_drvdata(pdev, info) which in turn calls > dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant. > s/dev_get_drvdata/dev_set_drvdata Thanks Vaibhav Gupta _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F8C1C433E0 for ; Mon, 10 Aug 2020 09:47:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF70D206B5 for ; Mon, 10 Aug 2020 09:47:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZQdL6gWm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tJvq3feY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF70D206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mnKgYeyFmfJn3SA3YJuR/1lY2wHXs7SZwF2Vi+ZJv2s=; b=ZQdL6gWmLPTDBp2UMarb3pAZ/ V1cd9vV/yfeUPJUzMJ70NAsBXo1H2oycR8G6EI7sS517eqvWVmQzYCaFHEZZ0qdNN3xBNhPg/2k6O OjY1CQDjqwXTruDM675Rd9sV2lYGHC5LHE0sIOlfnirVXfaZ5vh0pCWLESKJuVjaH0b049ZMMRYlL C/9I63JAJnS7i7hJUzGqs4ILGGbypi0Ut9/aikxZx6HtKTEt/4nSDA3w0gLoullwUk68ARZ5+LaUD AYg6T4ppf5EpcxDZP1Pf4vNpTBkNW5Xzm4dOETI486SOsQwCjr8CZCokwmR9h44PMCMkmd9h17kBg 7PvS3445Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k54Nd-0003Cv-Ly; Mon, 10 Aug 2020 09:46:09 +0000 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k54Na-0003Bx-R5; Mon, 10 Aug 2020 09:46:07 +0000 Received: by mail-pj1-x1044.google.com with SMTP id l60so4528593pjb.3; Mon, 10 Aug 2020 02:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3fQqRDOEEK3chzUCl0lL9Ogs6I8yGgHjcMYgs480q6A=; b=tJvq3feYTqDjpFSHsGa2nJp192C6I/gC+CaEBcq+Rjc10MIMDQEU3hwx8IX6Kd9idz AruD5txahoyc/RfHJNXbJrjPl6nc7UFpzVUaQeNGh5Pn6Jt3C6tfMbmw3RcNqymAsb6f IByBxrDQLihGva6ZJJSzfOCbQOMpoQ89ePpCdAc06+LDjHNe49iOuezNAf5j5IfaBJ/G Kaf58/2KRp1dnSVJNv3TXUz7ETLosn6Q61C9Akr0W6sQHuPPrT7nj2IqhwwwPfHNaL3G mArAkvtKlrcZT8j3HfLZqz4krYEZdlGTf2oFVGjHDUPYFOU3TK4n0dw6NweWPnPV3oP4 dIaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3fQqRDOEEK3chzUCl0lL9Ogs6I8yGgHjcMYgs480q6A=; b=XL9YzLgvNIhpZS+7LdlfCXis+3cdu4k+zldn8MdgeOOXZRoNj5jwwUkw/Gu5dp23P8 ufy+VXNb9hrtnwyAMPJD5YPL39q2Hh4Yqmye26/OrvcYeXL04LD3TttUwdjUzPqJVb6m h1OMM5DMIiq1PtSPxg9PxLhptDAuCd84EB7PqzFPu60qykyL+cX/6dOeJNpQZeuDylcT rTqEXslyMutsEC925maa1rpFx2NyveVjIgBkUwj+oZ7TLoeJjxChE6Q/soIB6AjQtaRi VfnRoTIAIOtkj8y4Ei4HQQaLIt9H2m/btENyF/Z9bjF55Jr29V15d40GmMyt91Ds8Yu9 Ulng== X-Gm-Message-State: AOAM530BQpXTQzfqQHGwG6dmsEAkGcewjMLI9ZDpJrlc+a2rjs+eagzA 3AjbYsd/HQkI6XmDn2QiA50= X-Google-Smtp-Source: ABdhPJwvz+1J3dgGouXI08GF3iGqfuD+/RYt1n1Cm2Iz11htOXNeqE5EI6zW35FtLcFUJzc2qTBLsw== X-Received: by 2002:a17:902:d3c6:: with SMTP id w6mr21348487plb.209.1597052764753; Mon, 10 Aug 2020 02:46:04 -0700 (PDT) Received: from gmail.com ([103.105.152.86]) by smtp.gmail.com with ESMTPSA id l4sm9385502pgk.74.2020.08.10.02.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2020 02:46:04 -0700 (PDT) Date: Mon, 10 Aug 2020 15:14:13 +0530 From: Vaibhav Gupta To: Sam Ravnborg Subject: Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management Message-ID: <20200810094413.GA7579@gmail.com> References: <20200805180722.244008-1-vaibhavgupta40@gmail.com> <20200805180722.244008-2-vaibhavgupta40@gmail.com> <20200808111746.GA24172@ravnborg.org> <20200810093948.GB6615@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200810093948.GB6615@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200810_054606_926163_1D6B3C5C X-CRM114-Status: GOOD ( 11.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Antonino Daplas , Bartlomiej Zolnierkiewicz , Vaibhav Gupta , Shuah Khan , Russell King , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Andres Salomon , Bjorn Helgaas , Paul Mackerras , linux-kernel-mentees@lists.linuxfoundation.org, linux-geode@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > > -static int gxfb_suspend(struct pci_dev *pdev, pm_message_t state) > > > +static int __maybe_unused gxfb_suspend(struct device *dev) > > > { > > > - struct fb_info *info = pci_get_drvdata(pdev); > > > + struct fb_info *info = dev_get_drvdata(dev); > > I do not see any dev_set_drvdata() so I guess we get a NULL pointer > > here which is not intended. > > Adding a dev_set_data() to gxfb_probe() would do the trick. > > > gxfb_probe() invokes pci_set_drvdata(pdev, info) which in turn calls > dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant. > s/dev_get_drvdata/dev_set_drvdata Thanks Vaibhav Gupta _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68BC7C433DF for ; Tue, 11 Aug 2020 06:59:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 407A820772 for ; Tue, 11 Aug 2020 06:59:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tJvq3feY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 407A820772 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E9EB6E4BA; Tue, 11 Aug 2020 06:59:22 +0000 (UTC) Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2530589CAF for ; Mon, 10 Aug 2020 09:46:05 +0000 (UTC) Received: by mail-pl1-x643.google.com with SMTP id w17so4494531ply.11 for ; Mon, 10 Aug 2020 02:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3fQqRDOEEK3chzUCl0lL9Ogs6I8yGgHjcMYgs480q6A=; b=tJvq3feYTqDjpFSHsGa2nJp192C6I/gC+CaEBcq+Rjc10MIMDQEU3hwx8IX6Kd9idz AruD5txahoyc/RfHJNXbJrjPl6nc7UFpzVUaQeNGh5Pn6Jt3C6tfMbmw3RcNqymAsb6f IByBxrDQLihGva6ZJJSzfOCbQOMpoQ89ePpCdAc06+LDjHNe49iOuezNAf5j5IfaBJ/G Kaf58/2KRp1dnSVJNv3TXUz7ETLosn6Q61C9Akr0W6sQHuPPrT7nj2IqhwwwPfHNaL3G mArAkvtKlrcZT8j3HfLZqz4krYEZdlGTf2oFVGjHDUPYFOU3TK4n0dw6NweWPnPV3oP4 dIaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3fQqRDOEEK3chzUCl0lL9Ogs6I8yGgHjcMYgs480q6A=; b=HMYrZhCVu5kSbnfj5uewsDksQ+LFQnMX0NGAOlLa/t9mgAbIsn6kLaQs0bRfefPN8K HhNLaUN4bBVDmAcmas7bQnLOCxfuJcs2zc+sWyLlsAvpJQksyXTeflchVPBh3e8Xtmbn VR1A5RNFkWbPdwSBfwpgmzljAKoR3n/jMvhXcFF+4YMq3kQcjHWbW/UH6ROQ4I1JTlcC LlFYjTlsp6d79MX6INHE+TiFuxOlRHolYFd/eYZ9zXFAoZYw86kutOmM6n6bsMAdq/bq oz//YhXoapM29ROvSKXmVhf6lmuZwnA6b9WnOohOvFsGYt4WGSGg8QEbP0q6qLDL2cyk r7xg== X-Gm-Message-State: AOAM5330af6euvYMWKFDiWbkNBzmu6cs/NLsoyyTpOQZGk7lkhfno0u8 QHOKUM3nBKkWsVvwcRrH69GoyNnnkg/4bQ== X-Google-Smtp-Source: ABdhPJwvz+1J3dgGouXI08GF3iGqfuD+/RYt1n1Cm2Iz11htOXNeqE5EI6zW35FtLcFUJzc2qTBLsw== X-Received: by 2002:a17:902:d3c6:: with SMTP id w6mr21348487plb.209.1597052764753; Mon, 10 Aug 2020 02:46:04 -0700 (PDT) Received: from gmail.com ([103.105.152.86]) by smtp.gmail.com with ESMTPSA id l4sm9385502pgk.74.2020.08.10.02.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2020 02:46:04 -0700 (PDT) Date: Mon, 10 Aug 2020 15:14:13 +0530 From: Vaibhav Gupta To: Sam Ravnborg Subject: Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management Message-ID: <20200810094413.GA7579@gmail.com> References: <20200805180722.244008-1-vaibhavgupta40@gmail.com> <20200805180722.244008-2-vaibhavgupta40@gmail.com> <20200808111746.GA24172@ravnborg.org> <20200810093948.GB6615@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200810093948.GB6615@gmail.com> X-Mailman-Approved-At: Tue, 11 Aug 2020 06:58:41 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Vaibhav Gupta , Shuah Khan , Russell King , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Bjorn Helgaas , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Andres Salomon , Bjorn Helgaas , Paul Mackerras , linux-kernel-mentees@lists.linuxfoundation.org, linux-geode@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > > > -static int gxfb_suspend(struct pci_dev *pdev, pm_message_t state) > > > +static int __maybe_unused gxfb_suspend(struct device *dev) > > > { > > > - struct fb_info *info = pci_get_drvdata(pdev); > > > + struct fb_info *info = dev_get_drvdata(dev); > > I do not see any dev_set_drvdata() so I guess we get a NULL pointer > > here which is not intended. > > Adding a dev_set_data() to gxfb_probe() would do the trick. > > > gxfb_probe() invokes pci_set_drvdata(pdev, info) which in turn calls > dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant. > s/dev_get_drvdata/dev_set_drvdata Thanks Vaibhav Gupta _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, FSL_HELO_FAKE,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C7E7C433DF for ; Mon, 10 Aug 2020 09:46:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D11EF206B5 for ; Mon, 10 Aug 2020 09:46:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tJvq3feY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726707AbgHJJqF (ORCPT ); Mon, 10 Aug 2020 05:46:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726173AbgHJJqF (ORCPT ); Mon, 10 Aug 2020 05:46:05 -0400 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D47BC061756; Mon, 10 Aug 2020 02:46:05 -0700 (PDT) Received: by mail-pj1-x1041.google.com with SMTP id mt12so4529318pjb.4; Mon, 10 Aug 2020 02:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=3fQqRDOEEK3chzUCl0lL9Ogs6I8yGgHjcMYgs480q6A=; b=tJvq3feYTqDjpFSHsGa2nJp192C6I/gC+CaEBcq+Rjc10MIMDQEU3hwx8IX6Kd9idz AruD5txahoyc/RfHJNXbJrjPl6nc7UFpzVUaQeNGh5Pn6Jt3C6tfMbmw3RcNqymAsb6f IByBxrDQLihGva6ZJJSzfOCbQOMpoQ89ePpCdAc06+LDjHNe49iOuezNAf5j5IfaBJ/G Kaf58/2KRp1dnSVJNv3TXUz7ETLosn6Q61C9Akr0W6sQHuPPrT7nj2IqhwwwPfHNaL3G mArAkvtKlrcZT8j3HfLZqz4krYEZdlGTf2oFVGjHDUPYFOU3TK4n0dw6NweWPnPV3oP4 dIaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3fQqRDOEEK3chzUCl0lL9Ogs6I8yGgHjcMYgs480q6A=; b=Pj7swVnK/iwmFca0JbzvUQJLQpeHJ+pVKRe3cWnX53cGG/38sYSgDVZW1w3yd4O1IB /HaapkV9RtGrtqPWJ+Z+2Biq3fSDMbGe9ECiKCVCwVxDvmL65XzvlcC8twYzU4Xd0B0B ecIeKy8jEzQYmAb9GIcDSLEPNU2yXHEcBVjZeAok2zzCqnnfJ+stl3optILokXXz4c6X F1rYaTGOn1Q7AaMgOqAsPJLKnPbfdSNTFqJBciG7X6QdHJP6Zv/dnIPYXzWXMLd0FxRp 2VJ/eg5PM5s9XHUd8YZc4wmcfRhOIlU+WKmLU8dc+QNdDCJpklemVAQ473tMS8TaDYN8 Q6fg== X-Gm-Message-State: AOAM530PlqdEzr8Ji4xMrZTfxEMiozmQIhLNvh1QO+C4wxz1dpwbmo2h sZNv3vD70iWAG+L9mQcMfNI= X-Google-Smtp-Source: ABdhPJwvz+1J3dgGouXI08GF3iGqfuD+/RYt1n1Cm2Iz11htOXNeqE5EI6zW35FtLcFUJzc2qTBLsw== X-Received: by 2002:a17:902:d3c6:: with SMTP id w6mr21348487plb.209.1597052764753; Mon, 10 Aug 2020 02:46:04 -0700 (PDT) Received: from gmail.com ([103.105.152.86]) by smtp.gmail.com with ESMTPSA id l4sm9385502pgk.74.2020.08.10.02.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2020 02:46:04 -0700 (PDT) Date: Mon, 10 Aug 2020 15:14:13 +0530 From: Vaibhav Gupta To: Sam Ravnborg Cc: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Bartlomiej Zolnierkiewicz , Paul Mackerras , Russell King , Andres Salomon , Antonino Daplas , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-geode@lists.infradead.org, Shuah Khan , linux-kernel-mentees@lists.linuxfoundation.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management Message-ID: <20200810094413.GA7579@gmail.com> References: <20200805180722.244008-1-vaibhavgupta40@gmail.com> <20200805180722.244008-2-vaibhavgupta40@gmail.com> <20200808111746.GA24172@ravnborg.org> <20200810093948.GB6615@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200810093948.GB6615@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > -static int gxfb_suspend(struct pci_dev *pdev, pm_message_t state) > > > +static int __maybe_unused gxfb_suspend(struct device *dev) > > > { > > > - struct fb_info *info = pci_get_drvdata(pdev); > > > + struct fb_info *info = dev_get_drvdata(dev); > > I do not see any dev_set_drvdata() so I guess we get a NULL pointer > > here which is not intended. > > Adding a dev_set_data() to gxfb_probe() would do the trick. > > > gxfb_probe() invokes pci_set_drvdata(pdev, info) which in turn calls > dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant. > s/dev_get_drvdata/dev_set_drvdata Thanks Vaibhav Gupta