All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] gpu: ipu-v3: remove unused functions
Date: Mon, 10 Aug 2020 22:04:32 +0200	[thread overview]
Message-ID: <20200810200432.GA415947@ravnborg.org> (raw)
In-Reply-To: <20200721130504.22081-1-p.zabel@pengutronix.de>

On Tue, Jul 21, 2020 at 03:05:04PM +0200, Philipp Zabel wrote:
> ipu_mbus_code_to_colorspace, ipu_stride_to_bytes, and
> ipu_pixelformat_is_planar are unused. Remove them.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

git grep agrees with you.

Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

> ---
>  drivers/gpu/ipu-v3/ipu-common.c | 67 ---------------------------------
>  include/video/imx-ipu-v3.h      |  3 --
>  2 files changed, 70 deletions(-)
> 
> diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c
> index b3dae9ec1a38..d166ee262ce4 100644
> --- a/drivers/gpu/ipu-v3/ipu-common.c
> +++ b/drivers/gpu/ipu-v3/ipu-common.c
> @@ -133,73 +133,6 @@ enum ipu_color_space ipu_pixelformat_to_colorspace(u32 pixelformat)
>  }
>  EXPORT_SYMBOL_GPL(ipu_pixelformat_to_colorspace);
>  
> -bool ipu_pixelformat_is_planar(u32 pixelformat)
> -{
> -	switch (pixelformat) {
> -	case V4L2_PIX_FMT_YUV420:
> -	case V4L2_PIX_FMT_YVU420:
> -	case V4L2_PIX_FMT_YUV422P:
> -	case V4L2_PIX_FMT_NV12:
> -	case V4L2_PIX_FMT_NV21:
> -	case V4L2_PIX_FMT_NV16:
> -	case V4L2_PIX_FMT_NV61:
> -		return true;
> -	}
> -
> -	return false;
> -}
> -EXPORT_SYMBOL_GPL(ipu_pixelformat_is_planar);
> -
> -enum ipu_color_space ipu_mbus_code_to_colorspace(u32 mbus_code)
> -{
> -	switch (mbus_code & 0xf000) {
> -	case 0x1000:
> -		return IPUV3_COLORSPACE_RGB;
> -	case 0x2000:
> -		return IPUV3_COLORSPACE_YUV;
> -	default:
> -		return IPUV3_COLORSPACE_UNKNOWN;
> -	}
> -}
> -EXPORT_SYMBOL_GPL(ipu_mbus_code_to_colorspace);
> -
> -int ipu_stride_to_bytes(u32 pixel_stride, u32 pixelformat)
> -{
> -	switch (pixelformat) {
> -	case V4L2_PIX_FMT_YUV420:
> -	case V4L2_PIX_FMT_YVU420:
> -	case V4L2_PIX_FMT_YUV422P:
> -	case V4L2_PIX_FMT_NV12:
> -	case V4L2_PIX_FMT_NV21:
> -	case V4L2_PIX_FMT_NV16:
> -	case V4L2_PIX_FMT_NV61:
> -		/*
> -		 * for the planar YUV formats, the stride passed to
> -		 * cpmem must be the stride in bytes of the Y plane.
> -		 * And all the planar YUV formats have an 8-bit
> -		 * Y component.
> -		 */
> -		return (8 * pixel_stride) >> 3;
> -	case V4L2_PIX_FMT_RGB565:
> -	case V4L2_PIX_FMT_YUYV:
> -	case V4L2_PIX_FMT_UYVY:
> -		return (16 * pixel_stride) >> 3;
> -	case V4L2_PIX_FMT_BGR24:
> -	case V4L2_PIX_FMT_RGB24:
> -		return (24 * pixel_stride) >> 3;
> -	case V4L2_PIX_FMT_BGR32:
> -	case V4L2_PIX_FMT_RGB32:
> -	case V4L2_PIX_FMT_XBGR32:
> -	case V4L2_PIX_FMT_XRGB32:
> -		return (32 * pixel_stride) >> 3;
> -	default:
> -		break;
> -	}
> -
> -	return -EINVAL;
> -}
> -EXPORT_SYMBOL_GPL(ipu_stride_to_bytes);
> -
>  int ipu_degrees_to_rot_mode(enum ipu_rotate_mode *mode, int degrees,
>  			    bool hflip, bool vflip)
>  {
> diff --git a/include/video/imx-ipu-v3.h b/include/video/imx-ipu-v3.h
> index 06b0b57e996c..d1b3889f74d8 100644
> --- a/include/video/imx-ipu-v3.h
> +++ b/include/video/imx-ipu-v3.h
> @@ -484,9 +484,6 @@ int ipu_smfc_set_watermark(struct ipu_smfc *smfc, u32 set_level, u32 clr_level);
>  
>  enum ipu_color_space ipu_drm_fourcc_to_colorspace(u32 drm_fourcc);
>  enum ipu_color_space ipu_pixelformat_to_colorspace(u32 pixelformat);
> -enum ipu_color_space ipu_mbus_code_to_colorspace(u32 mbus_code);
> -int ipu_stride_to_bytes(u32 pixel_stride, u32 pixelformat);
> -bool ipu_pixelformat_is_planar(u32 pixelformat);
>  int ipu_degrees_to_rot_mode(enum ipu_rotate_mode *mode, int degrees,
>  			    bool hflip, bool vflip);
>  int ipu_rot_mode_to_degrees(int *degrees, enum ipu_rotate_mode mode,
> -- 
> 2.20.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2020-08-10 20:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 13:05 [PATCH] gpu: ipu-v3: remove unused functions Philipp Zabel
2020-08-10 20:04 ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200810200432.GA415947@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel@pengutronix.de \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.