From: Gregory Etelson <getelson@nvidia.com>
To: <dev@dpdk.org>
Cc: <getelson@nvidia.com>, <matan@nvidia.com>, <rasland@nvidia.com>,
<stable@dpdk.org>, Ori Kam <orika@nvidia.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
"Bernard Iremonger" <bernard.iremonger@intel.com>
Subject: [dpdk-dev] [PATCH] app/testpmd: fix flow rules list after port stop
Date: Tue, 11 Aug 2020 09:14:42 +0300 [thread overview]
Message-ID: <20200811061443.8214-1-getelson@nvidia.com> (raw)
According to current RTE API, port flow rules must not be kept
after port stop.
Testpmd did not flush port flow rules after `port stop' command was
called. As the result, after the port was restarted, it showed bogus
flow rules.
Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings")
Cc: stable@dpdk.org
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Acked-by: Ori Kam <orika@nvidia.com>
---
app/test-pmd/testpmd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 7842c3b781..4ba5c41c6e 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -2627,6 +2627,9 @@ stop_port(portid_t pid)
RTE_PORT_HANDLING) == 0)
continue;
+ if (port->flow_list)
+ port_flow_flush(pi);
+
rte_eth_dev_stop(pi);
if (rte_atomic16_cmpset(&(port->port_status),
--
2.25.1
next reply other threads:[~2020-08-11 6:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 6:14 Gregory Etelson [this message]
2020-11-24 14:42 ` [dpdk-dev] [PATCH] app/testpmd: fix flow rules list after port stop Ajit Khaparde
2020-11-26 15:41 ` Thomas Monjalon
2020-11-26 16:43 ` [dpdk-dev] [PATCH v2] app/testpmd: fix testpmd flows left before " Gregory Etelson
2020-11-27 16:01 ` Andrew Rybchenko
2020-11-29 6:59 ` Gregory Etelson
2021-01-06 18:07 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
[not found] <20200810161523.6904-1-getelson@mellanox.com>
2020-08-20 8:40 ` [dpdk-dev] [PATCH] app/testpmd: fix flow rules list after " Gregory Etelson
2020-08-25 15:51 ` Ferruh Yigit
2020-08-26 17:34 ` Ori Kam
2020-09-13 12:12 ` Ori Kam
2020-09-13 14:00 ` Thomas Monjalon
2020-11-17 19:08 ` Gregory Etelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811061443.8214-1-getelson@nvidia.com \
--to=getelson@nvidia.com \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.