From: Greg KH <gregkh@linuxfoundation.org>
To: Gage Eads <gage.eads@intel.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
magnus.karlsson@intel.com, bjorn.topel@intel.com
Subject: Re: [PATCH v2 02/19] dlb2: initialize PF device
Date: Tue, 11 Aug 2020 19:06:27 +0200 [thread overview]
Message-ID: <20200811170627.GB765993@kroah.com> (raw)
In-Reply-To: <20200811162732.1369-3-gage.eads@intel.com>
On Tue, Aug 11, 2020 at 11:27:15AM -0500, Gage Eads wrote:
> The driver detects the device type (PF/VF) at probe time, and assigns the
> corresponding 'ops' callbacks from that. These callbacks include mapping
> and unmapping the PCI BAR space, creating/destroying the device, and
> adding/deleting a char device.
>
> Signed-off-by: Gage Eads <gage.eads@intel.com>
> Reviewed-by: Magnus Karlsson <magnus.karlsson@intel.com>
> ---
> drivers/misc/dlb2/Makefile | 5 +-
> drivers/misc/dlb2/dlb2_hw_types.h | 28 +++++++++
> drivers/misc/dlb2/dlb2_main.c | 49 ++++++++++++++-
> drivers/misc/dlb2/dlb2_main.h | 30 +++++++++
> drivers/misc/dlb2/dlb2_pf_ops.c | 126 ++++++++++++++++++++++++++++++++++++++
> 5 files changed, 235 insertions(+), 3 deletions(-)
> create mode 100644 drivers/misc/dlb2/dlb2_pf_ops.c
>
> diff --git a/drivers/misc/dlb2/Makefile b/drivers/misc/dlb2/Makefile
> index 90ae953d2a8f..95e67e5bd8ff 100644
> --- a/drivers/misc/dlb2/Makefile
> +++ b/drivers/misc/dlb2/Makefile
> @@ -4,5 +4,6 @@
>
> obj-$(CONFIG_INTEL_DLB2) := dlb2.o
>
> -dlb2-objs := \
> - dlb2_main.o \
> +dlb2-objs := \
> + dlb2_main.o \
> + dlb2_pf_ops.o \
> diff --git a/drivers/misc/dlb2/dlb2_hw_types.h b/drivers/misc/dlb2/dlb2_hw_types.h
> index a0f908c603eb..10b26356535f 100644
> --- a/drivers/misc/dlb2/dlb2_hw_types.h
> +++ b/drivers/misc/dlb2/dlb2_hw_types.h
> @@ -5,6 +5,25 @@
> #ifndef __DLB2_HW_TYPES_H
> #define __DLB2_HW_TYPES_H
>
> +#include <linux/io.h>
> +
> +#define DLB2_PCI_REG_READ(addr) ioread32(addr)
> +#define DLB2_PCI_REG_WRITE(reg, value) iowrite32(value, reg)
Why create a macro that is larger than the native call, this saves
nothing except make the reviewer wonder what in the world is happening.
Just use the real call.
next prev parent reply other threads:[~2020-08-11 17:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 16:27 [PATCH v2 00/19] dlb2: introduce DLB 2.0 device driver Gage Eads
2020-08-11 16:27 ` [PATCH v2 01/19] dlb2: add skeleton for DLB 2.0 driver Gage Eads
2020-08-11 17:05 ` Greg KH
2020-08-11 16:27 ` [PATCH v2 02/19] dlb2: initialize PF device Gage Eads
2020-08-11 17:06 ` Greg KH [this message]
2020-08-24 16:50 ` Eads, Gage
2020-08-11 16:27 ` [PATCH v2 03/19] dlb2: add resource and device initialization Gage Eads
2020-08-11 16:27 ` [PATCH v2 04/19] dlb2: add device ioctl layer and first three ioctls Gage Eads
2020-08-11 16:27 ` [PATCH v2 05/19] dlb2: add sched domain config and reset support Gage Eads
2020-08-11 16:27 ` [PATCH v2 06/19] dlb2: add runtime power-management support Gage Eads
2020-08-11 16:27 ` [PATCH v2 07/19] dlb2: add queue create and queue-depth-get ioctls Gage Eads
2020-08-11 16:27 ` [PATCH v2 08/19] dlb2: add ioctl to configure ports, query poll mode Gage Eads
2020-08-11 16:27 ` [PATCH v2 09/19] dlb2: add port mmap support Gage Eads
2020-08-11 16:27 ` [PATCH v2 10/19] dlb2: add start domain ioctl Gage Eads
2020-08-11 16:27 ` [PATCH v2 11/19] dlb2: add queue map and unmap ioctls Gage Eads
2020-08-11 16:27 ` [PATCH v2 12/19] dlb2: add port enable/disable ioctls Gage Eads
2020-08-11 16:27 ` [PATCH v2 13/19] dlb2: add CQ interrupt support Gage Eads
2020-08-11 16:27 ` [PATCH v2 14/19] dlb2: add domain alert support Gage Eads
2020-08-11 16:27 ` [PATCH v2 15/19] dlb2: add sequence-number management ioctls Gage Eads
2020-08-11 16:27 ` [PATCH v2 16/19] dlb2: add cos bandwidth get/set ioctls Gage Eads
2020-08-11 16:27 ` [PATCH v2 17/19] dlb2: add device FLR support Gage Eads
2020-08-11 16:27 ` [PATCH v2 18/19] dlb2: add basic PF sysfs interfaces Gage Eads
2020-08-11 16:27 ` [PATCH v2 19/19] dlb2: add ingress error handling Gage Eads
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811170627.GB765993@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=bjorn.topel@intel.com \
--cc=gage.eads@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.karlsson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.