From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB4CC433DF for ; Wed, 12 Aug 2020 08:47:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A70C42076B for ; Wed, 12 Aug 2020 08:47:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bDwl1W60" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726629AbgHLIrz (ORCPT ); Wed, 12 Aug 2020 04:47:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbgHLIrz (ORCPT ); Wed, 12 Aug 2020 04:47:55 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E4354C06174A for ; Wed, 12 Aug 2020 01:47:54 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id k20so1152734wmi.5 for ; Wed, 12 Aug 2020 01:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HEmqqaN3Cptn/L0IIb8kkOMEzBZVzXOJaGYzubXHWzw=; b=bDwl1W60RUfxSBU1CsOOzrdayBpOEeVukAihfKDvYdaEbs9bwfNzoF+yG3bLOv+d5b 4qLz31JZlxUFScwGi7Y12FISatc3Iy+Z8ZLzbM0ee2Kfd7WCsE8ki0ORp/2Mx3E36eBn OaRL5dwf6rTj7R80QjAmyUYE+qQFas43N+YXq5js1qZ3lzyjCVPt3CwDT9rQDudPRwxP VeKiVsjl7h8AKMnh+61Q7Qi0Ys/THfBCG0/0qZMO0yITgOIEa2BKE0/VdaOgKdbTmA72 xP3hs6N4DR4ZdSQD4Z5y1vo04uforaPHmc09dL9VZot3bPBtqYN84unQLR1Px/UWgZgA /Dmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HEmqqaN3Cptn/L0IIb8kkOMEzBZVzXOJaGYzubXHWzw=; b=d/BA7847a3iKbYfM5LkVZjK5xmw2fFyGAxWNgXJO9rbvP1eRD94H+MZuXHSFrDIaVA qfVg0ade/4PF4hANGZ1ZaFR1SlAsmlyM2oxuWtyMP3vctCciVnfk7XFQv12WbZY50zmi 3uqzoA2tY9YHb7ga1ABlJV0+z+PtFPRoV3LUe7DzyOBi2TFRjcZRrdmPranO31xID1nZ Q2Rz7V2iru2VRK+xXTDF5xECrORaK9hJ9HzZIwj4gX1HI+HWFoGRhA/Gy5VGRnX0jPtt 4gP8IdrNn9rSrznonNuB9UPDHm8X2pOmoZTkZd1mU7qRJgvyFqBL9NaLx8kdNPmI/5JO Uy/g== X-Gm-Message-State: AOAM532c4ToAxb6BBWo+ZZbdLV4QMQ9mraztWxYwizl22/KoBQ5CshUS 9h16NolToACndCdOxWdHb0n1Sw== X-Google-Smtp-Source: ABdhPJyh37vQVUgd85vM81zAQaFrcRnGbXt1MJT0w5ezPWRgNGrnuOzi78A4o5HB6maWF9QDX6DFGA== X-Received: by 2002:a1c:65d6:: with SMTP id z205mr7294055wmb.2.1597222073634; Wed, 12 Aug 2020 01:47:53 -0700 (PDT) Received: from dell ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id c17sm3099796wrc.42.2020.08.12.01.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 01:47:53 -0700 (PDT) Date: Wed, 12 Aug 2020 09:47:51 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-pwm@vger.kernel.org, Alexandre Belloni , Nicolas Ferre , Ludovic Desroches , Thierry Reding , kernel@pengutronix.de, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] pwm: atmel: Make use of dev_err_probe() Message-ID: <20200812084751.GE4354@dell> References: <20200812080259.4431-1-u.kleine-koenig@pengutronix.de> <20200812082002.GD4354@dell> <20200812083204.kktnid63j6vefsky@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200812083204.kktnid63j6vefsky@pengutronix.de> Sender: linux-pwm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pwm@vger.kernel.org On Wed, 12 Aug 2020, Uwe Kleine-König wrote: > On Wed, Aug 12, 2020 at 09:20:02AM +0100, Lee Jones wrote: > > On Wed, 12 Aug 2020, Uwe Kleine-König wrote: > > > > > Add an error message for failure points that currently lack a message > > > and convert dev_err to dev_err_probe() which does the right thing for > > > -EPROBE_DEFER. Also slightly simplify the error handling. > > > > > > Signed-off-by: Uwe Kleine-König > > > --- > > > drivers/pwm/pwm-atmel.c | 24 +++++++++++------------- > > > 1 file changed, 11 insertions(+), 13 deletions(-) > > > > > > diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c > > > index 6161e7e3e9ac..aa0b36695dc7 100644 > > > --- a/drivers/pwm/pwm-atmel.c > > > +++ b/drivers/pwm/pwm-atmel.c > > > @@ -415,17 +415,18 @@ static int atmel_pwm_probe(struct platform_device *pdev) > > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > atmel_pwm->base = devm_ioremap_resource(&pdev->dev, res); > > > if (IS_ERR(atmel_pwm->base)) > > > - return PTR_ERR(atmel_pwm->base); > > > + return dev_err_probe(&pdev->dev, PTR_ERR(atmel_pwm->base), > > > + "Failed to remap register space\n"); > > > > This is a regression. > > > > devm_ioremap_resource() already emits and error message for !-ENOMEM. > > > > -ENOMEM cases should fail silently. > > ah right. Maybe dev_err_probe() should do this right, too? Maybe, but you're still adding an unnecessary string to the kernel's binary. There was a bit push a little while back to cut down on these. > > > atmel_pwm->clk = devm_clk_get(&pdev->dev, NULL); > > > if (IS_ERR(atmel_pwm->clk)) > > > - return PTR_ERR(atmel_pwm->clk); > > > + return dev_err_probe(&pdev->dev, PTR_ERR(atmel_pwm->clk), > > > + "Failed to get clock\n"); > > > > Isn't dev_err_probe() only useful for drivers handling -EPROBE_DEFER? > > devm_clk_get() might return -EPROBE_DEFER. Perhaps, but the author has chosen not to handle it specifically. It's my understanding that dev_err_probe() was designed to simplify error handling in .probe() whereas this patch seems to do the polar opposite. > > > ret = clk_prepare(atmel_pwm->clk); > > > - if (ret) { > > > - dev_err(&pdev->dev, "failed to prepare PWM clock\n"); > > > - return ret; > > > - } > > > + if (ret) > > > + return dev_err_probe(&pdev->dev, ret, > > > + "Failed to prepare PWM clock\n"); > > > > As above. > > I only checked quickly and didn't find an instance where clk_prepare can > return -EPROBE_DEFER, but even if it doesn't it works fine. It's still misleading IMHO. dev_err_probe()'s header details its reason for existence. This seems to be a square peg in a round hole scenario. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61612C433DF for ; Wed, 12 Aug 2020 08:49:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 321CF2076B for ; Wed, 12 Aug 2020 08:49:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Dw7qjxO6"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bDwl1W60" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 321CF2076B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wrtGd3PHsLxM14gmBApufgdAImVzoIkAwMnxdaZCnSk=; b=Dw7qjxO6NTnCYBpQBh/oKOYfN T3pXkJF1UC8HmMObPDJEnh/9qXS+3Al2rrJv0OblZxmlHi2jgiSAYtzkkoFamU7ot7KxPPhU00QBe ilzt8d2DVk1+CbtEyhco2nhNb/7UDgY8C3BZxld1U4rNhVMtZYdNSA3zDA0Vf+bAPTPvpWsSp6Mnp jjgMQX66iudwykhAvytzNsqeXvYwRY3jeGj77yV1I9+Z3WBvl2bYAZnJB+M7P0GogaK0AZLo6tSF3 iNmrCcOVXxoxdnhP24wFyzY1uUyxHi7YuQE4nIUtSCL6SxjQi1NNX/hlYa9xfGSrapktdbh4pT+jm GnHfzYRMw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5mQP-0006lF-Kw; Wed, 12 Aug 2020 08:47:57 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5mQM-0006kn-Mx for linux-arm-kernel@lists.infradead.org; Wed, 12 Aug 2020 08:47:55 +0000 Received: by mail-wm1-x341.google.com with SMTP id k8so1162927wma.2 for ; Wed, 12 Aug 2020 01:47:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=HEmqqaN3Cptn/L0IIb8kkOMEzBZVzXOJaGYzubXHWzw=; b=bDwl1W60RUfxSBU1CsOOzrdayBpOEeVukAihfKDvYdaEbs9bwfNzoF+yG3bLOv+d5b 4qLz31JZlxUFScwGi7Y12FISatc3Iy+Z8ZLzbM0ee2Kfd7WCsE8ki0ORp/2Mx3E36eBn OaRL5dwf6rTj7R80QjAmyUYE+qQFas43N+YXq5js1qZ3lzyjCVPt3CwDT9rQDudPRwxP VeKiVsjl7h8AKMnh+61Q7Qi0Ys/THfBCG0/0qZMO0yITgOIEa2BKE0/VdaOgKdbTmA72 xP3hs6N4DR4ZdSQD4Z5y1vo04uforaPHmc09dL9VZot3bPBtqYN84unQLR1Px/UWgZgA /Dmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=HEmqqaN3Cptn/L0IIb8kkOMEzBZVzXOJaGYzubXHWzw=; b=i3bBMFJ/IMaP4yrMGsUu4CTPU9mC8B20db5b3ry/UX2pcG5Ci2N6ZgxQiEeooho8D6 2g5bl8I267Ubm6W7HigDSd2fyT6ivakaX+rdUILVIyvTVYUcWcag2Rwp6/PmsEKGdcZp DdjXmBaVkcskf6j6zCpOsVdRSRtpJLkuf3YYGeeS8AsnCNmO8ppG19y96+a/MmnNo6v5 rzaCepHhenkinOxPdcwp9mFRGudoHg9vbZQs8Wn1HQUTj0ii2VTU8Fcn/abRa0n237Jy Uxj63LaBCxsP3L2NMhNoTYHIiWpgGqZOGMnQLLgC+4AgujVexAQGMVUWGcJT7mM4EFzG 0Eow== X-Gm-Message-State: AOAM530aBNaGrahIHj5lq2r6ACXqiUuYwxUf6i6a6Zb7b17VRdtPkTDP 4f90fLSW2rGhk+nDEBvCywuxuQ== X-Google-Smtp-Source: ABdhPJyh37vQVUgd85vM81zAQaFrcRnGbXt1MJT0w5ezPWRgNGrnuOzi78A4o5HB6maWF9QDX6DFGA== X-Received: by 2002:a1c:65d6:: with SMTP id z205mr7294055wmb.2.1597222073634; Wed, 12 Aug 2020 01:47:53 -0700 (PDT) Received: from dell ([2.27.167.73]) by smtp.gmail.com with ESMTPSA id c17sm3099796wrc.42.2020.08.12.01.47.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 01:47:53 -0700 (PDT) Date: Wed, 12 Aug 2020 09:47:51 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] pwm: atmel: Make use of dev_err_probe() Message-ID: <20200812084751.GE4354@dell> References: <20200812080259.4431-1-u.kleine-koenig@pengutronix.de> <20200812082002.GD4354@dell> <20200812083204.kktnid63j6vefsky@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200812083204.kktnid63j6vefsky@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_044754_868884_49615E5F X-CRM114-Status: GOOD ( 28.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Alexandre Belloni , Ludovic Desroches , Thierry Reding , kernel@pengutronix.de, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAxMiBBdWcgMjAyMCwgVXdlIEtsZWluZS1Lw7ZuaWcgd3JvdGU6Cgo+IE9uIFdlZCwg QXVnIDEyLCAyMDIwIGF0IDA5OjIwOjAyQU0gKzAxMDAsIExlZSBKb25lcyB3cm90ZToKPiA+IE9u IFdlZCwgMTIgQXVnIDIwMjAsIFV3ZSBLbGVpbmUtS8O2bmlnIHdyb3RlOgo+ID4gCj4gPiA+IEFk ZCBhbiBlcnJvciBtZXNzYWdlIGZvciBmYWlsdXJlIHBvaW50cyB0aGF0IGN1cnJlbnRseSBsYWNr IGEgbWVzc2FnZQo+ID4gPiBhbmQgY29udmVydCBkZXZfZXJyIHRvIGRldl9lcnJfcHJvYmUoKSB3 aGljaCBkb2VzIHRoZSByaWdodCB0aGluZyBmb3IKPiA+ID4gLUVQUk9CRV9ERUZFUi4gQWxzbyBz bGlnaHRseSBzaW1wbGlmeSB0aGUgZXJyb3IgaGFuZGxpbmcuCj4gPiA+IAo+ID4gPiBTaWduZWQt b2ZmLWJ5OiBVd2UgS2xlaW5lLUvDtm5pZyA8dS5rbGVpbmUta29lbmlnQHBlbmd1dHJvbml4LmRl Pgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvcHdtL3B3bS1hdG1lbC5jIHwgMjQgKysrKysrKysr KystLS0tLS0tLS0tLS0tCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwg MTMgZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9wd20vcHdt LWF0bWVsLmMgYi9kcml2ZXJzL3B3bS9wd20tYXRtZWwuYwo+ID4gPiBpbmRleCA2MTYxZTdlM2U5 YWMuLmFhMGIzNjY5NWRjNyAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy9wd20vcHdtLWF0bWVs LmMKPiA+ID4gKysrIGIvZHJpdmVycy9wd20vcHdtLWF0bWVsLmMKPiA+ID4gQEAgLTQxNSwxNyAr NDE1LDE4IEBAIHN0YXRpYyBpbnQgYXRtZWxfcHdtX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZp Y2UgKnBkZXYpCj4gPiA+ICAJcmVzID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNlKHBkZXYsIElPUkVT T1VSQ0VfTUVNLCAwKTsKPiA+ID4gIAlhdG1lbF9wd20tPmJhc2UgPSBkZXZtX2lvcmVtYXBfcmVz b3VyY2UoJnBkZXYtPmRldiwgcmVzKTsKPiA+ID4gIAlpZiAoSVNfRVJSKGF0bWVsX3B3bS0+YmFz ZSkpCj4gPiA+IC0JCXJldHVybiBQVFJfRVJSKGF0bWVsX3B3bS0+YmFzZSk7Cj4gPiA+ICsJCXJl dHVybiBkZXZfZXJyX3Byb2JlKCZwZGV2LT5kZXYsIFBUUl9FUlIoYXRtZWxfcHdtLT5iYXNlKSwK PiA+ID4gKwkJCQkgICAgICJGYWlsZWQgdG8gcmVtYXAgcmVnaXN0ZXIgc3BhY2VcbiIpOwo+ID4g Cj4gPiBUaGlzIGlzIGEgcmVncmVzc2lvbi4KPiA+IAo+ID4gZGV2bV9pb3JlbWFwX3Jlc291cmNl KCkgYWxyZWFkeSBlbWl0cyBhbmQgZXJyb3IgbWVzc2FnZSBmb3IgIS1FTk9NRU0uCj4gPiAKPiA+ IC1FTk9NRU0gY2FzZXMgc2hvdWxkIGZhaWwgc2lsZW50bHkuCj4gCj4gYWggcmlnaHQuIE1heWJl IGRldl9lcnJfcHJvYmUoKSBzaG91bGQgZG8gdGhpcyByaWdodCwgdG9vPwoKTWF5YmUsIGJ1dCB5 b3UncmUgc3RpbGwgYWRkaW5nIGFuIHVubmVjZXNzYXJ5IHN0cmluZyB0byB0aGUga2VybmVsJ3MK YmluYXJ5LiAgVGhlcmUgd2FzIGEgYml0IHB1c2ggYSBsaXR0bGUgd2hpbGUgYmFjayB0byBjdXQg ZG93biBvbgp0aGVzZS4KCj4gPiA+ICAJYXRtZWxfcHdtLT5jbGsgPSBkZXZtX2Nsa19nZXQoJnBk ZXYtPmRldiwgTlVMTCk7Cj4gPiA+ICAJaWYgKElTX0VSUihhdG1lbF9wd20tPmNsaykpCj4gPiA+ IC0JCXJldHVybiBQVFJfRVJSKGF0bWVsX3B3bS0+Y2xrKTsKPiA+ID4gKwkJcmV0dXJuIGRldl9l cnJfcHJvYmUoJnBkZXYtPmRldiwgUFRSX0VSUihhdG1lbF9wd20tPmNsayksCj4gPiA+ICsJCQkJ ICAgICAiRmFpbGVkIHRvIGdldCBjbG9ja1xuIik7Cj4gPiAKPiA+IElzbid0IGRldl9lcnJfcHJv YmUoKSBvbmx5IHVzZWZ1bCBmb3IgZHJpdmVycyBoYW5kbGluZyAtRVBST0JFX0RFRkVSPwo+IAo+ IGRldm1fY2xrX2dldCgpIG1pZ2h0IHJldHVybiAtRVBST0JFX0RFRkVSLgoKUGVyaGFwcywgYnV0 IHRoZSBhdXRob3IgaGFzIGNob3NlbiBub3QgdG8gaGFuZGxlIGl0IHNwZWNpZmljYWxseS4KCkl0 J3MgbXkgdW5kZXJzdGFuZGluZyB0aGF0IGRldl9lcnJfcHJvYmUoKSB3YXMgZGVzaWduZWQgdG8g c2ltcGxpZnkKZXJyb3IgaGFuZGxpbmcgaW4gLnByb2JlKCkgd2hlcmVhcyB0aGlzIHBhdGNoIHNl ZW1zIHRvIGRvIHRoZSBwb2xhcgpvcHBvc2l0ZS4KCj4gPiA+ICAJcmV0ID0gY2xrX3ByZXBhcmUo YXRtZWxfcHdtLT5jbGspOwo+ID4gPiAtCWlmIChyZXQpIHsKPiA+ID4gLQkJZGV2X2VycigmcGRl di0+ZGV2LCAiZmFpbGVkIHRvIHByZXBhcmUgUFdNIGNsb2NrXG4iKTsKPiA+ID4gLQkJcmV0dXJu IHJldDsKPiA+ID4gLQl9Cj4gPiA+ICsJaWYgKHJldCkKPiA+ID4gKwkJcmV0dXJuIGRldl9lcnJf cHJvYmUoJnBkZXYtPmRldiwgcmV0LAo+ID4gPiArCQkJCSAgICAgIkZhaWxlZCB0byBwcmVwYXJl IFBXTSBjbG9ja1xuIik7Cj4gPiAKPiA+IEFzIGFib3ZlLgo+IAo+IEkgb25seSBjaGVja2VkIHF1 aWNrbHkgYW5kIGRpZG4ndCBmaW5kIGFuIGluc3RhbmNlIHdoZXJlIGNsa19wcmVwYXJlIGNhbgo+ IHJldHVybiAtRVBST0JFX0RFRkVSLCBidXQgZXZlbiBpZiBpdCBkb2Vzbid0IGl0IHdvcmtzIGZp bmUuCgpJdCdzIHN0aWxsIG1pc2xlYWRpbmcgSU1ITy4gIGRldl9lcnJfcHJvYmUoKSdzIGhlYWRl ciBkZXRhaWxzIGl0cwpyZWFzb24gZm9yIGV4aXN0ZW5jZS4gIFRoaXMgc2VlbXMgdG8gYmUgYSBz cXVhcmUgcGVnIGluIGEgcm91bmQgaG9sZQpzY2VuYXJpby4KCi0tIApMZWUgSm9uZXMgW+adjueQ vOaWr10KU2VuaW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5v cmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBG YWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0t a2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==