All of lore.kernel.org
 help / color / mirror / Atom feed
From: balbi@kernel.org
To: Linux USB <linux-usb@vger.kernel.org>
Cc: Felipe Balbi <balbi@kernel.org>
Subject: [PATCH 01/11] dwc3: meson: fix coccinelle WARNING
Date: Thu, 13 Aug 2020 09:25:22 +0300	[thread overview]
Message-ID: <20200813062532.829720-1-balbi@kernel.org> (raw)

From: Felipe Balbi <balbi@kernel.org>

Coccinelle suggests using PTR_ERR_OR_ZERO().

Signed-off-by: Felipe Balbi <balbi@kernel.org>
---
 drivers/usb/dwc3/dwc3-meson-g12a.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/usb/dwc3/dwc3-meson-g12a.c b/drivers/usb/dwc3/dwc3-meson-g12a.c
index 88b75b5a039c..9c50a8f2929e 100644
--- a/drivers/usb/dwc3/dwc3-meson-g12a.c
+++ b/drivers/usb/dwc3/dwc3-meson-g12a.c
@@ -626,10 +626,7 @@ static int dwc3_meson_gxl_setup_regmaps(struct dwc3_meson_g12a *priv,
 	/* GXL controls the PHY mode in the PHY registers unlike G12A */
 	priv->usb_glue_regmap = devm_regmap_init_mmio(priv->dev, base,
 					&phy_meson_g12a_usb_glue_regmap_conf);
-	if (IS_ERR(priv->usb_glue_regmap))
-		return PTR_ERR(priv->usb_glue_regmap);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(priv->usb_glue_regmap);
 }
 
 static int dwc3_meson_g12a_setup_regmaps(struct dwc3_meson_g12a *priv,
-- 
2.28.0


             reply	other threads:[~2020-08-13  6:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-13  6:25 balbi [this message]
2020-08-13  6:25 ` [PATCH 02/11] dwc3: debug: fix sparse warning balbi
2020-08-13  6:25 ` [PATCH 03/11] dwc3: meson: fix checkpatch errors and warnings balbi
2020-08-13  6:25 ` [PATCH 04/11] dwc3: ulpi: fix checkpatch warning balbi
2020-08-13  6:25 ` [PATCH 05/11] dwc3: trace: fix checkpatch warnings balbi
2020-08-13  6:25 ` [PATCH 06/11] dwc3: debug: fix checkpatch warning balbi
2020-08-13  6:25 ` [PATCH 07/11] dwc3: core: fix checkpatch warnings balbi
2020-08-13  6:25 ` [PATCH 08/11] dwc3: gadget: " balbi
2020-08-13  6:25 ` [PATCH 09/11] dwc3: ep0: " balbi
2020-08-13  6:25 ` [PATCH 10/11] dwc3: qcom: " balbi
2020-08-13  6:25 ` [PATCH 11/11] dwc3: debugfs: " balbi
2020-08-13 19:14   ` Thinh Nguyen
2020-08-14  5:12     ` Felipe Balbi
2020-08-14  5:36       ` Thinh Nguyen
2020-08-14  6:16         ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200813062532.829720-1-balbi@kernel.org \
    --to=balbi@kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.