From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28359C433DF for ; Thu, 13 Aug 2020 09:24:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2DDA20781 for ; Thu, 13 Aug 2020 09:24:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="swKWN87N" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726574AbgHMJYH (ORCPT ); Thu, 13 Aug 2020 05:24:07 -0400 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:40099 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726106AbgHMJYH (ORCPT ); Thu, 13 Aug 2020 05:24:07 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 4A2855803D6; Thu, 13 Aug 2020 05:24:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 13 Aug 2020 05:24:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=W630GV 7ui2/hkTmbjxGwCT8hexFFpv2lFKcSnPeWDoY=; b=swKWN87NjnPLCS4FU5Ntjq 26N4klYVNc1qt8pzFtANrik6ByWjMqyg0lat5aNcZPvSP8CFj9Bb4f2XXgZ6Xjti 06BPRlaqo0WmyfIyInMxMo+f8/QFwaEEvETeVToA8zGhp7iS6VBhHGZK/T7D/Q4N s9HWt0F60eFHjpSKKtqwiX6HwaHmchRisHO6f7XmbbFKjhvb2w75i4ynuTV6SIQa SYEaueIjY1OAZc8HoaGzIK6E+//t/1u34GuFg8WFUP56stuuP+36tpPkmtXl64YD PCy882iOz0l+RnKrWaXQuP8S1QbocVQ+1yEBdH6wACUrLocu7Jk2WX0X94TUBjjQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrleeggdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcuufgt hhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrthhtvg hrnheptdffkeekfeduffevgeeujeffjefhtefgueeugfevtdeiheduueeukefhudehleet necukfhppeejledrudekvddrieefrdegvdenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Received: from localhost (bzq-79-182-63-42.red.bezeqint.net [79.182.63.42]) by mail.messagingengine.com (Postfix) with ESMTPA id 58DF830600A3; Thu, 13 Aug 2020 05:24:05 -0400 (EDT) Date: Thu, 13 Aug 2020 12:24:02 +0300 From: Ido Schimmel To: Adrian Pop Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, jiri@mellanox.com, vadimp@mellanox.com, andrew@lunn.ch, mlxsw@mellanox.com, idosch@mellanox.com, roopa@nvidia.com, paschmidt@nvidia.com Subject: Re: [PATCH ethtool v3] Add QSFP-DD support Message-ID: <20200813092402.GA3426088@shredder> References: <20200813071735.7970-1-popadrian1996@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200813071735.7970-1-popadrian1996@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Aug 13, 2020 at 10:17:35AM +0300, Adrian Pop wrote: > The Common Management Interface Specification (CMIS) for QSFP-DD shares > some similarities with other form factors such as QSFP or SFP, but due to > the fact that the module memory map is different, the current ethtool > version is not able to provide relevant information about an interface. > > This patch adds QSFP-DD support to ethtool. The changes are similar to > the ones already existing in qsfp.c, but customized to use the memory > addresses and logic as defined in the specifications document. > > Several functions from qsfp.c could be reused, so an additional parameter > was added to each and the functions were moved to sff-common.c. > > Changelog (diff from v2): > * Remove functions assuming the existance of page 0x10 and 0x11 > * Remove structs and constants related to the page 0x10 and 0x11 Adrian, you're missing diff from v1 and Signed-off-by tag. Please send v4 with these changes. And please CC Michal Kubecek on ethtool patches since he maintains the tool. Thanks > ---