From: Kent Gibson <warthog618@gmail.com>
To: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
bgolaszewski@baylibre.com, linus.walleij@linaro.org
Cc: Kent Gibson <warthog618@gmail.com>
Subject: [PATCH v4 03/20] gpio: uapi: define GPIO_MAX_NAME_SIZE for array sizes
Date: Fri, 14 Aug 2020 11:02:40 +0800 [thread overview]
Message-ID: <20200814030257.135463-4-warthog618@gmail.com> (raw)
In-Reply-To: <20200814030257.135463-1-warthog618@gmail.com>
Replace constant array sizes with a macro constant to clarify the source
of array sizes, provide a place to document any constraints on the size,
and to simplify array sizing in userspace if constructing structs
from their composite fields.
Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
include/uapi/linux/gpio.h | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/include/uapi/linux/gpio.h b/include/uapi/linux/gpio.h
index 9c27cecf406f..285cc10355b2 100644
--- a/include/uapi/linux/gpio.h
+++ b/include/uapi/linux/gpio.h
@@ -14,6 +14,11 @@
#include <linux/ioctl.h>
#include <linux/types.h>
+/*
+ * The maximum size of name and label arrays.
+ */
+#define GPIO_MAX_NAME_SIZE 32
+
/**
* struct gpiochip_info - Information about a certain GPIO chip
* @name: the Linux kernel name of this GPIO chip
@@ -22,8 +27,8 @@
* @lines: number of GPIO lines on this chip
*/
struct gpiochip_info {
- char name[32];
- char label[32];
+ char name[GPIO_MAX_NAME_SIZE];
+ char label[GPIO_MAX_NAME_SIZE];
__u32 lines;
};
@@ -52,8 +57,8 @@ struct gpiochip_info {
struct gpioline_info {
__u32 line_offset;
__u32 flags;
- char name[32];
- char consumer[32];
+ char name[GPIO_MAX_NAME_SIZE];
+ char consumer[GPIO_MAX_NAME_SIZE];
};
/* Maximum number of requested handles */
@@ -123,7 +128,7 @@ struct gpiohandle_request {
__u32 lineoffsets[GPIOHANDLES_MAX];
__u32 flags;
__u8 default_values[GPIOHANDLES_MAX];
- char consumer_label[32];
+ char consumer_label[GPIO_MAX_NAME_SIZE];
__u32 lines;
int fd;
};
@@ -182,7 +187,7 @@ struct gpioevent_request {
__u32 lineoffset;
__u32 handleflags;
__u32 eventflags;
- char consumer_label[32];
+ char consumer_label[GPIO_MAX_NAME_SIZE];
int fd;
};
--
2.28.0
next prev parent reply other threads:[~2020-08-14 3:03 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 3:02 [PATCH v4 00/20] gpio: cdev: add uAPI v2 Kent Gibson
2020-08-14 3:02 ` [PATCH v4 01/20] gpiolib: cdev: desc_to_lineinfo should set info offset Kent Gibson
2020-08-14 3:02 ` [PATCH v4 02/20] gpiolib: cdev: replace strncpy with strscpy Kent Gibson
2020-08-14 3:02 ` Kent Gibson [this message]
2020-08-14 3:02 ` [PATCH v4 04/20] gpio: uapi: define uAPI v2 Kent Gibson
2020-08-14 3:02 ` [PATCH v4 05/20] gpiolib: make cdev a build option Kent Gibson
2020-08-14 3:02 ` [PATCH v4 06/20] gpiolib: add build option for CDEV v1 ABI Kent Gibson
2020-08-14 3:02 ` [PATCH v4 07/20] gpiolib: cdev: support GPIO_V2_GET_LINE_IOCTL and GPIO_V2_LINE_GET_VALUES_IOCTL Kent Gibson
2020-08-14 19:31 ` Bartosz Golaszewski
2020-08-15 6:53 ` Kent Gibson
2020-08-15 7:21 ` Bartosz Golaszewski
2020-08-15 13:21 ` Kent Gibson
2020-08-16 12:13 ` Bartosz Golaszewski
2020-08-14 3:02 ` [PATCH v4 08/20] gpiolib: cdev: support GPIO_V2_GET_LINEINFO_IOCTL and GPIO_V2_GET_LINEINFO_WATCH_IOCTL Kent Gibson
2020-08-16 12:03 ` Bartosz Golaszewski
2020-08-14 3:02 ` [PATCH v4 09/20] gpiolib: cdev: support edge detection for uAPI v2 Kent Gibson
2020-08-16 14:32 ` Bartosz Golaszewski
2020-08-18 14:00 ` Kent Gibson
2020-08-14 3:02 ` [PATCH v4 10/20] gpiolib: cdev: support GPIO_V2_LINE_SET_CONFIG_IOCTL Kent Gibson
2020-08-16 14:40 ` Bartosz Golaszewski
2020-08-14 3:02 ` [PATCH v4 11/20] gpiolib: cdev: support GPIO_V2_LINE_SET_VALUES_IOCTL Kent Gibson
2020-08-16 14:57 ` Bartosz Golaszewski
2020-08-14 3:02 ` [PATCH v4 12/20] gpiolib: cdev: support setting debounce Kent Gibson
2020-08-17 18:21 ` Bartosz Golaszewski
2020-08-18 14:37 ` Kent Gibson
2020-08-14 3:02 ` [PATCH v4 13/20] gpio: uapi: document uAPI v1 as deprecated Kent Gibson
2020-08-14 3:02 ` [PATCH v4 14/20] tools: gpio: port lsgpio to v2 uAPI Kent Gibson
2020-08-14 3:02 ` [PATCH v4 15/20] tools: gpio: port gpio-watch " Kent Gibson
2020-08-14 3:02 ` [PATCH v4 16/20] tools: gpio: rename nlines to num_lines Kent Gibson
2020-08-14 3:02 ` [PATCH v4 17/20] tools: gpio: port gpio-hammer to v2 uAPI Kent Gibson
2020-08-14 3:02 ` [PATCH v4 18/20] tools: gpio: port gpio-event-mon " Kent Gibson
2020-08-14 3:02 ` [PATCH v4 19/20] tools: gpio: add multi-line monitoring to gpio-event-mon Kent Gibson
2020-08-14 3:02 ` [PATCH v4 20/20] tools: gpio: add debounce support " Kent Gibson
2020-08-17 18:24 ` [PATCH v4 00/20] gpio: cdev: add uAPI v2 Bartosz Golaszewski
2020-08-17 18:40 ` Andy Shevchenko
2020-08-17 19:25 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814030257.135463-4-warthog618@gmail.com \
--to=warthog618@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.