From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, sagi@grimberg.me
Subject: Re: [PATCHv2] nvme: skip noiob for zoned devices
Date: Fri, 14 Aug 2020 08:28:44 +0200 [thread overview]
Message-ID: <20200814062844.GA1656@lst.de> (raw)
In-Reply-To: <20200810145622.GA4159317@dhcp-10-100-145-180.wdl.wdc.com>
On Mon, Aug 10, 2020 at 07:56:22AM -0700, Keith Busch wrote:
> On Mon, Aug 10, 2020 at 02:33:13PM +0200, Christoph Hellwig wrote:
> > On Fri, Aug 07, 2020 at 09:32:35AM -0700, Keith Busch wrote:
> > > Zoned block devices reuse the chunk_sectors queue limit to define zone
> > > boundaries. If a such a device happens to also report an optimal
> > > boundary, do not use that to define the chunk_sectors as that may
> > > intermittently interfere with io splitting and zone size queries.
> >
> > Instead of skipping shouldn't we use the max of noiob and the zone
> > size, even if that is mostly theoretical?
>
> No, I don't think so. If noiob is larger, we'll return the wrong value
> for blk_queue_zone_sectors() and blkdev_nr_zones(), which will have
> undesirable consequences.
Then we at least need to warn about a larger noiob. And add a
comment that we are ignoring it deliberately.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-08-14 6:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 16:32 [PATCHv2] nvme: skip noiob for zoned devices Keith Busch
2020-08-07 16:33 ` Sagi Grimberg
2020-08-10 12:33 ` Christoph Hellwig
2020-08-10 14:56 ` Keith Busch
2020-08-14 6:28 ` Christoph Hellwig [this message]
2020-08-14 6:34 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814062844.GA1656@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.