From: Christoph Hellwig <hch@lst.de>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: kbusch@kernel.org, linux-nvme@lists.infradead.org, hch@lst.de,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: Re: [PATVH V5] nvme-core: use xarray for ctrl ns tracking
Date: Fri, 14 Aug 2020 08:57:11 +0200 [thread overview]
Message-ID: <20200814065711.GA2070@lst.de> (raw)
In-Reply-To: <4654370f-40b9-1b35-1e22-864e762c3001@grimberg.me>
On Thu, Aug 13, 2020 at 11:33:41PM -0700, Sagi Grimberg wrote:
>
>> This patch replaces the ctrl->namespaces tracking from linked list to
>> xarray for better ns-mgmt on the host side. For host side
>> nvme_find_get_ns() falls into the fast path for NVMeOF passthru target.
>> This allows us to have better performance for NVMeOF passthru backend
>> since XArray has shows better performance numbers over having
>> a combination of read-write semapore read + linked list in the
>> nvme_find_get_ns() to find namespace in I/O patch from nsid specified
>> in the nvme_rw_cmd.
>
> This patch scares me to be honest...
>
> We have such non-trivial synchronization paths for ns scanning, ns
> removal, quiescing, freezing, path handling... I'm not even sure
> how many tests we'll need to verify that nothing breaks here.
Yes, same concern here. That being said I have plans for this or
next merge window to fix a lot of crap in the block layer about
the bdev mutex to update the size, which should lead to major
simpliciations of the nvme ns scanning/removal path. But I'd much
rather sort that our first rather than touching this code now.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-08-14 6:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 2:16 [PATVH V5] nvme-core: use xarray for ctrl ns tracking Chaitanya Kulkarni
2020-08-14 6:33 ` Sagi Grimberg
2020-08-14 6:57 ` Christoph Hellwig [this message]
2020-08-15 2:59 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814065711.GA2070@lst.de \
--to=hch@lst.de \
--cc=chaitanya.kulkarni@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.