From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8395C433DF for ; Fri, 14 Aug 2020 12:47:57 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8BA622087D for ; Fri, 14 Aug 2020 12:47:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="fhBl0a5b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8BA622087D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k6Z7Q-0001sq-Ge; Fri, 14 Aug 2020 12:47:36 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1k6Z7O-0001sl-PW for xen-devel@lists.xenproject.org; Fri, 14 Aug 2020 12:47:34 +0000 X-Inumbo-ID: a9f3130d-3345-4534-94d5-ddf7010ce06a Received: from esa6.hc3370-68.iphmx.com (unknown [216.71.155.175]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id a9f3130d-3345-4534-94d5-ddf7010ce06a; Fri, 14 Aug 2020 12:47:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597409253; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=vqjMOLWnURMtkyVmLKBVLJihqVbQncODXADZyEOQvAk=; b=fhBl0a5b2BJDy19cenDqciV0nrmiNovKp0+SXluCB1p/501b0X2feqqo 6xSuS1KrCeVsQ21GIba176wNEHlcSTG58NK5do7SoVaIxhZCozRp5Yemf ETmM+irpwGKGVCPRs12EwUqtuSCc5enRRl+jOmzCAyuc5vkW4x8TQ5Aff A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: w0A6Vy4ueaWrF7WgfuyBrSR1ACS+hknjc95m+9zhN7fc2SAsmovKRsi3m41T/jo7eaFuu78C7Z S5MTDLXuflc0oQ1pEQ7/9xHjpo5CwxYh3w/78O9M19ZBSjqnsDO5hTI/QpYfLCVTsqY3rO+TdA lbC/WWyTBQbMerqZS+yaBvI3Y+TDQgr/7/ffkMR3MsIWS/vtCi8ou01AxoCZ+/N/T1DSOpRv+J GZhylUerYrKxWKmzDSfQJlY510XRbTKxifOc5UaGesqqi1ipL3B/WtYRbgtGC/JNVtACLQ8jDM CR0= X-SBRS: 2.7 X-MesageID: 24855572 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.76,312,1592884800"; d="scan'208";a="24855572" Date: Fri, 14 Aug 2020 14:47:25 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= CC: Christoph Hellwig , , Oleksandr Andrushchenko , David Airlie , Daniel Vetter , Boris Ostrovsky , Stefano Stabellini , Dan Carpenter , Wei Liu , "Yan Yankovskyi" , , , , David Hildenbrand , Michal Hocko , Dan Williams Subject: Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory Message-ID: <20200814124724.GK975@Air-de-Roger> References: <20200811094447.31208-1-roger.pau@citrix.com> <20200811094447.31208-3-roger.pau@citrix.com> <20200813073337.GA16160@infradead.org> <20200813075420.GC975@Air-de-Roger> <20200814072920.GA6126@infradead.org> <20200814095629.GJ975@Air-de-Roger> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On Fri, Aug 14, 2020 at 12:27:32PM +0200, Jürgen Groß wrote: > On 14.08.20 11:56, Roger Pau Monné wrote: > > On Fri, Aug 14, 2020 at 08:29:20AM +0100, Christoph Hellwig wrote: > > > On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monn?? wrote: > > > > On Thu, Aug 13, 2020 at 08:33:37AM +0100, Christoph Hellwig wrote: > > > > > On Tue, Aug 11, 2020 at 11:44:47AM +0200, Roger Pau Monne wrote: > > > > > > If enabled (because ZONE_DEVICE is supported) the usage of the new > > > > > > functionality untangles Xen balloon and RAM hotplug from the usage of > > > > > > unpopulated physical memory ranges to map foreign pages, which is the > > > > > > correct thing to do in order to avoid mappings of foreign pages depend > > > > > > on memory hotplug. > > > > > > > > > > So please just select ZONE_DEVICE if this is so much better rather > > > > > than maintaining two variants. > > > > > > > > We still need to other variant for Arm at least, so both need to be > > > > maintained anyway, even if we force ZONE_DEVICE on x86. > > > > > > Well, it still really helps reproducability if you stick to one > > > implementation of x86. > > > > > > The alternative would be an explicit config option to opt into it, > > > but just getting a different implementation based on a random > > > kernel option is strange. > > > > Would adding something like the chunk below to the patch be OK? > > > > ---8<--- > > diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig > > index 018020b91baa..5f321a1319e6 100644 > > --- a/drivers/xen/Kconfig > > +++ b/drivers/xen/Kconfig > > @@ -328,7 +328,14 @@ config XEN_FRONT_PGDIR_SHBUF > > tristate > > config XEN_UNPOPULATED_ALLOC > > - bool > > - default y if ZONE_DEVICE && !ARM && !ARM64 > > + bool "Use unpopulated memory ranges for guest mappings" > > + depends on X86 > > + select ZONE_DEVICE > > + default y > > I'd rather use "default XEN_BACKEND" here, as mappings of other guest's > memory is rarely used for non-backend guests. There's also the privcmd and gnt devices which make heavy use of this, so I'm not sure only selecting by default on XEN_BACKEND is the best option. Thanks, Roger. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA2F9C433E1 for ; Mon, 17 Aug 2020 07:07:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BA162072D for ; Mon, 17 Aug 2020 07:07:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="PJtz4UOp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7BA162072D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D59A6E4B6; Mon, 17 Aug 2020 07:06:52 +0000 (UTC) Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by gabe.freedesktop.org (Postfix) with ESMTPS id 367896E090 for ; Fri, 14 Aug 2020 12:47:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1597409254; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=vqjMOLWnURMtkyVmLKBVLJihqVbQncODXADZyEOQvAk=; b=PJtz4UOpB6clDELaDb6ZI6pYZdOgQbLMZWb/nkw1XwxImClpjYmCfjXE 6R7meuerV1AUV+yh5JrImShIDtGXjalFHi+m4cRsl0aAXPNj/Dmt02nMF J4uayLnDgKXIq0jTr69nHXixg/2CMpAv7pB4XRKDFg/olz7S0TC4Wuuda Y=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: w0A6Vy4ueaWrF7WgfuyBrSR1ACS+hknjc95m+9zhN7fc2SAsmovKRsi3m41T/jo7eaFuu78C7Z S5MTDLXuflc0oQ1pEQ7/9xHjpo5CwxYh3w/78O9M19ZBSjqnsDO5hTI/QpYfLCVTsqY3rO+TdA lbC/WWyTBQbMerqZS+yaBvI3Y+TDQgr/7/ffkMR3MsIWS/vtCi8ou01AxoCZ+/N/T1DSOpRv+J GZhylUerYrKxWKmzDSfQJlY510XRbTKxifOc5UaGesqqi1ipL3B/WtYRbgtGC/JNVtACLQ8jDM CR0= X-SBRS: 2.7 X-MesageID: 24855572 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.76,312,1592884800"; d="scan'208";a="24855572" Date: Fri, 14 Aug 2020 14:47:25 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: =?utf-8?B?SsO8cmdlbiBHcm/Dnw==?= Subject: Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory Message-ID: <20200814124724.GK975@Air-de-Roger> References: <20200811094447.31208-1-roger.pau@citrix.com> <20200811094447.31208-3-roger.pau@citrix.com> <20200813073337.GA16160@infradead.org> <20200813075420.GC975@Air-de-Roger> <20200814072920.GA6126@infradead.org> <20200814095629.GJ975@Air-de-Roger> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) X-Mailman-Approved-At: Mon, 17 Aug 2020 07:06:11 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Stefano Stabellini , Wei Liu , Oleksandr Andrushchenko , David Airlie , Yan Yankovskyi , David Hildenbrand , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Michal Hocko , Christoph Hellwig , linux-mm@kvack.org, xen-devel@lists.xenproject.org, Boris Ostrovsky , Dan Williams , Dan Carpenter Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBBdWcgMTQsIDIwMjAgYXQgMTI6Mjc6MzJQTSArMDIwMCwgSsO8cmdlbiBHcm/DnyB3 cm90ZToKPiBPbiAxNC4wOC4yMCAxMTo1NiwgUm9nZXIgUGF1IE1vbm7DqSB3cm90ZToKPiA+IE9u IEZyaSwgQXVnIDE0LCAyMDIwIGF0IDA4OjI5OjIwQU0gKzAxMDAsIENocmlzdG9waCBIZWxsd2ln IHdyb3RlOgo+ID4gPiBPbiBUaHUsIEF1ZyAxMywgMjAyMCBhdCAwOTo1NDoyMEFNICswMjAwLCBS b2dlciBQYXUgTW9ubj8/IHdyb3RlOgo+ID4gPiA+IE9uIFRodSwgQXVnIDEzLCAyMDIwIGF0IDA4 OjMzOjM3QU0gKzAxMDAsIENocmlzdG9waCBIZWxsd2lnIHdyb3RlOgo+ID4gPiA+ID4gT24gVHVl LCBBdWcgMTEsIDIwMjAgYXQgMTE6NDQ6NDdBTSArMDIwMCwgUm9nZXIgUGF1IE1vbm5lIHdyb3Rl Ogo+ID4gPiA+ID4gPiBJZiBlbmFibGVkIChiZWNhdXNlIFpPTkVfREVWSUNFIGlzIHN1cHBvcnRl ZCkgdGhlIHVzYWdlIG9mIHRoZSBuZXcKPiA+ID4gPiA+ID4gZnVuY3Rpb25hbGl0eSB1bnRhbmds ZXMgWGVuIGJhbGxvb24gYW5kIFJBTSBob3RwbHVnIGZyb20gdGhlIHVzYWdlIG9mCj4gPiA+ID4g PiA+IHVucG9wdWxhdGVkIHBoeXNpY2FsIG1lbW9yeSByYW5nZXMgdG8gbWFwIGZvcmVpZ24gcGFn ZXMsIHdoaWNoIGlzIHRoZQo+ID4gPiA+ID4gPiBjb3JyZWN0IHRoaW5nIHRvIGRvIGluIG9yZGVy IHRvIGF2b2lkIG1hcHBpbmdzIG9mIGZvcmVpZ24gcGFnZXMgZGVwZW5kCj4gPiA+ID4gPiA+IG9u IG1lbW9yeSBob3RwbHVnLgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBTbyBwbGVhc2UganVzdCBzZWxl Y3QgWk9ORV9ERVZJQ0UgaWYgdGhpcyBpcyBzbyBtdWNoIGJldHRlciByYXRoZXIKPiA+ID4gPiA+ IHRoYW4gbWFpbnRhaW5pbmcgdHdvIHZhcmlhbnRzLgo+ID4gPiA+IAo+ID4gPiA+IFdlIHN0aWxs IG5lZWQgdG8gb3RoZXIgdmFyaWFudCBmb3IgQXJtIGF0IGxlYXN0LCBzbyBib3RoIG5lZWQgdG8g YmUKPiA+ID4gPiBtYWludGFpbmVkIGFueXdheSwgZXZlbiBpZiB3ZSBmb3JjZSBaT05FX0RFVklD RSBvbiB4ODYuCj4gPiA+IAo+ID4gPiBXZWxsLCBpdCBzdGlsbCByZWFsbHkgaGVscHMgcmVwcm9k dWNhYmlsaXR5IGlmIHlvdSBzdGljayB0byBvbmUKPiA+ID4gaW1wbGVtZW50YXRpb24gb2YgeDg2 Lgo+ID4gPiAKPiA+ID4gVGhlIGFsdGVybmF0aXZlIHdvdWxkIGJlIGFuIGV4cGxpY2l0IGNvbmZp ZyBvcHRpb24gdG8gb3B0IGludG8gaXQsCj4gPiA+IGJ1dCBqdXN0IGdldHRpbmcgYSBkaWZmZXJl bnQgaW1wbGVtZW50YXRpb24gYmFzZWQgb24gYSByYW5kb20KPiA+ID4ga2VybmVsIG9wdGlvbiBp cyBzdHJhbmdlLgo+ID4gCj4gPiBXb3VsZCBhZGRpbmcgc29tZXRoaW5nIGxpa2UgdGhlIGNodW5r IGJlbG93IHRvIHRoZSBwYXRjaCBiZSBPSz8KPiA+IAo+ID4gLS0tODwtLS0KPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL3hlbi9LY29uZmlnIGIvZHJpdmVycy94ZW4vS2NvbmZpZwo+ID4gaW5kZXgg MDE4MDIwYjkxYmFhLi41ZjMyMWExMzE5ZTYgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL3hlbi9L Y29uZmlnCj4gPiArKysgYi9kcml2ZXJzL3hlbi9LY29uZmlnCj4gPiBAQCAtMzI4LDcgKzMyOCwx NCBAQCBjb25maWcgWEVOX0ZST05UX1BHRElSX1NIQlVGCj4gPiAgIAl0cmlzdGF0ZQo+ID4gICBj b25maWcgWEVOX1VOUE9QVUxBVEVEX0FMTE9DCj4gPiAtCWJvb2wKPiA+IC0JZGVmYXVsdCB5IGlm IFpPTkVfREVWSUNFICYmICFBUk0gJiYgIUFSTTY0Cj4gPiArCWJvb2wgIlVzZSB1bnBvcHVsYXRl ZCBtZW1vcnkgcmFuZ2VzIGZvciBndWVzdCBtYXBwaW5ncyIKPiA+ICsJZGVwZW5kcyBvbiBYODYK PiA+ICsJc2VsZWN0IFpPTkVfREVWSUNFCj4gPiArCWRlZmF1bHQgeQo+IAo+IEknZCByYXRoZXIg dXNlICJkZWZhdWx0IFhFTl9CQUNLRU5EIiBoZXJlLCBhcyBtYXBwaW5ncyBvZiBvdGhlciBndWVz dCdzCj4gbWVtb3J5IGlzIHJhcmVseSB1c2VkIGZvciBub24tYmFja2VuZCBndWVzdHMuCgpUaGVy ZSdzIGFsc28gdGhlIHByaXZjbWQgYW5kIGdudCBkZXZpY2VzIHdoaWNoIG1ha2UgaGVhdnkgdXNl IG9mIHRoaXMsCnNvIEknbSBub3Qgc3VyZSBvbmx5IHNlbGVjdGluZyBieSBkZWZhdWx0IG9uIFhF Tl9CQUNLRU5EIGlzIHRoZSBiZXN0Cm9wdGlvbi4KClRoYW5rcywgUm9nZXIuCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=