All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ansuel Smith <ansuelsmth@gmail.com>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: Ansuel Smith <ansuelsmth@gmail.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC PATCH v6 1/8] drivers: thermal: tsens: use get_temp for tsens_valid
Date: Fri, 14 Aug 2020 15:41:15 +0200	[thread overview]
Message-ID: <20200814134123.14566-2-ansuelsmth@gmail.com> (raw)
In-Reply-To: <20200814134123.14566-1-ansuelsmth@gmail.com>

Use the driver get_temp function instead of force to use the generic get
temp function. This is needed as tsens v0 version use a custom function
to get the real temperature.

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
---
 drivers/thermal/qcom/tsens.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
index 9af6f71ab640..9fe9a2b26705 100644
--- a/drivers/thermal/qcom/tsens.c
+++ b/drivers/thermal/qcom/tsens.c
@@ -580,7 +580,6 @@ int get_temp_tsens_valid(const struct tsens_sensor *s, int *temp)
 {
 	struct tsens_priv *priv = s->priv;
 	int hw_id = s->hw_id;
-	u32 temp_idx = LAST_TEMP_0 + hw_id;
 	u32 valid_idx = VALID_0 + hw_id;
 	u32 valid;
 	int ret;
@@ -600,9 +599,9 @@ int get_temp_tsens_valid(const struct tsens_sensor *s, int *temp)
 	}
 
 	/* Valid bit is set, OK to read the temperature */
-	*temp = tsens_hw_to_mC(s, temp_idx);
+	ret = priv->ops->get_temp(s, temp);
 
-	return 0;
+	return ret;
 }
 
 int get_temp_common(const struct tsens_sensor *s, int *temp)
-- 
2.27.0


  reply	other threads:[~2020-08-14 13:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-14 13:41 [RFC PATCH v6 0/8] Add support for ipq8064 tsens Ansuel Smith
2020-08-14 13:41 ` Ansuel Smith [this message]
2020-11-22 19:35   ` [RFC PATCH v6 1/8] drivers: thermal: tsens: use get_temp for tsens_valid Amit Kucheria
2020-08-14 13:41 ` [RFC PATCH v6 2/8] drivers: thermal: tsens: Add VER_0 tsens version Ansuel Smith
2020-11-22 20:05   ` Amit Kucheria
2020-11-25 12:22     ` Ansuel Smith
2020-11-29 12:58       ` Amit Kucheria
2020-11-29 16:28         ` Ansuel Smith
2020-08-14 13:41 ` [RFC PATCH v6 3/8] drivers: thermal: tsens: Convert msm8960 to reg_field Ansuel Smith
2020-08-14 13:41 ` [RFC PATCH v6 4/8] drivers: thermal: tsens: Use init_common for msm8960 Ansuel Smith
2020-08-14 13:41 ` [RFC PATCH v6 5/8] drivers: thermal: tsens: Fix wrong get_temp " Ansuel Smith
2020-08-14 13:41 ` [RFC PATCH v6 6/8] drivers: thermal: tsens: Change calib_backup name " Ansuel Smith
2020-08-14 13:41 ` [RFC PATCH v6 7/8] drivers: thermal: tsens: Add support for ipq8064-tsens Ansuel Smith
2020-08-14 13:41 ` [RFC PATCH v6 8/8] dt-bindings: thermal: tsens: Document ipq8064 bindings Ansuel Smith
2020-09-28 11:32 ` [RFC PATCH v6 0/8] Add support for ipq8064 tsens Amit Kucheria
2020-09-28 11:35   ` ansuelsmth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200814134123.14566-2-ansuelsmth@gmail.com \
    --to=ansuelsmth@gmail.com \
    --cc=agross@kernel.org \
    --cc=amit.kucheria@linaro.org \
    --cc=amitk@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.