From: Kalle Valo <kvalo@codeaurora.org>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Maya Erez <merez@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Subject: Re: [PATCH][next] wil6210: Avoid the use of one-element array
Date: Fri, 14 Aug 2020 14:47:41 +0000 (UTC) [thread overview]
Message-ID: <20200814144741.DB6D4C43391@smtp.codeaurora.org> (raw)
In-Reply-To: <20200715215755.GA21716@embeddedor>
"Gustavo A. R. Silva" <gustavoars@kernel.org> wrote:
> One-element arrays are being deprecated[1]. Replace the one-element
> array with a simple value type 'u8 reserved'[2], once this is just
> a placeholder for alignment.
>
> [1] https://github.com/KSPP/linux/issues/79
> [2] https://github.com/KSPP/linux/issues/86
>
> Tested-by: kernel test robot <lkp@intel.com>
> Link: https://github.com/GustavoARSilva/linux-hardening/blob/master/cii/0-day/wil6210-20200715.md
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
I agree with Johannes, I don't see the point of this patch as there are
no clear benefits.
Patch set to Rejected.
--
https://patchwork.kernel.org/patch/11666325/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2020-08-14 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 21:57 [PATCH][next] wil6210: Avoid the use of one-element array Gustavo A. R. Silva
2020-07-22 18:27 ` Gustavo A. R. Silva
2020-07-23 6:43 ` Kalle Valo
2020-07-24 18:29 ` Gustavo A. R. Silva
2020-07-22 19:40 ` Johannes Berg
2020-07-22 20:00 ` Gustavo A. R. Silva
2020-08-14 14:47 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814144741.DB6D4C43391@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=davem@davemloft.net \
--cc=gustavoars@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=wil6210@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.