Re: [master/dunfell][PATCH] linux: copy-defconfig: Move do_create_srcipk only if defined

From: Denys Dmytriyenko <denys@ti.com>
To: Paul Barker <pbarker@konsulko.com>
Cc: meta-arago@arago-project.org
Subject: Re: [master/dunfell][PATCH] linux: copy-defconfig: Move do_create_srcipk only if defined
Date: Fri, 14 Aug 2020 18:30:55 -0400	[thread overview]
Message-ID: <20200814223055.GQ13081@beryl> (raw)
In-Reply-To: <20200630213041.GN7211@beryl>

Ping.

In case this was missed - the submitted patch was causing a breakage and was 
not merged. Thanks.

On Tue, Jun 30, 2020 at 05:30:41PM -0400, Denys Dmytriyenko wrote:
> That doesn't work:
> 
> ERROR: 351 unbuildable tasks were found.
> These are usually caused by circular dependencies and any circular dependency chains found will be printed below. Increase the debug level to see a list of unbuildable tasks.
> 
> Identifying dependency loops (this may take a short while)...
> 
> ERROR: 
> Dependency loop #1 found:
>   Task /OE/arago-dunfell/sources/meta-ti/recipes-kernel/linux/linux-ti-staging_5.4.bb:do_compile (dependent Tasks ['linux-ti-staging_5.4.bb:do_configure'])
>   Task /OE/arago-dunfell/sources/meta-ti/recipes-kernel/linux/linux-ti-staging_5.4.bb:do_create_srcipk (dependent Tasks ['external-arm-toolchain.bb:do_patch', 'bc_1.07.1.bb:do_patch', 'bison_3.5.3.bb:do_patch', 'kmod-native_git.bb:do_patch', 'lzop_1.04.bb:do_patch', 'linux-ti-staging_5.4.bb:do_compile'])
>   Task /OE/arago-dunfell/sources/meta-ti/recipes-kernel/linux/linux-ti-staging_5.4.bb:do_configure (dependent Tasks ['linux-ti-staging_5.4.bb:do_prepare_recipe_sysroot', 'linux-ti-staging_5.4.bb:do_patch', 'linux-ti-staging_5.4.bb:do_symlink_kernsrc', 'linux-ti-staging_5.4.bb:do_unpack', 'linux-ti-staging_5.4.bb:do_create_srcipk'])
> 
> 
> ERROR: Command execution failed: 1
> 
> 
> On Mon, Jun 29, 2020 at 06:43:51PM -0400, Denys Dmytriyenko wrote:
> > Thanks, will merge it shortly.
> > 
> > On Sun, Jun 21, 2020 at 09:43:49PM +0100, Paul Barker wrote:
> > > Signed-off-by: Paul Barker <pbarker@konsulko.com>
> > > ---
> > >  .../recipes-kernel/linux/copy-defconfig.inc              | 9 ++++++---
> > >  1 file changed, 6 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc b/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
> > > index 10ecf8ea..65b615cb 100644
> > > --- a/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
> > > +++ b/meta-arago-distro/recipes-kernel/linux/copy-defconfig.inc
> > > @@ -17,6 +17,9 @@ do_configure_append() {
> > >      fi
> > >  }
> > >  
> > > -# Move create_srcipk task so that the release defconfig is included.
> > > -deltask do_create_srcipk
> > > -addtask create_srcipk after do_configure before do_compile
> > > +python __anonymous() {
> > > +    # Move create_srcipk task so that the release defconfig is included.
> > > +    if d.getVarFlag('do_create_srcipk', "task"):
> > > +        bb.build.deltask('do_create_srcipk', d)
> > > +        bb.build.addtask('do_create_srcipk', 'do_configure', 'do_compile', d)
> > > +}
> > > -- 
> > > 2.27.0
> > > 
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago