From: Alexey Dobriyan <adobriyan@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Pascal Bouchareine <kalou@tfz.net>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] mm: add GFP mask param to strndup_user
Date: Sun, 16 Aug 2020 19:10:15 +0300 [thread overview]
Message-ID: <20200816161015.GA242961@localhost.localdomain> (raw)
In-Reply-To: <20200815224210.GA1236603@ZenIV.linux.org.uk>
On Sat, Aug 15, 2020 at 11:42:10PM +0100, Al Viro wrote:
> On Sat, Aug 15, 2020 at 11:23:43AM -0700, Pascal Bouchareine wrote:
> > Let caller specify allocation.
> > Preserve existing calls with GFP_USER.
>
> Bloody bad idea, unless you slap a BUG_ON(flags & GFP_ATOMIC) on it,
> to make sure nobody tries _that_. Note that copying from userland
> is an inherently blocking operation, and this interface invites
> just that.
>
> What do you need that flag for, anyway?
You need it for kmem accounting.
next prev parent reply other threads:[~2020-08-16 16:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-15 18:23 [RFC PATCH 0/2] proc,socket: attach description to sockets Pascal Bouchareine
2020-08-15 18:23 ` [PATCH 1/2] mm: add GFP mask param to strndup_user Pascal Bouchareine
2020-08-15 22:42 ` Al Viro
2020-08-16 16:10 ` Alexey Dobriyan [this message]
2020-08-15 18:23 ` [PATCH 2/2] net: socket: implement SO_DESCRIPTION Pascal Bouchareine
2020-08-16 5:02 ` kernel test robot
2020-08-16 5:02 ` kernel test robot
2020-08-16 7:33 ` kernel test robot
2020-08-16 7:33 ` kernel test robot
2020-08-16 7:33 ` [RFC PATCH] net: socket: sock_set_description() can be static kernel test robot
2020-08-16 7:33 ` kernel test robot
2020-08-16 9:00 ` [PATCH 2/2] net: socket: implement SO_DESCRIPTION kernel test robot
2020-08-16 9:00 ` kernel test robot
2020-08-16 18:15 ` Eric Dumazet
2020-08-16 19:30 ` Pascal Bouchareine
2020-08-22 3:28 ` [PATCH v2 1/2] mm: add GFP mask param to strndup_user Pascal Bouchareine
2020-08-22 3:28 ` [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION Pascal Bouchareine
2020-08-22 6:57 ` kernel test robot
2020-08-22 6:57 ` kernel test robot
2020-08-22 19:36 ` David Miller
2020-08-22 19:59 ` Pascal Bouchareine
2020-08-22 20:19 ` Pascal Bouchareine
2020-08-22 20:53 ` Pascal Bouchareine
2020-08-22 21:01 ` David Miller
2020-08-23 22:28 ` Pascal Bouchareine
2020-08-22 3:51 ` [PATCH v2 1/2] mm: add GFP mask param to strndup_user Andrew Morton
2020-08-22 19:36 ` Pascal Bouchareine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200816161015.GA242961@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=kalou@tfz.net \
--cc=kuba@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.