diff for duplicates of <20200816201601.GA1426650@ravnborg.org> diff --git a/a/1.txt b/N1/1.txt index b74de53..72ee5e3 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -26,7 +26,7 @@ This part matches the patch - good. > Hibernate, as the function does nothing in their case. What I think you are explaining above is that the pci pm support will only call the suspend operation in case of suspend, so the -state.event = PM_EVENT_SUSPEND can be dropped in gxfb_suspend(). +state.event == PM_EVENT_SUSPEND can be dropped in gxfb_suspend(). For reference later I would prefer that this is explained a bit more explicit - not that the changelog needs update anyway. @@ -91,7 +91,7 @@ from a similar clarification. > - struct fb_info *info = pci_get_drvdata(pdev); > + struct fb_info *info = dev_get_drvdata(dev); > -> - if (state.event = PM_EVENT_SUSPEND) { +> - if (state.event == PM_EVENT_SUSPEND) { > - console_lock(); > - gx_powerdown(info); > - fb_set_suspend(info, 1); @@ -173,3 +173,7 @@ from a similar clarification. > -#endif > -- > 2.27.0 +_______________________________________________ +Linux-kernel-mentees mailing list +Linux-kernel-mentees@lists.linuxfoundation.org +https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees diff --git a/a/content_digest b/N1/content_digest index fd46319..a3828ee 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,18 +2,17 @@ "ref\020200810185723.15540-1-vaibhavgupta40@gmail.com\0" "ref\020200810185723.15540-2-vaibhavgupta40@gmail.com\0" "From\0Sam Ravnborg <sam@ravnborg.org>\0" - "Subject\0Re: [PATCH v2 01/12] fbdev: gxfb: use generic power management\0" - "Date\0Sun, 16 Aug 2020 20:16:01 +0000\0" + "Subject\0Re: [Linux-kernel-mentees] [PATCH v2 01/12] fbdev: gxfb: use generic power management\0" + "Date\0Sun, 16 Aug 2020 22:16:01 +0200\0" "To\0Vaibhav Gupta <vaibhavgupta40@gmail.com>\0" "Cc\0linux-fbdev@vger.kernel.org" linux-kernel@vger.kernel.org + Antonino Daplas <adaplas@gmail.com> Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Vaibhav Gupta <vaibhav.varodek@gmail.com> - Shuah Khan <skhan@linuxfoundation.org> Russell King <linux@armlinux.org.uk> dri-devel@lists.freedesktop.org linux-geode@lists.infradead.org - Bjorn Helgaas <bjorn@helgaas.com> Bjorn Helgaas <helgaas@kernel.org> Andres Salomon <dilinger@queued.net> Bjorn Helgaas <bhelgaas@google.com> @@ -50,7 +49,7 @@ "> Hibernate, as the function does nothing in their case.\n" "What I think you are explaining above is that the pci pm support\n" "will only call the suspend operation in case of suspend, so the \n" - "state.event = PM_EVENT_SUSPEND can be dropped in gxfb_suspend().\n" + "state.event == PM_EVENT_SUSPEND can be dropped in gxfb_suspend().\n" "\n" "For reference later I would prefer that this is explained a bit\n" "more explicit - not that the changelog needs update anyway.\n" @@ -115,7 +114,7 @@ "> -\tstruct fb_info *info = pci_get_drvdata(pdev);\n" "> +\tstruct fb_info *info = dev_get_drvdata(dev);\n" "> \n" - "> -\tif (state.event = PM_EVENT_SUSPEND) {\n" + "> -\tif (state.event == PM_EVENT_SUSPEND) {\n" "> -\t\tconsole_lock();\n" "> -\t\tgx_powerdown(info);\n" "> -\t\tfb_set_suspend(info, 1);\n" @@ -196,6 +195,10 @@ "> -\n" "> -#endif\n" "> -- \n" - > 2.27.0 + "> 2.27.0\n" + "_______________________________________________\n" + "Linux-kernel-mentees mailing list\n" + "Linux-kernel-mentees@lists.linuxfoundation.org\n" + https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees -723822e314eb4e28aa030ea76d29a5b3eddf79d08b87cdfd2bdfb307b0c685b2 +7a987f9b7e81ddfb8a1b7fc2d93f7207275c24de47ce5cd6adab9b66250958d6
diff --git a/a/1.txt b/N2/1.txt index b74de53..339cae8 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -26,7 +26,7 @@ This part matches the patch - good. > Hibernate, as the function does nothing in their case. What I think you are explaining above is that the pci pm support will only call the suspend operation in case of suspend, so the -state.event = PM_EVENT_SUSPEND can be dropped in gxfb_suspend(). +state.event == PM_EVENT_SUSPEND can be dropped in gxfb_suspend(). For reference later I would prefer that this is explained a bit more explicit - not that the changelog needs update anyway. @@ -91,7 +91,7 @@ from a similar clarification. > - struct fb_info *info = pci_get_drvdata(pdev); > + struct fb_info *info = dev_get_drvdata(dev); > -> - if (state.event = PM_EVENT_SUSPEND) { +> - if (state.event == PM_EVENT_SUSPEND) { > - console_lock(); > - gx_powerdown(info); > - fb_set_suspend(info, 1); @@ -173,3 +173,8 @@ from a similar clarification. > -#endif > -- > 2.27.0 + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N2/content_digest index fd46319..b8dd930 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -3,10 +3,11 @@ "ref\020200810185723.15540-2-vaibhavgupta40@gmail.com\0" "From\0Sam Ravnborg <sam@ravnborg.org>\0" "Subject\0Re: [PATCH v2 01/12] fbdev: gxfb: use generic power management\0" - "Date\0Sun, 16 Aug 2020 20:16:01 +0000\0" + "Date\0Sun, 16 Aug 2020 22:16:01 +0200\0" "To\0Vaibhav Gupta <vaibhavgupta40@gmail.com>\0" "Cc\0linux-fbdev@vger.kernel.org" linux-kernel@vger.kernel.org + Antonino Daplas <adaplas@gmail.com> Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Vaibhav Gupta <vaibhav.varodek@gmail.com> Shuah Khan <skhan@linuxfoundation.org> @@ -50,7 +51,7 @@ "> Hibernate, as the function does nothing in their case.\n" "What I think you are explaining above is that the pci pm support\n" "will only call the suspend operation in case of suspend, so the \n" - "state.event = PM_EVENT_SUSPEND can be dropped in gxfb_suspend().\n" + "state.event == PM_EVENT_SUSPEND can be dropped in gxfb_suspend().\n" "\n" "For reference later I would prefer that this is explained a bit\n" "more explicit - not that the changelog needs update anyway.\n" @@ -115,7 +116,7 @@ "> -\tstruct fb_info *info = pci_get_drvdata(pdev);\n" "> +\tstruct fb_info *info = dev_get_drvdata(dev);\n" "> \n" - "> -\tif (state.event = PM_EVENT_SUSPEND) {\n" + "> -\tif (state.event == PM_EVENT_SUSPEND) {\n" "> -\t\tconsole_lock();\n" "> -\t\tgx_powerdown(info);\n" "> -\t\tfb_set_suspend(info, 1);\n" @@ -196,6 +197,11 @@ "> -\n" "> -#endif\n" "> -- \n" - > 2.27.0 + "> 2.27.0\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -723822e314eb4e28aa030ea76d29a5b3eddf79d08b87cdfd2bdfb307b0c685b2 +c79d0e474fc71779ab7864b94712aca66dd51635768c449e55db85f8a1132d51
diff --git a/a/1.txt b/N3/1.txt index b74de53..a8894d8 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -26,7 +26,7 @@ This part matches the patch - good. > Hibernate, as the function does nothing in their case. What I think you are explaining above is that the pci pm support will only call the suspend operation in case of suspend, so the -state.event = PM_EVENT_SUSPEND can be dropped in gxfb_suspend(). +state.event == PM_EVENT_SUSPEND can be dropped in gxfb_suspend(). For reference later I would prefer that this is explained a bit more explicit - not that the changelog needs update anyway. @@ -91,7 +91,7 @@ from a similar clarification. > - struct fb_info *info = pci_get_drvdata(pdev); > + struct fb_info *info = dev_get_drvdata(dev); > -> - if (state.event = PM_EVENT_SUSPEND) { +> - if (state.event == PM_EVENT_SUSPEND) { > - console_lock(); > - gx_powerdown(info); > - fb_set_suspend(info, 1); @@ -173,3 +173,7 @@ from a similar clarification. > -#endif > -- > 2.27.0 +_______________________________________________ +dri-devel mailing list +dri-devel@lists.freedesktop.org +https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/a/content_digest b/N3/content_digest index fd46319..569195b 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -3,7 +3,7 @@ "ref\020200810185723.15540-2-vaibhavgupta40@gmail.com\0" "From\0Sam Ravnborg <sam@ravnborg.org>\0" "Subject\0Re: [PATCH v2 01/12] fbdev: gxfb: use generic power management\0" - "Date\0Sun, 16 Aug 2020 20:16:01 +0000\0" + "Date\0Sun, 16 Aug 2020 22:16:01 +0200\0" "To\0Vaibhav Gupta <vaibhavgupta40@gmail.com>\0" "Cc\0linux-fbdev@vger.kernel.org" linux-kernel@vger.kernel.org @@ -50,7 +50,7 @@ "> Hibernate, as the function does nothing in their case.\n" "What I think you are explaining above is that the pci pm support\n" "will only call the suspend operation in case of suspend, so the \n" - "state.event = PM_EVENT_SUSPEND can be dropped in gxfb_suspend().\n" + "state.event == PM_EVENT_SUSPEND can be dropped in gxfb_suspend().\n" "\n" "For reference later I would prefer that this is explained a bit\n" "more explicit - not that the changelog needs update anyway.\n" @@ -115,7 +115,7 @@ "> -\tstruct fb_info *info = pci_get_drvdata(pdev);\n" "> +\tstruct fb_info *info = dev_get_drvdata(dev);\n" "> \n" - "> -\tif (state.event = PM_EVENT_SUSPEND) {\n" + "> -\tif (state.event == PM_EVENT_SUSPEND) {\n" "> -\t\tconsole_lock();\n" "> -\t\tgx_powerdown(info);\n" "> -\t\tfb_set_suspend(info, 1);\n" @@ -196,6 +196,10 @@ "> -\n" "> -#endif\n" "> -- \n" - > 2.27.0 + "> 2.27.0\n" + "_______________________________________________\n" + "dri-devel mailing list\n" + "dri-devel@lists.freedesktop.org\n" + https://lists.freedesktop.org/mailman/listinfo/dri-devel -723822e314eb4e28aa030ea76d29a5b3eddf79d08b87cdfd2bdfb307b0c685b2 +2a4eccf29ff9fff23c7e5279eef28109689e3ca5fb6216d752c6e4da3d6987b0
diff --git a/a/1.txt b/N4/1.txt index b74de53..90e97ea 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -26,7 +26,7 @@ This part matches the patch - good. > Hibernate, as the function does nothing in their case. What I think you are explaining above is that the pci pm support will only call the suspend operation in case of suspend, so the -state.event = PM_EVENT_SUSPEND can be dropped in gxfb_suspend(). +state.event == PM_EVENT_SUSPEND can be dropped in gxfb_suspend(). For reference later I would prefer that this is explained a bit more explicit - not that the changelog needs update anyway. @@ -91,7 +91,7 @@ from a similar clarification. > - struct fb_info *info = pci_get_drvdata(pdev); > + struct fb_info *info = dev_get_drvdata(dev); > -> - if (state.event = PM_EVENT_SUSPEND) { +> - if (state.event == PM_EVENT_SUSPEND) { > - console_lock(); > - gx_powerdown(info); > - fb_set_suspend(info, 1); diff --git a/a/content_digest b/N4/content_digest index fd46319..6d177f9 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -3,23 +3,24 @@ "ref\020200810185723.15540-2-vaibhavgupta40@gmail.com\0" "From\0Sam Ravnborg <sam@ravnborg.org>\0" "Subject\0Re: [PATCH v2 01/12] fbdev: gxfb: use generic power management\0" - "Date\0Sun, 16 Aug 2020 20:16:01 +0000\0" + "Date\0Sun, 16 Aug 2020 22:16:01 +0200\0" "To\0Vaibhav Gupta <vaibhavgupta40@gmail.com>\0" - "Cc\0linux-fbdev@vger.kernel.org" - linux-kernel@vger.kernel.org - Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> + "Cc\0Bjorn Helgaas <helgaas@kernel.org>" + Bjorn Helgaas <bhelgaas@google.com> + Bjorn Helgaas <bjorn@helgaas.com> Vaibhav Gupta <vaibhav.varodek@gmail.com> - Shuah Khan <skhan@linuxfoundation.org> + Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> + Paul Mackerras <paulus@samba.org> Russell King <linux@armlinux.org.uk> + Andres Salomon <dilinger@queued.net> + Antonino Daplas <adaplas@gmail.com> dri-devel@lists.freedesktop.org + linux-fbdev@vger.kernel.org + linux-arm-kernel@lists.infradead.org linux-geode@lists.infradead.org - Bjorn Helgaas <bjorn@helgaas.com> - Bjorn Helgaas <helgaas@kernel.org> - Andres Salomon <dilinger@queued.net> - Bjorn Helgaas <bhelgaas@google.com> - Paul Mackerras <paulus@samba.org> + linux-kernel@vger.kernel.org linux-kernel-mentees@lists.linuxfoundation.org - " linux-arm-kernel@lists.infradead.org\0" + " Shuah Khan <skhan@linuxfoundation.org>\0" "\00:1\0" "b\0" "Hi Vaibhav\n" @@ -50,7 +51,7 @@ "> Hibernate, as the function does nothing in their case.\n" "What I think you are explaining above is that the pci pm support\n" "will only call the suspend operation in case of suspend, so the \n" - "state.event = PM_EVENT_SUSPEND can be dropped in gxfb_suspend().\n" + "state.event == PM_EVENT_SUSPEND can be dropped in gxfb_suspend().\n" "\n" "For reference later I would prefer that this is explained a bit\n" "more explicit - not that the changelog needs update anyway.\n" @@ -115,7 +116,7 @@ "> -\tstruct fb_info *info = pci_get_drvdata(pdev);\n" "> +\tstruct fb_info *info = dev_get_drvdata(dev);\n" "> \n" - "> -\tif (state.event = PM_EVENT_SUSPEND) {\n" + "> -\tif (state.event == PM_EVENT_SUSPEND) {\n" "> -\t\tconsole_lock();\n" "> -\t\tgx_powerdown(info);\n" "> -\t\tfb_set_suspend(info, 1);\n" @@ -198,4 +199,4 @@ "> -- \n" > 2.27.0 -723822e314eb4e28aa030ea76d29a5b3eddf79d08b87cdfd2bdfb307b0c685b2 +9a647bcd9c0ff1c537320eb48540feacc548fed32cd682eafa51506da574a5e1
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.