Re: [RFC PATCH net-next] bridge: Implement MLD Querier wake-up calls / Android bug workaround

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3279 bytes --]

Hi "Linus,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Linus-L-ssing/bridge-Implement-MLD-Querier-wake-up-calls-Android-bug-workaround/20200817-043402
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git bfdd5aaa54b0a44d9df550fe4c9db7e1470a11b8
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   net/bridge/br_multicast.c: In function 'br_multicast_wakeupcall_check':
>> net/bridge/br_multicast.c:1968:27: warning: ordered comparison of pointer with integer zero [-Wextra]
    1968 |  if (ipv6_mc_check_icmpv6 < 0)
         |                           ^

# https://github.com/0day-ci/linux/commit/fdde3c8b901df4c7d62fcd4cdd9a66114758889a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Linus-L-ssing/bridge-Implement-MLD-Querier-wake-up-calls-Android-bug-workaround/20200817-043402
git checkout fdde3c8b901df4c7d62fcd4cdd9a66114758889a
vim +1968 net/bridge/br_multicast.c

  1930	
  1931	static bool br_multicast_wakeupcall_check(struct net_bridge *br,
  1932						  struct net_bridge_port *port,
  1933						  struct sk_buff *skb, u16 vid)
  1934	{
  1935		struct ethhdr *eth = eth_hdr(skb);
  1936		const struct ipv6hdr *ip6h;
  1937		unsigned int offset, len;
  1938		struct icmp6hdr *icmp6h;
  1939	
  1940		/* Wake-up calls to VLANs unsupported for now */
  1941		if (!port->wakeupcall_num_rings || vid ||
  1942		    eth->h_proto != htons(ETH_P_IPV6))
  1943			return false;
  1944	
  1945		if (!ether_addr_equal(eth->h_dest, br->dev->dev_addr) ||
  1946		    is_multicast_ether_addr(eth->h_source) ||
  1947		    is_zero_ether_addr(eth->h_source))
  1948			return false;
  1949	
  1950		offset = skb_network_offset(skb) + sizeof(*ip6h);
  1951		if (!pskb_may_pull(skb, offset))
  1952			return false;
  1953	
  1954		ip6h = ipv6_hdr(skb);
  1955	
  1956		if (ip6h->version != 6)
  1957			return false;
  1958	
  1959		len = offset + ntohs(ip6h->payload_len);
  1960		if (skb->len < len || len <= offset)
  1961			return false;
  1962	
  1963		if (ip6h->nexthdr != IPPROTO_ICMPV6)
  1964			return false;
  1965	
  1966		skb_set_transport_header(skb, offset);
  1967	
> 1968		if (ipv6_mc_check_icmpv6 < 0)
  1969			return false;
  1970	
  1971		icmp6h = (struct icmp6hdr *)skb_transport_header(skb);
  1972		if (icmp6h->icmp6_type != ICMPV6_ECHO_REPLY ||
  1973		    icmp6h->icmp6_dataun.u_echo.identifier != BR_MC_WAKEUP_ID)
  1974			return false;
  1975	
  1976		return true;
  1977	}
  1978	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 73835 bytes --]