From: Krzysztof Kozlowski <krzk@kernel.org>
To: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: [PATCH v2 06/13] extcon: ptn5150: Simplify getting vbus-gpios with flags
Date: Mon, 17 Aug 2020 09:00:02 +0200 [thread overview]
Message-ID: <20200817070009.4631-7-krzk@kernel.org> (raw)
In-Reply-To: <20200817070009.4631-1-krzk@kernel.org>
Instead of obtaining GPIO as input and configuring it right after to
output-low, just use proper GPIOD_OUT_LOW flag. Code is smaller and
simpler.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
drivers/extcon/extcon-ptn5150.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
index 12e52ddbd77e..3b99ad41b06e 100644
--- a/drivers/extcon/extcon-ptn5150.c
+++ b/drivers/extcon/extcon-ptn5150.c
@@ -239,16 +239,11 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c,
info->dev = &i2c->dev;
info->i2c = i2c;
- info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_IN);
+ info->vbus_gpiod = devm_gpiod_get(&i2c->dev, "vbus", GPIOD_OUT_LOW);
if (IS_ERR(info->vbus_gpiod)) {
dev_err(dev, "failed to get VBUS GPIO\n");
return PTR_ERR(info->vbus_gpiod);
}
- ret = gpiod_direction_output(info->vbus_gpiod, 0);
- if (ret) {
- dev_err(dev, "failed to set VBUS GPIO direction\n");
- return -EINVAL;
- }
mutex_init(&info->mutex);
--
2.17.1
next prev parent reply other threads:[~2020-08-17 7:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200817070046epcas1p4c047a86ccef2e5604f31e674782c9c6c@epcas1p4.samsung.com>
2020-08-17 6:59 ` [PATCH v2 00/13] extcon: ptn5150: Improvements and fixes Krzysztof Kozlowski
2020-08-17 6:59 ` [PATCH v2 01/13] dt-bindings: extcon: ptn5150: Convert binding to DT schema Krzysztof Kozlowski
2020-08-17 6:59 ` [PATCH v2 02/13] dt-bindings: extcon: ptn5150: Use generic "interrupts" property Krzysztof Kozlowski
2020-08-17 6:59 ` [PATCH v2 03/13] dt-bindings: extcon: ptn5150: Make 'vbus-gpios' optional Krzysztof Kozlowski
2020-08-17 7:00 ` [PATCH v2 04/13] extcon: ptn5150: Fix usage of atomic GPIO with sleeping GPIO chips Krzysztof Kozlowski
2020-08-17 7:00 ` [PATCH v2 05/13] extcon: ptn5150: Use generic "interrupts" property Krzysztof Kozlowski
2020-08-17 7:00 ` Krzysztof Kozlowski [this message]
2020-08-17 7:00 ` [PATCH v2 07/13] extcon: ptn5150: Lower the noisiness of probe Krzysztof Kozlowski
2020-08-17 7:00 ` [PATCH v2 08/13] extcon: ptn5150: Check current USB mode when probing Krzysztof Kozlowski
2020-08-17 7:00 ` [PATCH v2 09/13] extcon: ptn5150: Make 'vbus-gpios' optional Krzysztof Kozlowski
2020-08-17 7:00 ` [PATCH v2 10/13] extcon: ptn5150: Reduce the amount of logs on deferred probe Krzysztof Kozlowski
2020-08-17 7:00 ` [PATCH v2 11/13] extcon: ptn5150: Convert to module_i2c_driver Krzysztof Kozlowski
2020-08-17 7:00 ` [PATCH v2 12/13] extcon: ptn5150: Convert to .probe_new Krzysztof Kozlowski
2020-08-17 7:00 ` [PATCH v2 13/13] MAINTAINERS: Add entry for NXP PTN5150A CC driver Krzysztof Kozlowski
2020-08-19 6:19 ` [PATCH v2 00/13] extcon: ptn5150: Improvements and fixes vijai kumar
2020-08-24 10:36 ` Ramuthevar, Vadivel MuruganX
2020-08-24 10:38 ` Krzysztof Kozlowski
2020-08-25 2:06 ` Ramuthevar, Vadivel MuruganX
2020-08-24 11:28 ` Chanwoo Choi
2020-08-26 21:56 ` Suman Anna
2020-08-27 2:40 ` Chanwoo Choi
2020-08-24 11:27 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817070009.4631-7-krzk@kernel.org \
--to=krzk@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=vijaikumar.kanagarajan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.