diff for duplicates of <20200817074634.GD5869@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 4a088f3..ca2be5f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -20,7 +20,7 @@ On Sun, Aug 16, 2020 at 10:24:42PM +0200, Sam Ravnborg wrote: > They then called a more generic function that uses the passes > enumeration to decide what to do. > -> But in this driver the test "state.event = PM_EVENT_FREEZE" is dropped +> But in this driver the test "state.event == PM_EVENT_FREEZE" is dropped > and there is no freeze operation. > Please explain this change so the reader is not left wondering. > @@ -51,7 +51,7 @@ Vaibhav Gupta > > struct i740fb_par *par = info->par; > > > > - /* don't disable console during hibernation and wakeup from it */ -> > - if (state.event = PM_EVENT_FREEZE || state.event = PM_EVENT_PRETHAW) +> > - if (state.event == PM_EVENT_FREEZE || state.event == PM_EVENT_PRETHAW) > > - return 0; > > - > > console_lock(); @@ -80,7 +80,7 @@ Vaibhav Gupta > > > > console_lock(); > > @@ -1218,11 +1209,6 @@ static int i740fb_resume(struct pci_dev *dev) -> > if (par->ref_count = 0) +> > if (par->ref_count == 0) > > goto fail; > > > > - pci_set_power_state(dev, PCI_D0); @@ -125,3 +125,7 @@ Vaibhav Gupta > > #ifndef MODULE > > -- > > 2.27.0 +_______________________________________________ +Linux-kernel-mentees mailing list +Linux-kernel-mentees@lists.linuxfoundation.org +https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees diff --git a/a/content_digest b/N1/content_digest index fb6abb1..0605004 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,18 +3,17 @@ "ref\020200810185723.15540-10-vaibhavgupta40@gmail.com\0" "ref\020200816202442.GB1426650@ravnborg.org\0" "From\0Vaibhav Gupta <vaibhavgupta40@gmail.com>\0" - "Subject\0Re: [PATCH v2 09/12] fbdev: i740fb: use generic power management\0" - "Date\0Mon, 17 Aug 2020 07:58:34 +0000\0" + "Subject\0Re: [Linux-kernel-mentees] [PATCH v2 09/12] fbdev: i740fb: use generic power management\0" + "Date\0Mon, 17 Aug 2020 13:16:34 +0530\0" "To\0Sam Ravnborg <sam@ravnborg.org>\0" "Cc\0linux-fbdev@vger.kernel.org" linux-kernel@vger.kernel.org + Antonino Daplas <adaplas@gmail.com> Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Vaibhav Gupta <vaibhav.varodek@gmail.com> - Shuah Khan <skhan@linuxfoundation.org> Russell King <linux@armlinux.org.uk> dri-devel@lists.freedesktop.org linux-geode@lists.infradead.org - Bjorn Helgaas <bjorn@helgaas.com> Bjorn Helgaas <helgaas@kernel.org> Andres Salomon <dilinger@queued.net> Bjorn Helgaas <bhelgaas@google.com> @@ -45,7 +44,7 @@ "> They then called a more generic function that uses the passes\n" "> enumeration to decide what to do.\n" "> \n" - "> But in this driver the test \"state.event = PM_EVENT_FREEZE\" is dropped\n" + "> But in this driver the test \"state.event == PM_EVENT_FREEZE\" is dropped\n" "> and there is no freeze operation.\n" "> Please explain this change so the reader is not left wondering.\n" "> \n" @@ -76,7 +75,7 @@ "> > \tstruct i740fb_par *par = info->par;\n" "> > \n" "> > -\t/* don't disable console during hibernation and wakeup from it */\n" - "> > -\tif (state.event = PM_EVENT_FREEZE || state.event = PM_EVENT_PRETHAW)\n" + "> > -\tif (state.event == PM_EVENT_FREEZE || state.event == PM_EVENT_PRETHAW)\n" "> > -\t\treturn 0;\n" "> > -\n" "> > \tconsole_lock();\n" @@ -105,7 +104,7 @@ "> > \n" "> > \tconsole_lock();\n" "> > @@ -1218,11 +1209,6 @@ static int i740fb_resume(struct pci_dev *dev)\n" - "> > \tif (par->ref_count = 0)\n" + "> > \tif (par->ref_count == 0)\n" "> > \t\tgoto fail;\n" "> > \n" "> > -\tpci_set_power_state(dev, PCI_D0);\n" @@ -149,6 +148,10 @@ "> > \n" "> > #ifndef MODULE\n" "> > -- \n" - > > 2.27.0 + "> > 2.27.0\n" + "_______________________________________________\n" + "Linux-kernel-mentees mailing list\n" + "Linux-kernel-mentees@lists.linuxfoundation.org\n" + https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees -dc0b600e35e22ea4f85c11df3ef8d7ad6008964c1130a02f4d13651775f71c38 +f81242ebb3042bb6ff1273b7818a03fbd4aa7392198fe66e72c2f984af93339d
diff --git a/a/1.txt b/N2/1.txt index 4a088f3..26d72a4 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -20,7 +20,7 @@ On Sun, Aug 16, 2020 at 10:24:42PM +0200, Sam Ravnborg wrote: > They then called a more generic function that uses the passes > enumeration to decide what to do. > -> But in this driver the test "state.event = PM_EVENT_FREEZE" is dropped +> But in this driver the test "state.event == PM_EVENT_FREEZE" is dropped > and there is no freeze operation. > Please explain this change so the reader is not left wondering. > @@ -51,7 +51,7 @@ Vaibhav Gupta > > struct i740fb_par *par = info->par; > > > > - /* don't disable console during hibernation and wakeup from it */ -> > - if (state.event = PM_EVENT_FREEZE || state.event = PM_EVENT_PRETHAW) +> > - if (state.event == PM_EVENT_FREEZE || state.event == PM_EVENT_PRETHAW) > > - return 0; > > - > > console_lock(); @@ -80,7 +80,7 @@ Vaibhav Gupta > > > > console_lock(); > > @@ -1218,11 +1209,6 @@ static int i740fb_resume(struct pci_dev *dev) -> > if (par->ref_count = 0) +> > if (par->ref_count == 0) > > goto fail; > > > > - pci_set_power_state(dev, PCI_D0); @@ -125,3 +125,8 @@ Vaibhav Gupta > > #ifndef MODULE > > -- > > 2.27.0 + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N2/content_digest index fb6abb1..b1586f6 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -4,10 +4,11 @@ "ref\020200816202442.GB1426650@ravnborg.org\0" "From\0Vaibhav Gupta <vaibhavgupta40@gmail.com>\0" "Subject\0Re: [PATCH v2 09/12] fbdev: i740fb: use generic power management\0" - "Date\0Mon, 17 Aug 2020 07:58:34 +0000\0" + "Date\0Mon, 17 Aug 2020 13:16:34 +0530\0" "To\0Sam Ravnborg <sam@ravnborg.org>\0" "Cc\0linux-fbdev@vger.kernel.org" linux-kernel@vger.kernel.org + Antonino Daplas <adaplas@gmail.com> Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Vaibhav Gupta <vaibhav.varodek@gmail.com> Shuah Khan <skhan@linuxfoundation.org> @@ -45,7 +46,7 @@ "> They then called a more generic function that uses the passes\n" "> enumeration to decide what to do.\n" "> \n" - "> But in this driver the test \"state.event = PM_EVENT_FREEZE\" is dropped\n" + "> But in this driver the test \"state.event == PM_EVENT_FREEZE\" is dropped\n" "> and there is no freeze operation.\n" "> Please explain this change so the reader is not left wondering.\n" "> \n" @@ -76,7 +77,7 @@ "> > \tstruct i740fb_par *par = info->par;\n" "> > \n" "> > -\t/* don't disable console during hibernation and wakeup from it */\n" - "> > -\tif (state.event = PM_EVENT_FREEZE || state.event = PM_EVENT_PRETHAW)\n" + "> > -\tif (state.event == PM_EVENT_FREEZE || state.event == PM_EVENT_PRETHAW)\n" "> > -\t\treturn 0;\n" "> > -\n" "> > \tconsole_lock();\n" @@ -105,7 +106,7 @@ "> > \n" "> > \tconsole_lock();\n" "> > @@ -1218,11 +1209,6 @@ static int i740fb_resume(struct pci_dev *dev)\n" - "> > \tif (par->ref_count = 0)\n" + "> > \tif (par->ref_count == 0)\n" "> > \t\tgoto fail;\n" "> > \n" "> > -\tpci_set_power_state(dev, PCI_D0);\n" @@ -149,6 +150,11 @@ "> > \n" "> > #ifndef MODULE\n" "> > -- \n" - > > 2.27.0 + "> > 2.27.0\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -dc0b600e35e22ea4f85c11df3ef8d7ad6008964c1130a02f4d13651775f71c38 +f6c6b245a9b3b6342f45af72e7bd1ce39b7a6057faf91bf968fd7487af0369b7
diff --git a/a/1.txt b/N3/1.txt index 4a088f3..274c950 100644 --- a/a/1.txt +++ b/N3/1.txt @@ -20,7 +20,7 @@ On Sun, Aug 16, 2020 at 10:24:42PM +0200, Sam Ravnborg wrote: > They then called a more generic function that uses the passes > enumeration to decide what to do. > -> But in this driver the test "state.event = PM_EVENT_FREEZE" is dropped +> But in this driver the test "state.event == PM_EVENT_FREEZE" is dropped > and there is no freeze operation. > Please explain this change so the reader is not left wondering. > @@ -51,7 +51,7 @@ Vaibhav Gupta > > struct i740fb_par *par = info->par; > > > > - /* don't disable console during hibernation and wakeup from it */ -> > - if (state.event = PM_EVENT_FREEZE || state.event = PM_EVENT_PRETHAW) +> > - if (state.event == PM_EVENT_FREEZE || state.event == PM_EVENT_PRETHAW) > > - return 0; > > - > > console_lock(); @@ -80,7 +80,7 @@ Vaibhav Gupta > > > > console_lock(); > > @@ -1218,11 +1209,6 @@ static int i740fb_resume(struct pci_dev *dev) -> > if (par->ref_count = 0) +> > if (par->ref_count == 0) > > goto fail; > > > > - pci_set_power_state(dev, PCI_D0); @@ -125,3 +125,7 @@ Vaibhav Gupta > > #ifndef MODULE > > -- > > 2.27.0 +_______________________________________________ +dri-devel mailing list +dri-devel@lists.freedesktop.org +https://lists.freedesktop.org/mailman/listinfo/dri-devel diff --git a/a/content_digest b/N3/content_digest index fb6abb1..ee01d90 100644 --- a/a/content_digest +++ b/N3/content_digest @@ -4,7 +4,7 @@ "ref\020200816202442.GB1426650@ravnborg.org\0" "From\0Vaibhav Gupta <vaibhavgupta40@gmail.com>\0" "Subject\0Re: [PATCH v2 09/12] fbdev: i740fb: use generic power management\0" - "Date\0Mon, 17 Aug 2020 07:58:34 +0000\0" + "Date\0Mon, 17 Aug 2020 13:16:34 +0530\0" "To\0Sam Ravnborg <sam@ravnborg.org>\0" "Cc\0linux-fbdev@vger.kernel.org" linux-kernel@vger.kernel.org @@ -45,7 +45,7 @@ "> They then called a more generic function that uses the passes\n" "> enumeration to decide what to do.\n" "> \n" - "> But in this driver the test \"state.event = PM_EVENT_FREEZE\" is dropped\n" + "> But in this driver the test \"state.event == PM_EVENT_FREEZE\" is dropped\n" "> and there is no freeze operation.\n" "> Please explain this change so the reader is not left wondering.\n" "> \n" @@ -76,7 +76,7 @@ "> > \tstruct i740fb_par *par = info->par;\n" "> > \n" "> > -\t/* don't disable console during hibernation and wakeup from it */\n" - "> > -\tif (state.event = PM_EVENT_FREEZE || state.event = PM_EVENT_PRETHAW)\n" + "> > -\tif (state.event == PM_EVENT_FREEZE || state.event == PM_EVENT_PRETHAW)\n" "> > -\t\treturn 0;\n" "> > -\n" "> > \tconsole_lock();\n" @@ -105,7 +105,7 @@ "> > \n" "> > \tconsole_lock();\n" "> > @@ -1218,11 +1209,6 @@ static int i740fb_resume(struct pci_dev *dev)\n" - "> > \tif (par->ref_count = 0)\n" + "> > \tif (par->ref_count == 0)\n" "> > \t\tgoto fail;\n" "> > \n" "> > -\tpci_set_power_state(dev, PCI_D0);\n" @@ -149,6 +149,10 @@ "> > \n" "> > #ifndef MODULE\n" "> > -- \n" - > > 2.27.0 + "> > 2.27.0\n" + "_______________________________________________\n" + "dri-devel mailing list\n" + "dri-devel@lists.freedesktop.org\n" + https://lists.freedesktop.org/mailman/listinfo/dri-devel -dc0b600e35e22ea4f85c11df3ef8d7ad6008964c1130a02f4d13651775f71c38 +14e5e7d7cd6ced658c36699e29a02ea79132d1b0875040da1f920a963b1e91eb
diff --git a/a/1.txt b/N4/1.txt index 4a088f3..0a4ef98 100644 --- a/a/1.txt +++ b/N4/1.txt @@ -20,7 +20,7 @@ On Sun, Aug 16, 2020 at 10:24:42PM +0200, Sam Ravnborg wrote: > They then called a more generic function that uses the passes > enumeration to decide what to do. > -> But in this driver the test "state.event = PM_EVENT_FREEZE" is dropped +> But in this driver the test "state.event == PM_EVENT_FREEZE" is dropped > and there is no freeze operation. > Please explain this change so the reader is not left wondering. > @@ -51,7 +51,7 @@ Vaibhav Gupta > > struct i740fb_par *par = info->par; > > > > - /* don't disable console during hibernation and wakeup from it */ -> > - if (state.event = PM_EVENT_FREEZE || state.event = PM_EVENT_PRETHAW) +> > - if (state.event == PM_EVENT_FREEZE || state.event == PM_EVENT_PRETHAW) > > - return 0; > > - > > console_lock(); @@ -80,7 +80,7 @@ Vaibhav Gupta > > > > console_lock(); > > @@ -1218,11 +1209,6 @@ static int i740fb_resume(struct pci_dev *dev) -> > if (par->ref_count = 0) +> > if (par->ref_count == 0) > > goto fail; > > > > - pci_set_power_state(dev, PCI_D0); diff --git a/a/content_digest b/N4/content_digest index fb6abb1..d0be250 100644 --- a/a/content_digest +++ b/N4/content_digest @@ -4,23 +4,24 @@ "ref\020200816202442.GB1426650@ravnborg.org\0" "From\0Vaibhav Gupta <vaibhavgupta40@gmail.com>\0" "Subject\0Re: [PATCH v2 09/12] fbdev: i740fb: use generic power management\0" - "Date\0Mon, 17 Aug 2020 07:58:34 +0000\0" + "Date\0Mon, 17 Aug 2020 13:16:34 +0530\0" "To\0Sam Ravnborg <sam@ravnborg.org>\0" - "Cc\0linux-fbdev@vger.kernel.org" - linux-kernel@vger.kernel.org - Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> + "Cc\0Bjorn Helgaas <helgaas@kernel.org>" + Bjorn Helgaas <bhelgaas@google.com> + Bjorn Helgaas <bjorn@helgaas.com> Vaibhav Gupta <vaibhav.varodek@gmail.com> - Shuah Khan <skhan@linuxfoundation.org> + Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> + Paul Mackerras <paulus@samba.org> Russell King <linux@armlinux.org.uk> + Andres Salomon <dilinger@queued.net> + Antonino Daplas <adaplas@gmail.com> dri-devel@lists.freedesktop.org + linux-fbdev@vger.kernel.org + linux-arm-kernel@lists.infradead.org linux-geode@lists.infradead.org - Bjorn Helgaas <bjorn@helgaas.com> - Bjorn Helgaas <helgaas@kernel.org> - Andres Salomon <dilinger@queued.net> - Bjorn Helgaas <bhelgaas@google.com> - Paul Mackerras <paulus@samba.org> + linux-kernel@vger.kernel.org linux-kernel-mentees@lists.linuxfoundation.org - " linux-arm-kernel@lists.infradead.org\0" + " Shuah Khan <skhan@linuxfoundation.org>\0" "\00:1\0" "b\0" "On Sun, Aug 16, 2020 at 10:24:42PM +0200, Sam Ravnborg wrote:\n" @@ -45,7 +46,7 @@ "> They then called a more generic function that uses the passes\n" "> enumeration to decide what to do.\n" "> \n" - "> But in this driver the test \"state.event = PM_EVENT_FREEZE\" is dropped\n" + "> But in this driver the test \"state.event == PM_EVENT_FREEZE\" is dropped\n" "> and there is no freeze operation.\n" "> Please explain this change so the reader is not left wondering.\n" "> \n" @@ -76,7 +77,7 @@ "> > \tstruct i740fb_par *par = info->par;\n" "> > \n" "> > -\t/* don't disable console during hibernation and wakeup from it */\n" - "> > -\tif (state.event = PM_EVENT_FREEZE || state.event = PM_EVENT_PRETHAW)\n" + "> > -\tif (state.event == PM_EVENT_FREEZE || state.event == PM_EVENT_PRETHAW)\n" "> > -\t\treturn 0;\n" "> > -\n" "> > \tconsole_lock();\n" @@ -105,7 +106,7 @@ "> > \n" "> > \tconsole_lock();\n" "> > @@ -1218,11 +1209,6 @@ static int i740fb_resume(struct pci_dev *dev)\n" - "> > \tif (par->ref_count = 0)\n" + "> > \tif (par->ref_count == 0)\n" "> > \t\tgoto fail;\n" "> > \n" "> > -\tpci_set_power_state(dev, PCI_D0);\n" @@ -151,4 +152,4 @@ "> > -- \n" > > 2.27.0 -dc0b600e35e22ea4f85c11df3ef8d7ad6008964c1130a02f4d13651775f71c38 +fc1b06ebca786671704e41e2ee86aee251156bc2beb0b65d852db3592352c297
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.