From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Stephen Kitt <steve@sk2.org>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/hwmon/adm1029.c: use simple i2c probe
Date: Mon, 17 Aug 2020 10:45:08 +0200 [thread overview]
Message-ID: <20200817084508.GA15571@Red> (raw)
In-Reply-To: <20200813161129.1507599-1-steve@sk2.org>
On Thu, Aug 13, 2020 at 06:11:29PM +0200, Stephen Kitt wrote:
> This driver doesn't use the id information provided by the old i2c
> probe function, so it can trivially be converted to the simple
> ("probe_new") form.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> ---
> drivers/hwmon/adm1029.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/adm1029.c b/drivers/hwmon/adm1029.c
> index f7752a5bef31..50b1df7b008c 100644
> --- a/drivers/hwmon/adm1029.c
> +++ b/drivers/hwmon/adm1029.c
> @@ -352,8 +352,7 @@ static int adm1029_init_client(struct i2c_client *client)
> return 1;
> }
>
> -static int adm1029_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int adm1029_probe(struct i2c_client *client)
> {
> struct device *dev = &client->dev;
> struct adm1029_data *data;
> @@ -390,7 +389,7 @@ static struct i2c_driver adm1029_driver = {
> .driver = {
> .name = "adm1029",
> },
> - .probe = adm1029_probe,
> + .probe_new = adm1029_probe,
> .id_table = adm1029_id,
> .detect = adm1029_detect,
> .address_list = normal_i2c,
> --
> 2.25.4
>
Hello
Tested-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Thanks
prev parent reply other threads:[~2020-08-17 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-13 16:11 [PATCH] drivers/hwmon/adm1029.c: use simple i2c probe Stephen Kitt
2020-08-14 11:39 ` Corentin Labbe
2020-08-17 8:45 ` Corentin Labbe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817084508.GA15571@Red \
--to=clabbe.montjoie@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.