From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04BCFC433DF for ; Mon, 17 Aug 2020 09:36:48 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA20A207FF for ; Mon, 17 Aug 2020 09:36:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EiPymNhh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CA20A207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 9C57E877A7; Mon, 17 Aug 2020 09:36:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RzwbH9r2RCfd; Mon, 17 Aug 2020 09:36:46 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id E0E85877A5; Mon, 17 Aug 2020 09:36:46 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C974AC07FF; Mon, 17 Aug 2020 09:36:46 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 72F23C0051 for ; Mon, 17 Aug 2020 09:36:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 6F44085F53 for ; Mon, 17 Aug 2020 09:36:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mXOBQHgrK3Ym for ; Mon, 17 Aug 2020 09:36:44 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by fraxinus.osuosl.org (Postfix) with ESMTPS id D795085F4B for ; Mon, 17 Aug 2020 09:36:44 +0000 (UTC) Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0928820758; Mon, 17 Aug 2020 09:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597657004; bh=U1qHP+qiwsmBgHRIfztUBNmpSWAG9yzGiWN9ezXPT3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EiPymNhhY7J7Q5icOVcgegOaakU7Wjj2YeuMQ4pVPv3Gt2hSkda6W/zXFgy7bPR2g 1s1yOQryIIu8tw4Q6paCL1UA+CEPbhsX79w/h11fiqC5/Qp/OzQgdUow+hBGom1JeQ lu+n17KSv+oNFc+3JxMUgVj2laBiqJyZFJX71MW4= Date: Mon, 17 Aug 2020 11:37:03 +0200 From: Greg Kroah-Hartman To: Mauro Carvalho Chehab Subject: Re: [PATCH 00/16] IOMMU driver for Kirin 960/970 Message-ID: <20200817093703.GA2258686@kroah.com> References: <20200817082106.GA16296@infradead.org> <20200817112725.26f1b7d6@coco.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200817112725.26f1b7d6@coco.lan> Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Joerg Roedel , Manivannan Sadhasivam , Chenfeng , linuxarm@huawei.com, Wei Xu , linux-kernel@vger.kernel.org, Christoph Hellwig , iommu@lists.linux-foundation.org, Rob Herring , John Stultz , mauro.chehab@huawei.com, Suzhuangluan , linux-arm-kernel@lists.infradead.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon, Aug 17, 2020 at 11:27:25AM +0200, Mauro Carvalho Chehab wrote: > Hi Christoph, > > Em Mon, 17 Aug 2020 09:21:06 +0100 > Christoph Hellwig escreveu: > > > On Mon, Aug 17, 2020 at 09:49:59AM +0200, Mauro Carvalho Chehab wrote: > > > Add a driver for the Kirin 960/970 iommu. > > > > > > As on the past series, this starts from the original 4.9 driver from > > > the 96boards tree: > > > > > > https://github.com/96boards-hikey/linux/tree/hikey970-v4.9 > > > > > > The remaining patches add SPDX headers and make it build and run with > > > the upstream Kernel. > > > > Please don't add iommu drivers to staging, and just work with the > > maintainers to properly clean it up. > > I need to start from the original patch in order to preserve its > authorship. > > My plan is to work with the iommu subsystem maintainers after > have this (and another pending patch series for DRM) merged. > > > I also don't think adding a totally out of date not compiling version > > is a good idea. Please do a proper rollup, and if required (probably > > not in this case), split it into useful chunks. > > This series make this driver working as expected. > > I mean, while patch 01/16 is against Kernel 4.9, the other patches > on this series ports it to upstream, cleans up the driver and > address several issues on it. > > This specific IOMMU seems to be an specific part of the SoC dedicated for > the display engine and by the encoding/decoding images via the ISP. > With this series, this driver builds and runs as expected, providing > IOMMU support needed by the upcoming KMS/DRM driver. > > The only issue on it (as far as I can tell) is that the DT bindings > require some work, as, instead of using dma-ranges, the DRM driver binds > into it with: > > smmu_lpae { > compatible = "hisilicon,smmu-lpae"; > }; > > dpe: dpe@e8600000 { > compatible = "hisilicon,kirin970-dpe"; > ... > iommu_info { > start-addr = <0x8000>; > size = <0xbfff8000>; > }; > }; > > In order to properly address it, the best would be to also have the > DRM driver merged upstream, as it relies on it. So, a change in DT will > also mean a change at the way the DRM uses it. > > The DRM itself should go via staging, as it has some bugs that I'd > like to fix before moving it to drivers/gpu/drm. Those are more > tricky to solve, as they seem to require using different settings for > some hardware registers, and the downstream driver also have the same > issues. Fixing them will likely require some time. DRM drivers can't go through staging unless you get the DRM developers to agree with it, and last I heard, they were strongly against it. It's _always_ faster to just do the work out-of-tree for a week or so and then merge it correctly to the proper part of the kernel tree. I'd recommend doing that here for the iommu driver, as well as the DRM driver. There's no issues with authorship and the like, just properly attribute it when you submit it and you are fine. Again, merging in staging always takes more work and energy, don't do it unless there is no other way. thanks, greg k-h _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFA77C433DF for ; Mon, 17 Aug 2020 09:38:13 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 858FC20758 for ; Mon, 17 Aug 2020 09:38:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f3qSpldP"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="EiPymNhh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 858FC20758 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=krDYDden8ezK8zxRNQOLVT0XZqipKcrEfkxwR6B+AvA=; b=f3qSpldPTuOU9BxEp1lN31KEx cXvev8zbHHOSAMFPoNKH7RHdx+hzwRNhHWA9dOdMMh7SS3K1x7grcbZu3ifVzLazM4SYJoNjCkyqN yQD8Ua968YJEQA9efUmwytcXgxD7w50DVCKMYQ0lfTCpN/ZcHBQ6xDdtKgcYoICDY48FfvgLwuSrm 3RKAXwj0WsCA/3sR+NFaJ71NSMbjLUri156Wg/rF14srwh5Mb27QwZVkG8r2och5V2sR8uKuJbzl8 T6aTx6LbxkUoNqjszwCIppt+ftZTRLEOs85aU+CvT26wM9RFTYieyp3qAc1ZmYHYy0VLGulnErKQ2 CeSzzWsDA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7bZQ-0005Wd-KS; Mon, 17 Aug 2020 09:36:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7bZN-0005Va-Lm for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 09:36:46 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0928820758; Mon, 17 Aug 2020 09:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597657004; bh=U1qHP+qiwsmBgHRIfztUBNmpSWAG9yzGiWN9ezXPT3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EiPymNhhY7J7Q5icOVcgegOaakU7Wjj2YeuMQ4pVPv3Gt2hSkda6W/zXFgy7bPR2g 1s1yOQryIIu8tw4Q6paCL1UA+CEPbhsX79w/h11fiqC5/Qp/OzQgdUow+hBGom1JeQ lu+n17KSv+oNFc+3JxMUgVj2laBiqJyZFJX71MW4= Date: Mon, 17 Aug 2020 11:37:03 +0200 From: Greg Kroah-Hartman To: Mauro Carvalho Chehab Subject: Re: [PATCH 00/16] IOMMU driver for Kirin 960/970 Message-ID: <20200817093703.GA2258686@kroah.com> References: <20200817082106.GA16296@infradead.org> <20200817112725.26f1b7d6@coco.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200817112725.26f1b7d6@coco.lan> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_053645_843829_CE28E6E8 X-CRM114-Status: GOOD ( 32.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Joerg Roedel , Manivannan Sadhasivam , Chenfeng , Joerg Roedel , linuxarm@huawei.com, Wei Xu , linux-kernel@vger.kernel.org, Christoph Hellwig , iommu@lists.linux-foundation.org, Rob Herring , John Stultz , mauro.chehab@huawei.com, Suzhuangluan , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 17, 2020 at 11:27:25AM +0200, Mauro Carvalho Chehab wrote: > Hi Christoph, > > Em Mon, 17 Aug 2020 09:21:06 +0100 > Christoph Hellwig escreveu: > > > On Mon, Aug 17, 2020 at 09:49:59AM +0200, Mauro Carvalho Chehab wrote: > > > Add a driver for the Kirin 960/970 iommu. > > > > > > As on the past series, this starts from the original 4.9 driver from > > > the 96boards tree: > > > > > > https://github.com/96boards-hikey/linux/tree/hikey970-v4.9 > > > > > > The remaining patches add SPDX headers and make it build and run with > > > the upstream Kernel. > > > > Please don't add iommu drivers to staging, and just work with the > > maintainers to properly clean it up. > > I need to start from the original patch in order to preserve its > authorship. > > My plan is to work with the iommu subsystem maintainers after > have this (and another pending patch series for DRM) merged. > > > I also don't think adding a totally out of date not compiling version > > is a good idea. Please do a proper rollup, and if required (probably > > not in this case), split it into useful chunks. > > This series make this driver working as expected. > > I mean, while patch 01/16 is against Kernel 4.9, the other patches > on this series ports it to upstream, cleans up the driver and > address several issues on it. > > This specific IOMMU seems to be an specific part of the SoC dedicated for > the display engine and by the encoding/decoding images via the ISP. > With this series, this driver builds and runs as expected, providing > IOMMU support needed by the upcoming KMS/DRM driver. > > The only issue on it (as far as I can tell) is that the DT bindings > require some work, as, instead of using dma-ranges, the DRM driver binds > into it with: > > smmu_lpae { > compatible = "hisilicon,smmu-lpae"; > }; > > dpe: dpe@e8600000 { > compatible = "hisilicon,kirin970-dpe"; > ... > iommu_info { > start-addr = <0x8000>; > size = <0xbfff8000>; > }; > }; > > In order to properly address it, the best would be to also have the > DRM driver merged upstream, as it relies on it. So, a change in DT will > also mean a change at the way the DRM uses it. > > The DRM itself should go via staging, as it has some bugs that I'd > like to fix before moving it to drivers/gpu/drm. Those are more > tricky to solve, as they seem to require using different settings for > some hardware registers, and the downstream driver also have the same > issues. Fixing them will likely require some time. DRM drivers can't go through staging unless you get the DRM developers to agree with it, and last I heard, they were strongly against it. It's _always_ faster to just do the work out-of-tree for a week or so and then merge it correctly to the proper part of the kernel tree. I'd recommend doing that here for the iommu driver, as well as the DRM driver. There's no issues with authorship and the like, just properly attribute it when you submit it and you are fine. Again, merging in staging always takes more work and energy, don't do it unless there is no other way. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C366C433E1 for ; Mon, 17 Aug 2020 09:36:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33CA1207DF for ; Mon, 17 Aug 2020 09:36:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597657007; bh=U1qHP+qiwsmBgHRIfztUBNmpSWAG9yzGiWN9ezXPT3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=M763I1gWAWlJ8xxro6kNeHk6EjBlNp6sQQFxJiv4jPp4hxf1h/30CXZf892/YmXgz /wn4JG/KV6KdY6ltYNB7sCkJn1frhgZLERaKV0//HB/7Zu0eIHyz+Zy/ijq2WfE3GX W30uyo+Qlw3EF71k2z6wFu7YWwaQ7q/GtVnHW4iU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726694AbgHQJgq (ORCPT ); Mon, 17 Aug 2020 05:36:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:46174 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726617AbgHQJgp (ORCPT ); Mon, 17 Aug 2020 05:36:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0928820758; Mon, 17 Aug 2020 09:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597657004; bh=U1qHP+qiwsmBgHRIfztUBNmpSWAG9yzGiWN9ezXPT3c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EiPymNhhY7J7Q5icOVcgegOaakU7Wjj2YeuMQ4pVPv3Gt2hSkda6W/zXFgy7bPR2g 1s1yOQryIIu8tw4Q6paCL1UA+CEPbhsX79w/h11fiqC5/Qp/OzQgdUow+hBGom1JeQ lu+n17KSv+oNFc+3JxMUgVj2laBiqJyZFJX71MW4= Date: Mon, 17 Aug 2020 11:37:03 +0200 From: Greg Kroah-Hartman To: Mauro Carvalho Chehab Cc: Christoph Hellwig , devel@driverdev.osuosl.org, devicetree@vger.kernel.org, Joerg Roedel , Manivannan Sadhasivam , Joerg Roedel , linuxarm@huawei.com, Wei Xu , linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, Rob Herring , John Stultz , Chenfeng , mauro.chehab@huawei.com, Suzhuangluan , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 00/16] IOMMU driver for Kirin 960/970 Message-ID: <20200817093703.GA2258686@kroah.com> References: <20200817082106.GA16296@infradead.org> <20200817112725.26f1b7d6@coco.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200817112725.26f1b7d6@coco.lan> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Aug 17, 2020 at 11:27:25AM +0200, Mauro Carvalho Chehab wrote: > Hi Christoph, > > Em Mon, 17 Aug 2020 09:21:06 +0100 > Christoph Hellwig escreveu: > > > On Mon, Aug 17, 2020 at 09:49:59AM +0200, Mauro Carvalho Chehab wrote: > > > Add a driver for the Kirin 960/970 iommu. > > > > > > As on the past series, this starts from the original 4.9 driver from > > > the 96boards tree: > > > > > > https://github.com/96boards-hikey/linux/tree/hikey970-v4.9 > > > > > > The remaining patches add SPDX headers and make it build and run with > > > the upstream Kernel. > > > > Please don't add iommu drivers to staging, and just work with the > > maintainers to properly clean it up. > > I need to start from the original patch in order to preserve its > authorship. > > My plan is to work with the iommu subsystem maintainers after > have this (and another pending patch series for DRM) merged. > > > I also don't think adding a totally out of date not compiling version > > is a good idea. Please do a proper rollup, and if required (probably > > not in this case), split it into useful chunks. > > This series make this driver working as expected. > > I mean, while patch 01/16 is against Kernel 4.9, the other patches > on this series ports it to upstream, cleans up the driver and > address several issues on it. > > This specific IOMMU seems to be an specific part of the SoC dedicated for > the display engine and by the encoding/decoding images via the ISP. > With this series, this driver builds and runs as expected, providing > IOMMU support needed by the upcoming KMS/DRM driver. > > The only issue on it (as far as I can tell) is that the DT bindings > require some work, as, instead of using dma-ranges, the DRM driver binds > into it with: > > smmu_lpae { > compatible = "hisilicon,smmu-lpae"; > }; > > dpe: dpe@e8600000 { > compatible = "hisilicon,kirin970-dpe"; > ... > iommu_info { > start-addr = <0x8000>; > size = <0xbfff8000>; > }; > }; > > In order to properly address it, the best would be to also have the > DRM driver merged upstream, as it relies on it. So, a change in DT will > also mean a change at the way the DRM uses it. > > The DRM itself should go via staging, as it has some bugs that I'd > like to fix before moving it to drivers/gpu/drm. Those are more > tricky to solve, as they seem to require using different settings for > some hardware registers, and the downstream driver also have the same > issues. Fixing them will likely require some time. DRM drivers can't go through staging unless you get the DRM developers to agree with it, and last I heard, they were strongly against it. It's _always_ faster to just do the work out-of-tree for a week or so and then merge it correctly to the proper part of the kernel tree. I'd recommend doing that here for the iommu driver, as well as the DRM driver. There's no issues with authorship and the like, just properly attribute it when you submit it and you are fine. Again, merging in staging always takes more work and energy, don't do it unless there is no other way. thanks, greg k-h