From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org
Cc: Juergen Gross <jgross@suse.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wl@xen.org>,
Anthony PERARD <anthony.perard@citrix.com>
Subject: [PATCH II v2 06/17] tools: don't assume libxenguest and libxenctrl to be in same directory
Date: Mon, 17 Aug 2020 11:49:11 +0200 [thread overview]
Message-ID: <20200817094922.15768-7-jgross@suse.com> (raw)
In-Reply-To: <20200817094922.15768-1-jgross@suse.com>
There are quite some places in Makefiles assuming libxenguest and
libxenctrl being built in the same directory via a single Makefile.
Drop this assumption by specifying the dependencies and path variables
for both libraries correctly.
Signed-off-by: Juergen Gross <jgross@suse.com>
---
tools/Rules.mk | 7 +++----
tools/libxl/Makefile | 2 +-
tools/misc/Makefile | 1 +
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tools/Rules.mk b/tools/Rules.mk
index b36818bcaa..35d237bba6 100644
--- a/tools/Rules.mk
+++ b/tools/Rules.mk
@@ -31,8 +31,7 @@ LIBS_LIBS += hypfs
USELIBS_hypfs := toollog toolcore call
XEN_libxenctrl = $(XEN_ROOT)/tools/libxc
-# Currently libxenguest lives in the same directory as libxenctrl
-XEN_libxenguest = $(XEN_libxenctrl)
+XEN_libxenguest = $(XEN_ROOT)/tools/libxc
XEN_libxenlight = $(XEN_ROOT)/tools/libxl
# Currently libxlutil lives in the same directory as libxenlight
XEN_libxlutil = $(XEN_libxenlight)
@@ -132,7 +131,7 @@ LDLIBS_libxenguest = $(SHDEPS_libxenguest) $(XEN_libxenguest)/libxenguest$(libex
SHLIB_libxenguest = $(SHDEPS_libxenguest) -Wl,-rpath-link=$(XEN_libxenguest)
CFLAGS_libxenstore = -I$(XEN_libxenstore)/include $(CFLAGS_xeninclude)
-SHDEPS_libxenstore = $(SHLIB_libxentoolcore)
+SHDEPS_libxenstore = $(SHLIB_libxentoolcore) $(SHLIB_libxenctrl)
LDLIBS_libxenstore = $(SHDEPS_libxenstore) $(XEN_libxenstore)/libxenstore$(libextension)
SHLIB_libxenstore = $(SHDEPS_libxenstore) -Wl,-rpath-link=$(XEN_libxenstore)
ifeq ($(CONFIG_Linux),y)
@@ -159,7 +158,7 @@ CFLAGS += -O2 -fomit-frame-pointer
endif
CFLAGS_libxenlight = -I$(XEN_libxenlight) $(CFLAGS_libxenctrl) $(CFLAGS_xeninclude)
-SHDEPS_libxenlight = $(SHLIB_libxenctrl) $(SHLIB_libxenstore) $(SHLIB_libxenhypfs)
+SHDEPS_libxenlight = $(SHLIB_libxenctrl) $(SHLIB_libxenstore) $(SHLIB_libxenhypfs) $(SHLIB_libxenguest)
LDLIBS_libxenlight = $(SHDEPS_libxenlight) $(XEN_libxenlight)/libxenlight$(libextension)
SHLIB_libxenlight = $(SHDEPS_libxenlight) -Wl,-rpath-link=$(XEN_libxenlight)
diff --git a/tools/libxl/Makefile b/tools/libxl/Makefile
index 0e8dfc6193..65f3968947 100644
--- a/tools/libxl/Makefile
+++ b/tools/libxl/Makefile
@@ -188,7 +188,7 @@ libxl_dom.o: CFLAGS += -I$(XEN_ROOT)/tools # include libacpi/x86.h
libxl_x86_acpi.o: CFLAGS += -I$(XEN_ROOT)/tools
SAVE_HELPER_OBJS = libxl_save_helper.o _libxl_save_msgs_helper.o
-$(SAVE_HELPER_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenevtchn)
+$(SAVE_HELPER_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(CFLAGS_libxenevtchn) $(CFLAGS_libxenguest)
PKG_CONFIG = xenlight.pc xlutil.pc
PKG_CONFIG_VERSION := $(MAJOR).$(MINOR)
diff --git a/tools/misc/Makefile b/tools/misc/Makefile
index 9fdb13597f..e7e74db85f 100644
--- a/tools/misc/Makefile
+++ b/tools/misc/Makefile
@@ -6,6 +6,7 @@ CFLAGS += -Werror
CFLAGS += -include $(XEN_ROOT)/tools/config.h
CFLAGS += $(CFLAGS_libxenevtchn)
CFLAGS += $(CFLAGS_libxenctrl)
+CFLAGS += $(CFLAGS_libxenguest)
CFLAGS += $(CFLAGS_xeninclude)
CFLAGS += $(CFLAGS_libxenstore)
--
2.26.2
next prev parent reply other threads:[~2020-08-17 9:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 9:49 [PATCH II v2 00/17] move libxenctrl to tools/libs directory Juergen Gross
2020-08-17 9:49 ` [PATCH II v2 01/17] stubdom: add correct dependencies for Xen libraries Juergen Gross
2020-08-17 10:12 ` Samuel Thibault
2020-08-17 11:07 ` Jürgen Groß
2020-08-17 9:49 ` [PATCH II v2 02/17] tools: drop explicit path specifications for qemu build Juergen Gross
2020-08-17 9:49 ` [PATCH II v2 03/17] tools: tweak tools/libs/libs.mk for being able to support libxenctrl Juergen Gross
2020-08-17 9:49 ` [PATCH II v2 04/17] tools/python: drop libxenguest from setup.py Juergen Gross
2020-08-17 9:49 ` [PATCH II v2 05/17] tools: fix pkg-config file for libxenguest Juergen Gross
2020-08-17 9:49 ` Juergen Gross [this message]
2020-08-17 9:49 ` [PATCH II v2 07/17] tools/misc: don't use libxenctrl internals from xen-hptool Juergen Gross
2020-08-17 9:49 ` [PATCH II v2 08/17] tools/misc: don't include xg_save_restore.h from xen-mfndump.c Juergen Gross
2020-08-17 9:49 ` [PATCH II v2 09/17] tools/misc: replace PAGE_SIZE with XC_PAGE_SIZE in xen-mfndump.c Juergen Gross
2020-08-17 9:49 ` [PATCH II v2 10/17] tools/misc: drop all libxc internals from xen-mfndump.c Juergen Gross
2020-08-17 9:49 ` [PATCH II v2 11/17] tools/libxc: remove unused headers xc_efi.h and xc_elf.h Juergen Gross
2020-08-17 9:49 ` [PATCH II v2 12/17] tools/libxc: move xc_[un]map_domain_meminfo() into new source xg_domain.c Juergen Gross
2020-08-17 9:49 ` [PATCH II v2 13/17] tools/libxc: rename all libxenguest sources to xg_* Juergen Gross
2020-08-17 9:49 ` [PATCH II v2 14/17] tools/libxc: rename libxenguest internal headers Juergen Gross
2020-08-17 9:49 ` [PATCH II v2 15/17] tools/misc: rename xc_dom.h do xenctrl_dom.h Juergen Gross
2020-08-17 9:49 ` [PATCH II v2 16/17] tools/libxc: untangle libxenctrl from libxenguest Juergen Gross
2020-08-17 9:49 ` [PATCH II v2 17/17] tools: move libxenctrl below tools/libs Juergen Gross
2020-08-17 10:17 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817094922.15768-7-jgross@suse.com \
--to=jgross@suse.com \
--cc=anthony.perard@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.