From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3 3/3] block: rename blk_discard_mergable as blk_discard_support_multi_range
Date: Mon, 17 Aug 2020 12:14:41 +0200 [thread overview]
Message-ID: <20200817101441.GA25336@lst.de> (raw)
In-Reply-To: <20200817095241.2494763-4-ming.lei@redhat.com>
On Mon, Aug 17, 2020 at 05:52:41PM +0800, Ming Lei wrote:
> Name of blk_discard_mergable() is very confusing, and this function
> actually means if the queue supports multi_range discard. Also there
> are two kinds of discard merge:
>
> 1) multi range discard, bios in one request won't have to be contiguous,
> and actually each bio is thought as one range
>
> 2) single range discard, all bios in one request have to be contiguous
> just like normal RW request's merge
>
> Rename blk_discard_mergable() for not confusing people, and avoiding
> to introduce bugs in future.
I agree the current name is not good, but I find the new one pretty
clumsy too. Not sure the rename is worth it, but also no strict NAK
from me.
next prev parent reply other threads:[~2020-08-17 10:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 9:52 [PATCH V3 0/3] block: fix discard merge for single max discard segment Ming Lei
2020-08-17 9:52 ` [PATCH V3 1/3] block: respect queue limit of " Ming Lei
2020-08-17 9:52 ` [PATCH V3 2/3] block: virtio_blk: fix handling single range discard request Ming Lei
2020-08-18 13:52 ` Stefan Hajnoczi
2020-08-17 9:52 ` [PATCH V3 3/3] block: rename blk_discard_mergable as blk_discard_support_multi_range Ming Lei
2020-08-17 10:14 ` Christoph Hellwig [this message]
2020-08-17 14:00 ` [PATCH V3 0/3] block: fix discard merge for single max discard segment Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817101441.GA25336@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.