From: Oleg Nesterov <oleg@redhat.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: akpm@linux-foundation.org, axboe@kernel.dk,
linux-kernel@vger.kernel.org, Greg Thelen <gthelen@google.com>,
Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 2/2] block: fix ioprio_get/set(IOPRIO_WHO_PGRP) vs setuid(2)
Date: Mon, 17 Aug 2020 16:09:42 +0200 [thread overview]
Message-ID: <20200817140942.GD29865@redhat.com> (raw)
In-Reply-To: <20200817003148.23691-3-dave@stgolabs.net>
On 08/16, Davidlohr Bueso wrote:
>
> --- a/block/ioprio.c
> +++ b/block/ioprio.c
> @@ -119,11 +119,13 @@ SYSCALL_DEFINE3(ioprio_set, int, which, int, who, int, ioprio)
> pgrp = task_pgrp(current);
> else
> pgrp = find_vpid(who);
> + read_lock(&tasklist_lock);
> do_each_pid_thread(pgrp, PIDTYPE_PGID, p) {
> ret = set_task_ioprio(p, ioprio);
> if (ret)
> break;
> } while_each_pid_thread(pgrp, PIDTYPE_PGID, p);
> + read_unlock(&tasklist_lock);
> break;
> case IOPRIO_WHO_USER:
> uid = make_kuid(current_user_ns(), who);
> @@ -207,6 +209,7 @@ SYSCALL_DEFINE2(ioprio_get, int, which, int, who)
> pgrp = task_pgrp(current);
> else
> pgrp = find_vpid(who);
> + read_lock(&tasklist_lock);
> do_each_pid_thread(pgrp, PIDTYPE_PGID, p) {
> tmpio = get_task_ioprio(p);
> if (tmpio < 0)
> @@ -216,6 +219,7 @@ SYSCALL_DEFINE2(ioprio_get, int, which, int, who)
> else
> ret = ioprio_best(ret, tmpio);
> } while_each_pid_thread(pgrp, PIDTYPE_PGID, p);
> + read_unlock(&tasklist_lock);
Acked-by: Oleg Nesterov <oleg@redhat.com>
next prev parent reply other threads:[~2020-08-17 14:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 0:31 [PATCH -next 0/2] tasklist_lock vs get/set priority syscalls Davidlohr Bueso
2020-08-17 0:31 ` [PATCH 1/2] kernel/sys: only take tasklist_lock for get/setpriority(PRIO_PGRP) Davidlohr Bueso
2020-08-17 14:10 ` Oleg Nesterov
2020-08-17 0:31 ` [PATCH 2/2] block: fix ioprio_get/set(IOPRIO_WHO_PGRP) vs setuid(2) Davidlohr Bueso
2020-08-17 14:09 ` Oleg Nesterov [this message]
2020-08-17 14:12 ` Jens Axboe
2020-09-04 22:39 ` [PATCH -next 0/2] tasklist_lock vs get/set priority syscalls Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817140942.GD29865@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=dave@stgolabs.net \
--cc=dbueso@suse.de \
--cc=gthelen@google.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.