From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6DADC433E1 for ; Mon, 17 Aug 2020 19:05:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C2B02076E for ; Mon, 17 Aug 2020 19:05:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597691102; bh=sBUCv5w3lNjKLqyJWKSVBjVv87IacI3e30a6X4QqE6w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=HVR//vsc1xy4pqwfTOdVGjvSM0X6CxhU00jlaUyHjCuR4kowOYbr1D9Sb5njv1cxu +Ep0yX40424Xtdx9FBPvoj2c398nEymfTn6JHqqJT8Zxzj6jyjDw1IxkM8IpohOnZp hwsetvXlEPYC8XjIkR9iw05hxzyK/421+wNu/A2A= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389880AbgHQTE5 (ORCPT ); Mon, 17 Aug 2020 15:04:57 -0400 Received: from mail-ej1-f67.google.com ([209.85.218.67]:41785 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730618AbgHQPp0 (ORCPT ); Mon, 17 Aug 2020 11:45:26 -0400 Received: by mail-ej1-f67.google.com with SMTP id t10so18278770ejs.8; Mon, 17 Aug 2020 08:45:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=88NsSfMcBydVtMdxoydTDCkwKyXtq2TXNnD+2/bVGE0=; b=Jafkq9PPkG1zkZN6RAB54JHNcKYZvbiTZjQswfkCRrI8IOa2GEQr6RRASL9kGvdgiL bmli8G8wVuP6URqwOb+BY4imLLXLLGxJp9Y1+UQtBVWuCcU9/lZjMF2pmVbM06UBTZbf Dq7nhknCdaXCF5N0fhN+k5F8AVUaR1MJHQHPRLI40ez7uJfL7uJaIayxwcZSlkc1cXuO cCZGh8vNEkigwC3WZGmARUcb8XJh4b5MktgTxY1Kj/94FOVs9qr7JkVoj7i2OD7TW5h/ 2CXw0N4deO9/RMUw405l/HpHlT8tX2SU27FAR2jYQsRtAT7DMP9QcdC0sxrKiojR4/Tl LG5Q== X-Gm-Message-State: AOAM531X+jvynh68dYEE0m29e8TBGHKe0qfX7x6tmkCLbFpoC44vWL0q 7VlLE/dTyEinS0SeEHVGn/U= X-Google-Smtp-Source: ABdhPJxhZ268mQwED+RocFeuapgWW+9IdkMyvpMZGdBWtySWhBhqmYB3SPqu8gQUSnqzUJrm7lL6yA== X-Received: by 2002:a17:906:228a:: with SMTP id p10mr15557518eja.23.1597679124911; Mon, 17 Aug 2020 08:45:24 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id s18sm14671616ejd.54.2020.08.17.08.45.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Aug 2020 08:45:24 -0700 (PDT) Date: Mon, 17 Aug 2020 17:45:22 +0200 From: Krzysztof Kozlowski To: Qinglang Miao Cc: Kukjin Kim , Greg Kroah-Hartman , Russell King , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] ARM: s3c: fix return value check in s3c_usb_otgphy_init() Message-ID: <20200817154522.GA15887@kozik-lap> References: <20200728022756.87687-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200728022756.87687-1-miaoqinglang@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Tue, Jul 28, 2020 at 10:27:56AM +0800, Qinglang Miao wrote: > the function clk_get() returns ERR_PTR() in case of error and > never returns NULL. So there's no need to test whether xusbxti > is NULL, just remove the redundant part in the return value check. > > Signed-off-by: Qinglang Miao > --- > arch/arm/mach-s3c64xx/setup-usb-phy.c | 2 +- Thanks, applied. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2944EC433E1 for ; Mon, 17 Aug 2020 15:46:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEA422173E for ; Mon, 17 Aug 2020 15:46:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="COgOtjGb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEA422173E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LeyZ2jPS5JuIKYN91bJCw2hXh7OQQ99wnip6108TQxI=; b=COgOtjGb/Wf89RAt6aUnLet/k 03NX/FSv83HoljLzSpMq7Ev87Nsa4j+IZeR7sJk9vVS0Gy791ccYXrICgHKQ2ZVR9/+35e2VgVVaV S3YtkeeUXT171KTgkvuZIIgkZ6Akpiz8RJua7fHeeALNVpqQonq80P3N0Kl6d65bbbpOrPaBN+h1U decDX2YSsc4lzaspyPwkbP4f1BuV2qM/Xy1aEMbMmzqm6yR5WFAZgHcnoT7ELJxhNtnhN1NwxfQVX wcWKlOIHflMi5vf6SVNEKuglUUudk9ABdjfNSLblvgtVTJHybIPx5FoY3skLmi7Uz5yNxs6HitVX4 6kmdfCtqQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7hKC-0001f9-DZ; Mon, 17 Aug 2020 15:45:28 +0000 Received: from mail-ej1-f65.google.com ([209.85.218.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7hKA-0001eI-1J for linux-arm-kernel@lists.infradead.org; Mon, 17 Aug 2020 15:45:26 +0000 Received: by mail-ej1-f65.google.com with SMTP id bo3so18249610ejb.11 for ; Mon, 17 Aug 2020 08:45:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=88NsSfMcBydVtMdxoydTDCkwKyXtq2TXNnD+2/bVGE0=; b=kR2NOVCFof/RTORqJShHMLD7vPQoW5wJVOuqC2kYgHKHRrK12nVT4DRXEn3a181czO dgv+tld0hZ/VINIm7f/vsAWLwg7dSbRDyDEDA6dg9IaCtOsXuxoDRQbHZhQh1UnKcmgo IxlI/W5wiF0Key+iwIk+YVVOGia6Z//mhSNJvqok3Ud/u/KGHrLefZaZObTynRHNvHk4 jxQW1EBFUt8MDAtGhXUm1CjJgD3YRNgtqVWQ3MjEkZSM6mP779vGpY43vRc29CuEWikj fzafYSy6z529ffgMj514DVrjdvCEhSxcG6vBD5xn2TAibklecbA43XlcQC264Wx81gVh l60Q== X-Gm-Message-State: AOAM530MY+vdosMTRuSYTDOVuBCXha8wK14pxPBktHVU9D0/VxCZJM6m Ane2gN9geW4Wn96nd4zspFg= X-Google-Smtp-Source: ABdhPJxhZ268mQwED+RocFeuapgWW+9IdkMyvpMZGdBWtySWhBhqmYB3SPqu8gQUSnqzUJrm7lL6yA== X-Received: by 2002:a17:906:228a:: with SMTP id p10mr15557518eja.23.1597679124911; Mon, 17 Aug 2020 08:45:24 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id s18sm14671616ejd.54.2020.08.17.08.45.23 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Aug 2020 08:45:24 -0700 (PDT) Date: Mon, 17 Aug 2020 17:45:22 +0200 From: Krzysztof Kozlowski To: Qinglang Miao Subject: Re: [PATCH -next] ARM: s3c: fix return value check in s3c_usb_otgphy_init() Message-ID: <20200817154522.GA15887@kozik-lap> References: <20200728022756.87687-1-miaoqinglang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200728022756.87687-1-miaoqinglang@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_114526_099198_82463CD6 X-CRM114-Status: GOOD ( 13.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Greg Kroah-Hartman , Russell King , linux-kernel@vger.kernel.org, Kukjin Kim , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 28, 2020 at 10:27:56AM +0800, Qinglang Miao wrote: > the function clk_get() returns ERR_PTR() in case of error and > never returns NULL. So there's no need to test whether xusbxti > is NULL, just remove the redundant part in the return value check. > > Signed-off-by: Qinglang Miao > --- > arch/arm/mach-s3c64xx/setup-usb-phy.c | 2 +- Thanks, applied. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel