From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4075C433E3 for ; Mon, 17 Aug 2020 18:00:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B522E2072E for ; Mon, 17 Aug 2020 18:00:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernelim-com.20150623.gappssmtp.com header.i=@kernelim-com.20150623.gappssmtp.com header.b="EMVxgntA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730887AbgHQSAM (ORCPT ); Mon, 17 Aug 2020 14:00:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388523AbgHQQKB (ORCPT ); Mon, 17 Aug 2020 12:10:01 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C997C061389 for ; Mon, 17 Aug 2020 09:10:01 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id r2so15558122wrs.8 for ; Mon, 17 Aug 2020 09:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelim-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=KWgT+MkZBcT1UMKwsraLbtIa27PJ9W0Vx5f5FJefoXQ=; b=EMVxgntAVCRBuIkO1uTA47j/IaafY8IzQQoN+HSEiJR7hNW+4FPgNI+KGhHAVQGbn3 iTo399mvZKxPx5RKA6ASxwkaFbYf77DwdFrwi9Aqq0JKYKBrji9BATTb5tAUynVFBQ7k V8NQ/+1wHv1lHq1zVAlng7YCky/lEP+vxvMZyVUtZScFSZmEkGEg+oiWmVZcum2qmKa+ qesISlmi6NzsWXwjeW+a5rdz+5Yrzo6RbDEuFrkobdiINRkmc+ATGW1csYXbxwgOzZ1U cHJDqrmVSq+1G42VTZRHoCRmS22c04XG+mNgfkjppA+HWwKSe0S2WXcgYcF97QBzti/l qQBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=KWgT+MkZBcT1UMKwsraLbtIa27PJ9W0Vx5f5FJefoXQ=; b=A0XrYzmS1IC0DBALGL/oO2U4JB/IHOXEHBDpm9YC4q3es+ED1E75F1Th9iKh2b0BA0 XtpPqJq7dnGrYLyzHHicsG58t6WWo/5+ftY0zkhjXJQLRIbKlS7WEMy+Gb+Xg7/mkfp0 fbRH76xYLOOna8qyy/wKhM+/0fZmRKjK3bQCSArxd3ghpaZC/InSU0vpjZFksotagRfN aZ6WV2jQpdw81uGaK158znhWK2MGiC2tC0y2/jYv2BXOYqQmP04/XMf5FwDASqd1JoCc h96+GmxDV1J4MHiozKspCSJEX/WnJzdiHQYs2OC6CAGHmXUP2f2eBdcUHlnMcnB9DAra uoXQ== X-Gm-Message-State: AOAM530wEiy3V9zOAaCq2uJv5ZWzQzLRZxcmtL1zxZ2Lga71cXUvlTKj fEtQBQj7Bjlhr2P1CEsi5FGtUA== X-Google-Smtp-Source: ABdhPJyy1+KdcX4VSXCJMIyyC50G4eN5wC9OX6EF2Ks3eu03dZlt0KpRbsMvWnTls1L1f05FjipkyA== X-Received: by 2002:adf:f011:: with SMTP id j17mr7171121wro.335.1597680600015; Mon, 17 Aug 2020 09:10:00 -0700 (PDT) Received: from gmail.com ([141.226.169.176]) by smtp.gmail.com with ESMTPSA id z8sm28679076wmf.10.2020.08.17.09.09.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 09:09:59 -0700 (PDT) Date: Mon, 17 Aug 2020 19:09:56 +0300 From: Dan Aloni To: Chuck Lever Cc: linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH RFC] xprtrdma: Release in-flight MRs on disconnect Message-ID: <20200817160956.GA3516778@gmail.com> References: <159767751439.190071.13659900216337230912.stgit@manet.1015granger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <159767751439.190071.13659900216337230912.stgit@manet.1015granger.net> Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Aug 17, 2020 at 11:19:26AM -0400, Chuck Lever wrote: > Dan Aloni reports that when a server disconnects abruptly, a few > memory regions are left DMA mapped. Over time this leak could pin > enough I/O resources to slow or even deadlock an NFS/RDMA client. > > I found that if a transport disconnects before pending Send and > FastReg WRs can be posted, the to-be-registered MRs are stranded on > the req's rl_registered list and never released -- since they > weren't posted, there's no Send completion to DMA unmap them. > > Reported-by: Dan Aloni > Signed-off-by: Chuck Lever > --- > net/sunrpc/xprtrdma/verbs.c | 2 ++ > 1 file changed, 2 insertions(+) > > Hi Dan, does this help? Yeah, works as expected with your fix. Thanks! -- Dan Aloni