All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v2 2/8] resource: Simplify region_intersects() by reducing conditionals
Date: Mon, 17 Aug 2020 19:36:41 +0300	[thread overview]
Message-ID: <20200817163647.48982-2-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20200817163647.48982-1-andriy.shevchenko@linux.intel.com>

Now we have for 'other' and 'type' variables

other	type	return
  0	  0	REGION_DISJOINT
  0	  x	REGION_INTERSECTS
  x	  0	REGION_DISJOINT
  x	  x	REGION_MIXED

Obviously it's easier to check 'type' for 0 first instead of
currently checked 'other'.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: converted ternary to usual if-cond (Rafael)
 kernel/resource.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/kernel/resource.c b/kernel/resource.c
index 841737bbda9e..be134bd5d82e 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -554,13 +554,13 @@ int region_intersects(resource_size_t start, size_t size, unsigned long flags,
 	}
 	read_unlock(&resource_lock);
 
-	if (other == 0)
-		return type ? REGION_INTERSECTS : REGION_DISJOINT;
+	if (type == 0)
+		return REGION_DISJOINT;
 
-	if (type)
-		return REGION_MIXED;
+	if (other == 0)
+		return REGION_INTERSECTS;
 
-	return REGION_DISJOINT;
+	return REGION_MIXED;
 }
 EXPORT_SYMBOL_GPL(region_intersects);
 
-- 
2.28.0


  reply	other threads:[~2020-08-17 16:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17 16:36 [PATCH v2 1/8] kernel.h: Split out min()/max() et al. helpers Andy Shevchenko
2020-08-17 16:36 ` Andy Shevchenko [this message]
2020-08-17 16:36 ` [PATCH v2 3/8] resource: Group resource_overlaps() with other inline helpers Andy Shevchenko
2020-08-17 16:36 ` [PATCH v2 4/8] resource: Introduce resource_union() for overlapping resources Andy Shevchenko
2020-08-17 16:36 ` [PATCH v2 5/8] resource: Introduce resource_intersection() " Andy Shevchenko
2020-08-17 16:36 ` [PATCH v2 6/8] PCI/ACPI: Replace open coded variant of resource_union() Andy Shevchenko
2020-08-17 16:36 ` [PATCH v2 7/8] PCI/ACPI: Fix description of @handle for acpi_is_root_bridge() Andy Shevchenko
2020-08-17 16:36 ` [PATCH v2 8/8] ACPI: watchdog: Replace open coded variant of resource_union() Andy Shevchenko
2020-08-17 16:54   ` Mika Westerberg
2020-08-27 11:44 ` [PATCH v2 1/8] kernel.h: Split out min()/max() et al. helpers Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200817163647.48982-2-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.