From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 021EAC433E1 for ; Mon, 17 Aug 2020 16:19:21 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B398A204FD for ; Mon, 17 Aug 2020 16:19:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CEeHJ1Tf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B398A204FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k7hqx-0001rq-Ot for qemu-devel@archiver.kernel.org; Mon, 17 Aug 2020 12:19:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39978) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k7hjH-0004cx-Nd for qemu-devel@nongnu.org; Mon, 17 Aug 2020 12:11:23 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:54111 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k7hjF-0003ty-T1 for qemu-devel@nongnu.org; Mon, 17 Aug 2020 12:11:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597680679; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zRtVzmcg/sTPxc1akNVn/FTJeH9RfRchNbBC1k5yRxg=; b=CEeHJ1TfwawmXvkVDWpRIQnS0W7bsz6yEapJ56pgbgGsFOcC4eyTXnbdBOR+t9+f4Ez6uZ 6zaOBKkfqzCXTJeYNxVfLMigFtbc2b2DTuF+3fKIxBpYNdYlaGAFHX2VJ7oAzUjQr7O/Zn bWMDXSx0Q6mkv1/3z6YshShW6fCMIlA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-170-IZ6QEqAhP2SB6R3ZEmIuuQ-1; Mon, 17 Aug 2020 12:11:17 -0400 X-MC-Unique: IZ6QEqAhP2SB6R3ZEmIuuQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AF1E618551B0; Mon, 17 Aug 2020 16:11:15 +0000 (UTC) Received: from gondolin (ovpn-112-230.ams2.redhat.com [10.36.112.230]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8C00410098A5; Mon, 17 Aug 2020 16:11:10 +0000 (UTC) Date: Mon, 17 Aug 2020 18:11:08 +0200 From: Cornelia Huck To: Pan Nengyuan Subject: Re: [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group() Message-ID: <20200817181108.6c5daebd.cohuck@redhat.com> In-Reply-To: <20200814160241.7915-3-pannengyuan@huawei.com> References: <20200814160241.7915-1-pannengyuan@huawei.com> <20200814160241.7915-3-pannengyuan@huawei.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=cohuck@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/17 05:13:21 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tony Krowiak , Thomas Huth , zhang.zhanghailiang@huawei.com, Pierre Morel , qemu-s390x@nongnu.org, qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , Alex Williamson , euler.robot@huawei.com, kuhn.chenqun@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 14 Aug 2020 12:02:31 -0400 Pan Nengyuan wrote: > Missing g_error_free() in vfio_ap_get_group() error path. Fix that. > > Reported-by: Euler Robot > Signed-off-by: Pan Nengyuan > --- > Cc: Cornelia Huck > Cc: Thomas Huth > Cc: Christian Borntraeger > Cc: Tony Krowiak > Cc: Halil Pasic > Cc: Pierre Morel > Cc: Alex Williamson > Cc: qemu-s390x@nongnu.org > --- > hw/vfio/ap.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c > index b9330a8e6f..cec6fe1599 100644 > --- a/hw/vfio/ap.c > +++ b/hw/vfio/ap.c > @@ -71,6 +71,7 @@ static VFIOGroup *vfio_ap_get_group(VFIOAPDevice *vapdev, Error **errp) > if (!group_path) { > error_setg(errp, "%s: no iommu_group found for %s: %s", > VFIO_AP_DEVICE_TYPE, vapdev->vdev.sysfsdev, gerror->message); > + g_error_free(gerror); > return NULL; > } > Thanks, applied.