From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C461C433E4 for ; Mon, 17 Aug 2020 18:32:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 756F42053B for ; Mon, 17 Aug 2020 18:32:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BqZ0tu4Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 756F42053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=odJH0Yav2Q8GSdQFBr5n8TJTZLUHnq8d3G+8nth+o2A=; b=BqZ0tu4Q5PSMjESOzD5il48si xWxJ87O6UwzXtb2tukx9C7nCzTdYfkbCNEPYLQQMg5yO9ROl2wnlSnmYt8I97mbkag3UfWBXo8RAs FJNt2x0qGBMG7EFNJwyEUxNNhqbkqJP92Pc9fXeUEZMGYdfkQQA67LeauGbO8yq13dSOv7G0OW3kJ n+Mg0rzy51P5MeOW0oQeKL91SOkn8ImUgD7XmNXGjAbWnH7KaqdaU1Q7CXObLlk/f6Vy0gStxpDSn QAH2icSdDJt/YMOht0uR95V4HVDEyxg3FIyLzPBBY3GC2dbT1PF3nOZ0gDgzy2yMEMcKTRHbnXKSL ER7/sXbqw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7jvt-0007Dl-Bk; Mon, 17 Aug 2020 18:32:33 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7jvm-0007CI-V3; Mon, 17 Aug 2020 18:32:27 +0000 Received: by mail-ed1-f66.google.com with SMTP id i26so13118945edv.4; Mon, 17 Aug 2020 11:32:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RjGzQA0sj9LgMuBKGfdljJoHuJrThb6OxdJKZW4mtwQ=; b=c5BFeuCTEx8cqOCC7FcUrsndd0075E9pQcNKI5z90ifIHVpxFfIbqtOD8+QbmHUeWn D95uIJbmJ+JMOyYqVwEu/ke9mGiNDZPWw2fg3pPrarVQRplRWWvyNIZPrVIrIgDG5WbP /YfcyD/ZqXi/rP+h1XgFMPRyw6MOlDt7DTjbTkofQDX3sfWKtkGYfm0CucDGiLLMbUpA Bhq+m43icHQgdzcM15wmhn/exJhuw+Md+j27z2t35xAq9x5ChVECnG47a0EoTIeDAKHs djp+/GXo49jYtOu8xLnBSqbs8jt7f/WEoW/M1S9hqCL6swmy2WcvdtT13OeFfHfdtLUM DxdQ== X-Gm-Message-State: AOAM532+s+glb6qVuQMO/3frlFDwEo0aDg26PIKt99JhmDWa7CmSkqRc 4Wxu/L/gd1xeoWz0QX8BeVk= X-Google-Smtp-Source: ABdhPJx9SUZGr2fbcqQFiUQhvkRu1lcumoJycjlLpHc32PzeyqMQGfQ7Wto1oEAieJGVwl6Ll2Ot+Q== X-Received: by 2002:aa7:c382:: with SMTP id k2mr15730132edq.249.1597689144539; Mon, 17 Aug 2020 11:32:24 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id q11sm14191537edn.12.2020.08.17.11.32.22 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Aug 2020 11:32:23 -0700 (PDT) Date: Mon, 17 Aug 2020 20:32:21 +0200 From: Krzysztof Kozlowski To: Arnd Bergmann , Olof Johansson , Markus Mayer , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , Santosh Shilimkar , Matthias Brugger , Roger Quadros , Tony Lindgren , Vladimir Zapolskiy , Kukjin Kim , Thierry Reding , Jonathan Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [RFT v2 20/29] memory: omap-gpmc: Return meaningful error codes in gpmc_cs_set_timings() Message-ID: <20200817183221.GC3464@kozik-lap> References: <20200724074038.5597-1-krzk@kernel.org> <20200724074038.5597-21-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200724074038.5597-21-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_143227_093561_5EA1997F X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Morton , Linus Torvalds Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, Jul 24, 2020 at 09:40:29AM +0200, Krzysztof Kozlowski wrote: > The callers of gpmc_cs_set_timings() expect to receive -ERRNO on errors > and they pass further what they have received. > > However gpmc_cs_set_timings() was returning -1 (equal to -EPERM) which > does not make sense in this context. > > Signed-off-by: Krzysztof Kozlowski > > --- Applied to drivers/memory tree. Best regards, Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD96AC433DF for ; Mon, 17 Aug 2020 18:32:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB46B20758 for ; Mon, 17 Aug 2020 18:32:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597689170; bh=Q+RvkdmTvZDKiQcZ2Ybj6pkL9qnBbcF5is3kGGgZqJE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Hl86yIu8DRjH/QtkgM91ZyHLlMIlK97cAsC6lDqI1T2thLQ6aiuJkemLBL/Foy5u6 uYgUIM3ur3JMKyPkJt5Hna49phUVb1EJILtEQbLXV+innArMOKHYoJkQdRfAQ/32du G9wjAahHelKmHcMFQqX2pFUK0/bnuydy0BsT+q0Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388179AbgHQScl (ORCPT ); Mon, 17 Aug 2020 14:32:41 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:40834 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391139AbgHQSc0 (ORCPT ); Mon, 17 Aug 2020 14:32:26 -0400 Received: by mail-ed1-f67.google.com with SMTP id a14so13121322edx.7; Mon, 17 Aug 2020 11:32:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RjGzQA0sj9LgMuBKGfdljJoHuJrThb6OxdJKZW4mtwQ=; b=NQDjUucxYNwwzfwMzIBnm5U6c+f3EFuNB/gCWWQjCrUCB0prnKeItuc6jVEsbcmbCh o+7TEEYK0klpVpktK82Zqf0LjUUFuHf8uVzinHRRjy/6++ITNJR2lq1t39wa0qKi+FRL 88/4IRqY9UhsHIZubDSP8ZgraqTWCLV/XWndHFgncTt3YQ9EIRGrHZh9nM2T+uvBzui2 4LLpdeUQSm4tbf7P6Gsj3bHDWxPHNS4IZbGEoGUuR5MfJYwyiVLbmrI9iQXL3rUpAL3u X7IPCngjzw5GdjpXjreHNZqTMBY0af9Z0pJS1yhEd0Y+yQkeBTDQItG5h/yCfJD/rGD7 KjDA== X-Gm-Message-State: AOAM531L0gOkJdn3esy1ppL678aI4P6qFgkWP3EKHKczSF1f6BAvwZQl JKq9xmSaVfHVYGEt78tvTGI= X-Google-Smtp-Source: ABdhPJx9SUZGr2fbcqQFiUQhvkRu1lcumoJycjlLpHc32PzeyqMQGfQ7Wto1oEAieJGVwl6Ll2Ot+Q== X-Received: by 2002:aa7:c382:: with SMTP id k2mr15730132edq.249.1597689144539; Mon, 17 Aug 2020 11:32:24 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id q11sm14191537edn.12.2020.08.17.11.32.22 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Aug 2020 11:32:23 -0700 (PDT) Date: Mon, 17 Aug 2020 20:32:21 +0200 From: Krzysztof Kozlowski To: Arnd Bergmann , Olof Johansson , Markus Mayer , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , Santosh Shilimkar , Matthias Brugger , Roger Quadros , Tony Lindgren , Vladimir Zapolskiy , Kukjin Kim , Thierry Reding , Jonathan Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org Cc: Andrew Morton , Linus Torvalds Subject: Re: [RFT v2 20/29] memory: omap-gpmc: Return meaningful error codes in gpmc_cs_set_timings() Message-ID: <20200817183221.GC3464@kozik-lap> References: <20200724074038.5597-1-krzk@kernel.org> <20200724074038.5597-21-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200724074038.5597-21-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Fri, Jul 24, 2020 at 09:40:29AM +0200, Krzysztof Kozlowski wrote: > The callers of gpmc_cs_set_timings() expect to receive -ERRNO on errors > and they pass further what they have received. > > However gpmc_cs_set_timings() was returning -1 (equal to -EPERM) which > does not make sense in this context. > > Signed-off-by: Krzysztof Kozlowski > > --- Applied to drivers/memory tree. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE933C433DF for ; Mon, 17 Aug 2020 18:33:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C58402053B for ; Mon, 17 Aug 2020 18:33:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tjMNU8hd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C58402053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+xngchZ4vjQqW3frIRl7ZvnPkTFLOLSCTEULUXmPd9k=; b=tjMNU8hdetW06faSHviCINvfu Hu5KuiKTHq2Yk7bMQwQ7IvFS392eBQNoMppX9rDL4xpQIF5oNf8t8UQs7h/FkyjTIyru41TxL4Oo/ h1NhUB3n1sfpVz7+f+dCmSyI8tUoiKwYb4KJAmrI8ypwc8omRm12z06iel8UD+stANdeD/fh0sU8f 3BRHgxHhgkmqoB5PNFFBZGPX8gWcNz8+GGbWwqKmxLK0jq9AOe0LhfRCb6PCY6GW9fjFTdFyYGHWg rlZ8zj+Yw8Wlibpr/CsiqLoGeFM0+8/U/OxO1KbkTJGDI4OR5qgCrvXKnQ3lpwQqfqZMHGHsemvKB r87JFpgkQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7jvq-0007D7-07; Mon, 17 Aug 2020 18:32:30 +0000 Received: from mail-ed1-f66.google.com ([209.85.208.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k7jvm-0007CI-V3; Mon, 17 Aug 2020 18:32:27 +0000 Received: by mail-ed1-f66.google.com with SMTP id i26so13118945edv.4; Mon, 17 Aug 2020 11:32:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RjGzQA0sj9LgMuBKGfdljJoHuJrThb6OxdJKZW4mtwQ=; b=c5BFeuCTEx8cqOCC7FcUrsndd0075E9pQcNKI5z90ifIHVpxFfIbqtOD8+QbmHUeWn D95uIJbmJ+JMOyYqVwEu/ke9mGiNDZPWw2fg3pPrarVQRplRWWvyNIZPrVIrIgDG5WbP /YfcyD/ZqXi/rP+h1XgFMPRyw6MOlDt7DTjbTkofQDX3sfWKtkGYfm0CucDGiLLMbUpA Bhq+m43icHQgdzcM15wmhn/exJhuw+Md+j27z2t35xAq9x5ChVECnG47a0EoTIeDAKHs djp+/GXo49jYtOu8xLnBSqbs8jt7f/WEoW/M1S9hqCL6swmy2WcvdtT13OeFfHfdtLUM DxdQ== X-Gm-Message-State: AOAM532+s+glb6qVuQMO/3frlFDwEo0aDg26PIKt99JhmDWa7CmSkqRc 4Wxu/L/gd1xeoWz0QX8BeVk= X-Google-Smtp-Source: ABdhPJx9SUZGr2fbcqQFiUQhvkRu1lcumoJycjlLpHc32PzeyqMQGfQ7Wto1oEAieJGVwl6Ll2Ot+Q== X-Received: by 2002:aa7:c382:: with SMTP id k2mr15730132edq.249.1597689144539; Mon, 17 Aug 2020 11:32:24 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id q11sm14191537edn.12.2020.08.17.11.32.22 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Aug 2020 11:32:23 -0700 (PDT) Date: Mon, 17 Aug 2020 20:32:21 +0200 From: Krzysztof Kozlowski To: Arnd Bergmann , Olof Johansson , Markus Mayer , bcm-kernel-feedback-list@broadcom.com, Florian Fainelli , Santosh Shilimkar , Matthias Brugger , Roger Quadros , Tony Lindgren , Vladimir Zapolskiy , Kukjin Kim , Thierry Reding , Jonathan Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [RFT v2 20/29] memory: omap-gpmc: Return meaningful error codes in gpmc_cs_set_timings() Message-ID: <20200817183221.GC3464@kozik-lap> References: <20200724074038.5597-1-krzk@kernel.org> <20200724074038.5597-21-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200724074038.5597-21-krzk@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200817_143227_093561_5EA1997F X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Morton , Linus Torvalds Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 24, 2020 at 09:40:29AM +0200, Krzysztof Kozlowski wrote: > The callers of gpmc_cs_set_timings() expect to receive -ERRNO on errors > and they pass further what they have received. > > However gpmc_cs_set_timings() was returning -1 (equal to -EPERM) which > does not make sense in this context. > > Signed-off-by: Krzysztof Kozlowski > > --- Applied to drivers/memory tree. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel