From: "hch@lst.de" <hch@lst.de>
To: "Engel, Amit" <Amit.Engel@Dell.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"hch@lst.de" <hch@lst.de>
Subject: Re: keep-alive timeout zero value
Date: Tue, 18 Aug 2020 08:33:52 +0200 [thread overview]
Message-ID: <20200818063352.GE1754@lst.de> (raw)
In-Reply-To: <MN2PR19MB30052F070D1839045AB6468DEE5F0@MN2PR19MB3005.namprd19.prod.outlook.com>
On Mon, Aug 17, 2020 at 04:19:36PM +0000, Engel, Amit wrote:
> Hi,
>
> keep-alive timeout is allowed (by spec) to be set to 0h
> In this case, the timer will be started ('nvmet_start_keep_alive_timer') where ctrl->kato = 0.
> This will lead to an immediate timer expiration
>
> We thought that in case of a zero keep alive timeout,
> ctrl->kato should be set to a default NVMET_DISC_KATO value
> (core.c , 'nvmet_alloc_ctrl')
> this way we will avoid stating the timer with a zero timeout value
> (This is correct for both NVME_NQN_DISC and NVME_NQN_NVME)
>
> What are your thoughts?
Yes. Can you send a patch?
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
prev parent reply other threads:[~2020-08-18 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 16:19 keep-alive timeout zero value Engel, Amit
2020-08-18 6:33 ` hch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818063352.GE1754@lst.de \
--to=hch@lst.de \
--cc=Amit.Engel@Dell.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.