All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bastien Nocera <hadess@hadess.net>
Cc: linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH v7 1/3] USB: Also check for ->match
Date: Tue, 18 Aug 2020 11:00:37 +0200	[thread overview]
Message-ID: <20200818090037.GC28036@kroah.com> (raw)
In-Reply-To: <20200804113834.6409-1-hadess@hadess.net>

On Tue, Aug 04, 2020 at 01:38:32PM +0200, Bastien Nocera wrote:
> We only ever used the ID table matching before, but we should probably
> also support an open-coded match function.
> 
> Fixes: 88b7381a939de ("USB: Select better matching USB drivers when available")
> Signed-off-by: Bastien Nocera <hadess@hadess.net>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>

The subject line does not make sense, what is "also"?  Who is doing
this?

Coming back to this after a week I have no idea what is going on, so
that's a sign that it needs to be reworded :(

thanks,

greg k-h

  parent reply	other threads:[~2020-08-18  9:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04 11:38 [PATCH v7 1/3] USB: Also check for ->match Bastien Nocera
2020-08-04 11:38 ` [PATCH v7 2/3] USB: Better name for __check_usb_generic() Bastien Nocera
2020-08-04 11:38 ` [PATCH v7 3/3] USB: Fix device driver race Bastien Nocera
2020-08-18  9:00 ` Greg Kroah-Hartman [this message]
2020-08-18  9:42   ` [PATCH v7 1/3] USB: Also check for ->match Bastien Nocera
2020-08-18  9:51     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200818090037.GC28036@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=hadess@hadess.net \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.