From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 361F4C433E1 for ; Tue, 18 Aug 2020 12:50:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 112B82054F for ; Tue, 18 Aug 2020 12:50:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="DgbxrKyG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726723AbgHRMuW (ORCPT ); Tue, 18 Aug 2020 08:50:22 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:45009 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726451AbgHRMuR (ORCPT ); Tue, 18 Aug 2020 08:50:17 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597755016; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=oevYdqFGLDHN5iSBw8FvMUwlcjiMNTgT96naIwWWoCU=; b=DgbxrKyGGHtqrhelLHc5Xzqtic31QaBwiDFDHU/kAbanI3Dn+T+V6yP+bLszRIpS/KcXMkti OLDMRFvU/4yCk89Zww8Qfos9e5UOU6byfcdTy9KAr+zIi1iCbIEBk3LecqCc/g6DL5TojoyK u6Ft3tCHDi7JWBuQtoyMyXzxvmc= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-east-1.postgun.com with SMTP id 5f3bce7ed48d4625ca7f6213 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 18 Aug 2020 12:50:06 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 77FBEC433A0; Tue, 18 Aug 2020 12:50:04 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6EE5BC433CA; Tue, 18 Aug 2020 12:50:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 6EE5BC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] brcmfmac: check ndev pointer From: Kalle Valo In-Reply-To: <20200802161804.6126-1-trix@redhat.com> References: <20200802161804.6126-1-trix@redhat.com> To: trix@redhat.com Cc: arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chi-hsien.lin@cypress.com, wright.feng@cypress.com, davem@davemloft.net, kuba@kernel.org, rafal@milecki.pl, tklauser@distanz.ch, linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tom Rix User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200818125004.77FBEC433A0@smtp.codeaurora.org> Date: Tue, 18 Aug 2020 12:50:04 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org trix@redhat.com wrote: > From: Tom Rix > > Clang static analysis reports this error > > brcmfmac/core.c:490:4: warning: Dereference of null pointer > (*ifp)->ndev->stats.rx_errors++; > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > In this block of code > > if (ret || !(*ifp) || !(*ifp)->ndev) { > if (ret != -ENODATA && *ifp) > (*ifp)->ndev->stats.rx_errors++; > brcmu_pkt_buf_free_skb(skb); > return -ENODATA; > } > > (*ifp)->ndev being NULL is caught as an error > But then it is used to report the error. > > So add a check before using it. > > Fixes: 91b632803ee4 ("brcmfmac: Use net_device_stats from struct net_device") > Signed-off-by: Tom Rix Patch applied to wireless-drivers-next.git, thanks. 9c9f015bc9f8 brcmfmac: check ndev pointer -- https://patchwork.kernel.org/patch/11696567/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches