All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/4] Integrate tst_taint_check() into main LTP library
Date: Tue, 18 Aug 2020 17:11:50 +0200	[thread overview]
Message-ID: <20200818151150.GE27964@yuki.lan> (raw)
In-Reply-To: <1124120972.9071386.1597758876284.JavaMail.zimbra@redhat.com>

Hi!
> >  static void do_test_setup(void)
> > @@ -1279,6 +1282,9 @@ static int fork_testrun(void)
> >  	alarm(0);
> >  	SAFE_SIGNAL(SIGINT, SIG_DFL);
> >  
> > +	if (tst_test->taint_check && tst_taint_check())
> > +		tst_brk(TBROK, "Kernel is now tainted.");
> > +
> 
> Shouldn't this be TFAIL?

I would agree, looking at the code tst_res(TFAIL, ) followed by a
return TFAIL should work.

-- 
Cyril Hrubis
chrubis@suse.cz

      parent reply	other threads:[~2020-08-18 15:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-11 13:04 [LTP] [PATCH 1/4] Integrate tst_taint_check() into main LTP library Martin Doucha
2020-08-11 13:05 ` [LTP] [PATCH 2/4] Update tests to new taint check API Martin Doucha
2020-08-14 15:38   ` Petr Vorel
2020-08-14 15:42     ` Martin Doucha
2020-08-14 18:36       ` Petr Vorel
2020-08-18  8:16       ` Petr Vorel
2020-08-18  9:19         ` Martin Doucha
2020-08-11 13:05 ` [LTP] [PATCH 3/4] Simplify syscalls/bind06 using " Martin Doucha
2020-08-14 15:41   ` Petr Vorel
2020-08-11 13:05 ` [LTP] [PATCH 4/4] Add taint check to syscalls/ptrace08 Martin Doucha
2020-08-14 15:42   ` Petr Vorel
2020-08-14 15:33 ` [LTP] [PATCH 1/4] Integrate tst_taint_check() into main LTP library Petr Vorel
2020-08-18 13:54 ` Jan Stancek
2020-08-18 14:39   ` Martin Doucha
2020-08-18 15:20     ` Cyril Hrubis
2020-08-18 15:11   ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200818151150.GE27964@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.