From: Matthew Wilcox <willy@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Yu Kuai <yukuai3@huawei.com>,
hch@infradead.org, david@fromorbit.com,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com
Subject: Re: [RFC PATCH V2] iomap: add support to track dirty state of sub pages
Date: Tue, 18 Aug 2020 17:50:19 +0100 [thread overview]
Message-ID: <20200818165019.GT17456@casper.infradead.org> (raw)
In-Reply-To: <20200818161229.GK6107@magnolia>
On Tue, Aug 18, 2020 at 09:12:29AM -0700, Darrick J. Wong wrote:
> On Tue, Aug 18, 2020 at 04:53:05PM +0100, Matthew Wilcox wrote:
> > It would be better to use the same wording as below:
> >
> > > + bitmap_zero(iop->state, PAGE_SIZE * 2 / SECTOR_SIZE);
>
> ISTR there was some reason why '512' was hardcoded in here instead of
> SECTOR_SIZE. I /think/ it was so that iomap.h did not then have a hard
> dependency on blkdev.h and everything else that requires...
That ship already sailed. I over-trimmed this line:
- bitmap_zero(iop->uptodate, PAGE_SIZE / SECTOR_SIZE);
Looks like Christoph changed his mind sometime between that message
and the first commit: 9dc55f1389f9569acf9659e58dd836a9c70df217
My THP patches convert the bit array to be per-block rather than
per-sector, so this is all going to go away soon ;-)
> https://lore.kernel.org/linux-xfs/20181215105155.GD1575@lst.de/
next prev parent reply other threads:[~2020-08-18 16:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 13:46 [RFC PATCH V2] iomap: add support to track dirty state of sub pages Yu Kuai
2020-08-18 15:53 ` Matthew Wilcox
2020-08-18 16:12 ` Darrick J. Wong
2020-08-18 16:50 ` Matthew Wilcox [this message]
2020-08-18 18:11 ` Darrick J. Wong
2020-08-21 6:10 ` Christoph Hellwig
2020-08-21 13:05 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200818165019.GT17456@casper.infradead.org \
--to=willy@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.