From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32810C433DF for ; Tue, 18 Aug 2020 17:25:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01BE820658 for ; Tue, 18 Aug 2020 17:25:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FXBE8ffi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01BE820658 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k/hB2YLNSIM1Z3i4jF61gUJHW5gGA8LP7EUoOek3o84=; b=FXBE8ffiS06LbwPqigPhZT4h3 YXdLIUjTpDlwUUXNgvPkq8nGZpok3CDZaoL2iwSBuMfO4iPJMt58m3jgcZ/vF+etPtsEuKMA3d0nE V5QzuR7rhVmR+zwGjb2a+f9i9XaQejYhbzG/asEupE02DEHO4pJnuplGsSmY5XBoECUtXQkz2jzzj 4IHxH3ogfZRTZQ2wvLA8sHr3rBFDMkCXDRjJfriezI+DkraSNFvF86PRY9DXZ8nnTcEIKsgCBHm5Q LX3NgXG+k8o1pbHTWzl5bZOVS26g/JRA2kE4BIjpHbhJhu1HyNjvOyFkHfexAwuHm03eJpXh1Jrb4 ouI90fScA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k85MD-00085V-RB; Tue, 18 Aug 2020 17:25:09 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k85MB-000856-CD for linux-nvme@lists.infradead.org; Tue, 18 Aug 2020 17:25:08 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 8912B68AFE; Tue, 18 Aug 2020 19:25:04 +0200 (CEST) Date: Tue, 18 Aug 2020 19:25:04 +0200 From: Christoph Hellwig To: Keith Busch Subject: Re: [PATCHv3] nvme: skip noiob for zoned devices Message-ID: <20200818172504.GA28474@lst.de> References: <20200818162941.2674340-1-kbusch@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200818162941.2674340-1-kbusch@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200818_132507_549008_1BBBE139 X-CRM114-Status: GOOD ( 18.93 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sagi@grimberg.me, linux-nvme@lists.infradead.org, hch@lst.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Tue, Aug 18, 2020 at 09:29:41AM -0700, Keith Busch wrote: > Zoned block devices reuse the chunk_sectors queue limit to define zone > boundaries. If a such a device happens to also report an optimal > boundary, log a warning of the conflicting attributes and do not use > that to define the chunk_sectors as that may intermittently interfere > with io splitting and zone size queries. > > Signed-off-by: Keith Busch > --- > v2 -> v3: > > Emit a warning on the initial validation if a zoned device reports an > optimal boundary. > > drivers/nvme/host/core.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index 88cff309d8e4..10cf40d2cfef 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -2075,8 +2075,13 @@ static int __nvme_revalidate_disk(struct gendisk *disk, struct nvme_id_ns *id) > } > } > > - if (iob) > - blk_queue_chunk_sectors(ns->queue, rounddown_pow_of_two(iob)); > + if (iob) { > + if (!blk_queue_is_zoned(disk->queue)) > + blk_queue_chunk_sectors(ns->queue, rounddown_pow_of_two(iob)); > + else if (!(disk->flags & GENHD_FL_UP)) > + pr_warn("%s: zone namespace has unused IO boundary:%u\n", > + disk->disk_name, iob); This has some overly long line and looks fairly convoluted, what about something like: if (iob) { unsigned int chunk_sectors = rounddown_pow_of_two(iob); if (blk_queue_is_zoned(disk->queue) && chunk_sectors > blk_queue_zone_sectors(disk->queue)) pr_warn("%s: ignoring too large IO boundary: %u\n", disk->disk_name, iob); else blk_queue_chunk_sectors(ns->queue, chunk_sectors); } _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme