From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE3C6C433DF for ; Tue, 18 Aug 2020 21:07:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D5E120786 for ; Tue, 18 Aug 2020 21:07:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="zkxD0cr1"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ewcCJvi+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D5E120786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=PzuRo6nib8PUnqweN77wUhXX+F2qVv+6Q0iSZgQelXM=; b=zkxD0cr1EdpiFgr6SjjB4lhiVa 9LxrOQlA+GT2KJOYJERAcUwd9PCg+tA/2eP5gHiwrBW9R203lZnac/Z7p0BaOnpzxstIrmATEI8H4 uH1jJlgzAGL/rGGHrcsZmuvgPBZaMxT/Z1+PBfSGJmvSftYORx0GNsekfS0uc1S2Oq3+ul9gBKBYH 68p5WZCw5Ug3Fu2Wx714A9b29pIwVGKchf9h04DTAPnXfAroboIHTrD3X9O3bLfdcW03mHIBAhc0x ML0aFJfwi0P/7DrPjOeyDiWbS7pMdZ+INPrMS4WS3dF957AupI1Y7qlApx25fPcrLy3/bqrjQM362 OTzdbdfA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k88ni-0006mq-UR; Tue, 18 Aug 2020 21:05:46 +0000 Received: from mail-qv1-xf44.google.com ([2607:f8b0:4864:20::f44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k88ne-0006kJ-Mm for linux-arm-kernel@lists.infradead.org; Tue, 18 Aug 2020 21:05:45 +0000 Received: by mail-qv1-xf44.google.com with SMTP id cs12so10291053qvb.2 for ; Tue, 18 Aug 2020 14:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=CA/4yR4MUNsPP+aYLpeY51ZZmq15rxEs/sUlFusDY+E=; b=ewcCJvi+3y46J4k5q5G+2bIzodC0Td0iWHS8jkzaoL33AHfdlIpX3MuVyFSM/7Vu3l LnpiaPXg9QJk0MPj50NrEsp1OaB8Yvob94GErgyY2uIo8TqCLOsSJLRkikAQHZU0ilmA 2nxNRwB+riAOswvJViIdkEazZw2sHUBip5Em8pTOZ6nHRiBEWyQukFoJBtvZMG6l1YpR BOj6h88Uae5bB2P3uo9UspNFqv+OTA3qIPg+Lxk3Em5yMi4yEa1HGSucUj8pg2m61bDp v+kO6lzYN8MZRjIIng1y1xqHeOyW4x3rO7n0QBWMVVu4KAkFn4OHQwku6hGyX/dtVkO+ yn7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=CA/4yR4MUNsPP+aYLpeY51ZZmq15rxEs/sUlFusDY+E=; b=crTc9YmChgAhFvqHDIEQ0sHNxFzBQ8uBGn1qF51I4MRxLySR5aQqf9HknzUEWA0ret HGmZVUtbqV+LLkPhisphsVs6utfv8lKol3cAE3Fi/RqIOgpf/IVH7NBwLjrfAcEmr6QO zga7ZB7dF8HnEqvAdADRBgk48NrGoVs4g5F1kNuWFuuCnRMZx2QF1P9eP6bqgJvuclei ZGbs6q2E/2+hfzqmZ2w1tUxZS3wpzd9cCRn98ZKdoE6RoSj6vsPcUzDcbLRR5DAO3mOm RPAaIQ744VUrmMBszAuAQGwfU0fVGg9ezz0alknccrpWLMZAlL63/8AgsR3TwRXoZWOX RvJA== X-Gm-Message-State: AOAM532fjU997Hn7FE/ITLw+kNAX0cdscX6K7xEbBbgFqlo4dM7DYZgp 6HBEUwzBrJnUWZsiLVw82Aa3leCWAe0= X-Google-Smtp-Source: ABdhPJzCRjCkE/o5YF7OaQGW/1tJkLq5d8jWXBpzlgVVnyUXmaSiOtIEe+t18DzisZBFhYIcoV1bnQ== X-Received: by 2002:a0c:aedf:: with SMTP id n31mr20637439qvd.16.1597784740566; Tue, 18 Aug 2020 14:05:40 -0700 (PDT) Received: from localhost.localdomain ([2804:14c:482:4fb::1000]) by smtp.gmail.com with ESMTPSA id x50sm26638640qtb.10.2020.08.18.14.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Aug 2020 14:05:39 -0700 (PDT) From: Fabio Estevam To: fugang.duan@nxp.com Subject: [RFC PATCH 1/2] arm64: dts: imx8mm: Fix the ENET interrupts order Date: Tue, 18 Aug 2020 18:05:28 -0300 Message-Id: <20200818210529.5884-1-festevam@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200818_170542_756844_5C3508CC X-CRM114-Status: GOOD ( 14.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Fabio Estevam , shawnguo@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org According to Documentation/devicetree/bindings/net/fsl-fec.txt, when interrupt-names is not passed the following interrupt order is assumed: __Number of interrupts__ __Default__ 1 "int0" 2 "int0", "pps" 3 "int0", "int1", "int2" 4 "int0", "int1", "int2", "pps" In the current imx8mm.dtsi this translates to: - int0 ---> IRQ 118 - int1 ---> IRQ 119 - int2 ---> IRQ 120 However, just like i.MX7, i.MX8MM uses the following ENET irq mapping: - int0 ---> IRQ 120 - int1 ---> IRQ 118 - int2 ---> IRQ 119 Fix it by passing the interrupt-names property with the correct mapping. Tested networking on a imx8mm-evk board successfully. Signed-off-by: Fabio Estevam --- Hi Fugang, Could you please help review this RFC series? My understanding is that the i.MX8M class of products are derived from i.MX7 from an ENET IRQ mapping perspective. (i.MX8QXP also uses the same i.MX7 mapping by the way). The Reference Manual also seems to indicate the same, but the ENET IRQ naming differs a bit between the i.MX7 and i.MX8MM RM's. If this is correct, then I plan to also fix i.MX8MQ, i.MX8MN and i.MX8MP dtsi files. My initial goal was to add the pps irq (patch 2/2), but then I noticed the potential irq mismatch and now it is a two patch series. Thanks arch/arm64/boot/dts/freescale/imx8mm.dtsi | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi index aaf6e71101a1..551afc270fb7 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi @@ -844,9 +844,10 @@ fec1: ethernet@30be0000 { compatible = "fsl,imx8mm-fec", "fsl,imx6sx-fec"; reg = <0x30be0000 0x10000>; - interrupts = , - , - ; + interrupt-names = "int0", "int1", "int2"; + interrupts = , + , + ; clocks = <&clk IMX8MM_CLK_ENET1_ROOT>, <&clk IMX8MM_CLK_ENET1_ROOT>, <&clk IMX8MM_CLK_ENET_TIMER>, -- 2.17.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel