From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09F17C433E1 for ; Wed, 19 Aug 2020 04:58:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E368F207BB for ; Wed, 19 Aug 2020 04:58:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725497AbgHSE6u (ORCPT ); Wed, 19 Aug 2020 00:58:50 -0400 Received: from muru.com ([72.249.23.125]:40838 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbgHSE6u (ORCPT ); Wed, 19 Aug 2020 00:58:50 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 2718F810D; Wed, 19 Aug 2020 04:58:46 +0000 (UTC) Date: Wed, 19 Aug 2020 07:59:14 +0300 From: Tony Lindgren To: Adam Ford Cc: linux-omap@vger.kernel.org, aford@beaconembedded.com, Russell King , Eduardo Valentin , Keerthy , Zhang Rui , Daniel Lezcano , Amit Kucheria , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 1/2] thermal: ti-soc-thermal: Enable addition power management Message-ID: <20200819045914.GS2994@atomide.com> References: <20200818154633.5421-1-aford173@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200818154633.5421-1-aford173@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org * Adam Ford [200818 15:46]: > @@ -1153,6 +1166,38 @@ static int ti_bandgap_suspend(struct device *dev) > return err; > } > > +static int bandgap_omap_cpu_notifier(struct notifier_block *nb, > + unsigned long cmd, void *v) > +{ > + struct ti_bandgap *bgp; > + > + bgp = container_of(nb, struct ti_bandgap, nb); > + > + spin_lock(&bgp->lock); > + switch (cmd) { > + case CPU_CLUSTER_PM_ENTER: > + if (bgp->is_suspended) > + break; > + ti_bandgap_save_ctxt(bgp); > + ti_bandgap_power(bgp, false); > + if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) > + clk_disable(bgp->fclock); > + break; > + case CPU_CLUSTER_PM_ENTER_FAILED: > + case CPU_CLUSTER_PM_EXIT: > + if (bgp->is_suspended) > + break; > + if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) > + clk_enable(bgp->fclock); > + ti_bandgap_power(bgp, true); > + ti_bandgap_restore_ctxt(bgp); > + break; > + } > + spin_unlock(&bgp->lock); > + > + return NOTIFY_OK; > +} Hmm to me it looks like is_suspended is not used right now? I guess you want to set it in ti_bandgap_suspend() and clear it in ti_bandgap_resume()? Otherwise looks good to me, I can't test the power consumption right now though so you may want to check it to make sure device still hits off mode during idle. Regards, Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA3D7C433DF for ; Wed, 19 Aug 2020 05:00:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3A2620772 for ; Wed, 19 Aug 2020 05:00:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GB7r0tja" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3A2620772 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zq+peM9M/sE3OgXk0rd938/FKsByVT+s+KVfnZWianU=; b=GB7r0tjadSLgTHzFNcOpgnlh8 SNewyUjSiG5rZyZKZXA5eIT/dj5BugqXDflRSsLq76k2Oix9B4isEABIle4dxlkKu34oNZtDju30p qAxt+CX0KPaaENjxyUqlZptHF7lGqi4sDdILuSe1f1So0kgwHpEAlsoWpJwaXRKVlju6thbgYZSG4 IDCrc6aeK6vZLW3H5ZmlyaZRmlxncUM5TMcFO9wEkPuZ0bQn9IfzKqGEoCVSLXtF6pFgRLI/DLcFi qh27gISBh40xmyEeXbs5CUtw/NcIOG/n1zeJj+kZFuxKBJQ0uTDSsuOR9MDMQBzaDZ/8WfLietMyq 2s9SU0sJg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8GBa-0003w3-GV; Wed, 19 Aug 2020 04:58:54 +0000 Received: from muru.com ([72.249.23.125]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8GBW-0003vS-RT for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2020 04:58:51 +0000 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 2718F810D; Wed, 19 Aug 2020 04:58:46 +0000 (UTC) Date: Wed, 19 Aug 2020 07:59:14 +0300 From: Tony Lindgren To: Adam Ford Subject: Re: [PATCH 1/2] thermal: ti-soc-thermal: Enable addition power management Message-ID: <20200819045914.GS2994@atomide.com> References: <20200818154633.5421-1-aford173@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200818154633.5421-1-aford173@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_005850_994976_EEAA04D0 X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Amit Kucheria , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Keerthy , Daniel Lezcano , aford@beaconembedded.com, Russell King , Eduardo Valentin , Zhang Rui , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Adam Ford [200818 15:46]: > @@ -1153,6 +1166,38 @@ static int ti_bandgap_suspend(struct device *dev) > return err; > } > > +static int bandgap_omap_cpu_notifier(struct notifier_block *nb, > + unsigned long cmd, void *v) > +{ > + struct ti_bandgap *bgp; > + > + bgp = container_of(nb, struct ti_bandgap, nb); > + > + spin_lock(&bgp->lock); > + switch (cmd) { > + case CPU_CLUSTER_PM_ENTER: > + if (bgp->is_suspended) > + break; > + ti_bandgap_save_ctxt(bgp); > + ti_bandgap_power(bgp, false); > + if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) > + clk_disable(bgp->fclock); > + break; > + case CPU_CLUSTER_PM_ENTER_FAILED: > + case CPU_CLUSTER_PM_EXIT: > + if (bgp->is_suspended) > + break; > + if (TI_BANDGAP_HAS(bgp, CLK_CTRL)) > + clk_enable(bgp->fclock); > + ti_bandgap_power(bgp, true); > + ti_bandgap_restore_ctxt(bgp); > + break; > + } > + spin_unlock(&bgp->lock); > + > + return NOTIFY_OK; > +} Hmm to me it looks like is_suspended is not used right now? I guess you want to set it in ti_bandgap_suspend() and clear it in ti_bandgap_resume()? Otherwise looks good to me, I can't test the power consumption right now though so you may want to check it to make sure device still hits off mode during idle. Regards, Tony _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel