All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Icenowy Zheng <icenowy@aosc.io>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: core: Fix handle of OF disabled MFD cells
Date: Wed, 19 Aug 2020 09:26:50 +0100	[thread overview]
Message-ID: <20200819082650.GC4354@dell> (raw)
In-Reply-To: <3b0ba1c95efa2ac465d9b6312b8e0e2c8fb461b5.camel@aosc.io>

On Wed, 19 Aug 2020, Icenowy Zheng wrote:

> 在 2020-08-19星期三的 09:11 +0100,Lee Jones写道:
> > On Sat, 01 Aug 2020, Icenowy Zheng wrote:
> > 
> > > When rewriting the OF match code of MFD core, addition of cells
> > > disabled
> > > in OF will result in a failure with error -ENODEV. This is an
> > > unexpected
> > > behavior, as the previous behavior is silently ignore the cell. On
> > > SBCs with AXP20x PMICs, this leads to boot failure if AXP20x PMIC
> > > support is built-in and some cells (especially power supply ones)
> > > are
> > > disabled.
> > 
> > Thanks for reporting this.
> > 
> > Do you mind if I fix this another way?  I plan to reinstate the old
> > code that was removed as part of the offending patch.  I will of
> > course add your Reported-by tag.
> 
> I think it's okay.
> 
> I will test it once it's out.

That would be great.  Then I can add your Tested-by also.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

      reply	other threads:[~2020-08-19  8:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-01  7:01 [PATCH] mfd: core: Fix handle of OF disabled MFD cells Icenowy Zheng
2020-08-19  8:11 ` Lee Jones
2020-08-19  8:16   ` Icenowy Zheng
2020-08-19  8:26     ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200819082650.GC4354@dell \
    --to=lee.jones@linaro.org \
    --cc=icenowy@aosc.io \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.