From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB23C433E1 for ; Wed, 19 Aug 2020 09:31:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DCBAC206FA for ; Wed, 19 Aug 2020 09:31:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726702AbgHSJbt (ORCPT ); Wed, 19 Aug 2020 05:31:49 -0400 Received: from mga09.intel.com ([134.134.136.24]:6347 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726835AbgHSJbs (ORCPT ); Wed, 19 Aug 2020 05:31:48 -0400 IronPort-SDR: xl7tFlJVo1u+8NsAVDxBs7J87a6PDhXO6zFe9L/74oABnElySxxJxf7GKPgAZmXcwxCt7aOXtA LLdUeB4QdixA== X-IronPort-AV: E=McAfee;i="6000,8403,9717"; a="156145907" X-IronPort-AV: E=Sophos;i="5.76,330,1592895600"; d="scan'208";a="156145907" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2020 02:31:47 -0700 IronPort-SDR: KcYYofNl8Lq06snYEvg+e1pLJ9t2x0pWy5+yYL30Q0/rQZf0DELbUCRdSMIf3//398c4qQQ+tp tPhDeiPAuAuQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,330,1592895600"; d="scan'208";a="327032676" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 19 Aug 2020 02:31:44 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k8KAi-009qDg-0R; Wed, 19 Aug 2020 12:14:16 +0300 Date: Wed, 19 Aug 2020 12:14:16 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Michal Simek , Greg Kroah-Hartman , Guenter Roeck , linux-iio , Linux ARM , Linux Kernel Mailing List , Bartosz Golaszewski Subject: Re: [PATCH v7 1/3] devres: provide devm_krealloc() Message-ID: <20200819091416.GX1891694@smile.fi.intel.com> References: <20200817170535.17041-1-brgl@bgdev.pl> <20200817170535.17041-2-brgl@bgdev.pl> <20200817173908.GS1891694@smile.fi.intel.com> <20200818082500.GB1891694@smile.fi.intel.com> <20200818171046.GU1891694@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org On Tue, Aug 18, 2020 at 08:13:10PM +0200, Bartosz Golaszewski wrote: > On Tue, Aug 18, 2020 at 7:19 PM Andy Shevchenko > wrote: > > On Tue, Aug 18, 2020 at 06:27:12PM +0200, Bartosz Golaszewski wrote: > > > On Tue, Aug 18, 2020 at 10:40 AM Andy Shevchenko > > > wrote: > > > > On Mon, Aug 17, 2020 at 10:02:05PM +0200, Bartosz Golaszewski wrote: > > > > > On Mon, Aug 17, 2020 at 7:43 PM Andy Shevchenko > > > > > wrote: > > > > > > On Mon, Aug 17, 2020 at 07:05:33PM +0200, Bartosz Golaszewski wrote: > > > > > > > From: Bartosz Golaszewski ... > > > > > > > +static struct devres *to_devres(void *data) > > > > > > > +{ > > > > > > > + return (struct devres *)((u8 *)data - ALIGN(sizeof(struct devres), > > > > > > > + ARCH_KMALLOC_MINALIGN)); > > > > > > > > > > > > Do you really need both explicit castings? > > > > > > > > > > > > > > > > Yeah, we can probably drop the (struct devres *) here. > > > > > > > > void * -> u8 * here is also not needed, it is considered byte access IIRC. > > > > > > > > > > Actually it turns out that while we don't need the (void *) -> (u8 *) > > > casting, we must cast to (struct devres *) or the following error is > > > produced: > > > > > > drivers/base/devres.c: In function ‘to_devres’: > > > drivers/base/devres.c:41:21: error: returning ‘u8 *’ {aka ‘unsigned > > > char *’} from a function with incompatible return type ‘struct devres > > > *’ [-Werror=incompatible-pointer-types] > > > return ((u8 *)data - ALIGN(sizeof(struct devres), > > > ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > ARCH_KMALLOC_MINALIGN)); > > > ~~~~~~~~~~~~~~~~~~~~~~~ > > > > Of course, you have to drop u8 * casting as well. > > > > Yes, of course. Duh With this addressed (and don't forget to remove also unneeded parentheses), Reviewed-by: Andy Shevchenko Thanks! -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97FBAC433DF for ; Wed, 19 Aug 2020 09:33:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 649F5206FA for ; Wed, 19 Aug 2020 09:33:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iD7Jqa3A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 649F5206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hlwW7tfSjCsGD5avDVm6E3DNP+LucNRCGVSk+qrhSq4=; b=iD7Jqa3AEC65ARyYo3EPLqeEu Hr1h7bYUbkMcoHH8oqrS1L5XRs4BAl31cxmE81GeNXGapss/hMWN+doh9T/RS4OZvAoxbEA5Cuy+Z 7qsAoMwCULmlq9rO6CCxVwMHybr148z2fRALC5P8mGdXhgAal4tqif9LYmApLdyOHFydMCIWnoB/e cV2VEav03Jfqgvu/FciWVGFIncX4Mvq8qNxtnpabXOtIq2oCMBs4u2mrn6066FoXPPf2RRzWG7tVt OX0dRbGaGZVcVHQpI1d5nbzPmKAf4QKrFqsOQmtyI8NwwY6Cfjx/Wv+ArQbdQ9L9QUpMKenENz285 s8S/JTPmQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8KRl-0005pM-Aa; Wed, 19 Aug 2020 09:31:53 +0000 Received: from mga09.intel.com ([134.134.136.24]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8KRi-0005oe-S9 for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2020 09:31:51 +0000 IronPort-SDR: N/nxtOor5Ws+SYMx2nmCVMfEqpeJqSIAOcvz1KlZ+Mfigw+fT3YPkyxwDoE36ckZ+WhdaQo8hl 9+YUyATiFvpw== X-IronPort-AV: E=McAfee;i="6000,8403,9717"; a="156145909" X-IronPort-AV: E=Sophos;i="5.76,330,1592895600"; d="scan'208";a="156145909" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2020 02:31:47 -0700 IronPort-SDR: KcYYofNl8Lq06snYEvg+e1pLJ9t2x0pWy5+yYL30Q0/rQZf0DELbUCRdSMIf3//398c4qQQ+tp tPhDeiPAuAuQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,330,1592895600"; d="scan'208";a="327032676" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga008.jf.intel.com with ESMTP; 19 Aug 2020 02:31:44 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1k8KAi-009qDg-0R; Wed, 19 Aug 2020 12:14:16 +0300 Date: Wed, 19 Aug 2020 12:14:16 +0300 From: Andy Shevchenko To: Bartosz Golaszewski Subject: Re: [PATCH v7 1/3] devres: provide devm_krealloc() Message-ID: <20200819091416.GX1891694@smile.fi.intel.com> References: <20200817170535.17041-1-brgl@bgdev.pl> <20200817170535.17041-2-brgl@bgdev.pl> <20200817173908.GS1891694@smile.fi.intel.com> <20200818082500.GB1891694@smile.fi.intel.com> <20200818171046.GU1891694@smile.fi.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_053151_068569_947CECE0 X-CRM114-Status: GOOD ( 23.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Lars-Peter Clausen , linux-iio , Greg Kroah-Hartman , Michal Simek , Linux Kernel Mailing List , Bartosz Golaszewski , Guenter Roeck , Peter Meerwald-Stadler , Hartmut Knaack , Jonathan Cameron Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBdWcgMTgsIDIwMjAgYXQgMDg6MTM6MTBQTSArMDIwMCwgQmFydG9zeiBHb2xhc3pl d3NraSB3cm90ZToKPiBPbiBUdWUsIEF1ZyAxOCwgMjAyMCBhdCA3OjE5IFBNIEFuZHkgU2hldmNo ZW5rbwo+IDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4gT24g VHVlLCBBdWcgMTgsIDIwMjAgYXQgMDY6Mjc6MTJQTSArMDIwMCwgQmFydG9zeiBHb2xhc3pld3Nr aSB3cm90ZToKPiA+ID4gT24gVHVlLCBBdWcgMTgsIDIwMjAgYXQgMTA6NDAgQU0gQW5keSBTaGV2 Y2hlbmtvCj4gPiA+IDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ ID4gPiA+IE9uIE1vbiwgQXVnIDE3LCAyMDIwIGF0IDEwOjAyOjA1UE0gKzAyMDAsIEJhcnRvc3og R29sYXN6ZXdza2kgd3JvdGU6Cj4gPiA+ID4gPiBPbiBNb24sIEF1ZyAxNywgMjAyMCBhdCA3OjQz IFBNIEFuZHkgU2hldmNoZW5rbwo+ID4gPiA+ID4gPGFuZHJpeS5zaGV2Y2hlbmtvQGxpbnV4Lmlu dGVsLmNvbT4gd3JvdGU6Cj4gPiA+ID4gPiA+IE9uIE1vbiwgQXVnIDE3LCAyMDIwIGF0IDA3OjA1 OjMzUE0gKzAyMDAsIEJhcnRvc3ogR29sYXN6ZXdza2kgd3JvdGU6Cj4gPiA+ID4gPiA+ID4gRnJv bTogQmFydG9zeiBHb2xhc3pld3NraSA8YmdvbGFzemV3c2tpQGJheWxpYnJlLmNvbT4KCi4uLgoK PiA+ID4gPiA+ID4gPiArc3RhdGljIHN0cnVjdCBkZXZyZXMgKnRvX2RldnJlcyh2b2lkICpkYXRh KQo+ID4gPiA+ID4gPiA+ICt7Cj4gPiA+ID4gPiA+ID4gKyAgICAgcmV0dXJuIChzdHJ1Y3QgZGV2 cmVzICopKCh1OCAqKWRhdGEgLSBBTElHTihzaXplb2Yoc3RydWN0IGRldnJlcyksCj4gPiA+ID4g PiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBB UkNIX0tNQUxMT0NfTUlOQUxJR04pKTsKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gRG8geW91IHJl YWxseSBuZWVkIGJvdGggZXhwbGljaXQgY2FzdGluZ3M/Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPgo+ ID4gPiA+ID4gWWVhaCwgd2UgY2FuIHByb2JhYmx5IGRyb3AgdGhlIChzdHJ1Y3QgZGV2cmVzICop IGhlcmUuCj4gPiA+ID4KPiA+ID4gPiB2b2lkICogLT4gdTggKiBoZXJlIGlzIGFsc28gbm90IG5l ZWRlZCwgaXQgaXMgY29uc2lkZXJlZCBieXRlIGFjY2VzcyBJSVJDLgo+ID4gPiA+Cj4gPiA+Cj4g PiA+IEFjdHVhbGx5IGl0IHR1cm5zIG91dCB0aGF0IHdoaWxlIHdlIGRvbid0IG5lZWQgdGhlICh2 b2lkICopIC0+ICh1OCAqKQo+ID4gPiBjYXN0aW5nLCB3ZSBtdXN0IGNhc3QgdG8gKHN0cnVjdCBk ZXZyZXMgKikgb3IgdGhlIGZvbGxvd2luZyBlcnJvciBpcwo+ID4gPiBwcm9kdWNlZDoKPiA+ID4K PiA+ID4gZHJpdmVycy9iYXNlL2RldnJlcy5jOiBJbiBmdW5jdGlvbiDigJh0b19kZXZyZXPigJk6 Cj4gPiA+IGRyaXZlcnMvYmFzZS9kZXZyZXMuYzo0MToyMTogZXJyb3I6IHJldHVybmluZyDigJh1 OCAq4oCZIHtha2Eg4oCYdW5zaWduZWQKPiA+ID4gY2hhciAq4oCZfSBmcm9tIGEgZnVuY3Rpb24g d2l0aCBpbmNvbXBhdGlibGUgcmV0dXJuIHR5cGUg4oCYc3RydWN0IGRldnJlcwo+ID4gPiAq4oCZ IFstV2Vycm9yPWluY29tcGF0aWJsZS1wb2ludGVyLXR5cGVzXQo+ID4gPiAgIHJldHVybiAoKHU4 ICopZGF0YSAtIEFMSUdOKHNpemVvZihzdHJ1Y3QgZGV2cmVzKSwKPiA+ID4gICAgICAgICAgfn5+ fn5+fn5+fn5+Xn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4gPiA+ICAgICAgICAgQVJD SF9LTUFMTE9DX01JTkFMSUdOKSk7Cj4gPiA+ICAgICAgICAgfn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn4KPiA+Cj4gPiBPZiBjb3Vyc2UsIHlvdSBoYXZlIHRvIGRyb3AgdTggKiBjYXN0aW5nIGFzIHdl bGwuCj4gPgo+IAo+IFllcywgb2YgY291cnNlLiBEdWgKCldpdGggdGhpcyBhZGRyZXNzZWQgKGFu ZCBkb24ndCBmb3JnZXQgdG8gcmVtb3ZlIGFsc28gdW5uZWVkZWQgcGFyZW50aGVzZXMpLApSZXZp ZXdlZC1ieTogQW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNoZW5rb0BsaW51eC5pbnRlbC5j b20+ClRoYW5rcyEKCi0tIApXaXRoIEJlc3QgUmVnYXJkcywKQW5keSBTaGV2Y2hlbmtvCgoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK