From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F791C433E1 for ; Wed, 19 Aug 2020 12:38:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC710206FA for ; Wed, 19 Aug 2020 12:38:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597840702; bh=o1aH6Vc5HDoeUAUMEJNJq1za6d80HUUBuus+I+GTc6o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wL0ANJhzKF6r3KOpVQL7RsLs4KeM/+/ebMipJfAJal78V1EUuLOHpgKq/aWkbC/V4 Le8ycXS2J5krlZ4Z09GmJPMksJOkA8aRl1csSn3FiALxSUigowaIeshU9iHR7QGvEu HxaXd1Va8dl/ZzEMpKavQumfoPFhmKzw5Oyky9Sw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728191AbgHSMhu convert rfc822-to-8bit (ORCPT ); Wed, 19 Aug 2020 08:37:50 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:41099 "EHLO mail-ej1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727018AbgHSMhh (ORCPT ); Wed, 19 Aug 2020 08:37:37 -0400 Received: by mail-ej1-f65.google.com with SMTP id t10so26087374ejs.8; Wed, 19 Aug 2020 05:37:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=6FCKFOV4tXuhe4ALaKK45GgE/rtv2KFtTsBAHakWHm4=; b=CocKN0U5OmS0A9cRNxM7XxA7kFlY1XGFx/vS47SaPi+ke1XyjYcuyi84gaHrjyvkh/ dvPCBmaVxEFZKYWYoT/fSALggJBilw9EpuMBcxuZbffjIHIPoJQy5z0TWM/uOQrU77X4 +7uKkrakBmB98YCmfhsvGprQ5exW+z9neYLOD+41qTYSRb8B1Ep+kgbwERT1NVgc91dz WA0nNFcNWEUdk4oz1H5Mpz4lUsGcNHsCTnqvxNm+gKLWoV+t5nK9ENXD8vhMS9e1hFZU Z1q7OW+ldGcO//JpkTmDUXDMLKuq6VnHv10RbpIArho++lzE6s79kgmRDpU47wFnORKq QV6A== X-Gm-Message-State: AOAM5327rMf1eoWeNlrjJoxqEPQusspEMU7OljDXBFgKJIUbUxb3gea6 zSMTbtd8CWWgQ4PMYblmT4U= X-Google-Smtp-Source: ABdhPJw9xEf2bvQxWdoKfV7GBCyYJK5pCq04/DM+3vXVGjGug31Euua3pze+tmiaLYIlaBLh8/tQsA== X-Received: by 2002:a17:906:cc51:: with SMTP id mm17mr25546416ejb.137.1597840654741; Wed, 19 Aug 2020 05:37:34 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id pv28sm18391843ejb.71.2020.08.19.05.37.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Aug 2020 05:37:34 -0700 (PDT) Date: Wed, 19 Aug 2020 14:37:32 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Cc: Kukjin Kim , Andi Shyti , Mark Brown , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com Subject: Re: [PATCH 5/8] spi: spi-s3c64xx: Fix doc comment for struct s3c64xx_spi_driver_data Message-ID: <20200819123732.GA18122@kozik-lap> References: <20200819123208.12337-1-l.stelmach@samsung.com> <20200819123208.12337-6-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20200819123208.12337-6-l.stelmach@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, Aug 19, 2020 at 02:32:05PM +0200, Łukasz Stelmach wrote: > Signed-off-by: Łukasz Stelmach Hi, Missing commit msg - fix what exactly? You need to rebase your patch as most of these were already fixed by Lee Jones. However he did not remove the @rx_dmach and tx entries... Best regards, Krzysztof > --- > drivers/spi/spi-s3c64xx.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 6fe896f2be18..505789f91fdf 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -155,19 +155,21 @@ struct s3c64xx_spi_port_config { > * @clk: Pointer to the spi clock. > * @src_clk: Pointer to the clock used to generate SPI signals. > * @ioclk: Pointer to the i/o clock between master and slave > + * @pdev: Pointer to the SPI controller platform device > * @master: Pointer to the SPI Protocol master. > * @cntrlr_info: Platform specific data for the controller this driver manages. > * @lock: Controller specific lock. > * @state: Set of FLAGS to indicate status. > - * @rx_dmach: Controller's DMA channel for Rx. > - * @tx_dmach: Controller's DMA channel for Tx. > + * @rx_dma: Controller's DMA channel for Rx. > + * @tx_dma: Controller's DMA channel for Tx. > * @sfr_start: BUS address of SPI controller regs. > * @regs: Pointer to ioremap'ed controller registers. > - * @irq: interrupt > * @xfer_completion: To indicate completion of xfer task. > * @cur_mode: Stores the active configuration of the controller. > * @cur_bpw: Stores the active bits per word settings. > * @cur_speed: Stores the active xfer clock speed. > + * @port_conf: Pointer to the SPI port configuration > + * @port_id: SPI port ID number > */ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6125C433DF for ; Wed, 19 Aug 2020 13:51:03 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4CC0204FD for ; Wed, 19 Aug 2020 13:51:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qxJABoHm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hu3Tph94" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4CC0204FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1psvMrdUdqtEo/UnMEY1rJfz9WUjD4svbV4C36nd2/U=; b=qxJABoHmGZFCfAiR7VXwCvpg4 rrByWFQoZpMlurwI2g71ShpqisbEvUUQyiUHBvW+ejBcrIsjcVl3BmjKRZGBLqUk9SsLDnTZ7uwfD 8niSixZrIzr97SZ55h0MGRfZHUs+vSoppdl34umjNUpWhs/e80aHgUj3NoVoy380vQHdN00HbhoDH niFZpwr5zI7Dmq+NJuhy7eeA1n6en+lUm4voeZjW41DevhVfAjIiLA/P3GEl/SzX3KWPvbTplbYHp 7g58xvQaMgUGcN0LSCAI0tBzZfNIZrvk4rcO09AgIn8GiL+WRbsvWkyn/IzXQOzSN/2JNjsXrRGU/ inpGSqcFQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8OT4-0005co-3j; Wed, 19 Aug 2020 13:49:30 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8NLa-0000Ub-Pj for linux-arm-kernel@merlin.infradead.org; Wed, 19 Aug 2020 12:37:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=6FCKFOV4tXuhe4ALaKK45GgE/rtv2KFtTsBAHakWHm4=; b=hu3Tph94L7+IBU+xZd13MW8rxC 5j51x8x+yqwn5ux2cRlMYh5flvqrkcFtXFa9UjzuQ1cpGescAYx+dC/dk88s37Z6VmtZkZj5N52p9 ZCCpsG9PxhcPRnieEnP5W1GTta2PrnXxdxaGB25f4GVn6WIz7wp35ne2zD8vN6aMH/ccWoZoZROCa 1hdzTBp2vHNoCcktXrF45LMTHghUl8ZW4l1GE347wT9RDVuaLecD3OZ/+BT4il1mxc+vZ+IwHB5vi PFOuKruXER8+6HPGKIxXqC/Czo8Qt6Zqv/AxUr5nR19a661urV7JoRZCg1VfBpHZ+zw8CNKknofJP b/jj+YnA==; Received: from mail-ej1-f68.google.com ([209.85.218.68]) by casper.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8NLX-0006nl-E8 for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2020 12:37:41 +0000 Received: by mail-ej1-f68.google.com with SMTP id bo3so26053479ejb.11 for ; Wed, 19 Aug 2020 05:37:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=6FCKFOV4tXuhe4ALaKK45GgE/rtv2KFtTsBAHakWHm4=; b=aEvp/zKYLjhrU+7csltJlYCQ1ujk0Jhfsq76dF2HgBRoeCqw7iFteh6gg4PbIiRXY9 Cgf+mLppl8rNv90FfLZiKoOLZf+ZR9no3YcXyVhQYMho7djRc+8D3sUDf4w08kCLy7bs 2q9bo4h/2CrUa0uY65HRNUIFWLoqeD35q6umUy737TIP12G4HjU6SWdPmNyblN8mqdJp aKc6glR37FllmWnQ04oLRsJVbKDCsLoCv8jy3f/8AE63qaW39YMTnkiKb78cwyvCqzjQ pMKY9ZMCziuYWHt/xNlCE8Wn1Fnw+Njwkdkv79P3WTuV1vA85WO1QuWuF7uRQATrBRm5 72Nw== X-Gm-Message-State: AOAM531Bq8QQnfVmpIkCqHHX2bf4EK2y/K0XTIgv6FYwZxe7FsXZ6+Go DIAlzoC4UBuCH1gN7j20uWIAyexRMnGFMw== X-Google-Smtp-Source: ABdhPJw9xEf2bvQxWdoKfV7GBCyYJK5pCq04/DM+3vXVGjGug31Euua3pze+tmiaLYIlaBLh8/tQsA== X-Received: by 2002:a17:906:cc51:: with SMTP id mm17mr25546416ejb.137.1597840654741; Wed, 19 Aug 2020 05:37:34 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id pv28sm18391843ejb.71.2020.08.19.05.37.33 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Aug 2020 05:37:34 -0700 (PDT) Date: Wed, 19 Aug 2020 14:37:32 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Subject: Re: [PATCH 5/8] spi: spi-s3c64xx: Fix doc comment for struct s3c64xx_spi_driver_data Message-ID: <20200819123732.GA18122@kozik-lap> References: <20200819123208.12337-1-l.stelmach@samsung.com> <20200819123208.12337-6-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200819123208.12337-6-l.stelmach@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_133739_763450_0E519793 X-CRM114-Status: GOOD ( 19.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown , Kukjin Kim , Andi Shyti , linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBBdWcgMTksIDIwMjAgYXQgMDI6MzI6MDVQTSArMDIwMCwgxYF1a2FzeiBTdGVsbWFj aCB3cm90ZToKPiBTaWduZWQtb2ZmLWJ5OiDFgXVrYXN6IFN0ZWxtYWNoIDxsLnN0ZWxtYWNoQHNh bXN1bmcuY29tPgoKSGksCgpNaXNzaW5nIGNvbW1pdCBtc2cgLSBmaXggd2hhdCBleGFjdGx5PwoK WW91IG5lZWQgdG8gcmViYXNlIHlvdXIgcGF0Y2ggYXMgbW9zdCBvZiB0aGVzZSB3ZXJlIGFscmVh ZHkgZml4ZWQgYnkgTGVlCkpvbmVzLgoKSG93ZXZlciBoZSBkaWQgbm90IHJlbW92ZSB0aGUgQHJ4 X2RtYWNoIGFuZCB0eCBlbnRyaWVzLi4uCgpCZXN0IHJlZ2FyZHMsCktyenlzenRvZgoKPiAtLS0K PiAgZHJpdmVycy9zcGkvc3BpLXMzYzY0eHguYyB8IDEwICsrKysrKy0tLS0KPiAgMSBmaWxlIGNo YW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9zcGkvc3BpLXMzYzY0eHguYyBiL2RyaXZlcnMvc3BpL3NwaS1zM2M2NHh4LmMKPiBp bmRleCA2ZmU4OTZmMmJlMTguLjUwNTc4OWY5MWZkZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3Nw aS9zcGktczNjNjR4eC5jCj4gKysrIGIvZHJpdmVycy9zcGkvc3BpLXMzYzY0eHguYwo+IEBAIC0x NTUsMTkgKzE1NSwyMSBAQCBzdHJ1Y3QgczNjNjR4eF9zcGlfcG9ydF9jb25maWcgewo+ICAgKiBA Y2xrOiBQb2ludGVyIHRvIHRoZSBzcGkgY2xvY2suCj4gICAqIEBzcmNfY2xrOiBQb2ludGVyIHRv IHRoZSBjbG9jayB1c2VkIHRvIGdlbmVyYXRlIFNQSSBzaWduYWxzLgo+ICAgKiBAaW9jbGs6IFBv aW50ZXIgdG8gdGhlIGkvbyBjbG9jayBiZXR3ZWVuIG1hc3RlciBhbmQgc2xhdmUKPiArICogQHBk ZXY6IFBvaW50ZXIgdG8gdGhlIFNQSSBjb250cm9sbGVyIHBsYXRmb3JtIGRldmljZQo+ICAgKiBA bWFzdGVyOiBQb2ludGVyIHRvIHRoZSBTUEkgUHJvdG9jb2wgbWFzdGVyLgo+ICAgKiBAY250cmxy X2luZm86IFBsYXRmb3JtIHNwZWNpZmljIGRhdGEgZm9yIHRoZSBjb250cm9sbGVyIHRoaXMgZHJp dmVyIG1hbmFnZXMuCj4gICAqIEBsb2NrOiBDb250cm9sbGVyIHNwZWNpZmljIGxvY2suCj4gICAq IEBzdGF0ZTogU2V0IG9mIEZMQUdTIHRvIGluZGljYXRlIHN0YXR1cy4KPiAtICogQHJ4X2RtYWNo OiBDb250cm9sbGVyJ3MgRE1BIGNoYW5uZWwgZm9yIFJ4Lgo+IC0gKiBAdHhfZG1hY2g6IENvbnRy b2xsZXIncyBETUEgY2hhbm5lbCBmb3IgVHguCj4gKyAqIEByeF9kbWE6IENvbnRyb2xsZXIncyBE TUEgY2hhbm5lbCBmb3IgUnguCj4gKyAqIEB0eF9kbWE6IENvbnRyb2xsZXIncyBETUEgY2hhbm5l bCBmb3IgVHguCj4gICAqIEBzZnJfc3RhcnQ6IEJVUyBhZGRyZXNzIG9mIFNQSSBjb250cm9sbGVy IHJlZ3MuCj4gICAqIEByZWdzOiBQb2ludGVyIHRvIGlvcmVtYXAnZWQgY29udHJvbGxlciByZWdp c3RlcnMuCj4gLSAqIEBpcnE6IGludGVycnVwdAo+ICAgKiBAeGZlcl9jb21wbGV0aW9uOiBUbyBp bmRpY2F0ZSBjb21wbGV0aW9uIG9mIHhmZXIgdGFzay4KPiAgICogQGN1cl9tb2RlOiBTdG9yZXMg dGhlIGFjdGl2ZSBjb25maWd1cmF0aW9uIG9mIHRoZSBjb250cm9sbGVyLgo+ICAgKiBAY3VyX2Jw dzogU3RvcmVzIHRoZSBhY3RpdmUgYml0cyBwZXIgd29yZCBzZXR0aW5ncy4KPiAgICogQGN1cl9z cGVlZDogU3RvcmVzIHRoZSBhY3RpdmUgeGZlciBjbG9jayBzcGVlZC4KPiArICogQHBvcnRfY29u ZjogUG9pbnRlciB0byB0aGUgU1BJIHBvcnQgY29uZmlndXJhdGlvbgo+ICsgKiBAcG9ydF9pZDog U1BJIHBvcnQgSUQgbnVtYmVyCj4gICAqLwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=