From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F93C433DF for ; Wed, 19 Aug 2020 12:48:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 307F5206B5 for ; Wed, 19 Aug 2020 12:48:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597841320; bh=vSfytZP8+I0+ZyXxWN8mIaFVW1Syu2+avDpGWRu8uOY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=hrkbk2K2+TLCqRIXLYrPWPUhi2IxlFEZKdRHhT+2gr/oW6I0oqHS5eKU/heoUaYfB /Jho13NFn+IBzurmZiqjEGEsgFwzXtH9iPZmrAzPAIdG8/wLyOOzA1v+ZSbys5sVjP c2F7s9+FUfADD+koHEs+RxIN2uCBk0dbNoFe2bjo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728348AbgHSMsj convert rfc822-to-8bit (ORCPT ); Wed, 19 Aug 2020 08:48:39 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:42452 "EHLO mail-ej1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728192AbgHSMsh (ORCPT ); Wed, 19 Aug 2020 08:48:37 -0400 Received: by mail-ej1-f68.google.com with SMTP id g19so26097503ejc.9; Wed, 19 Aug 2020 05:48:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=XfTWVsSwjI65UWFf8mFq+y/lWsZWshehQWdU+KFwzuU=; b=HKzMBdh+PxyjxnrUOI6ZeqHAslPkTLw8gDc4YiBgR8EIqyzfrX4fbeRGVfz+JNRPx0 DfT/nBraFeSHPztXPTWiIwSxiemI4l5abcmLOgHGoVvDXGHKHoW0TmP28Zc7cRB6XY5e 0RhtohupN6lxLEWCgslG/LJ0Os1DTOp6UfN5u2KS5Kt3Pqyj0mjsARXQ6sgYk3nrth0l f0E9reNcEWQYg9ob3r9abBRk7C0LQdWYYLeDnZlWSvBuJXdtBVBaBrRCIsHrp3/9Knzz g7hMla0MMX82O8kER2jlXE4HN/XCmVccuQwBR/73i8KcSPufQWYWPzGlvKXh6JJrLQre ebSw== X-Gm-Message-State: AOAM533SXQe+NUeAGJCrD16bN7f0IVvhNid67x4w6hXaP+1lGVHzp4+f 8Ve+R9e3lEgTaACznBX7yT8= X-Google-Smtp-Source: ABdhPJzZe31W/+8QBDGcHi1xcG1tLh3FVP1X/kz/OeUtmPGjjH2C8BtqdYDfN27v2jUrKeIpCLdHcw== X-Received: by 2002:a17:906:840c:: with SMTP id n12mr24102300ejx.246.1597841315755; Wed, 19 Aug 2020 05:48:35 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id m26sm19793213ejn.92.2020.08.19.05.48.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Aug 2020 05:48:35 -0700 (PDT) Date: Wed, 19 Aug 2020 14:48:33 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Cc: Kukjin Kim , Andi Shyti , Mark Brown , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com Subject: Re: [PATCH 6/8] spi: spi-s3c64xx: Check return values Message-ID: <20200819124833.GF18122@kozik-lap> References: <20200819123208.12337-1-l.stelmach@samsung.com> <20200819123208.12337-7-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20200819123208.12337-7-l.stelmach@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, Aug 19, 2020 at 02:32:06PM +0200, Łukasz Stelmach wrote: > Signed-off-by: Łukasz Stelmach > --- > drivers/spi/spi-s3c64xx.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) Oh, come on, stop fixing the same local issue without fixing bigger picture... or at least documenting why bigger picture does not have to be fixed and simple 'return' is enough. That's the third, same fix for the same problem. https://lore.kernel.org/lkml/20190314064202.14864-1-kjlu@umn.edu/ https://lore.kernel.org/lkml/20170207204520.h2eo3yn5kge56lk7@kozik-lap/ Best regards, Krzysztof > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 505789f91fdf..27d77600a820 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -273,6 +273,7 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma, > struct s3c64xx_spi_driver_data *sdd; > struct dma_slave_config config; > struct dma_async_tx_descriptor *desc; > + int ret; > > memset(&config, 0, sizeof(config)); > > @@ -296,11 +297,22 @@ static void prepare_dma(struct s3c64xx_spi_dma_data *dma, > > desc = dmaengine_prep_slave_sg(dma->ch, sgt->sgl, sgt->nents, > dma->direction, DMA_PREP_INTERRUPT); > + if (!desc) { > + dev_err(&sdd->pdev->dev, "unable to prepare %s scatterlist", > + dma->direction == DMA_DEV_TO_MEM ? "rx" : "tx"); > + return; > + } > > desc->callback = s3c64xx_spi_dmacb; > desc->callback_param = dma; > > dma->cookie = dmaengine_submit(desc); > + ret = dma_submit_error(dma->cookie); > + if (ret) { > + dev_err(&sdd->pdev->dev, "dmaengine_submit() failed %d", ret); > + return; > + } > + > dma_async_issue_pending(dma->ch); > } > > -- > 2.26.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85DCFC433E1 for ; Wed, 19 Aug 2020 12:50:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E468206B5 for ; Wed, 19 Aug 2020 12:50:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="23xYPsXP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E468206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k+JFQsabWWq0y/DUO+rD86aRwnH8sAA07l468WjMd6g=; b=23xYPsXPGWbIeveeHJmc8KfqD SfAYHfVK9D4b3yZBx/4vGkpJSdBM5sEpz5Rid6mz9S/uqCQ7r0BeEUFMcf+z9e4H992QAKihCL2YV 0N29yUHKdulvfE6CkWGehqCXekIcgYpt878ew+xSpchG2GM7+T+j8fLxS8QbcjIHxCF6cEqRQ5Dpk SQk1GOKKzJua3NbS9gFeT5qrwtG9B4JC+8NPrYazXoOfSukgOVbTozKjIlqZvfzKjrvnjyCBEjG+7 gfPpvVQqu4Eb/ahdFMG9oigUUJSFONKwkQbpKAuwDRgfh0iL2QvZv6zJI0JjDflG2/KGjje+bPV+P lIwBE4GfA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8NWD-0004TT-0H; Wed, 19 Aug 2020 12:48:41 +0000 Received: from mail-ej1-f67.google.com ([209.85.218.67]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8NW9-0004Re-9b for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2020 12:48:38 +0000 Received: by mail-ej1-f67.google.com with SMTP id a26so26143884ejc.2 for ; Wed, 19 Aug 2020 05:48:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=XfTWVsSwjI65UWFf8mFq+y/lWsZWshehQWdU+KFwzuU=; b=MOUk2k6TVf37h6+1+UFldN/p+xreL81/XXS4XAL1M3ZJ0gTHNa4brxHVR4Zj/KHMBR NhK2YzH208+IoQa0VVHBpNLARWvBznRcf8uM6nor0vkoti/a7zkW8I96NLz0Yz/OPbUj qbJ0eeidyTa8fGVxcI22aBdU/7zO1+QETI4OVS6pgSvAjl+YJ2JJexTtWYDiem5MaL1o u3U2K4rFZOU1GiP0BNdE3f8yf3MOnK/u/2p9vK1vTR/g0+puwVduIHrbZ33N7DfT6Shg fOnCxJPkMmHwjtRzKgBK1YQmctbuHk+HecjT645DceskqyljFwO7XUpLrS4vxrjcI6pM /Oog== X-Gm-Message-State: AOAM531JlMRXIH2ovLmHnNNKTnJISvtfivn+sylqbHKJnMRX3vka2R/D 9BooT1qKOGSqLvDLO5J3DH0= X-Google-Smtp-Source: ABdhPJzZe31W/+8QBDGcHi1xcG1tLh3FVP1X/kz/OeUtmPGjjH2C8BtqdYDfN27v2jUrKeIpCLdHcw== X-Received: by 2002:a17:906:840c:: with SMTP id n12mr24102300ejx.246.1597841315755; Wed, 19 Aug 2020 05:48:35 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id m26sm19793213ejn.92.2020.08.19.05.48.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Aug 2020 05:48:35 -0700 (PDT) Date: Wed, 19 Aug 2020 14:48:33 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Subject: Re: [PATCH 6/8] spi: spi-s3c64xx: Check return values Message-ID: <20200819124833.GF18122@kozik-lap> References: <20200819123208.12337-1-l.stelmach@samsung.com> <20200819123208.12337-7-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200819123208.12337-7-l.stelmach@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_084837_357401_23CBDBAB X-CRM114-Status: GOOD ( 17.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown , Kukjin Kim , Andi Shyti , linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBBdWcgMTksIDIwMjAgYXQgMDI6MzI6MDZQTSArMDIwMCwgxYF1a2FzeiBTdGVsbWFj aCB3cm90ZToKPiBTaWduZWQtb2ZmLWJ5OiDFgXVrYXN6IFN0ZWxtYWNoIDxsLnN0ZWxtYWNoQHNh bXN1bmcuY29tPgo+IC0tLQo+ICBkcml2ZXJzL3NwaS9zcGktczNjNjR4eC5jIHwgMTIgKysrKysr KysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspCgpPaCwgY29tZSBvbiwg c3RvcCBmaXhpbmcgdGhlIHNhbWUgbG9jYWwgaXNzdWUgd2l0aG91dCBmaXhpbmcgYmlnZ2VyCnBp Y3R1cmUuLi4gb3IgYXQgbGVhc3QgZG9jdW1lbnRpbmcgd2h5IGJpZ2dlciBwaWN0dXJlIGRvZXMg bm90IGhhdmUgdG8gYmUKZml4ZWQgYW5kIHNpbXBsZSAncmV0dXJuJyBpcyBlbm91Z2guCgpUaGF0 J3MgdGhlIHRoaXJkLCBzYW1lIGZpeCBmb3IgdGhlIHNhbWUgcHJvYmxlbS4KCmh0dHBzOi8vbG9y ZS5rZXJuZWwub3JnL2xrbWwvMjAxOTAzMTQwNjQyMDIuMTQ4NjQtMS1ramx1QHVtbi5lZHUvCmh0 dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xrbWwvMjAxNzAyMDcyMDQ1MjAuaDJlbzN5bjVrZ2U1Nmxr N0Brb3ppay1sYXAvCgpCZXN0IHJlZ2FyZHMsCktyenlzenRvZgoKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9zcGkvc3BpLXMzYzY0eHguYyBiL2RyaXZlcnMvc3BpL3NwaS1zM2M2NHh4LmMKPiBp bmRleCA1MDU3ODlmOTFmZGYuLjI3ZDc3NjAwYTgyMCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3Nw aS9zcGktczNjNjR4eC5jCj4gKysrIGIvZHJpdmVycy9zcGkvc3BpLXMzYzY0eHguYwo+IEBAIC0y NzMsNiArMjczLDcgQEAgc3RhdGljIHZvaWQgcHJlcGFyZV9kbWEoc3RydWN0IHMzYzY0eHhfc3Bp X2RtYV9kYXRhICpkbWEsCj4gIAlzdHJ1Y3QgczNjNjR4eF9zcGlfZHJpdmVyX2RhdGEgKnNkZDsK PiAgCXN0cnVjdCBkbWFfc2xhdmVfY29uZmlnIGNvbmZpZzsKPiAgCXN0cnVjdCBkbWFfYXN5bmNf dHhfZGVzY3JpcHRvciAqZGVzYzsKPiArCWludCByZXQ7Cj4gIAo+ICAJbWVtc2V0KCZjb25maWcs IDAsIHNpemVvZihjb25maWcpKTsKPiAgCj4gQEAgLTI5NiwxMSArMjk3LDIyIEBAIHN0YXRpYyB2 b2lkIHByZXBhcmVfZG1hKHN0cnVjdCBzM2M2NHh4X3NwaV9kbWFfZGF0YSAqZG1hLAo+ICAKPiAg CWRlc2MgPSBkbWFlbmdpbmVfcHJlcF9zbGF2ZV9zZyhkbWEtPmNoLCBzZ3QtPnNnbCwgc2d0LT5u ZW50cywKPiAgCQkJCSAgICAgICBkbWEtPmRpcmVjdGlvbiwgRE1BX1BSRVBfSU5URVJSVVBUKTsK PiArCWlmICghZGVzYykgewo+ICsJCWRldl9lcnIoJnNkZC0+cGRldi0+ZGV2LCAidW5hYmxlIHRv IHByZXBhcmUgJXMgc2NhdHRlcmxpc3QiLAo+ICsJCQlkbWEtPmRpcmVjdGlvbiA9PSBETUFfREVW X1RPX01FTSA/ICJyeCIgOiAidHgiKTsKPiArCQlyZXR1cm47Cj4gKwl9Cj4gIAo+ICAJZGVzYy0+ Y2FsbGJhY2sgPSBzM2M2NHh4X3NwaV9kbWFjYjsKPiAgCWRlc2MtPmNhbGxiYWNrX3BhcmFtID0g ZG1hOwo+ICAKPiAgCWRtYS0+Y29va2llID0gZG1hZW5naW5lX3N1Ym1pdChkZXNjKTsKPiArCXJl dCA9IGRtYV9zdWJtaXRfZXJyb3IoZG1hLT5jb29raWUpOwo+ICsJaWYgKHJldCkgewo+ICsJCWRl dl9lcnIoJnNkZC0+cGRldi0+ZGV2LCAiZG1hZW5naW5lX3N1Ym1pdCgpIGZhaWxlZCAlZCIsIHJl dCk7Cj4gKwkJcmV0dXJuOwo+ICsJfQo+ICsKPiAgCWRtYV9hc3luY19pc3N1ZV9wZW5kaW5nKGRt YS0+Y2gpOwo+ICB9Cj4gIAo+IC0tIAo+IDIuMjYuMgo+IAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=