From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63502C433DF for ; Wed, 19 Aug 2020 12:49:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 330952072D for ; Wed, 19 Aug 2020 12:49:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597841386; bh=nBKhfdP32spKnedkFS1PBCUAHlv74sAfz7m/hS+rbDw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=wOpFr6EUeRlNHgqCnEZL0BXt12zP9Nhf0YpdgsrcdZL14OTkzbHsNeEqEkP+ZmT96 BaFBD5NjA1m6rH0N6Oh8jEJy/A602x2RQ1bjYTB2s0867UhM/z+AsDKurqVJbrDnBY x4M4g/XK2zgZltrARMlgGOW6woAwI/0o/K7gJhlM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728215AbgHSMtp convert rfc822-to-8bit (ORCPT ); Wed, 19 Aug 2020 08:49:45 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:34267 "EHLO mail-ej1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728090AbgHSMtp (ORCPT ); Wed, 19 Aug 2020 08:49:45 -0400 Received: by mail-ej1-f65.google.com with SMTP id o23so26173946ejr.1; Wed, 19 Aug 2020 05:49:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=8dBUU0Q21El3kg2jckdztSie/u5vjySYPFsHaaaxqE4=; b=aowkI0wdiZo5eNbJqbNd5DD0BbD0D6Vu6YNhzSe49fxzsdsK4ZjYB8/EwK30TK6C+L wog14BSdGbpKYp9BJ6pPcJqepuDw4s71C705c7ZWY2N+L5huvPvKRMLKNz2AYXxxs5lY /uRUYUP3LNLJEJiHusvqOTgdracu3dWkYUUohpY+Y6CTFGhGDV/xzWaxCYQ7kR0tygqQ ZooJP5NyidMYhi94g6952j+aSrXOcM0jC+AjBIEtBG12Bnrw79s7OISuJQLu9tI2S5bM Y5S3zlZqHceRUn8X+x9srAmg93D7Lyh6RM0B9Xd/b7moXBmvXZMXzzfR7q8gjilmlp+I qHzA== X-Gm-Message-State: AOAM530XxB6tbAIUgOCgqxeMXz30uf7LeOTORcHj1MT7SbwopCltnwhC o5ZqcXG3UvFP6yMUNY7pC9M= X-Google-Smtp-Source: ABdhPJwy4yfwjOFogEcaLGnuwIXtds88I8TK5q6CoVDJRuHTnx/Axp937fjZo4CNQzAIXBPAB9WNUQ== X-Received: by 2002:a17:906:8510:: with SMTP id i16mr8060277ejx.76.1597841383455; Wed, 19 Aug 2020 05:49:43 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id g9sm16778134edk.97.2020.08.19.05.49.42 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Aug 2020 05:49:42 -0700 (PDT) Date: Wed, 19 Aug 2020 14:49:40 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Cc: Kukjin Kim , Andi Shyti , Mark Brown , linux-spi@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, m.szyprowski@samsung.com, b.zolnierkie@samsung.com Subject: Re: [PATCH 7/8] spi: spi-s3c64xx: Increase transfer timeout Message-ID: <20200819124940.GG18122@kozik-lap> References: <20200819123208.12337-1-l.stelmach@samsung.com> <20200819123208.12337-8-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20200819123208.12337-8-l.stelmach@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On Wed, Aug 19, 2020 at 02:32:07PM +0200, Łukasz Stelmach wrote: > Signed-off-by: Łukasz Stelmach Why? Everything works fine and suddenly minimum timeout is 100 ms? Best regards, Krzysztof > --- > drivers/spi/spi-s3c64xx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 27d77600a820..27db1e0f6f32 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -464,7 +464,8 @@ static int s3c64xx_wait_for_dma(struct s3c64xx_spi_driver_data *sdd, > > /* millisecs to xfer 'len' bytes @ 'cur_speed' */ > ms = xfer->len * 8 * 1000 / sdd->cur_speed; > - ms += 10; /* some tolerance */ > + ms = (ms * 10) + 30; /* some tolerance */ > + ms = max(ms, 100); /* minimum timeout */ > > val = msecs_to_jiffies(ms) + 10; > val = wait_for_completion_timeout(&sdd->xfer_completion, val); > -- > 2.26.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2698AC433DF for ; Wed, 19 Aug 2020 12:52:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7127206B5 for ; Wed, 19 Aug 2020 12:52:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Xb61zwka" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E7127206B5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8nzEKmCyeOg6vyUziiiUksasHuF8fm8WKetOVsMTO+0=; b=Xb61zwkaIzEd+SppNOzLQmPzN o3nn4HhL5R+lGWRiYXcmvpuatYHcnROaHBVaBgucxgNQ+On8g9eNdm36fTNqSOcRaJfWMw7GGwv0c 4kTDYJ1wG8N09076xYwwW5x7Ma/k9DrEIAUefWxWVX7NYMAJpm1X+gElB4//6b9MaiAa4q7fE6aLo ClAn8X7iGdkCZ/cU9THqw5aQB3tyGhglvaE5tQVTQN6gifEopjIr/CHxvWxyb8FjlX764E8fRuy4g MJ8ctMkJUWQNWLM1nvXBaKk8Hm3sv7+8X95yl9Rr4iTj7x/wwEmqQ2Su9mZAzyw3CgjaL0dG17Rcj p8ZLjHiXA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8NXv-0005AN-EL; Wed, 19 Aug 2020 12:50:28 +0000 Received: from mail-ej1-f68.google.com ([209.85.218.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8NXE-0004rs-Tl for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2020 12:49:49 +0000 Received: by mail-ej1-f68.google.com with SMTP id p24so26096988ejf.13 for ; Wed, 19 Aug 2020 05:49:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=8dBUU0Q21El3kg2jckdztSie/u5vjySYPFsHaaaxqE4=; b=c/5dwX1nbRc8opWK+MKuCTMwQSZjxjfD3MOmcvbIXebu8bIiUwcy2bP6n6JafgLfFk fTQRZq6EUyKJlNDWBYsUSQXDbDnUI875+pmZouQybzLB1OOBhXHrxvBSFwMpAv1A22zl DyWnuPGfc/lxRSU9IA8S74ZT6L8I1Pz+1mA+d0tZI5CHHfu+64PBaJqRLy5mme1m794r SRNwIabFlTvB0uO+NzV+UBpUNN0BDBd7p8GINykI+y87ffrHIfN8F3piadtFF0yBn5mM xH8WJfBf+2EECrF1ict97lfVEBy3G+jbkivbxJ6xwXMMmDn+ywip6SFpxGGiStxTs/FK w6nQ== X-Gm-Message-State: AOAM532IEGQmsxao0BGPoNe4NmwkO5Dh6MJV879zgyMsAI917TBAAFgA XNCN/RCqPy7SVT+084Q4x6s= X-Google-Smtp-Source: ABdhPJwy4yfwjOFogEcaLGnuwIXtds88I8TK5q6CoVDJRuHTnx/Axp937fjZo4CNQzAIXBPAB9WNUQ== X-Received: by 2002:a17:906:8510:: with SMTP id i16mr8060277ejx.76.1597841383455; Wed, 19 Aug 2020 05:49:43 -0700 (PDT) Received: from kozik-lap ([194.230.155.216]) by smtp.googlemail.com with ESMTPSA id g9sm16778134edk.97.2020.08.19.05.49.42 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Aug 2020 05:49:42 -0700 (PDT) Date: Wed, 19 Aug 2020 14:49:40 +0200 From: Krzysztof Kozlowski To: =?utf-8?Q?=C5=81ukasz?= Stelmach Subject: Re: [PATCH 7/8] spi: spi-s3c64xx: Increase transfer timeout Message-ID: <20200819124940.GG18122@kozik-lap> References: <20200819123208.12337-1-l.stelmach@samsung.com> <20200819123208.12337-8-l.stelmach@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200819123208.12337-8-l.stelmach@samsung.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_084945_042331_98CF4CCD X-CRM114-Status: GOOD ( 16.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, b.zolnierkie@samsung.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Mark Brown , Kukjin Kim , Andi Shyti , linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBBdWcgMTksIDIwMjAgYXQgMDI6MzI6MDdQTSArMDIwMCwgxYF1a2FzeiBTdGVsbWFj aCB3cm90ZToKPiBTaWduZWQtb2ZmLWJ5OiDFgXVrYXN6IFN0ZWxtYWNoIDxsLnN0ZWxtYWNoQHNh bXN1bmcuY29tPgoKV2h5PyBFdmVyeXRoaW5nIHdvcmtzIGZpbmUgYW5kIHN1ZGRlbmx5IG1pbmlt dW0gdGltZW91dCBpcyAxMDAgbXM/CgpCZXN0IHJlZ2FyZHMsCktyenlzenRvZgoKPiAtLS0KPiAg ZHJpdmVycy9zcGkvc3BpLXMzYzY0eHguYyB8IDMgKystCj4gIDEgZmlsZSBjaGFuZ2VkLCAyIGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zcGkv c3BpLXMzYzY0eHguYyBiL2RyaXZlcnMvc3BpL3NwaS1zM2M2NHh4LmMKPiBpbmRleCAyN2Q3NzYw MGE4MjAuLjI3ZGIxZTBmNmYzMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL3NwaS9zcGktczNjNjR4 eC5jCj4gKysrIGIvZHJpdmVycy9zcGkvc3BpLXMzYzY0eHguYwo+IEBAIC00NjQsNyArNDY0LDgg QEAgc3RhdGljIGludCBzM2M2NHh4X3dhaXRfZm9yX2RtYShzdHJ1Y3QgczNjNjR4eF9zcGlfZHJp dmVyX2RhdGEgKnNkZCwKPiAgCj4gIAkvKiBtaWxsaXNlY3MgdG8geGZlciAnbGVuJyBieXRlcyBA ICdjdXJfc3BlZWQnICovCj4gIAltcyA9IHhmZXItPmxlbiAqIDggKiAxMDAwIC8gc2RkLT5jdXJf c3BlZWQ7Cj4gLQltcyArPSAxMDsgLyogc29tZSB0b2xlcmFuY2UgKi8KPiArCW1zID0gKG1zICog MTApICsgMzA7ICAgIC8qIHNvbWUgdG9sZXJhbmNlICovCj4gKwltcyA9IG1heChtcywgMTAwKTsg ICAgICAvKiBtaW5pbXVtIHRpbWVvdXQgKi8KPiAgCj4gIAl2YWwgPSBtc2Vjc190b19qaWZmaWVz KG1zKSArIDEwOwo+ICAJdmFsID0gd2FpdF9mb3JfY29tcGxldGlvbl90aW1lb3V0KCZzZGQtPnhm ZXJfY29tcGxldGlvbiwgdmFsKTsKPiAtLSAKPiAyLjI2LjIKPiAKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBs aXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5m cmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK