From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55062C433DF for ; Wed, 19 Aug 2020 16:53:58 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 143D2207FF for ; Wed, 19 Aug 2020 16:53:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Zrc4oyKa"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mELPK41e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 143D2207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FZzF5A1vGrSMToEZy30w9XO41voZESJkJejxXH7Iw2M=; b=Zrc4oyKaW7yb+q87ZjpTy9fqA XqfDuUYWzMp6avUY9HIDHdIY2uuUvhGjRxldmqm85M3P0Hfsifzdz3/jZ6Hc7Bpvy7i70ZWZrzyph 2CqJmBSeol2bxE7AnjnWGzTMFneJ+p737ZFfe5+chQQg+Q3fjwCG6DvNfVDhlHRAOR3RkAP9nMQNn cAWIcp2gpwSixGrhzeefjGATIucbB1MjceYLVV91vDiA+ZMpkVlhHMsqUFE6Kpjw2kzbf2TOGRjE2 iWq0txNaNMzOUplgIxN1EuKFqyFEqH7JbqAxCZTgi/TGrs5B2nIAqOlrvTaxziJzrKMBo+I4e6IAV ysja1GRiQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8RJw-0003pt-WC; Wed, 19 Aug 2020 16:52:17 +0000 Received: from mail-ej1-x642.google.com ([2a00:1450:4864:20::642]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8RJt-0003p2-OE; Wed, 19 Aug 2020 16:52:14 +0000 Received: by mail-ej1-x642.google.com with SMTP id o23so27155415ejr.1; Wed, 19 Aug 2020 09:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Lu1L8Np4Sb1znwysVOMYeFd9PeezWxo0K5RLTh1iwF8=; b=mELPK41eNWYV7XCpw+RnLESHqhS/nSXA6SruNKm9XqHomDbZgcdomg5q5FIYFGSOgF 57r/JqBVViqLKlIIsg4KLyBe+8DjxUn/C3Pxdj8RqwGLc09S8EnZ1QG4OsN8REr6N3cA M9xwDj9I+1WK7OWfJLVMDuugstPh+OdMFKN5xF+M1U3BL7npqHGqOFaoEGxTJIZextjX h51o68qT+7dEgZdmXXYLzP5h3cBRwnRkk2j8Moh/pdNLYDtvuLyYHGt0dZNXEibMbOHh bf/bOUyNZb6D6Ws0NgvGv5DJ63UXWsa8GHq2DiTJysjxkCsWRM8wgyxzQehSY1O1zaar i2ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Lu1L8Np4Sb1znwysVOMYeFd9PeezWxo0K5RLTh1iwF8=; b=YmvfIjQ+UvN6xQpER6vLOColY/uZde7w8miH8EXlhbOG+rRYFO9aDk1YlpDls8hNQB fZkkPHMDO001bUsGNX/p4+4teNQicMQSXOVMqpUL+zSixuFoUIlpmwFs2nKuC39zB0Ds 9kN8oqFlcnI2OpTF0xRHFkC/n4VcBHHY4OMN50Vyf3Taxu3dMu7fYm/f5cWEH0cCYSlP xfdMocFP3k4HeqBvlir8eB6wdJ6HRWaAKrmNCSsjuAqzfnx4C4Sek5ufsBqWX5iva5Bw EZ4qhRCjvZgUO7qDGs/UKe+OTq2kAv15COhyjv6M0UTaJ2KOnVnjSHRe5X/pK0oVW+bj lMVQ== X-Gm-Message-State: AOAM53386A70MCSX3QDVzSuJHl5RwbAPTxph++x7Kk86y+rclRiPeg3i z+pbEhuG/NRo7yWxlwqPVmA= X-Google-Smtp-Source: ABdhPJzExkOe6H5raBLgYHpzAZF5ZdHMeGO0Fle/sZJSryqt3vGK8hjC1O2pz4tO/1tevNlhoZxw8w== X-Received: by 2002:a17:906:f8c3:: with SMTP id lh3mr26531749ejb.263.1597855932552; Wed, 19 Aug 2020 09:52:12 -0700 (PDT) Received: from BV030612LT ([188.24.144.238]) by smtp.gmail.com with ESMTPSA id u6sm19416937ejf.98.2020.08.19.09.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 09:52:12 -0700 (PDT) Date: Wed, 19 Aug 2020 19:52:09 +0300 From: Cristian Ciocaltea To: Marc Zyngier Subject: Re: [PATCH v4 2/3] irqchip: Add Actions Semi Owl SIRQ controller Message-ID: <20200819165209.GA2137769@BV030612LT> References: <8e43fe6c6246bfd5347dc21b6f5c3f50@kernel.org> <20200818174241.GA2020288@BV030612LT> <87lfibn0ie.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87lfibn0ie.wl-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_125213_859991_90F83D29 X-CRM114-Status: GOOD ( 50.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jason Cooper , linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Manivannan Sadhasivam , Thomas Gleixner , Andreas =?iso-8859-1?Q?F=E4rber?= , linux-arm-kernel@lists.infradead.org, Saravanan Sekar Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBBdWcgMTgsIDIwMjAgYXQgMDk6NDg6NDFQTSArMDEwMCwgTWFyYyBaeW5naWVyIHdy b3RlOgo+IE9uIFR1ZSwgMTggQXVnIDIwMjAgMTg6NDI6NDEgKzAxMDAsCj4gQ3Jpc3RpYW4gQ2lv Y2FsdGVhIDxjcmlzdGlhbi5jaW9jYWx0ZWFAZ21haWwuY29tPiB3cm90ZToKPiA+IAo+ID4gSGkg TWFyYywKPiA+IAo+ID4gVGhhbmtzIGZvciB5b3VyIHF1aWNrIGFuZCBkZXRhaWxlZCByZXZpZXch Cj4gPiAKPiA+IE9uIE1vbiwgQXVnIDE3LCAyMDIwIGF0IDAyOjUyOjA2UE0gKzAxMDAsIE1hcmMg WnluZ2llciB3cm90ZToKPiA+ID4gT24gMjAyMC0wOC0xNiAxMjozMywgQ3Jpc3RpYW4gQ2lvY2Fs dGVhIHdyb3RlOgo+ID4gPiA+IFRoaXMgY29udHJvbGxlciBhcHBlYXJzIG9uIEFjdGlvbnMgU2Vt aSBPd2wgZmFtaWx5IFNvQydzIFM1MDAsIFM3MDAgYW5kCj4gPiA+ID4gUzkwMCBhbmQgcHJvdmlk ZXMgc3VwcG9ydCBmb3IgMyBleHRlcm5hbCBpbnRlcnJ1cHQgY29udHJvbGxlcnMgdGhyb3VnaAo+ ID4gPiAKPiA+ID4gSXMgdGhhdCByZWFsbHkgMyBpbnRlcnJ1cHQgY29udHJvbGxlcnM/IE9yIG1l cmVseSAzIGludGVycnVwdCBsaW5lcz8KPiA+IAo+ID4gVGhpcyBpcyBtb3N0bHkgYSBsZWZ0b3Zl ciBzdGF0ZW1lbnQgZnJvbSB0aGUgcHJldmlvdXMgcGF0Y2ggcmV2aXNpb24uCj4gPiBJIHdpbGwg Y2hhbmdlIGl0IHRvIHNvbWV0aGluZyBsaWtlOgo+ID4gCj4gPiAiVGhpcyBpbnRlcnJ1cHQgY29u dHJvbGxlciBpcyBmb3VuZCBpbiB0aGUgQWN0aW9ucyBTZW1pIE93bCBTb0NzIChTNTAwLAo+ID4g UzcwMCBhbmQgUzkwMCkgYW5kIHByb3ZpZGVzIHN1cHBvcnQgZm9yIGhhbmRsaW5nIHVwIHRvIDMg ZXh0ZXJuYWwKPiA+IGludGVycnVwdCBsaW5lcy4iCj4gCj4gTG9va3MgZ29vZC4KPiAKPiA+IAo+ ID4gPiA+IGRlZGljYXRlZCBTSVJRIHBpbnMuCj4gPiA+ID4gCj4gPiA+ID4gRWFjaCBsaW5lIGNh biBiZSBpbmRlcGVuZGVudGx5IGNvbmZpZ3VyZWQgYXMgaW50ZXJydXB0IGFuZCB0cmlnZ2Vycwo+ ID4gPiA+IG9uIGVpdGhlciBvZiB0aGUgZWRnZXMgKHJhaXNpbmcgb3IgZmFsbGluZykgb3IgZWl0 aGVyIG9mIHRoZSBsZXZlbHMKPiA+ID4gPiAoaGlnaCBvciBsb3cpLiBFYWNoIGxpbmUgY2FuIGFs c28gYmUgbWFza2VkIGluZGVwZW5kZW50bHkuCj4gPiA+ID4gCj4gPiA+ID4gVGhpcyBpcyBiYXNl ZCBvbiB0aGUgcGF0Y2ggc2VyaWVzIHN1Ym1pdHRlZCBieSBQYXJ0aGliYW4gTmFsbGF0aGFtYmk6 Cj4gPiA+ID4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGttbC8yMDE4MTEyNjEwMDM1Ni4yODQw NTc4LTEtcG5AZGVueC5kZS8KPiA+ID4gPiAKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBQYXJ0aGli YW4gTmFsbGF0aGFtYmkgPHBuQGRlbnguZGU+Cj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogU2FyYXZh bmFuIFNla2FyIDxzcmF2YW5ob21lQGdtYWlsLmNvbT4KPiA+ID4gPiBbY3Jpc3RpOiBvcHRpbWl6 ZWQgRFQsIHZhcmlvdXMgZml4ZXMvY2xlYW51cHMvaW1wcm92ZW1lbnRzXQo+ID4gPiA+IFNpZ25l ZC1vZmYtYnk6IENyaXN0aWFuIENpb2NhbHRlYSA8Y3Jpc3RpYW4uY2lvY2FsdGVhQGdtYWlsLmNv bT4KPiA+ID4gPiAtLS0KPiA+ID4gPiAgZHJpdmVycy9pcnFjaGlwL01ha2VmaWxlICAgICAgIHwg ICAxICsKPiA+ID4gPiAgZHJpdmVycy9pcnFjaGlwL2lycS1vd2wtc2lycS5jIHwgMzE4ICsrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+ID4gPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDMx OSBpbnNlcnRpb25zKCspCj4gPiA+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL2lycWNo aXAvaXJxLW93bC1zaXJxLmMKPiA+ID4gPiAKPiA+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9p cnFjaGlwL01ha2VmaWxlIGIvZHJpdmVycy9pcnFjaGlwL01ha2VmaWxlCj4gPiA+ID4gaW5kZXgg MTMzZjljNDU3NDRhLi5iOGViNWI4Yjc2NmQgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy9p cnFjaGlwL01ha2VmaWxlCj4gPiA+ID4gKysrIGIvZHJpdmVycy9pcnFjaGlwL01ha2VmaWxlCj4g PiA+ID4gQEAgLTcsNiArNyw3IEBAIG9iai0kKENPTkZJR19BVEg3OSkJCQkrPSBpcnEtYXRoNzkt Y3B1Lm8KPiA+ID4gPiAgb2JqLSQoQ09ORklHX0FUSDc5KQkJCSs9IGlycS1hdGg3OS1taXNjLm8K PiA+ID4gPiAgb2JqLSQoQ09ORklHX0FSQ0hfQkNNMjgzNSkJCSs9IGlycS1iY20yODM1Lm8KPiA+ ID4gPiAgb2JqLSQoQ09ORklHX0FSQ0hfQkNNMjgzNSkJCSs9IGlycS1iY20yODM2Lm8KPiA+ID4g PiArb2JqLSQoQ09ORklHX0FSQ0hfQUNUSU9OUykJCSs9IGlycS1vd2wtc2lycS5vCj4gPiA+ID4g IG9iai0kKENPTkZJR19EQVZJTkNJX0FJTlRDKQkJKz0gaXJxLWRhdmluY2ktYWludGMubwo+ID4g PiA+ICBvYmotJChDT05GSUdfREFWSU5DSV9DUF9JTlRDKQkJKz0gaXJxLWRhdmluY2ktY3AtaW50 Yy5vCj4gPiA+ID4gIG9iai0kKENPTkZJR19FWFlOT1NfSVJRX0NPTUJJTkVSKQkrPSBleHlub3Mt Y29tYmluZXIubwo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2lycWNoaXAvaXJxLW93bC1z aXJxLmMKPiA+ID4gPiBiL2RyaXZlcnMvaXJxY2hpcC9pcnEtb3dsLXNpcnEuYwo+ID4gPiA+IG5l dyBmaWxlIG1vZGUgMTAwNjQ0Cj4gPiA+ID4gaW5kZXggMDAwMDAwMDAwMDAwLi4yOWI3ZmZjNDBh YzcKPiA+ID4gPiAtLS0gL2Rldi9udWxsCj4gPiA+ID4gKysrIGIvZHJpdmVycy9pcnFjaGlwL2ly cS1vd2wtc2lycS5jCj4gPiA+ID4gQEAgLTAsMCArMSwzMTggQEAKPiA+ID4gPiArLy8gU1BEWC1M aWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjArCj4gPiA+ID4gKy8qCj4gPiA+ID4gKyAqIEFjdGlv bnMgU2VtaSBPd2wgU29DcyBTSVJRIGludGVycnVwdCBjb250cm9sbGVyIGRyaXZlcgo+ID4gPiA+ ICsgKgo+ID4gPiA+ICsgKiBDb3B5cmlnaHQgKEMpIDIwMTQgQWN0aW9ucyBTZW1pIEluYy4KPiA+ ID4gPiArICogRGF2aWQgTGl1IDxsaXV3ZWlAYWN0aW9ucy1zZW1pLmNvbT4KPiA+ID4gPiArICoK PiA+ID4gPiArICogQXV0aG9yOiBQYXJ0aGliYW4gTmFsbGF0aGFtYmkgPHBuQGRlbnguZGU+Cj4g PiA+ID4gKyAqIEF1dGhvcjogU2FyYXZhbmFuIFNla2FyIDxzcmF2YW5ob21lQGdtYWlsLmNvbT4K PiA+ID4gPiArICogQXV0aG9yOiBDcmlzdGlhbiBDaW9jYWx0ZWEgPGNyaXN0aWFuLmNpb2NhbHRl YUBnbWFpbC5jb20+Cj4gPiA+ID4gKyAqLwo+ID4gPiA+ICsKPiA+ID4gPiArI2luY2x1ZGUgPGxp bnV4L2ludGVycnVwdC5oPgo+ID4gPiA+ICsjaW5jbHVkZSA8bGludXgvaXJxY2hpcC5oPgo+ID4g PiA+ICsjaW5jbHVkZSA8bGludXgvb2ZfYWRkcmVzcy5oPgo+ID4gPiA+ICsjaW5jbHVkZSA8bGlu dXgvb2ZfaXJxLmg+Cj4gPiA+ID4gKwo+ID4gPiA+ICsjZGVmaW5lIE5VTV9TSVJRCQkJMwo+ID4g PiA+ICsKPiA+ID4gPiArI2RlZmluZSBJTlRDX0VYVENUTF9QRU5ESU5HCQlCSVQoMCkKPiA+ID4g PiArI2RlZmluZSBJTlRDX0VYVENUTF9DTEtfU0VMCQlCSVQoNCkKPiA+ID4gPiArI2RlZmluZSBJ TlRDX0VYVENUTF9FTgkJCUJJVCg1KQo+ID4gPiA+ICsjZGVmaW5lIElOVENfRVhUQ1RMX1RZUEVf TUFTSwkJR0VOTUFTSyg3LCA2KQo+ID4gPiA+ICsjZGVmaW5lIElOVENfRVhUQ1RMX1RZUEVfSElH SAkJMAo+ID4gPiA+ICsjZGVmaW5lIElOVENfRVhUQ1RMX1RZUEVfTE9XCQlCSVQoNikKPiA+ID4g PiArI2RlZmluZSBJTlRDX0VYVENUTF9UWVBFX1JJU0lORwkJQklUKDcpCj4gPiA+ID4gKyNkZWZp bmUgSU5UQ19FWFRDVExfVFlQRV9GQUxMSU5HCShCSVQoNikgfCBCSVQoNykpCj4gPiA+ID4gKwo+ ID4gPiA+ICsvKiBTOTAwIFNJUlExICYgU0lSUTIgY29udHJvbCByZWdpc3RlciBvZmZzZXRzLCBy ZWxhdGl2ZSB0byBTSVJRMCAqLwo+ID4gPiA+ICsjZGVmaW5lIElOVENfRVhUQ1RMMQkJCTB4MDMy OAo+ID4gPiA+ICsjZGVmaW5lIElOVENfRVhUQ1RMMgkJCTB4MDMyYwo+ID4gPiA+ICsKPiA+ID4g PiArc3RydWN0IG93bF9zaXJxX3BhcmFtcyB7Cj4gPiA+ID4gKwkvKiBJTlRDX0VYVENUTCByZWcg c2hhcmVkIGZvciBhbGwgdGhyZWUgU0lSUSBsaW5lcyAqLwo+ID4gPiA+ICsJYm9vbCByZWdfc2hh cmVkOwo+ID4gPiA+ICsJLyogSU5UQ19FWFRDVEwgcmVnIG9mZnNldHMgcmVsYXRpdmUgdG8gY29u dHJvbGxlciBiYXNlIGFkZHJlc3MgKi8KPiA+ID4gPiArCXUxNiByZWdfb2Zmc2V0W05VTV9TSVJR XTsKPiA+ID4gPiArfTsKPiA+ID4gPiArCj4gPiA+ID4gK3N0cnVjdCBvd2xfc2lycV9jaGlwX2Rh dGEgewo+ID4gPiA+ICsJY29uc3Qgc3RydWN0IG93bF9zaXJxX3BhcmFtcyAqcGFyYW1zOwo+ID4g PiA+ICsJdm9pZCBfX2lvbWVtICpiYXNlOwo+ID4gPiA+ICsJcmF3X3NwaW5sb2NrX3QgbG9jazsK PiA+ID4gPiArCXUzMiBleHRfaXJxc1tOVU1fU0lSUV07Cj4gPiA+ID4gKwl1OCB0cmlnZ2VyOwo+ ID4gPiAKPiA+ID4gTml0OiBQbGVhc2UgYWxpZ24gZGF0YSBzdHJ1Y3R1cmUgbWVtYmVycyB2ZXJ0 aWNhbGx5Ogo+ID4gPiAKPiA+ID4gc3RydWN0IG93bF9zaXJxX2NoaXBfZGF0YSB7Cj4gPiA+IAlj b25zdCBzdHJ1Y3Qgb3dsX3NpcnFfcGFyYW1zICpwYXJhbXM7Cj4gPiA+IAl2b2lkIF9faW9tZW0g ICAgICAgICAgICAgICAgICpiYXNlOwo+ID4gPiAJcmF3X3NwaW5sb2NrX3QgICAgICAgICAgICAg ICBsb2NrOwo+ID4gPiAJdTMyICAgICAgICAgICAgICAgICAgICAgICAgICBleHRfaXJxc1tOVU1f U0lSUV07Cj4gPiA+IAl1OCAgICAgICAgICAgICAgICAgICAgICAgICAgIHRyaWdnZXI7Cj4gPiA+ IH07Cj4gPiAKPiA+IERvbmUuCj4gPiAKPiA+ID4gPiArfTsKPiA+ID4gPiArCj4gPiA+ID4gKy8q IFM1MDAgYW5kIFM3MDAgU29DcyAqLwo+ID4gPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IG93bF9z aXJxX3BhcmFtcyBvd2xfc2lycV9zNTAwX3BhcmFtcyA9IHsKPiA+ID4gPiArCS5yZWdfc2hhcmVk ID0gdHJ1ZSwKPiA+ID4gPiArCS5yZWdfb2Zmc2V0ID0geyAwLCAwLCAwIH0sCj4gPiA+ID4gK307 Cj4gPiA+ID4gKwo+ID4gPiA+ICsvKiBTOTAwIFNvQyAqLwo+ID4gPiA+ICtzdGF0aWMgY29uc3Qg c3RydWN0IG93bF9zaXJxX3BhcmFtcyBvd2xfc2lycV9zOTAwX3BhcmFtcyA9IHsKPiA+ID4gPiAr CS5yZWdfc2hhcmVkID0gZmFsc2UsCj4gPiA+ID4gKwkucmVnX29mZnNldCA9IHsgMCwgSU5UQ19F WFRDVEwxLCBJTlRDX0VYVENUTDIgfSwKPiA+ID4gCj4gPiA+IDAgKmlzKiBhbiBvZmZzZXQsIHJp Z2h0PyBXaHkgZG9lc24ndCBpdCBoYXZlIGEgbmFtZSB0b28/Cj4gPiAKPiA+IFJpZ2h0LCBJIHVw ZGF0ZWQgdGhlIGRlZmluZXMgc2VjdGlvbjoKPiA+IAo+ID4gLyogUzkwMCBTSVJRIGNvbnRyb2wg cmVnaXN0ZXIgb2Zmc2V0cywgcmVsYXRpdmUgdG8gY29udHJvbGxlciBiYXNlIGFkZHJlc3MgKi8K PiA+ICNkZWZpbmUgSU5UQ19FWFRDVEwwCQkJMHgwMDAwCj4gPiAjZGVmaW5lIElOVENfRVhUQ1RM MQkJCTB4MDMyOAo+ID4gWy4uLl0KPiA+IAo+ID4gVGhlIGNvbnRyb2xsZXIgYmFzZSBhZGRyZXNz IHBvaW50cyB0byBTSVJRMCBjb250cm9sIHJlZ2lzdGVyLCBzbyB0aGlzCj4gPiBvZmZzZXQgaXMg YWx3YXlzIDAsIGJ1dCBJIHRvdGFsbHkgYWdyZWUgd2Ugc2hvdWxkIGhhdmUgYSBuYW1lIGZvciBp dC4KPiA+IAo+ID4gPiA+ICt9Owo+ID4gPiA+ICsKPiA+ID4gPiArc3RhdGljIHUzMiBvd2xfc2ly cV9yZWFkX2V4dGN0bChzdHJ1Y3Qgb3dsX3NpcnFfY2hpcF9kYXRhICpkYXRhLCB1MzIKPiA+ID4g PiBpbmRleCkKPiA+ID4gPiArewo+ID4gPiA+ICsJdTMyIHZhbDsKPiA+ID4gPiArCj4gPiA+ID4g Kwl2YWwgPSByZWFkbF9yZWxheGVkKGRhdGEtPmJhc2UgKyBkYXRhLT5wYXJhbXMtPnJlZ19vZmZz ZXRbaW5kZXhdKTsKPiA+ID4gPiArCWlmIChkYXRhLT5wYXJhbXMtPnJlZ19zaGFyZWQpCj4gPiA+ ID4gKwkJdmFsID0gKHZhbCA+PiAoMiAtIGluZGV4KSAqIDgpICYgMHhmZjsKPiA+ID4gCj4gPiA+ ICAgICAgICAgYmFzZSA9ICgyIC0gaW5kZXgpICogODsKPiA+ID4gICAgICAgICB2YWwgPSBGSUVM RF9HRVQoR0VOTUFTSyhiYXNlICsgNywgYmFzZSksIHZhbCk7Cj4gPiAKPiA+IFVuZm9ydHVuYXRl bHkgdGhlIGNvbnRleHQgZG9lc24ndCBhbGxvdyB1c2luZyBGSUVMRF9HRVQ6Cj4gPiAKPiA+IC4v aW5jbHVkZS9saW51eC9jb21waWxlci5oOjM5MjozODogZXJyb3I6IGNhbGwgdG8g4oCYX19jb21w aWxldGltZV9hc3NlcnRfMTU54oCZIAo+ID4gIGRlY2xhcmVkIHdpdGggYXR0cmlidXRlIGVycm9y OiBGSUVMRF9HRVQ6IG1hc2sgaXMgbm90IGNvbnN0YW50Cj4gCj4gQmFoLiBUdXJuaW5nIHRoZSB3 aG9sZSB0aGluZyBpbnRvIGNvbXBpbGUtdGltZSB2YWx1ZXMgd291bGQgYWN0dWFsbHkKPiBiZSBt b3JlIHJlYWRhYmxlLCBzbyBob3cgYWJvdXQgdGhpczoKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9pcnFjaGlwL2lycS1vd2wtc2lycS5jIGIvZHJpdmVycy9pcnFjaGlwL2lycS1vd2wtc2lycS5j Cj4gaW5kZXggMjliN2ZmYzQwYWM3Li5iNzcxYWNiZGE3ZDUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9pcnFjaGlwL2lycS1vd2wtc2lycS5jCj4gKysrIGIvZHJpdmVycy9pcnFjaGlwL2lycS1vd2wt c2lycS5jCj4gQEAgLTU3LDEzICs1NywzOSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG93bF9zaXJx X3BhcmFtcyBvd2xfc2lycV9zOTAwX3BhcmFtcyA9IHsKPiAgCS5yZWdfb2Zmc2V0ID0geyAwLCBJ TlRDX0VYVENUTDEsIElOVENfRVhUQ1RMMiB9LAo+ICB9Owo+ICAKPiArc3RhdGljIHUzMiBvd2xf ZmllbGRfZ2V0KHUzMiB2YWwsIGludCBpbmRleCkKPiArewo+ICsJc3dpdGNoKGluZGV4KSB7Cj4g KwljYXNlIDA6Cj4gKwkJcmV0dXJuIEZJRUxEX0dFVChHRU5NQVNLKDIzLCAxNiksIHZhbCk7Cj4g KwljYXNlIDE6Cj4gKwkJcmV0dXJuIEZJRUxEX0dFVChHRU5NQVNLKDE1LCA4KSwgdmFsKTsKPiAr CWNhc2UgMjoKPiArCWRlZmF1bHQ6Cj4gKwkJcmV0dXJuIEZJRUxEX0dFVChHRU5NQVNLKDcsIDAp LCB2YWwpOwo+ICsJfQo+ICt9Cj4gKwo+ICtzdGF0aWMgdTMyIG93bF9maWVsZF9wcmVwKHUzMiB2 YWwsIGludCBpbmRleCkKPiArewo+ICsJc3dpdGNoKGluZGV4KSB7Cj4gKwljYXNlIDA6Cj4gKwkJ cmV0dXJuIEZJRUxEX1BSRVAoR0VOTUFTSygyMywgMTYpLCB2YWwpOwo+ICsJY2FzZSAxOgo+ICsJ CXJldHVybiBGSUVMRF9QUkVQKEdFTk1BU0soMTUsIDgpLCB2YWwpOwo+ICsJY2FzZSAyOgo+ICsJ ZGVmYXVsdDoKPiArCQlyZXR1cm4gRklFTERfUFJFUChHRU5NQVNLKDcsIDApLCB2YWwpOwo+ICsJ fQo+ICt9Cj4gKwo+ICBzdGF0aWMgdTMyIG93bF9zaXJxX3JlYWRfZXh0Y3RsKHN0cnVjdCBvd2xf c2lycV9jaGlwX2RhdGEgKmRhdGEsIHUzMiBpbmRleCkKPiAgewo+ICAJdTMyIHZhbDsKPiAgCj4g IAl2YWwgPSByZWFkbF9yZWxheGVkKGRhdGEtPmJhc2UgKyBkYXRhLT5wYXJhbXMtPnJlZ19vZmZz ZXRbaW5kZXhdKTsKPiAgCWlmIChkYXRhLT5wYXJhbXMtPnJlZ19zaGFyZWQpCj4gLQkJdmFsID0g KHZhbCA+PiAoMiAtIGluZGV4KSAqIDgpICYgMHhmZjsKPiArCQl2YWwgPSBvd2xfZmllbGRfZ2V0 KHZhbCwgaW5kZXgpOwo+ICAKPiAgCXJldHVybiB2YWw7Cj4gIH0KPiBAQCAtNzUsOSArMTAxLDgg QEAgc3RhdGljIHZvaWQgb3dsX3NpcnFfd3JpdGVfZXh0Y3RsKHN0cnVjdCBvd2xfc2lycV9jaGlw X2RhdGEgKmRhdGEsCj4gIAo+ICAJaWYgKGRhdGEtPnBhcmFtcy0+cmVnX3NoYXJlZCkgewo+ICAJ CXZhbCA9IHJlYWRsX3JlbGF4ZWQoZGF0YS0+YmFzZSArIGRhdGEtPnBhcmFtcy0+cmVnX29mZnNl dFtpbmRleF0pOwo+IC0JCXZhbCAmPSB+KDB4ZmYgPDwgKDIgLSBpbmRleCkgKiA4KTsKPiAtCQll eHRjdGwgJj0gMHhmZjsKPiAtCQlleHRjdGwgPSAoZXh0Y3RsIDw8ICgyIC0gaW5kZXgpICogOCkg fCB2YWw7Cj4gKwkJdmFsICY9IH5vd2xfZmllbGRfcHJlcCgweGZmLCBpbmRleCk7Cj4gKwkJZXh0 Y3RsID0gb3dsX2ZpZWxkX3ByZXAoZXh0Y3RsLCBpbmRleCkgfCB2YWw7Cj4gIAl9Cj4gIAo+ICAJ d3JpdGVsX3JlbGF4ZWQoZXh0Y3RsLCBkYXRhLT5iYXNlICsgZGF0YS0+cGFyYW1zLT5yZWdfb2Zm c2V0W2luZGV4XSk7Cj4gCj4gWWVzLCB0aGlzIGlzIGEgYml0IG1vcmUgY29kZSwgYnV0IGl0ICpp cyogcmVhZGFibGUuIEJvbnVzIHBvaW50cyBpZgo+IHlvdSBhZGQgcHJvcGVyIGRlZmluZXMgZm9y IHRoZSBtYXNrcy4KIApUaGF0J3MgZ3JlYXQsIHRoYW5rcyBhIGxvdCEKCkkgaGF2ZSBzdWJtaXR0 ZWQgYSBuZXcgcmV2aXNpb246Cmh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xrbWwvY292ZXIuMTU5 Nzg1MjM2MC5naXQuY3Jpc3RpYW4uY2lvY2FsdGVhQGdtYWlsLmNvbS8KClJlZ2FyZHMsCkNyaXN0 aQoKPiA+IAo+ID4gPiA+ICsKPiA+ID4gPiArCXJldHVybiB2YWw7Cj4gPiA+ID4gK30KPiA+ID4g PiArCj4gPiA+ID4gK3N0YXRpYyB2b2lkIG93bF9zaXJxX3dyaXRlX2V4dGN0bChzdHJ1Y3Qgb3ds X3NpcnFfY2hpcF9kYXRhICpkYXRhLAo+ID4gPiA+ICsJCQkJICB1MzIgZXh0Y3RsLCB1MzIgaW5k ZXgpCj4gPiA+ID4gK3sKPiA+ID4gPiArCXUzMiB2YWw7Cj4gPiA+ID4gKwo+ID4gPiA+ICsJaWYg KGRhdGEtPnBhcmFtcy0+cmVnX3NoYXJlZCkgewo+ID4gPiA+ICsJCXZhbCA9IHJlYWRsX3JlbGF4 ZWQoZGF0YS0+YmFzZSArIGRhdGEtPnBhcmFtcy0+cmVnX29mZnNldFtpbmRleF0pOwo+ID4gPiA+ ICsJCXZhbCAmPSB+KDB4ZmYgPDwgKDIgLSBpbmRleCkgKiA4KTsKPiA+ID4gPiArCQlleHRjdGwg Jj0gMHhmZjsKPiA+ID4gPiArCQlleHRjdGwgPSAoZXh0Y3RsIDw8ICgyIC0gaW5kZXgpICogOCkg fCB2YWw7Cj4gPiA+IAo+ID4gPiBQbGVhc2UgbWFrZSB1c2Ugb2YgRklFTERfUFJFUCwgRklFTERf R0VUIGFuZCBHRU5NQVNLLgo+ID4gCj4gPiBJJ20gbm90IHN1cmUgaG93IHRvIGRlYWwgd2l0aCB0 aGUgbWFzayBjb25zdG5lc3MgcmVzdHJpY3Rpb24sIGV4Y2VwdAo+ID4gdXNpbmcgc3RhdGljIGRl ZmluZXMgYW5kIGlmL2Vsc2Ugc3RhdGVtZW50cywgd2hpY2ggaXMgbm90IHF1aXRlCj4gPiBlbGVn YW50Lgo+IAo+IFNlZSBhYm92ZS4KPiAKPiA+IAo+ID4gPiA+ICsJfQo+ID4gPiA+ICsKPiA+ID4g PiArCXdyaXRlbF9yZWxheGVkKGV4dGN0bCwgZGF0YS0+YmFzZSArIGRhdGEtPnBhcmFtcy0+cmVn X29mZnNldFtpbmRleF0pOwo+ID4gPiA+ICt9Cj4gPiA+ID4gKwo+ID4gPiA+ICtzdGF0aWMgdm9p ZCBvd2xfc2lycV9jbGVhcl9zZXRfZXh0Y3RsKHN0cnVjdCBvd2xfc2lycV9jaGlwX2RhdGEgKmQs Cj4gPiA+ID4gKwkJCQkgICAgICB1MzIgY2xlYXIsIHUzMiBzZXQsIHUzMiBpbmRleCkKPiA+ID4g PiArewo+ID4gPiA+ICsJdW5zaWduZWQgbG9uZyBmbGFnczsKPiA+ID4gPiArCXUzMiB2YWw7Cj4g PiA+ID4gKwo+ID4gPiA+ICsJcmF3X3NwaW5fbG9ja19pcnFzYXZlKCZkLT5sb2NrLCBmbGFncyk7 Cj4gPiA+ID4gKwl2YWwgPSBvd2xfc2lycV9yZWFkX2V4dGN0bChkLCBpbmRleCk7Cj4gPiA+ID4g Kwl2YWwgJj0gfmNsZWFyOwo+ID4gPiA+ICsJdmFsIHw9IHNldDsKPiA+ID4gPiArCW93bF9zaXJx X3dyaXRlX2V4dGN0bChkLCB2YWwsIGluZGV4KTsKPiA+ID4gPiArCXJhd19zcGluX3VubG9ja19p cnFyZXN0b3JlKCZkLT5sb2NrLCBmbGFncyk7Cj4gPiA+ID4gK30KPiA+ID4gPiArCj4gPiA+ID4g K3N0YXRpYyB2b2lkIG93bF9zaXJxX2VvaShzdHJ1Y3QgaXJxX2RhdGEgKmRhdGEpCj4gPiA+ID4g K3sKPiA+ID4gPiArCXN0cnVjdCBvd2xfc2lycV9jaGlwX2RhdGEgKmNoaXBfZGF0YSA9Cj4gPiA+ ID4gaXJxX2RhdGFfZ2V0X2lycV9jaGlwX2RhdGEoZGF0YSk7Cj4gPiA+ID4gKwo+ID4gPiA+ICsJ LyoKPiA+ID4gPiArCSAqIFNvZnR3YXJlIG11c3QgY2xlYXIgZXh0ZXJuYWwgaW50ZXJydXB0IHBl bmRpbmcsIHdoZW4gaW50ZXJydXB0IHR5cGUKPiA+ID4gPiArCSAqIGlzIGVkZ2UgdHJpZ2dlcmVk LCBzbyB3ZSBuZWVkIHBlciBTSVJRIGJhc2VkIGNsZWFyaW5nLgo+ID4gPiA+ICsJICovCj4gPiA+ ID4gKwlpZiAoY2hpcF9kYXRhLT50cmlnZ2VyICYgKDEgPDwgZGF0YS0+aHdpcnEpKQo+ID4gPiAK PiA+ID4gQklUKGQtPmh3aXJxKQo+ID4gPiAKPiA+ID4gQnV0IGl0IGFsc28gYmVncyB0aGUgcXVl c3Rpb246IHdlIGFscmVhZHkgaGF2ZSBhbGwgdGhlIHRyaWdnZXIgaW5mb3JtYXRpb24KPiA+ID4g aW4gdGhlIGlycWRlc2MuIFdoeSBkbyB5b3UgbmVlZCBzb21lIGFkZGl0aW9uYWwgYm9va2tlZXBp bmc/Cj4gPiAKPiA+IFRoYXQncyBhbm90aGVyIGxlZnRvdmVyIGZyb20gdGhlIG9yaWdpbmFsIHdv cmsuIFRoYW5rcyBmb3IgcG9pbnRpbmcKPiA+IHRoaXMgb3V0LCBJIG1pc3NlZCBpdC4gSSBkcm9w cGVkIHRoZSByZWR1bmRhbnQgaGFuZGxpbmcgb2YgdGhlIElSUQo+ID4gdHJpZ2dlciBpbmZvcm1h dGlvbiBhbmQganVzdCByZXBsYWNlZCB0aGlzIHdpdGg6Cj4gPiAKPiA+ICAgaWYgKCFpcnFkX2lz X2xldmVsX3R5cGUoZGF0YSkpCj4gCj4gWXVwLgo+IAo+ID4gCj4gPiA+ID4gKwkJb3dsX3NpcnFf Y2xlYXJfc2V0X2V4dGN0bChjaGlwX2RhdGEsIDAsIElOVENfRVhUQ1RMX1BFTkRJTkcsCj4gPiA+ ID4gKwkJCQkJICBkYXRhLT5od2lycSk7Cj4gPiA+ID4gKwo+ID4gPiA+ICsJaXJxX2NoaXBfZW9p X3BhcmVudChkYXRhKTsKPiA+ID4gPiArfQo+ID4gPiA+ICsKPiA+ID4gPiArc3RhdGljIHZvaWQg b3dsX3NpcnFfbWFzayhzdHJ1Y3QgaXJxX2RhdGEgKmRhdGEpCj4gPiA+ID4gK3sKPiA+ID4gPiAr CXN0cnVjdCBvd2xfc2lycV9jaGlwX2RhdGEgKmNoaXBfZGF0YSA9Cj4gPiA+ID4gaXJxX2RhdGFf Z2V0X2lycV9jaGlwX2RhdGEoZGF0YSk7Cj4gPiA+ID4gKwo+ID4gPiA+ICsJb3dsX3NpcnFfY2xl YXJfc2V0X2V4dGN0bChjaGlwX2RhdGEsIElOVENfRVhUQ1RMX0VOLCAwLCBkYXRhLT5od2lycSk7 Cj4gPiA+ID4gKwlpcnFfY2hpcF9tYXNrX3BhcmVudChkYXRhKTsKPiA+ID4gPiArfQo+ID4gPiA+ ICsKPiA+ID4gPiArc3RhdGljIHZvaWQgb3dsX3NpcnFfdW5tYXNrKHN0cnVjdCBpcnFfZGF0YSAq ZGF0YSkKPiA+ID4gPiArewo+ID4gPiA+ICsJc3RydWN0IG93bF9zaXJxX2NoaXBfZGF0YSAqY2hp cF9kYXRhID0KPiA+ID4gPiBpcnFfZGF0YV9nZXRfaXJxX2NoaXBfZGF0YShkYXRhKTsKPiA+ID4g PiArCj4gPiA+ID4gKwlvd2xfc2lycV9jbGVhcl9zZXRfZXh0Y3RsKGNoaXBfZGF0YSwgMCwgSU5U Q19FWFRDVExfRU4sIGRhdGEtPmh3aXJxKTsKPiA+ID4gPiArCWlycV9jaGlwX3VubWFza19wYXJl bnQoZGF0YSk7Cj4gPiA+ID4gK30KPiA+ID4gPiArCj4gPiA+ID4gKy8qCj4gPiA+ID4gKyAqIEdJ QyBkb2VzIG5vdCBoYW5kbGUgZmFsbGluZyBlZGdlIG9yIGFjdGl2ZSBsb3csIGhlbmNlIFNJUlEg c2hhbGwgYmUKPiA+ID4gPiArICogcHJvZ3JhbW1lZCB0byBjb252ZXJ0IGZhbGxpbmcgZWRnZSB0 byByaXNpbmcgZWRnZSBzaWduYWwgYW5kIGFjdGl2ZQo+ID4gPiA+ICsgKiBsb3cgdG8gYWN0aXZl IGhpZ2ggc2lnbmFsLgo+ID4gPiA+ICsgKi8KPiA+ID4gPiArc3RhdGljIGludCBvd2xfc2lycV9z ZXRfdHlwZShzdHJ1Y3QgaXJxX2RhdGEgKmRhdGEsIHVuc2lnbmVkIGludCB0eXBlKQo+ID4gPiA+ ICt7Cj4gPiA+ID4gKwlzdHJ1Y3Qgb3dsX3NpcnFfY2hpcF9kYXRhICpjaGlwX2RhdGEgPQo+ID4g PiA+IGlycV9kYXRhX2dldF9pcnFfY2hpcF9kYXRhKGRhdGEpOwo+ID4gPiA+ICsJdTMyIHNpcnFf dHlwZTsKPiA+ID4gPiArCj4gPiA+ID4gKwlzd2l0Y2ggKHR5cGUpIHsKPiA+ID4gPiArCWNhc2Ug SVJRX1RZUEVfTEVWRUxfTE9XOgo+ID4gPiA+ICsJCXNpcnFfdHlwZSA9IElOVENfRVhUQ1RMX1RZ UEVfTE9XOwo+ID4gPiA+ICsJCWNoaXBfZGF0YS0+dHJpZ2dlciAmPSB+KDEgPDwgZGF0YS0+aHdp cnEpOwo+ID4gPiA+ICsJCXR5cGUgPSBJUlFfVFlQRV9MRVZFTF9ISUdIOwo+ID4gPiA+ICsJCWJy ZWFrOwo+ID4gPiA+ICsJY2FzZSBJUlFfVFlQRV9MRVZFTF9ISUdIOgo+ID4gPiA+ICsJCXNpcnFf dHlwZSA9IElOVENfRVhUQ1RMX1RZUEVfSElHSDsKPiA+ID4gPiArCQljaGlwX2RhdGEtPnRyaWdn ZXIgJj0gfigxIDw8IGRhdGEtPmh3aXJxKTsKPiA+ID4gPiArCQlicmVhazsKPiA+ID4gPiArCWNh c2UgSVJRX1RZUEVfRURHRV9GQUxMSU5HOgo+ID4gPiA+ICsJCXNpcnFfdHlwZSA9IElOVENfRVhU Q1RMX1RZUEVfRkFMTElORzsKPiA+ID4gPiArCQljaGlwX2RhdGEtPnRyaWdnZXIgfD0gMSA8PCBk YXRhLT5od2lycTsKPiA+ID4gPiArCQl0eXBlID0gSVJRX1RZUEVfRURHRV9SSVNJTkc7Cj4gPiA+ ID4gKwkJYnJlYWs7Cj4gPiA+ID4gKwljYXNlIElSUV9UWVBFX0VER0VfUklTSU5HOgo+ID4gPiA+ ICsJCXNpcnFfdHlwZSA9IElOVENfRVhUQ1RMX1RZUEVfUklTSU5HOwo+ID4gPiA+ICsJCWNoaXBf ZGF0YS0+dHJpZ2dlciB8PSAxIDw8IGRhdGEtPmh3aXJxOwo+ID4gPiA+ICsJCWJyZWFrOwo+ID4g PiA+ICsJZGVmYXVsdDoKPiA+ID4gPiArCQlXQVJOX09OKDEpOwo+ID4gPiAKPiA+ID4gTm8gbmVl ZCBmb3IgdGhpcyBXQVJOX09OKCksIHRoZSBjb3JlIGtlcm5lbCBpcyBsb3VkIGVub3VnaC4KPiA+ IAo+ID4gRG9uZS4KPiA+IAo+ID4gPiA+ICsJCXJldHVybiAtRUlOVkFMOwo+ID4gPiA+ICsJfQo+ ID4gPiA+ICsKPiA+ID4gPiArCW93bF9zaXJxX2NsZWFyX3NldF9leHRjdGwoY2hpcF9kYXRhLCBJ TlRDX0VYVENUTF9UWVBFX01BU0ssIHNpcnFfdHlwZSwKPiA+ID4gPiArCQkJCSAgZGF0YS0+aHdp cnEpOwo+ID4gPiA+ICsKPiA+ID4gPiArCXJldHVybiBpcnFfY2hpcF9zZXRfdHlwZV9wYXJlbnQo ZGF0YSwgdHlwZSk7Cj4gPiA+ID4gK30KPiA+ID4gPiArCj4gPiA+ID4gK3N0YXRpYyBzdHJ1Y3Qg aXJxX2NoaXAgb3dsX3NpcnFfY2hpcCA9IHsKPiA+ID4gPiArCS5uYW1lCQk9ICJvd2wtc2lycSIs Cj4gPiA+ID4gKwkuaXJxX21hc2sJPSBvd2xfc2lycV9tYXNrLAo+ID4gPiA+ICsJLmlycV91bm1h c2sJPSBvd2xfc2lycV91bm1hc2ssCj4gPiA+ID4gKwkuaXJxX2VvaQk9IG93bF9zaXJxX2VvaSwK PiA+ID4gPiArCS5pcnFfc2V0X3R5cGUJPSBvd2xfc2lycV9zZXRfdHlwZSwKPiA+ID4gPiArCS5p cnFfcmV0cmlnZ2VyCT0gaXJxX2NoaXBfcmV0cmlnZ2VyX2hpZXJhcmNoeSwKPiA+ID4gCj4gPiA+ IEhvdyBhYm91dCBpcnFfc2V0X2FmZmluaXR5PyBPciBkb2VzIGl0IG9ubHkgZXhpc3Qgb24gVVAg c3lzdGVtcz8KPiA+IAo+ID4gSSBoYXZlIGp1c3QgYWRkZWQ6Cj4gPiAKPiA+ICNpZmRlZiBDT05G SUdfU01QCj4gPiAJLmlycV9zZXRfYWZmaW5pdHkgPSBpcnFfY2hpcF9zZXRfYWZmaW5pdHlfcGFy ZW50LAo+ID4gI2VuZGlmCj4gCj4gTG9va3MgT0suCj4gCj4gQ2hlZXJzLAo+IAo+IAlNLgo+IAo+ IC0tIAo+IFdpdGhvdXQgZGV2aWF0aW9uIGZyb20gdGhlIG5vcm0sIHByb2dyZXNzIGlzIG5vdCBw b3NzaWJsZS4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B504BC433DF for ; Wed, 19 Aug 2020 16:52:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8283F207FF for ; Wed, 19 Aug 2020 16:52:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mELPK41e" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725939AbgHSQwQ (ORCPT ); Wed, 19 Aug 2020 12:52:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbgHSQwO (ORCPT ); Wed, 19 Aug 2020 12:52:14 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04A7DC061757; Wed, 19 Aug 2020 09:52:14 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id bo3so27077206ejb.11; Wed, 19 Aug 2020 09:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=Lu1L8Np4Sb1znwysVOMYeFd9PeezWxo0K5RLTh1iwF8=; b=mELPK41eNWYV7XCpw+RnLESHqhS/nSXA6SruNKm9XqHomDbZgcdomg5q5FIYFGSOgF 57r/JqBVViqLKlIIsg4KLyBe+8DjxUn/C3Pxdj8RqwGLc09S8EnZ1QG4OsN8REr6N3cA M9xwDj9I+1WK7OWfJLVMDuugstPh+OdMFKN5xF+M1U3BL7npqHGqOFaoEGxTJIZextjX h51o68qT+7dEgZdmXXYLzP5h3cBRwnRkk2j8Moh/pdNLYDtvuLyYHGt0dZNXEibMbOHh bf/bOUyNZb6D6Ws0NgvGv5DJ63UXWsa8GHq2DiTJysjxkCsWRM8wgyxzQehSY1O1zaar i2ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Lu1L8Np4Sb1znwysVOMYeFd9PeezWxo0K5RLTh1iwF8=; b=A2C3Q7SxF3ICTNUq71Iac5guKEhha+0uNvvuaH6BYGhoaAehluLisIpGCHKUoUpNMF 6VFhUiLIuYKPIfSstzWOfGKShc3FLgP6UtIFlgwLwgHSnGfomdRLnoaj3VO9zjumwb8i 8OnRW9hOj0P7igfK0Fktaspt04W47xb7TDlw1TSF1lVlnvw6PC5mG1Zm+mpJh2aIYKjx CMVSGZtOU40Van43oiDqSCiar99yauynPioVIzCc74touCYArrqIQViEdHIx+za7ltnl TBpB3X9yxuqxt3LOvEDK9DN7mx07jUC0X8X8Hd52vVLesQpgCZdMyv76MDGFfsR/wRlQ Ykdw== X-Gm-Message-State: AOAM530YzW0HLHyuihCyZeCxS2biwNA0vjVD0BKU80PS+jazTJxgYU+P 5ry7/K07xIDPtYTPnyvSOSw= X-Google-Smtp-Source: ABdhPJzExkOe6H5raBLgYHpzAZF5ZdHMeGO0Fle/sZJSryqt3vGK8hjC1O2pz4tO/1tevNlhoZxw8w== X-Received: by 2002:a17:906:f8c3:: with SMTP id lh3mr26531749ejb.263.1597855932552; Wed, 19 Aug 2020 09:52:12 -0700 (PDT) Received: from BV030612LT ([188.24.144.238]) by smtp.gmail.com with ESMTPSA id u6sm19416937ejf.98.2020.08.19.09.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 09:52:12 -0700 (PDT) Date: Wed, 19 Aug 2020 19:52:09 +0300 From: Cristian Ciocaltea To: Marc Zyngier Cc: Thomas Gleixner , Jason Cooper , Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , Manivannan Sadhasivam , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, Saravanan Sekar Subject: Re: [PATCH v4 2/3] irqchip: Add Actions Semi Owl SIRQ controller Message-ID: <20200819165209.GA2137769@BV030612LT> References: <8e43fe6c6246bfd5347dc21b6f5c3f50@kernel.org> <20200818174241.GA2020288@BV030612LT> <87lfibn0ie.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87lfibn0ie.wl-maz@kernel.org> Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Aug 18, 2020 at 09:48:41PM +0100, Marc Zyngier wrote: > On Tue, 18 Aug 2020 18:42:41 +0100, > Cristian Ciocaltea wrote: > > > > Hi Marc, > > > > Thanks for your quick and detailed review! > > > > On Mon, Aug 17, 2020 at 02:52:06PM +0100, Marc Zyngier wrote: > > > On 2020-08-16 12:33, Cristian Ciocaltea wrote: > > > > This controller appears on Actions Semi Owl family SoC's S500, S700 and > > > > S900 and provides support for 3 external interrupt controllers through > > > > > > Is that really 3 interrupt controllers? Or merely 3 interrupt lines? > > > > This is mostly a leftover statement from the previous patch revision. > > I will change it to something like: > > > > "This interrupt controller is found in the Actions Semi Owl SoCs (S500, > > S700 and S900) and provides support for handling up to 3 external > > interrupt lines." > > Looks good. > > > > > > > dedicated SIRQ pins. > > > > > > > > Each line can be independently configured as interrupt and triggers > > > > on either of the edges (raising or falling) or either of the levels > > > > (high or low). Each line can also be masked independently. > > > > > > > > This is based on the patch series submitted by Parthiban Nallathambi: > > > > https://lore.kernel.org/lkml/20181126100356.2840578-1-pn@denx.de/ > > > > > > > > Signed-off-by: Parthiban Nallathambi > > > > Signed-off-by: Saravanan Sekar > > > > [cristi: optimized DT, various fixes/cleanups/improvements] > > > > Signed-off-by: Cristian Ciocaltea > > > > --- > > > > drivers/irqchip/Makefile | 1 + > > > > drivers/irqchip/irq-owl-sirq.c | 318 +++++++++++++++++++++++++++++++++ > > > > 2 files changed, 319 insertions(+) > > > > create mode 100644 drivers/irqchip/irq-owl-sirq.c > > > > > > > > diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile > > > > index 133f9c45744a..b8eb5b8b766d 100644 > > > > --- a/drivers/irqchip/Makefile > > > > +++ b/drivers/irqchip/Makefile > > > > @@ -7,6 +7,7 @@ obj-$(CONFIG_ATH79) += irq-ath79-cpu.o > > > > obj-$(CONFIG_ATH79) += irq-ath79-misc.o > > > > obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2835.o > > > > obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2836.o > > > > +obj-$(CONFIG_ARCH_ACTIONS) += irq-owl-sirq.o > > > > obj-$(CONFIG_DAVINCI_AINTC) += irq-davinci-aintc.o > > > > obj-$(CONFIG_DAVINCI_CP_INTC) += irq-davinci-cp-intc.o > > > > obj-$(CONFIG_EXYNOS_IRQ_COMBINER) += exynos-combiner.o > > > > diff --git a/drivers/irqchip/irq-owl-sirq.c > > > > b/drivers/irqchip/irq-owl-sirq.c > > > > new file mode 100644 > > > > index 000000000000..29b7ffc40ac7 > > > > --- /dev/null > > > > +++ b/drivers/irqchip/irq-owl-sirq.c > > > > @@ -0,0 +1,318 @@ > > > > +// SPDX-License-Identifier: GPL-2.0+ > > > > +/* > > > > + * Actions Semi Owl SoCs SIRQ interrupt controller driver > > > > + * > > > > + * Copyright (C) 2014 Actions Semi Inc. > > > > + * David Liu > > > > + * > > > > + * Author: Parthiban Nallathambi > > > > + * Author: Saravanan Sekar > > > > + * Author: Cristian Ciocaltea > > > > + */ > > > > + > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > + > > > > +#define NUM_SIRQ 3 > > > > + > > > > +#define INTC_EXTCTL_PENDING BIT(0) > > > > +#define INTC_EXTCTL_CLK_SEL BIT(4) > > > > +#define INTC_EXTCTL_EN BIT(5) > > > > +#define INTC_EXTCTL_TYPE_MASK GENMASK(7, 6) > > > > +#define INTC_EXTCTL_TYPE_HIGH 0 > > > > +#define INTC_EXTCTL_TYPE_LOW BIT(6) > > > > +#define INTC_EXTCTL_TYPE_RISING BIT(7) > > > > +#define INTC_EXTCTL_TYPE_FALLING (BIT(6) | BIT(7)) > > > > + > > > > +/* S900 SIRQ1 & SIRQ2 control register offsets, relative to SIRQ0 */ > > > > +#define INTC_EXTCTL1 0x0328 > > > > +#define INTC_EXTCTL2 0x032c > > > > + > > > > +struct owl_sirq_params { > > > > + /* INTC_EXTCTL reg shared for all three SIRQ lines */ > > > > + bool reg_shared; > > > > + /* INTC_EXTCTL reg offsets relative to controller base address */ > > > > + u16 reg_offset[NUM_SIRQ]; > > > > +}; > > > > + > > > > +struct owl_sirq_chip_data { > > > > + const struct owl_sirq_params *params; > > > > + void __iomem *base; > > > > + raw_spinlock_t lock; > > > > + u32 ext_irqs[NUM_SIRQ]; > > > > + u8 trigger; > > > > > > Nit: Please align data structure members vertically: > > > > > > struct owl_sirq_chip_data { > > > const struct owl_sirq_params *params; > > > void __iomem *base; > > > raw_spinlock_t lock; > > > u32 ext_irqs[NUM_SIRQ]; > > > u8 trigger; > > > }; > > > > Done. > > > > > > +}; > > > > + > > > > +/* S500 and S700 SoCs */ > > > > +static const struct owl_sirq_params owl_sirq_s500_params = { > > > > + .reg_shared = true, > > > > + .reg_offset = { 0, 0, 0 }, > > > > +}; > > > > + > > > > +/* S900 SoC */ > > > > +static const struct owl_sirq_params owl_sirq_s900_params = { > > > > + .reg_shared = false, > > > > + .reg_offset = { 0, INTC_EXTCTL1, INTC_EXTCTL2 }, > > > > > > 0 *is* an offset, right? Why doesn't it have a name too? > > > > Right, I updated the defines section: > > > > /* S900 SIRQ control register offsets, relative to controller base address */ > > #define INTC_EXTCTL0 0x0000 > > #define INTC_EXTCTL1 0x0328 > > [...] > > > > The controller base address points to SIRQ0 control register, so this > > offset is always 0, but I totally agree we should have a name for it. > > > > > > +}; > > > > + > > > > +static u32 owl_sirq_read_extctl(struct owl_sirq_chip_data *data, u32 > > > > index) > > > > +{ > > > > + u32 val; > > > > + > > > > + val = readl_relaxed(data->base + data->params->reg_offset[index]); > > > > + if (data->params->reg_shared) > > > > + val = (val >> (2 - index) * 8) & 0xff; > > > > > > base = (2 - index) * 8; > > > val = FIELD_GET(GENMASK(base + 7, base), val); > > > > Unfortunately the context doesn't allow using FIELD_GET: > > > > ./include/linux/compiler.h:392:38: error: call to ‘__compiletime_assert_159’ > > declared with attribute error: FIELD_GET: mask is not constant > > Bah. Turning the whole thing into compile-time values would actually > be more readable, so how about this: > > diff --git a/drivers/irqchip/irq-owl-sirq.c b/drivers/irqchip/irq-owl-sirq.c > index 29b7ffc40ac7..b771acbda7d5 100644 > --- a/drivers/irqchip/irq-owl-sirq.c > +++ b/drivers/irqchip/irq-owl-sirq.c > @@ -57,13 +57,39 @@ static const struct owl_sirq_params owl_sirq_s900_params = { > .reg_offset = { 0, INTC_EXTCTL1, INTC_EXTCTL2 }, > }; > > +static u32 owl_field_get(u32 val, int index) > +{ > + switch(index) { > + case 0: > + return FIELD_GET(GENMASK(23, 16), val); > + case 1: > + return FIELD_GET(GENMASK(15, 8), val); > + case 2: > + default: > + return FIELD_GET(GENMASK(7, 0), val); > + } > +} > + > +static u32 owl_field_prep(u32 val, int index) > +{ > + switch(index) { > + case 0: > + return FIELD_PREP(GENMASK(23, 16), val); > + case 1: > + return FIELD_PREP(GENMASK(15, 8), val); > + case 2: > + default: > + return FIELD_PREP(GENMASK(7, 0), val); > + } > +} > + > static u32 owl_sirq_read_extctl(struct owl_sirq_chip_data *data, u32 index) > { > u32 val; > > val = readl_relaxed(data->base + data->params->reg_offset[index]); > if (data->params->reg_shared) > - val = (val >> (2 - index) * 8) & 0xff; > + val = owl_field_get(val, index); > > return val; > } > @@ -75,9 +101,8 @@ static void owl_sirq_write_extctl(struct owl_sirq_chip_data *data, > > if (data->params->reg_shared) { > val = readl_relaxed(data->base + data->params->reg_offset[index]); > - val &= ~(0xff << (2 - index) * 8); > - extctl &= 0xff; > - extctl = (extctl << (2 - index) * 8) | val; > + val &= ~owl_field_prep(0xff, index); > + extctl = owl_field_prep(extctl, index) | val; > } > > writel_relaxed(extctl, data->base + data->params->reg_offset[index]); > > Yes, this is a bit more code, but it *is* readable. Bonus points if > you add proper defines for the masks. That's great, thanks a lot! I have submitted a new revision: https://lore.kernel.org/lkml/cover.1597852360.git.cristian.ciocaltea@gmail.com/ Regards, Cristi > > > > > > + > > > > + return val; > > > > +} > > > > + > > > > +static void owl_sirq_write_extctl(struct owl_sirq_chip_data *data, > > > > + u32 extctl, u32 index) > > > > +{ > > > > + u32 val; > > > > + > > > > + if (data->params->reg_shared) { > > > > + val = readl_relaxed(data->base + data->params->reg_offset[index]); > > > > + val &= ~(0xff << (2 - index) * 8); > > > > + extctl &= 0xff; > > > > + extctl = (extctl << (2 - index) * 8) | val; > > > > > > Please make use of FIELD_PREP, FIELD_GET and GENMASK. > > > > I'm not sure how to deal with the mask constness restriction, except > > using static defines and if/else statements, which is not quite > > elegant. > > See above. > > > > > > > + } > > > > + > > > > + writel_relaxed(extctl, data->base + data->params->reg_offset[index]); > > > > +} > > > > + > > > > +static void owl_sirq_clear_set_extctl(struct owl_sirq_chip_data *d, > > > > + u32 clear, u32 set, u32 index) > > > > +{ > > > > + unsigned long flags; > > > > + u32 val; > > > > + > > > > + raw_spin_lock_irqsave(&d->lock, flags); > > > > + val = owl_sirq_read_extctl(d, index); > > > > + val &= ~clear; > > > > + val |= set; > > > > + owl_sirq_write_extctl(d, val, index); > > > > + raw_spin_unlock_irqrestore(&d->lock, flags); > > > > +} > > > > + > > > > +static void owl_sirq_eoi(struct irq_data *data) > > > > +{ > > > > + struct owl_sirq_chip_data *chip_data = > > > > irq_data_get_irq_chip_data(data); > > > > + > > > > + /* > > > > + * Software must clear external interrupt pending, when interrupt type > > > > + * is edge triggered, so we need per SIRQ based clearing. > > > > + */ > > > > + if (chip_data->trigger & (1 << data->hwirq)) > > > > > > BIT(d->hwirq) > > > > > > But it also begs the question: we already have all the trigger information > > > in the irqdesc. Why do you need some additional bookkeeping? > > > > That's another leftover from the original work. Thanks for pointing > > this out, I missed it. I dropped the redundant handling of the IRQ > > trigger information and just replaced this with: > > > > if (!irqd_is_level_type(data)) > > Yup. > > > > > > > + owl_sirq_clear_set_extctl(chip_data, 0, INTC_EXTCTL_PENDING, > > > > + data->hwirq); > > > > + > > > > + irq_chip_eoi_parent(data); > > > > +} > > > > + > > > > +static void owl_sirq_mask(struct irq_data *data) > > > > +{ > > > > + struct owl_sirq_chip_data *chip_data = > > > > irq_data_get_irq_chip_data(data); > > > > + > > > > + owl_sirq_clear_set_extctl(chip_data, INTC_EXTCTL_EN, 0, data->hwirq); > > > > + irq_chip_mask_parent(data); > > > > +} > > > > + > > > > +static void owl_sirq_unmask(struct irq_data *data) > > > > +{ > > > > + struct owl_sirq_chip_data *chip_data = > > > > irq_data_get_irq_chip_data(data); > > > > + > > > > + owl_sirq_clear_set_extctl(chip_data, 0, INTC_EXTCTL_EN, data->hwirq); > > > > + irq_chip_unmask_parent(data); > > > > +} > > > > + > > > > +/* > > > > + * GIC does not handle falling edge or active low, hence SIRQ shall be > > > > + * programmed to convert falling edge to rising edge signal and active > > > > + * low to active high signal. > > > > + */ > > > > +static int owl_sirq_set_type(struct irq_data *data, unsigned int type) > > > > +{ > > > > + struct owl_sirq_chip_data *chip_data = > > > > irq_data_get_irq_chip_data(data); > > > > + u32 sirq_type; > > > > + > > > > + switch (type) { > > > > + case IRQ_TYPE_LEVEL_LOW: > > > > + sirq_type = INTC_EXTCTL_TYPE_LOW; > > > > + chip_data->trigger &= ~(1 << data->hwirq); > > > > + type = IRQ_TYPE_LEVEL_HIGH; > > > > + break; > > > > + case IRQ_TYPE_LEVEL_HIGH: > > > > + sirq_type = INTC_EXTCTL_TYPE_HIGH; > > > > + chip_data->trigger &= ~(1 << data->hwirq); > > > > + break; > > > > + case IRQ_TYPE_EDGE_FALLING: > > > > + sirq_type = INTC_EXTCTL_TYPE_FALLING; > > > > + chip_data->trigger |= 1 << data->hwirq; > > > > + type = IRQ_TYPE_EDGE_RISING; > > > > + break; > > > > + case IRQ_TYPE_EDGE_RISING: > > > > + sirq_type = INTC_EXTCTL_TYPE_RISING; > > > > + chip_data->trigger |= 1 << data->hwirq; > > > > + break; > > > > + default: > > > > + WARN_ON(1); > > > > > > No need for this WARN_ON(), the core kernel is loud enough. > > > > Done. > > > > > > + return -EINVAL; > > > > + } > > > > + > > > > + owl_sirq_clear_set_extctl(chip_data, INTC_EXTCTL_TYPE_MASK, sirq_type, > > > > + data->hwirq); > > > > + > > > > + return irq_chip_set_type_parent(data, type); > > > > +} > > > > + > > > > +static struct irq_chip owl_sirq_chip = { > > > > + .name = "owl-sirq", > > > > + .irq_mask = owl_sirq_mask, > > > > + .irq_unmask = owl_sirq_unmask, > > > > + .irq_eoi = owl_sirq_eoi, > > > > + .irq_set_type = owl_sirq_set_type, > > > > + .irq_retrigger = irq_chip_retrigger_hierarchy, > > > > > > How about irq_set_affinity? Or does it only exist on UP systems? > > > > I have just added: > > > > #ifdef CONFIG_SMP > > .irq_set_affinity = irq_chip_set_affinity_parent, > > #endif > > Looks OK. > > Cheers, > > M. > > -- > Without deviation from the norm, progress is not possible.