From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8DCAC433DF for ; Wed, 19 Aug 2020 16:58:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EFDD20885 for ; Wed, 19 Aug 2020 16:58:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tP6c42ce"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="GVLkRIrC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EFDD20885 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FPjrBSHr6WMFFirFwHDcElY6WDDp1osQcL2TswoHXcs=; b=tP6c42ceic/wWAV84KF+7EJBE 84xJHAuNL0hEkEBwpHI2EhoT27nApQWBKAWkKLI00q8mArQ4kj1bzLLEc5Y3evY/MBErL9KzlLCHE z+qYZVnTB+6+nYOcN0IxHM6IvpNG9qaXMNo5Ne4Kxs172uQnXTwEdpc+dEwmH1KTyKcuNhBAMeatS kss/698/VRBuPO6SHbZmK+u76qQuZEaZMVnLWFnK4k/PC3VC3RMgE8ehjNSbjzCECcfVGwzTYmyLP u4kitPpiOH8Kl8hroYXqVg46ezggKIIACwt5b/FTkx+OkaLHUF0L4okcXPFfQiPzPg+FYLNsdsom3 3eNKe7rJw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8ROe-0004U6-Rb; Wed, 19 Aug 2020 16:57:08 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8ROc-0004TJ-CD for linux-arm-kernel@lists.infradead.org; Wed, 19 Aug 2020 16:57:07 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8175329E; Wed, 19 Aug 2020 18:56:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1597856219; bh=JSMuV5nAqp9B18iMvO4sKVXd8MjalDF0a0uByYXBzuw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GVLkRIrCYOJf1UNRl4LLIVufPjmaatK0mmlWAGyeaFVSQL+fT9Y4xTVY7bO+30Kbp Z6SwSWnw5mdu6D1H5au9CIcWREIVZSs0nFN7euhzh2Cf/NClI8HiwY4hZWppQqaD5U ljH7aYtrkszJRobor9w6E4k1Q8NsXRnNtrn6bsA8= Date: Wed, 19 Aug 2020 19:56:41 +0300 From: Laurent Pinchart To: Vishal Sagar , Hans Verkuil Subject: Re: [PATCH v3 3/3] media: v4l: xilinx: Add Xilinx UHD-SDI Rx Subsystem driver Message-ID: <20200819165641.GS6049@pendragon.ideasonboard.com> References: <20200618053304.14551-1-vishal.sagar@xilinx.com> <20200618053304.14551-4-vishal.sagar@xilinx.com> <50cc4f4b-e788-c5ad-cd6a-b428b96d5377@xs4all.nl> <20200715213315.GF6144@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200819_125706_554966_97572A4F X-CRM114-Status: GOOD ( 43.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , Dinesh Kumar , Hyun Kwon , Sandip Kothari , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , Michal Simek , "joe@perches.com" , "mchehab@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgVmlzaGFsLAoKKEhhbnMsIHRoZXJlJ3MgYSBxdWVzdGlvbiBmb3IgeW91IGJlbG93KQoKT24g V2VkLCBBdWcgMTksIDIwMjAgYXQgMDE6NDc6NDlQTSArMDAwMCwgVmlzaGFsIFNhZ2FyIHdyb3Rl Ogo+IE9uIFRodXJzZGF5LCBKdWx5IDE2LCAyMDIwIDM6MDMgQU0gTGF1cmVudCBQaW5jaGFydCB3 cm90ZToKPiA+IE9uIFRodSwgSnVuIDI1LCAyMDIwIGF0IDExOjQzOjAxQU0gKzAyMDAsIEhhbnMg VmVya3VpbCB3cm90ZToKPiA+ID4gT24gMTgvMDYvMjAyMCAwNzozMywgVmlzaGFsIFNhZ2FyIHdy b3RlOgo+ID4gPiA+IFRoZSBYaWxpbnggVUhELVNESSBSeCBzdWJzeXN0ZW0gc29mdCBJUCBpcyB1 c2VkIHRvIGNhcHR1cmUgbmF0aXZlIFNESQo+ID4gPiA+IHN0cmVhbXMgZnJvbSBTREkgc291cmNl cyBsaWtlIFNESSBicm9hZGNhc3QgZXF1aXBtZW50IGxpa2UgY2FtZXJhcyBhbmQKPiA+ID4gPiBt aXhlcnMuIFRoaXMgYmxvY2sgb3V0cHV0cyBlaXRoZXIgbmF0aXZlIFNESSwgbmF0aXZlIHZpZGVv IG9yCj4gPiA+ID4gQVhJNC1TdHJlYW0gY29tcGxpYW50IGRhdGEgc3RyZWFtIGZvciBmdXJ0aGVy IHByb2Nlc3NpbmcuIFBsZWFzZSByZWZlcgo+ID4gPiA+IHRvIFBHMjkwIGZvciBkZXRhaWxzLgo+ ID4gPiA+Cj4gPiA+ID4gVGhlIGRyaXZlciBpcyB1c2VkIHRvIGNvbmZpZ3VyZSB0aGUgSVAgdG8g YWRkIGZyYW1lciwgc2VhcmNoIGZvcgo+ID4gPiA+IHNwZWNpZmljIG1vZGVzLCBnZXQgdGhlIGRl dGVjdGVkIG1vZGUsIHN0cmVhbSBwYXJhbWV0ZXJzLCBlcnJvcnMsIGV0Yy4KPiA+ID4gPiBJdCBh bHNvIGdlbmVyYXRlcyBldmVudHMgZm9yIHZpZGVvIGxvY2svdW5sb2NrLCBicmlkZ2Ugb3Zlci91 bmRlciBmbG93Lgo+ID4gPiA+Cj4gPiA+ID4gVGhlIGRyaXZlciBzdXBwb3J0cyAxMC8xMiBicGMg WVVWIDQyMiBtZWRpYSBidXMgZm9ybWF0IGN1cnJlbnRseS4gSXQKPiA+ID4gPiBhbHNvIGRlY29k ZXMgdGhlIHN0cmVhbSBwYXJhbWV0ZXJzIGJhc2VkIG9uIHRoZSBTVDM1MiBwYWNrZXQgZW1iZWRk ZWQgaW4gdGhlCj4gPiA+ID4gc3RyZWFtLiBJbiBjYXNlIHRoZSBTVDM1MiBwYWNrZXQgaXNuJ3Qg cHJlc2VudCBpbiB0aGUgc3RyZWFtLCB0aGUgY29yZSdzCj4gPiA+ID4gZGV0ZWN0ZWQgcHJvcGVy dGllcyBhcmUgdXNlZCB0byBzZXQgc3RyZWFtIHByb3BlcnRpZXMuCj4gPiA+ID4KPiA+ID4gPiBU aGUgZHJpdmVyIGN1cnJlbnRseSBzdXBwb3J0cyBvbmx5IHRoZSBBWEk0LVN0cmVhbSBJUCBjb25m aWd1cmF0aW9uLgo+ID4gPiA+Cj4gPiA+ID4gU2lnbmVkLW9mZi1ieTogVmlzaGFsIFNhZ2FyIDx2 aXNoYWwuc2FnYXJAeGlsaW54LmNvbT4KPiA+ID4gPiAtLS0KPiA+ID4gPiB2Mwo+ID4gPiA+IC0g Zml4ZWQgS0NvbmZpZyB3aXRoIGJldHRlciBkZXNjcmlwdGlvbgo+ID4gPiA+IC0gcmVtb3ZlZCB1 bm5lY2Vzc2FyeSBoZWFkZXIgZmlsZXMKPiA+ID4gPiAtIGNvbnZlcnRlZCB1cHBlcmNhc2UgdG8g bG93ZXJjYXNlIGZvciBhbGwgaGV4IHZhbHVlcwo+ID4gPiA+IC0gbWVyZ2VkIGNvcmUgc3RydWN0 IHRvIHN0YXRlIHN0cnVjdAo+ID4gPiA+IC0gcmVtb3ZlZCBtb3N0IG9uZSBsaW5lIGZ1bmN0aW9u cyBhbmQgcmVwbGFjZWQgd2l0aCBkaXJlY3QgcmVnCj4gPiA+ID4gICByZWFkL3dyaXRlIG9yIG1h Y3Jvcwo+ID4gPiA+IC0gZHQgcHJvcGVydHkgYnBwIHRvIGJwYy4gZGVmYXVsdCAxMC4gbm90IG1h bmRhdG9yeS4KPiA+ID4gPiAtIGZpeGVkIHN1YnNjcmliZSBldmVudHMsIGxvZ19zdGF0dXMsIHNf c3RyZWFtCj4gPiA+ID4gLSBtZXJnZWQgb3ZlcmZsb3cvdW5kZXJmbG93IHRvIG9uZSBldmVudAo+ ID4gPiA+IC0gbW92ZWQgYWxsIGNvbnRyb2xzIHRvIHhpbGlueC1zZGlyeHNzLmgKPiA+ID4gPiAt IG1heCBldmVudHMgZnJvbSAxMjggdG8gOAo+ID4gPiA+IC0gdXNlZCBGSUVMRF9HRVQoKSBpbnN0 ZWFkIG9mIGN1c3RvbSBtYWNybwo+ID4gPiA+IC0gdXBkYXRlZCB0aGUgY29udHJvbHMgZG9jdW1l bnRhdGlvbgo+ID4gPiA+IC0gYWRkZWQgc3BpbmxvY2sKPiA+ID4gPiAtIHJlbW92ZWQgM0dCIGNv bnRyb2wgYW5kIGFkZGVkIG1vZGUgdG8gZGV0ZWN0IGJpdG1hc2sKPiA+ID4gPiAtIGZpeGVkIGZv cm1hdCBmb3IgKHdpZHRoLCBoZWlnaHQsIGNvbG9yc3BhY2UsIHhmZXIgZnVuYywgZXRjKQo+ID4g PiA+IC0gYWRkZWQgZHZfdGltaW5nc19jYXAsIHMvZ19kdl90aW1pbmdzCj4gPiA+ID4gLSBmaXhl ZCBzZXQvZ2V0X2Zvcm1hdAo+ID4gPiA+IC0gZml4IHY0bCBjb250cm9sIHJlZ2lzdHJhdGlvbnMK PiA+ID4gPiAtIGZpeCBvcmRlciBvZiByZWdpc3RyYXRpb24gLyBkZXJlZ2lzdHJhdGlvbiBpbiBw cm9iZSgpIHJlbW92ZSgpCj4gPiA+ID4gLSBmaXhlZCBvdGhlciBjb21tZW50cyBmcm9tIEh5dW4s IExhdXJlbnQgYW5kIEhhbnMKPiA+ID4gPiAtIHRoaW5ncyB5ZXQgdG8gY2xvc2UKPiA+ID4gPiAg IC0gYWRkaW5nIHNvdXJjZSBwb3J0IGZvciBjb25uZWN0b3IgKExhdXJlbnQncyBzdWdnZXN0aW9u KQo+ID4gPiA+ICAgLSBhZGRpbmcgbmV3IEZJRUxEIHR5cGUgZm9yIFRyYW5zcG9ydCBTdHJlYW0g VjRMMl9GSUVMRF9BTFRFUk5BVEVfUFJPRyAoSGFuJ3Mgc3VnZ2VzdGlvbikKPiA+ID4gPiAgIC0g VXBkYXRlIC8gcmVtb3ZlIEVESCBvciBDUkMgcmVsYXRlZCBjb250cm9scwo+ID4gPiA+Cj4gPiA+ ID4gdjIKPiA+ID4gPiAtIEFkZGVkIERWIHRpbWluZyBzdXBwb3J0IGJhc2VkIG9uIEhhbnMgVmVy a3VpbMWbIGZlZWRiYWNrCj4gPiA+ID4gLSBNb3JlIGRvY3VtZW50YXRpb24gdG8gY3VzdG9tIHY0 bCBjb250cm9scyBhbmQgZXZlbnRzCj4gPiA+ID4gLSBGaXhlZCBIeXVuxZsgY29tbWVudHMKPiA+ ID4gPiAtIEFkZGVkIG1hY3JvIGZvciBtYXNraW5nIGFuZCBzaGlmdGluZyBhcyBwZXIgSm9lIFBl cmNoZXMgY29tbWVudHMKPiA+ID4gPiAtIFVwZGF0ZWQgdG8gbGF0ZXN0IGFzIHBlciBYaWxpbngg Z2l0aHViIHJlcG8gZHJpdmVyIGxpa2UKPiA+ID4gPiAgIGFkZGluZyBuZXcgRFYgdGltaW5ncyBu b3QgaW4gbWFpbmxpbmUgeWV0IHVwdGlsbCAwMy8yMS8yMAo+ID4gPiA+Cj4gPiA+ID4gIGRyaXZl cnMvbWVkaWEvcGxhdGZvcm0veGlsaW54L0tjb25maWcgICAgICAgICB8ICAgMTEgKwo+ID4gPiA+ ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3hpbGlueC9NYWtlZmlsZSAgICAgICAgfCAgICAxICsK PiA+ID4gPiAgLi4uL21lZGlhL3BsYXRmb3JtL3hpbGlueC94aWxpbngtc2Rpcnhzcy5jICAgIHwg MjEyMSArKysrKysrKysrKysrKysrKwo+ID4gPiA+ICBpbmNsdWRlL3VhcGkvbGludXgvdjRsMi1j b250cm9scy5oICAgICAgICAgICAgfCAgICA2ICsKPiA+ID4gPiAgaW5jbHVkZS91YXBpL2xpbnV4 L3hpbGlueC1zZGlyeHNzLmggICAgICAgICAgIHwgIDI4MyArKysKPiA+ID4gPiAgNSBmaWxlcyBj aGFuZ2VkLCAyNDIyIGluc2VydGlvbnMoKykKPiA+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRy aXZlcnMvbWVkaWEvcGxhdGZvcm0veGlsaW54L3hpbGlueC1zZGlyeHNzLmMKPiA+ID4gPiAgY3Jl YXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvdWFwaS9saW51eC94aWxpbngtc2Rpcnhzcy5oCgpbc25p cF0KCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0veGlsaW54L3hp bGlueC1zZGlyeHNzLmMgYi9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3hpbGlueC94aWxpbngtc2Rp cnhzcy5jCj4gPiA+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+ID4gPiBpbmRleCAwMDAwMDAw MDAwMDAuLmUzOWFhYjdjNjU2YQo+ID4gPiA+IC0tLSAvZGV2L251bGwKPiA+ID4gPiArKysgYi9k cml2ZXJzL21lZGlhL3BsYXRmb3JtL3hpbGlueC94aWxpbngtc2Rpcnhzcy5jCj4gPiA+ID4gQEAg LTAsMCArMSwyMTIxIEBACgpbc25pcF0KCj4gPiA+ID4gKwljYXNlIFY0TDJfQ0lEX1hJTElOWF9T RElSWF9UU19JU19JTlRFUkxBQ0VEOgo+ID4gPiA+ICsJCWN0cmwtPnZhbCA9IHhzZGlyeHNzLT50 c19pc19pbnRlcmxhY2VkOwo+ID4gPiA+ICsJCWJyZWFrOwo+ID4gPgo+ID4gPiBJIGFzc3VtZSB0 aGlzIGNvbnRyb2wgd2lsbCBkaXNhcHBlYXIgb25jZSB5b3UgYWRkZWQgc3VwcG9ydCBmb3IKPiA+ ID4gRklFTERfQUxURVJOQVRFX1BST0c/Cj4gPiAKPiA+IEknbSBub3Qgc3VyZSBGSUVMRF9BTFRF Uk5BVEVfUFJPRyBpcyBhIGdvb2QgaWRlYS4gVGhlIHY0bDJfZmllbGQKPiA+IHNwZWNpZmllcyB0 b2RheSBob3cgZnJhbWVzIGFyZSBzcGxpdCBpbnRvIG11bHRpcGxlIGJ1ZmZlcnMuIFRoZXJlJ3Mg YW4KPiA+IGltcGxpY2l0IGFzc3VtcHRpb24gdGhhdCBhIGZyYW1lIHNwbGl0IGludG8gdHdvIGJ1 ZmZlcnMgaXMgY2FwdHVyZWQgd2l0aAo+ID4gaW50ZXJsYWNpbmcuIEluIHRoZSBTREkgY2FzZSwg dGhlIHR3byBjb25jZXB0cyBnZXQgZGVjb3VwbGVkLCBhCj4gPiBwcm9ncmVzc2l2ZSBmcmFtZSBj YW4gYmUgdHJhbnNtaXR0ZWQgKGFuZCBjYXB0dXJlZCkgaW4gdHdvIHNlcGFyYXRlCj4gPiBwYXJ0 cy4gSWYgd2UgYWRkIGEgKl9QUk9HIGZpZWxkLCB3ZSdsbCBuZWVkIHRvIGR1cGxpY2F0ZSBtb3N0 IG9mIHRoZQo+ID4gdjRsMl9maWVsZCB2YWx1ZXMgd2l0aCBhIF9QUk9HIHN1ZmZpeCwgYXMgdGhl IHByb2dyZXNzaXZlIGZyYW1lIGNhbiBiZQo+ID4gY2FwdHVyZWQgaW4gYWx0ZXJuYXRlIGJ1ZmZl cnMgb24gYSB2aWRlbyBub2RlLCBidXQgYWxzbyBpbiBzZXBhcmF0ZSBvZGQKPiA+IGFuZCBldmVu IGJ1ZmZlcnMgb24gdHdvIHZpZGVvIG5vZGVzLiBUdCB0aGUgaGFyZHdhcmUgbGV2ZWwsIGRhdGEg aXMKPiA+IHRyYW5zbWl0dGVkIHdpdGggb2RkIGxpbmVzIG9uIG9uZSBsaW5rLCBhbmQgZXZlbiBs aW5lcyBvbiBhIHNlY29uZCBsaW5rLgo+ID4gVGhlcmUgYXJlIHRoZW4gdHdvIGluc3RhbmNlcyBv ZiB0aGlzIElQIGNvcmUsIG9uZSBmb3IgZWFjaCBsaW5rLiBPbmUKPiA+IGluc3RhbmNlIHdvdWxk IHJlY2VpdmUgYW5kIHByb2Nlc3MgdGhlIGV2ZW4gbGluZXMsIHRoZSBvdGhlciBpbnN0YW5jZQo+ ID4gdGhlIG9kZCBsaW5lcy4gVGhlIG91dHB1dCBvZiB0aGUgdHdvIGluc3RhbmNlcyBjYW4gdGhl biBiZSBjb25uZWN0ZWQgdG8KPiA+IHR3byBzZXBhcmF0ZSBETUEgZW5naW5lcywgb3IgY29tYmlu ZWQgaW4gdGhlIEZQR0EgZmFicmljLCBkZXBlbmRpbmcgb24KPiA+IGhvdyB0aGUgdXNlciBkZXNp Z25zIHRoZSBzeXN0ZW0uCj4gCj4gTXkgYXBvbG9naWVzIHRvIGdpdmUgaW5jb3JyZWN0IGluZm8g cmVnYXJkaW5nIHRoaXMuCj4gSW4gdGhlIHByb2dyZXNzaXZlIHNlZ21lbnRlZCBmcmFtZSwgYSBw cm9ncmVzc2l2ZSBjYXB0dXJlZCBmcmFtZSBpcyBzZW50Cj4gYWNyb3NzIHRvIHJlY2VpdmVyIG92 ZXIgYW4gaW50ZXJsYWNlZCB0cmFuc3BvcnQuIFRoZSAyIGZpZWxkcyByZWNlaXZlZAo+IGFyZSBz aW1pbGFyIHRvIGhvdyBWNEwyX0ZJRUxEX0FMVEVSTkFURSBpcyBleGNlcHQgdGhhdCB0aGUgZmll bGRzIHdlcmVuJ3QKPiBjYXB0dXJlZCBhdCAyIGRpZmZlcmVudCB0aW1lcy4KCkkndmUgbm93IHJl YWQgbW9yZSBhYm91dCBwcm9ncmVzc2l2ZSBzZWdtZW50ZWQgZnJhbWVzLCBhbmQgSSB3YXMgaW5k ZWVkCndyb25nIGFib3V0IHRoZSBmYWN0IHRoYXQgdGhlIHR3byBzZWdtZW50cyBhcmUgdHJhbnNw b3J0ZWQgb3ZlcgpkaWZmZXJlbnQgbGlua3MuCgpJIHN0aWxsIHdvbmRlciwgaG93ZXZlciwgaWYg YSBfUFJPRyBzdWZmaXggaXMgdGhlIGJlc3Qgb3B0aW9uLiBXb3VsZG4ndAp3ZSBuZWVkIHRvIGFs c28gYWRkIFY0TDJfRklFTERfVE9QX1BST0csIFY0TDJfRklFTERfQk9UVE9NX1BST0csClY0TDJf RklFTERfU0VRX1RCX1BST0cgYW5kIFY0TDJfRklFTERfU0VRX0JUX1BST0csIG5vdCBuZWNlc3Nh cmlseSBmb3IKdGhpcyBkcml2ZXIsIGJ1dCBmb3Igb3RoZXIgZGV2aWNlcyB0aGF0IHdvdWxkIHN1 cHBvcnQgY2FwdHVyaW5nIHRoZQpvZGQvZXZlbiBzZWdtZW50cyBvbmx5LCBvciBzdXBwb3J0IGNh cHR1cmluZyBib3RoIHNlZ21lbnRzIGluIGEgc2luZ2xlCmJ1ZmZlciwgb25lIGFmdGVyIHRoZSBv dGhlciA/CgpNYXliZSB0aGF0J3MgdW5hdm9pZGFibGUsIGFzIGVudW0gdjRsMl9maWVsZCBjb21i aW5lcyBib3RoIHRoZSBidWZmZXIKbGF5b3V0IGFuZCB0aGUgZmFjdCB0aGF0IHRoZSBmcmFtZSBp cyBpbnRlcmxhY2VkIG9yIHByb2dyZXNzaXZlLiBJZiB3ZQpoYWQgdG8gcmVkZXNpZ24gaXQgd2Ug Y291bGQgZG8gYmV0dGVyLCBidXQgaGF2aW5nIHRvIGtlZXAgYmFja3dhcmQKY29tcGF0aWJpbGl0 eSwgZHVwbGljYXRpbmcgbW9zdCB2YWx1ZXMgd2l0aCBhIF9QUk9HIHN1ZmZpeCBtYXkgYmUgdGhl CmJlc3Qgb3B0aW9uLgoKSGFucywgYW55IG9waW5pb24gPwoKPiBTbyBJIHdpbGwgYWRkIHRoZSBW NEwyX0ZJRUxEX0FMVEVSTkFURV9QUk9HIGluIG5leHQgcGF0Y2ggdmVyc2lvbi4KCltzbmlwXQoK LS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51 eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74309C433DF for ; Wed, 19 Aug 2020 16:58:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CDE5207FF for ; Wed, 19 Aug 2020 16:58:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="GVLkRIrC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726703AbgHSQ5V (ORCPT ); Wed, 19 Aug 2020 12:57:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbgHSQ5H (ORCPT ); Wed, 19 Aug 2020 12:57:07 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E7B0C061757; Wed, 19 Aug 2020 09:57:06 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8175329E; Wed, 19 Aug 2020 18:56:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1597856219; bh=JSMuV5nAqp9B18iMvO4sKVXd8MjalDF0a0uByYXBzuw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GVLkRIrCYOJf1UNRl4LLIVufPjmaatK0mmlWAGyeaFVSQL+fT9Y4xTVY7bO+30Kbp Z6SwSWnw5mdu6D1H5au9CIcWREIVZSs0nFN7euhzh2Cf/NClI8HiwY4hZWppQqaD5U ljH7aYtrkszJRobor9w6E4k1Q8NsXRnNtrn6bsA8= Date: Wed, 19 Aug 2020 19:56:41 +0300 From: Laurent Pinchart To: Vishal Sagar , Hans Verkuil Cc: Hyun Kwon , "mchehab@kernel.org" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , Michal Simek , "linux-media@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "joe@perches.com" , Sandip Kothari , Dinesh Kumar Subject: Re: [PATCH v3 3/3] media: v4l: xilinx: Add Xilinx UHD-SDI Rx Subsystem driver Message-ID: <20200819165641.GS6049@pendragon.ideasonboard.com> References: <20200618053304.14551-1-vishal.sagar@xilinx.com> <20200618053304.14551-4-vishal.sagar@xilinx.com> <50cc4f4b-e788-c5ad-cd6a-b428b96d5377@xs4all.nl> <20200715213315.GF6144@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Vishal, (Hans, there's a question for you below) On Wed, Aug 19, 2020 at 01:47:49PM +0000, Vishal Sagar wrote: > On Thursday, July 16, 2020 3:03 AM Laurent Pinchart wrote: > > On Thu, Jun 25, 2020 at 11:43:01AM +0200, Hans Verkuil wrote: > > > On 18/06/2020 07:33, Vishal Sagar wrote: > > > > The Xilinx UHD-SDI Rx subsystem soft IP is used to capture native SDI > > > > streams from SDI sources like SDI broadcast equipment like cameras and > > > > mixers. This block outputs either native SDI, native video or > > > > AXI4-Stream compliant data stream for further processing. Please refer > > > > to PG290 for details. > > > > > > > > The driver is used to configure the IP to add framer, search for > > > > specific modes, get the detected mode, stream parameters, errors, etc. > > > > It also generates events for video lock/unlock, bridge over/under flow. > > > > > > > > The driver supports 10/12 bpc YUV 422 media bus format currently. It > > > > also decodes the stream parameters based on the ST352 packet embedded in the > > > > stream. In case the ST352 packet isn't present in the stream, the core's > > > > detected properties are used to set stream properties. > > > > > > > > The driver currently supports only the AXI4-Stream IP configuration. > > > > > > > > Signed-off-by: Vishal Sagar > > > > --- > > > > v3 > > > > - fixed KConfig with better description > > > > - removed unnecessary header files > > > > - converted uppercase to lowercase for all hex values > > > > - merged core struct to state struct > > > > - removed most one line functions and replaced with direct reg > > > > read/write or macros > > > > - dt property bpp to bpc. default 10. not mandatory. > > > > - fixed subscribe events, log_status, s_stream > > > > - merged overflow/underflow to one event > > > > - moved all controls to xilinx-sdirxss.h > > > > - max events from 128 to 8 > > > > - used FIELD_GET() instead of custom macro > > > > - updated the controls documentation > > > > - added spinlock > > > > - removed 3GB control and added mode to detect bitmask > > > > - fixed format for (width, height, colorspace, xfer func, etc) > > > > - added dv_timings_cap, s/g_dv_timings > > > > - fixed set/get_format > > > > - fix v4l control registrations > > > > - fix order of registration / deregistration in probe() remove() > > > > - fixed other comments from Hyun, Laurent and Hans > > > > - things yet to close > > > > - adding source port for connector (Laurent's suggestion) > > > > - adding new FIELD type for Transport Stream V4L2_FIELD_ALTERNATE_PROG (Han's suggestion) > > > > - Update / remove EDH or CRC related controls > > > > > > > > v2 > > > > - Added DV timing support based on Hans Verkuilś feedback > > > > - More documentation to custom v4l controls and events > > > > - Fixed Hyunś comments > > > > - Added macro for masking and shifting as per Joe Perches comments > > > > - Updated to latest as per Xilinx github repo driver like > > > > adding new DV timings not in mainline yet uptill 03/21/20 > > > > > > > > drivers/media/platform/xilinx/Kconfig | 11 + > > > > drivers/media/platform/xilinx/Makefile | 1 + > > > > .../media/platform/xilinx/xilinx-sdirxss.c | 2121 +++++++++++++++++ > > > > include/uapi/linux/v4l2-controls.h | 6 + > > > > include/uapi/linux/xilinx-sdirxss.h | 283 +++ > > > > 5 files changed, 2422 insertions(+) > > > > create mode 100644 drivers/media/platform/xilinx/xilinx-sdirxss.c > > > > create mode 100644 include/uapi/linux/xilinx-sdirxss.h [snip] > > > > diff --git a/drivers/media/platform/xilinx/xilinx-sdirxss.c b/drivers/media/platform/xilinx/xilinx-sdirxss.c > > > > new file mode 100644 > > > > index 000000000000..e39aab7c656a > > > > --- /dev/null > > > > +++ b/drivers/media/platform/xilinx/xilinx-sdirxss.c > > > > @@ -0,0 +1,2121 @@ [snip] > > > > + case V4L2_CID_XILINX_SDIRX_TS_IS_INTERLACED: > > > > + ctrl->val = xsdirxss->ts_is_interlaced; > > > > + break; > > > > > > I assume this control will disappear once you added support for > > > FIELD_ALTERNATE_PROG? > > > > I'm not sure FIELD_ALTERNATE_PROG is a good idea. The v4l2_field > > specifies today how frames are split into multiple buffers. There's an > > implicit assumption that a frame split into two buffers is captured with > > interlacing. In the SDI case, the two concepts get decoupled, a > > progressive frame can be transmitted (and captured) in two separate > > parts. If we add a *_PROG field, we'll need to duplicate most of the > > v4l2_field values with a _PROG suffix, as the progressive frame can be > > captured in alternate buffers on a video node, but also in separate odd > > and even buffers on two video nodes. Tt the hardware level, data is > > transmitted with odd lines on one link, and even lines on a second link. > > There are then two instances of this IP core, one for each link. One > > instance would receive and process the even lines, the other instance > > the odd lines. The output of the two instances can then be connected to > > two separate DMA engines, or combined in the FPGA fabric, depending on > > how the user designs the system. > > My apologies to give incorrect info regarding this. > In the progressive segmented frame, a progressive captured frame is sent > across to receiver over an interlaced transport. The 2 fields received > are similar to how V4L2_FIELD_ALTERNATE is except that the fields weren't > captured at 2 different times. I've now read more about progressive segmented frames, and I was indeed wrong about the fact that the two segments are transported over different links. I still wonder, however, if a _PROG suffix is the best option. Wouldn't we need to also add V4L2_FIELD_TOP_PROG, V4L2_FIELD_BOTTOM_PROG, V4L2_FIELD_SEQ_TB_PROG and V4L2_FIELD_SEQ_BT_PROG, not necessarily for this driver, but for other devices that would support capturing the odd/even segments only, or support capturing both segments in a single buffer, one after the other ? Maybe that's unavoidable, as enum v4l2_field combines both the buffer layout and the fact that the frame is interlaced or progressive. If we had to redesign it we could do better, but having to keep backward compatibility, duplicating most values with a _PROG suffix may be the best option. Hans, any opinion ? > So I will add the V4L2_FIELD_ALTERNATE_PROG in next patch version. [snip] -- Regards, Laurent Pinchart