From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Date: Wed, 19 Aug 2020 16:57:02 +0000 Subject: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error Message-Id: <20200819165702.GC3248864@dell> List-Id: References: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> In-Reply-To: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Markus Elfring Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Gyungoh Yoo , Bryan Wu , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dinghao Liu , Jingoo Han , Kangjie Lu , Daniel Thompson On Wed, 19 Aug 2020, Markus Elfring wrote: > > When of_property_read_u32_array() returns an error code, > > a pairing refcount decrement is needed to keep np's refcount balanced. > > Can another imperative wording be helpful for the change description? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id445bf405cb331117bc98427b1ba6f12418ad17#n151 > > Would an other commit message be a bit nicer? > > > … > > +++ b/drivers/video/backlight/sky81452-backlight.c > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt( > > num_entry); > > if (ret < 0) { > > dev_err(dev, "led-sources node is invalid.\n"); > > + of_node_put(np); > > return ERR_PTR(-EINVAL); > > } > > I propose to add the jump target “put_node” so that a bit of common exception > handling code can be better reused at the end of this function implementation. > > Regards, > Markus You can safely ignore any review comments from Markus! However, this patch doesn't appear to be in my inbox. Any ideas as to why? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5950EC433DF for ; Wed, 19 Aug 2020 16:57:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29B9C207FF for ; Wed, 19 Aug 2020 16:57:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CCVFYUUE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 29B9C207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 93A7589A91; Wed, 19 Aug 2020 16:57:07 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id CF25F89A91 for ; Wed, 19 Aug 2020 16:57:06 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id p14so2772861wmg.1 for ; Wed, 19 Aug 2020 09:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=pYhO7PbSDe8dru1dk/4z1pXylH1/0mvxSDfzBAAOOrk=; b=CCVFYUUES1mcKzrLyt3Uqs9hjoeY+tJL5sKDMD90jBM3CZHjqak1l36nSYdbzmwHiM ShBiyCY0+gsgm2uPLeGH7G2dj9qmxT9SsE0Gr1R5exx5TeLVWfX6zkwSGuuAegx+feg9 cd+kDQto4FDMM8i0SIpIsYNdmSqqDHNglX9B9xFrE/aL/GgzJ52q3fO+bVw7zQvPgWSb PvOzsN6j3X1nHaXqiW8Mx959AAaS7Hgg8/JFaY9LRnHCBDNWUHK0xgaeFzf6fqkFc0/e j6OuefwpxT6vbWxzlisTrBHsiDSOsGTXRXtsFzWaDolcVpQrLKf/xLen8IASn9H5CKDj y2EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=pYhO7PbSDe8dru1dk/4z1pXylH1/0mvxSDfzBAAOOrk=; b=Kter9gYk2N69qzOrpLLWMm5SxNykEbOkU1nVeqVejFNI4sPSeofN/d7kzWY0Aqxu2Z YGRMT2KAgdQzw9NfWU02tX3466P8cWY75zqrSLZLABh+Ovp/03PpOzOWR3g9QOeYj3jn 2Qvh7WFsNN5UPmqBx+WdnNNvA4S6GPziCuL3ImsH+W8aOQzNbgq/OUgQRiO0c/KMjO4j YWCAB2ia2bsuPfX6X9LsE2oxYHgqSwgJk73/IuYSUpgYCMSxBP76Ndr1rv0h95qO4v7b p3KbygKZT6gm09G9F0h2iIWcPtPWu4+G77PKbUUMxu8cDso4YoS4mWA22hE0WHuCPcHP boaw== X-Gm-Message-State: AOAM532fVXgjcgwczMqEouI45SlRl3PeJtAyR4Hw0smB0b4S92U/Imny 1XZnIo6En0hArQx7vCdu1h6/tg== X-Google-Smtp-Source: ABdhPJz8qA3JOjs+ieJsjG0S48f11108VeZdaRV17brCNc3yaDMVfbUHOgU27SWVv+InAy1PTRPfOw== X-Received: by 2002:a1c:448a:: with SMTP id r132mr5661262wma.158.1597856225352; Wed, 19 Aug 2020 09:57:05 -0700 (PDT) Received: from dell ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id c4sm41113675wrt.41.2020.08.19.09.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 09:57:04 -0700 (PDT) Date: Wed, 19 Aug 2020 17:57:02 +0100 From: Lee Jones To: Markus Elfring Subject: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error Message-ID: <20200819165702.GC3248864@dell> References: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Bartlomiej Zolnierkiewicz , Gyungoh Yoo , Bryan Wu , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Dinghao Liu , Jingoo Han , Kangjie Lu , Daniel Thompson Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCAxOSBBdWcgMjAyMCwgTWFya3VzIEVsZnJpbmcgd3JvdGU6Cgo+ID4gV2hlbiBvZl9w cm9wZXJ0eV9yZWFkX3UzMl9hcnJheSgpIHJldHVybnMgYW4gZXJyb3IgY29kZSwKPiA+IGEgcGFp cmluZyByZWZjb3VudCBkZWNyZW1lbnQgaXMgbmVlZGVkIHRvIGtlZXAgbnAncyByZWZjb3VudCBi YWxhbmNlZC4KPiAKPiBDYW4gYW5vdGhlciBpbXBlcmF0aXZlIHdvcmRpbmcgYmUgaGVscGZ1bCBm b3IgdGhlIGNoYW5nZSBkZXNjcmlwdGlvbj8KPiBodHRwczovL2dpdC5rZXJuZWwub3JnL3B1Yi9z Y20vbGludXgva2VybmVsL2dpdC90b3J2YWxkcy9saW51eC5naXQvdHJlZS9Eb2N1bWVudGF0aW9u L3Byb2Nlc3Mvc3VibWl0dGluZy1wYXRjaGVzLnJzdD9pZD0xODQ0NWJmNDA1Y2IzMzExMTdiYzk4 NDI3YjFiYTZmMTI0MThhZDE3I24xNTEKPiAKPiBXb3VsZCBhbiBvdGhlciBjb21taXQgbWVzc2Fn ZSBiZSBhIGJpdCBuaWNlcj8KPiAKPiAKPiDigKYKPiA+ICsrKyBiL2RyaXZlcnMvdmlkZW8vYmFj a2xpZ2h0L3NreTgxNDUyLWJhY2tsaWdodC5jCj4gPiBAQCAtMjE3LDYgKzIxNyw3IEBAIHN0YXRp YyBzdHJ1Y3Qgc2t5ODE0NTJfYmxfcGxhdGZvcm1fZGF0YSAqc2t5ODE0NTJfYmxfcGFyc2VfZHQo Cj4gPiAgCQkJCQludW1fZW50cnkpOwo+ID4gIAkJaWYgKHJldCA8IDApIHsKPiA+ICAJCQlkZXZf ZXJyKGRldiwgImxlZC1zb3VyY2VzIG5vZGUgaXMgaW52YWxpZC5cbiIpOwo+ID4gKwkJCW9mX25v ZGVfcHV0KG5wKTsKPiA+ICAJCQlyZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiA+ICAJCX0KPiAK PiBJIHByb3Bvc2UgdG8gYWRkIHRoZSBqdW1wIHRhcmdldCDigJxwdXRfbm9kZeKAnSBzbyB0aGF0 IGEgYml0IG9mIGNvbW1vbiBleGNlcHRpb24KPiBoYW5kbGluZyBjb2RlIGNhbiBiZSBiZXR0ZXIg cmV1c2VkIGF0IHRoZSBlbmQgb2YgdGhpcyBmdW5jdGlvbiBpbXBsZW1lbnRhdGlvbi4KPiAKPiBS ZWdhcmRzLAo+IE1hcmt1cwoKWW91IGNhbiBzYWZlbHkgaWdub3JlIGFueSByZXZpZXcgY29tbWVu dHMgZnJvbSBNYXJrdXMhCgpIb3dldmVyLCB0aGlzIHBhdGNoIGRvZXNuJ3QgYXBwZWFyIHRvIGJl IGluIG15IGluYm94LgoKQW55IGlkZWFzIGFzIHRvIHdoeT8KCi0tIApMZWUgSm9uZXMgW+adjueQ vOaWr10KU2VuaW9yIFRlY2huaWNhbCBMZWFkIC0gRGV2ZWxvcGVyIFNlcnZpY2VzCkxpbmFyby5v cmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBcm0gU29DcwpGb2xsb3cgTGluYXJvOiBG YWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3D9FC433E1 for ; Wed, 19 Aug 2020 16:57:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1FF6207FF for ; Wed, 19 Aug 2020 16:57:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CCVFYUUE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727098AbgHSQ5f (ORCPT ); Wed, 19 Aug 2020 12:57:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbgHSQ5H (ORCPT ); Wed, 19 Aug 2020 12:57:07 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC5BDC061383 for ; Wed, 19 Aug 2020 09:57:06 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id x5so2761824wmi.2 for ; Wed, 19 Aug 2020 09:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=pYhO7PbSDe8dru1dk/4z1pXylH1/0mvxSDfzBAAOOrk=; b=CCVFYUUES1mcKzrLyt3Uqs9hjoeY+tJL5sKDMD90jBM3CZHjqak1l36nSYdbzmwHiM ShBiyCY0+gsgm2uPLeGH7G2dj9qmxT9SsE0Gr1R5exx5TeLVWfX6zkwSGuuAegx+feg9 cd+kDQto4FDMM8i0SIpIsYNdmSqqDHNglX9B9xFrE/aL/GgzJ52q3fO+bVw7zQvPgWSb PvOzsN6j3X1nHaXqiW8Mx959AAaS7Hgg8/JFaY9LRnHCBDNWUHK0xgaeFzf6fqkFc0/e j6OuefwpxT6vbWxzlisTrBHsiDSOsGTXRXtsFzWaDolcVpQrLKf/xLen8IASn9H5CKDj y2EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=pYhO7PbSDe8dru1dk/4z1pXylH1/0mvxSDfzBAAOOrk=; b=qN7ZezDB3C1d3HsNmmMhln1P6GAvy1jpAJJC8odxXvJQ04ThgE9v+DyCFMZmkgomUz 6dFYgTzu3eEy++qexSvFHq+la01//yrbYnBKmemhdYftaNcPp1Uf3ZU9rQ2lHfAJCtI6 j4tFapEsVD81JaBvlEcdOjqGDf2aL1n3U2CHnP+s24il/gTG547OE058pYWaZiyUXd6l bGn+P57pgCvPjiww6JA2smahgwANIm4WkYRrcUII9+Vz1j9bRdtkphLxbG1P6vlRdIu9 OjGNSRJ6g+tl6d8LZvVf0K9/gllxGpKjHQaGHP8Z07Y0aqqef+4TPTA+Vt22Q6Hnioj9 79ow== X-Gm-Message-State: AOAM532jLycXIoKzhNlV/exr8gOhFvmvZi7ODDUyoVvGxxAF5rZ7KlR0 57bQlvhqVh2rxX+/1k7UiIORTA== X-Google-Smtp-Source: ABdhPJz8qA3JOjs+ieJsjG0S48f11108VeZdaRV17brCNc3yaDMVfbUHOgU27SWVv+InAy1PTRPfOw== X-Received: by 2002:a1c:448a:: with SMTP id r132mr5661262wma.158.1597856225352; Wed, 19 Aug 2020 09:57:05 -0700 (PDT) Received: from dell ([95.149.164.62]) by smtp.gmail.com with ESMTPSA id c4sm41113675wrt.41.2020.08.19.09.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2020 09:57:04 -0700 (PDT) Date: Wed, 19 Aug 2020 17:57:02 +0100 From: Lee Jones To: Markus Elfring Cc: Dinghao Liu , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Bartlomiej Zolnierkiewicz , Bryan Wu , Daniel Thompson , Gyungoh Yoo , Jingoo Han , Kangjie Lu Subject: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error Message-ID: <20200819165702.GC3248864@dell> References: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <321fb03d-2307-7f60-f437-cfb99184dfd6@web.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Aug 2020, Markus Elfring wrote: > > When of_property_read_u32_array() returns an error code, > > a pairing refcount decrement is needed to keep np's refcount balanced. > > Can another imperative wording be helpful for the change description? > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=18445bf405cb331117bc98427b1ba6f12418ad17#n151 > > Would an other commit message be a bit nicer? > > > … > > +++ b/drivers/video/backlight/sky81452-backlight.c > > @@ -217,6 +217,7 @@ static struct sky81452_bl_platform_data *sky81452_bl_parse_dt( > > num_entry); > > if (ret < 0) { > > dev_err(dev, "led-sources node is invalid.\n"); > > + of_node_put(np); > > return ERR_PTR(-EINVAL); > > } > > I propose to add the jump target “put_node” so that a bit of common exception > handling code can be better reused at the end of this function implementation. > > Regards, > Markus You can safely ignore any review comments from Markus! However, this patch doesn't appear to be in my inbox. Any ideas as to why? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog