From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D127C433DF for ; Wed, 19 Aug 2020 18:20:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D65320758 for ; Wed, 19 Aug 2020 18:20:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D65320758 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 674706E5A9; Wed, 19 Aug 2020 18:20:09 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2ACF06E5A9 for ; Wed, 19 Aug 2020 18:20:07 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id EBB5320020; Wed, 19 Aug 2020 20:20:04 +0200 (CEST) Date: Wed, 19 Aug 2020 20:20:03 +0200 From: Sam Ravnborg To: Paul Cercueil Subject: Re: [PATCH] drm/panel: novatek,nt39016: Remove 'dev' field in priv struct Message-ID: <20200819182003.GA12176@ravnborg.org> References: <20200819181412.137785-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20200819181412.137785-1-paul@crapouillou.net> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=C1W1wG20L6skF9YZcpEA:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thierry Reding , od@zcrc.me, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Paul. On Wed, Aug 19, 2020 at 08:14:12PM +0200, Paul Cercueil wrote: > There is already a 'struct device' pointer in the drm_panel structure, > that we can access easily from our priv structure, so there's no need > for a separate 'dev' field there. > > This also allows drm_panel_of_backlight() to work properly, as it > requires the drm_panel.dev field to be initialized. > > Signed-off-by: Paul Cercueil > --- > drivers/gpu/drm/panel/panel-novatek-nt39016.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt39016.c b/drivers/gpu/drm/panel/panel-novatek-nt39016.c > index 39f7be679da5..292ad1d58313 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt39016.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt39016.c > @@ -56,7 +56,6 @@ struct nt39016_panel_info { > > struct nt39016 { > struct drm_panel drm_panel; > - struct device *dev; > struct regmap *map; > struct regulator *supply; > const struct nt39016_panel_info *panel_info; > @@ -124,7 +123,7 @@ static int nt39016_prepare(struct drm_panel *drm_panel) > > err = regulator_enable(panel->supply); > if (err) { > - dev_err(panel->dev, "Failed to enable power supply: %d\n", err); > + dev_err(drm_panel->dev, "Failed to enable power supply: %d\n", err); > return err; > } > > @@ -143,7 +142,7 @@ static int nt39016_prepare(struct drm_panel *drm_panel) > err = regmap_multi_reg_write(panel->map, nt39016_panel_regs, > ARRAY_SIZE(nt39016_panel_regs)); > if (err) { > - dev_err(panel->dev, "Failed to init registers: %d\n", err); > + dev_err(drm_panel->dev, "Failed to init registers: %d\n", err); > goto err_disable_regulator; > } > > @@ -173,7 +172,7 @@ static int nt39016_enable(struct drm_panel *drm_panel) > ret = regmap_write(panel->map, NT39016_REG_SYSTEM, > NT39016_SYSTEM_RESET_N | NT39016_SYSTEM_STANDBY); > if (ret) { > - dev_err(panel->dev, "Unable to enable panel: %d\n", ret); > + dev_err(drm_panel->dev, "Unable to enable panel: %d\n", ret); > return ret; > } > > @@ -193,7 +192,7 @@ static int nt39016_disable(struct drm_panel *drm_panel) > err = regmap_write(panel->map, NT39016_REG_SYSTEM, > NT39016_SYSTEM_RESET_N); > if (err) { > - dev_err(panel->dev, "Unable to disable panel: %d\n", err); > + dev_err(drm_panel->dev, "Unable to disable panel: %d\n", err); > return err; > } > > @@ -252,7 +251,7 @@ static int nt39016_probe(struct spi_device *spi) > if (!panel) > return -ENOMEM; > > - panel->dev = dev; > + panel->drm_panel.dev = dev; This is wrong. You need to fix when drm_panel_of_backlight is called. >From drm_panel.c: * drm_panel_of_backlight() must be called after the call to drm_panel_init(). Then the assignment can go away. Sam > spi_set_drvdata(spi, panel); > > panel->panel_info = of_device_get_match_data(dev); > -- > 2.28.0 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7613AC433E3 for ; Wed, 19 Aug 2020 18:20:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6082822B40 for ; Wed, 19 Aug 2020 18:20:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726745AbgHSSUJ (ORCPT ); Wed, 19 Aug 2020 14:20:09 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:56932 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726578AbgHSSUI (ORCPT ); Wed, 19 Aug 2020 14:20:08 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id EBB5320020; Wed, 19 Aug 2020 20:20:04 +0200 (CEST) Date: Wed, 19 Aug 2020 20:20:03 +0200 From: Sam Ravnborg To: Paul Cercueil Cc: Thierry Reding , od@zcrc.me, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/panel: novatek,nt39016: Remove 'dev' field in priv struct Message-ID: <20200819182003.GA12176@ravnborg.org> References: <20200819181412.137785-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200819181412.137785-1-paul@crapouillou.net> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=C1W1wG20L6skF9YZcpEA:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul. On Wed, Aug 19, 2020 at 08:14:12PM +0200, Paul Cercueil wrote: > There is already a 'struct device' pointer in the drm_panel structure, > that we can access easily from our priv structure, so there's no need > for a separate 'dev' field there. > > This also allows drm_panel_of_backlight() to work properly, as it > requires the drm_panel.dev field to be initialized. > > Signed-off-by: Paul Cercueil > --- > drivers/gpu/drm/panel/panel-novatek-nt39016.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-novatek-nt39016.c b/drivers/gpu/drm/panel/panel-novatek-nt39016.c > index 39f7be679da5..292ad1d58313 100644 > --- a/drivers/gpu/drm/panel/panel-novatek-nt39016.c > +++ b/drivers/gpu/drm/panel/panel-novatek-nt39016.c > @@ -56,7 +56,6 @@ struct nt39016_panel_info { > > struct nt39016 { > struct drm_panel drm_panel; > - struct device *dev; > struct regmap *map; > struct regulator *supply; > const struct nt39016_panel_info *panel_info; > @@ -124,7 +123,7 @@ static int nt39016_prepare(struct drm_panel *drm_panel) > > err = regulator_enable(panel->supply); > if (err) { > - dev_err(panel->dev, "Failed to enable power supply: %d\n", err); > + dev_err(drm_panel->dev, "Failed to enable power supply: %d\n", err); > return err; > } > > @@ -143,7 +142,7 @@ static int nt39016_prepare(struct drm_panel *drm_panel) > err = regmap_multi_reg_write(panel->map, nt39016_panel_regs, > ARRAY_SIZE(nt39016_panel_regs)); > if (err) { > - dev_err(panel->dev, "Failed to init registers: %d\n", err); > + dev_err(drm_panel->dev, "Failed to init registers: %d\n", err); > goto err_disable_regulator; > } > > @@ -173,7 +172,7 @@ static int nt39016_enable(struct drm_panel *drm_panel) > ret = regmap_write(panel->map, NT39016_REG_SYSTEM, > NT39016_SYSTEM_RESET_N | NT39016_SYSTEM_STANDBY); > if (ret) { > - dev_err(panel->dev, "Unable to enable panel: %d\n", ret); > + dev_err(drm_panel->dev, "Unable to enable panel: %d\n", ret); > return ret; > } > > @@ -193,7 +192,7 @@ static int nt39016_disable(struct drm_panel *drm_panel) > err = regmap_write(panel->map, NT39016_REG_SYSTEM, > NT39016_SYSTEM_RESET_N); > if (err) { > - dev_err(panel->dev, "Unable to disable panel: %d\n", err); > + dev_err(drm_panel->dev, "Unable to disable panel: %d\n", err); > return err; > } > > @@ -252,7 +251,7 @@ static int nt39016_probe(struct spi_device *spi) > if (!panel) > return -ENOMEM; > > - panel->dev = dev; > + panel->drm_panel.dev = dev; This is wrong. You need to fix when drm_panel_of_backlight is called. >From drm_panel.c: * drm_panel_of_backlight() must be called after the call to drm_panel_init(). Then the assignment can go away. Sam > spi_set_drvdata(spi, panel); > > panel->panel_info = of_device_get_match_data(dev); > -- > 2.28.0