From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D915C433E1 for ; Wed, 19 Aug 2020 22:15:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7136D206FA for ; Wed, 19 Aug 2020 22:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726754AbgHSWPs (ORCPT ); Wed, 19 Aug 2020 18:15:48 -0400 Received: from mga17.intel.com ([192.55.52.151]:32544 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726435AbgHSWPr (ORCPT ); Wed, 19 Aug 2020 18:15:47 -0400 IronPort-SDR: 9F7HC0n50dofNJEBLpIEN7s5n3HsCAOS8vQIYeFG9LsG8qhSf1rPE2kEnGCKlWnCDoUTsX1dS6 M9waSi8Wva3Q== X-IronPort-AV: E=McAfee;i="6000,8403,9718"; a="135273900" X-IronPort-AV: E=Sophos;i="5.76,332,1592895600"; d="scan'208";a="135273900" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2020 15:15:46 -0700 IronPort-SDR: RA0K3fI6AgJT1LHdoG/ExZDHEKs0gn7L5aVEG2ImD7wbljrmNN+Hhoww056OcbPJPmB2yr+xmR O9Gn1eO1miGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,332,1592895600"; d="scan'208";a="310916764" Received: from pbooyens-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.52.107]) by orsmga002.jf.intel.com with ESMTP; 19 Aug 2020 15:15:45 -0700 Date: Thu, 20 Aug 2020 01:15:44 +0300 From: Jarkko Sakkinen To: Mimi Zohar Cc: Jason Gunthorpe , James Bottomley , linux-integrity@vger.kernel.org Subject: Re: [PATCH v4 1/1] tpm: add sysfs exports for all banks of PCR registers Message-ID: <20200819221544.GM9942@linux.intel.com> References: <20200817213506.4474-2-James.Bottomley@HansenPartnership.com> <20200818161207.GC137138@linux.intel.com> <20200818161955.GD137138@linux.intel.com> <20200818162630.GE137138@linux.intel.com> <20200818164602.GZ1152540@nvidia.com> <39eb6b408e7f060ab241954102d06f97d1f99611.camel@linux.ibm.com> <20200818183603.GC1152540@nvidia.com> <14eaf21a808e333ca414c954d8f3a2f7b6dbf2ca.camel@linux.ibm.com> <20200819120238.GD1152540@nvidia.com> <59f983156fed466d568c324de72ef733c1a15d76.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59f983156fed466d568c324de72ef733c1a15d76.camel@linux.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-integrity-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-integrity@vger.kernel.org On Wed, Aug 19, 2020 at 09:27:33AM -0400, Mimi Zohar wrote: > On Wed, 2020-08-19 at 09:02 -0300, Jason Gunthorpe wrote: > > On Tue, Aug 18, 2020 at 02:55:50PM -0400, Mimi Zohar wrote: > > > > > The problem is that there isn't just one single userspace library or > > > application for reading PCRs. So now not only is there the kernel > > > "boot_aggregate" regression testing, but regression testing of the tool > > > itself to support multiple methods of reading the PCRs. > > > > I was thinking just open code > > open("/dev/tpm") > > write(read_pcrs_cmd) > > read(read_pcrs_cmd) > > > > It isn't particularly hard to retrive the PCRs, don't really need to > > depend on a library. > > Ok, do you want to contribute it to ima-evm-utils? While you're at it, > do you also have code to parse the TPM 2.0 event log that you could > contribute? > > Seriously, we shouldn't be (re-)writing code to do this. > > Mimi > I'm puzzled why go the trouble of submitting this to LKML and not use that time to do the whatever changes ima-evm-utils requires? /Jarkko